[Wasm RyuJit] fix some issues with calls

[AndyAyersMS]

For calls with managed conventions, pass a faked-up PE pointer as the last argument to match the expected signature.

If the last instruction in the main method or funclet is a call that does not return, make sure to emit an end after any unreachable.

[Copilot]

Pull request overview

This PR implements support for WASM RyuJIT managed call conventions by adding two special arguments (shadow stack pointer and portable entry point) and ensuring proper WASM control flow structure with end instructions after unreachable code.

Changes:

• Added WasmPortableEntryPoint argument (zero pointer stub) to managed WASM calls
• Updated non-standard argument count from 1 to 2 for WASM managed calls
• Added WASM-specific logic to emit end instruction after unreachable (breakpoint) at function/funclet boundaries

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/jit/morph.cpp	Adds portable entry point argument to WASM managed calls alongside existing stack pointer argument
src/coreclr/jit/gentree.cpp	Updates GetNonStandardAddedArgCount to return 2 instead of 1 for WASM managed calls
src/coreclr/jit/codegenlinear.cpp	Adds WASM-specific logic to emit end instruction after unreachable when at function/funclet boundaries

[AndyAyersMS]

PTAL @dotnet/jit-contrib

This depends (somewhat) on #123738 -- which fixes some issues with signature generation. I will work on passing a proper PE arg soonish, but for now nothing depends on it having the right value.

We won't need the unreachable (which is what INS_BREAKPOINT maps to) after throw helpers or no return calls to help unwind or EH region, but we might want to keep it since we really don't expect control to return.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

[AndyAyersMS]

For calls with managed conventions, pass a faked-up PE pointer as the last argument to match the expected signature.

If the last instruction in the main method or funclet is a call that does not return, make sure to emit an end after any unreachable.

[Copilot]

Pull request overview

This PR implements support for WASM RyuJIT managed call conventions by adding two special arguments (shadow stack pointer and portable entry point) and ensuring proper WASM control flow structure with end instructions after unreachable code.

Changes:

• Added WasmPortableEntryPoint argument (zero pointer stub) to managed WASM calls
• Updated non-standard argument count from 1 to 2 for WASM managed calls
• Added WASM-specific logic to emit end instruction after unreachable (breakpoint) at function/funclet boundaries

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/jit/morph.cpp	Adds portable entry point argument to WASM managed calls alongside existing stack pointer argument
src/coreclr/jit/gentree.cpp	Updates GetNonStandardAddedArgCount to return 2 instead of 1 for WASM managed calls
src/coreclr/jit/codegenlinear.cpp	Adds WASM-specific logic to emit end instruction after unreachable when at function/funclet boundaries

[AndyAyersMS]

PTAL @dotnet/jit-contrib

This depends (somewhat) on #123738 -- which fixes some issues with signature generation. I will work on passing a proper PE arg soonish, but for now nothing depends on it having the right value.

We won't need the unreachable (which is what INS_BREAKPOINT maps to) after throw helpers or no return calls to help unwind or EH region, but we might want to keep it since we really don't expect control to return.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

[AndyAyersMS]

For calls with managed conventions, pass a faked-up PE pointer as the last argument to match the expected signature.

If the last instruction in the main method or funclet is a call that does not return, make sure to emit an end after any unreachable.

[Copilot]

Pull request overview

This PR implements support for WASM RyuJIT managed call conventions by adding two special arguments (shadow stack pointer and portable entry point) and ensuring proper WASM control flow structure with end instructions after unreachable code.

Changes:

• Added WasmPortableEntryPoint argument (zero pointer stub) to managed WASM calls
• Updated non-standard argument count from 1 to 2 for WASM managed calls
• Added WASM-specific logic to emit end instruction after unreachable (breakpoint) at function/funclet boundaries

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/jit/morph.cpp	Adds portable entry point argument to WASM managed calls alongside existing stack pointer argument
src/coreclr/jit/gentree.cpp	Updates GetNonStandardAddedArgCount to return 2 instead of 1 for WASM managed calls
src/coreclr/jit/codegenlinear.cpp	Adds WASM-specific logic to emit end instruction after unreachable when at function/funclet boundaries

[AndyAyersMS]

PTAL @dotnet/jit-contrib

This depends (somewhat) on #123738 -- which fixes some issues with signature generation. I will work on passing a proper PE arg soonish, but for now nothing depends on it having the right value.

We won't need the unreachable (which is what INS_BREAKPOINT maps to) after throw helpers or no return calls to help unwind or EH region, but we might want to keep it since we really don't expect control to return.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

[AndyAyersMS]

For calls with managed conventions, pass a faked-up PE pointer as the last argument to match the expected signature.

If the last instruction in the main method or funclet is a call that does not return, make sure to emit an end after any unreachable.

[Copilot]

Pull request overview

This PR implements support for WASM RyuJIT managed call conventions by adding two special arguments (shadow stack pointer and portable entry point) and ensuring proper WASM control flow structure with end instructions after unreachable code.

Changes:

• Added WasmPortableEntryPoint argument (zero pointer stub) to managed WASM calls
• Updated non-standard argument count from 1 to 2 for WASM managed calls
• Added WASM-specific logic to emit end instruction after unreachable (breakpoint) at function/funclet boundaries

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/jit/morph.cpp	Adds portable entry point argument to WASM managed calls alongside existing stack pointer argument
src/coreclr/jit/gentree.cpp	Updates GetNonStandardAddedArgCount to return 2 instead of 1 for WASM managed calls
src/coreclr/jit/codegenlinear.cpp	Adds WASM-specific logic to emit end instruction after unreachable when at function/funclet boundaries

[AndyAyersMS]

PTAL @dotnet/jit-contrib

This depends (somewhat) on #123738 -- which fixes some issues with signature generation. I will work on passing a proper PE arg soonish, but for now nothing depends on it having the right value.

We won't need the unreachable (which is what INS_BREAKPOINT maps to) after throw helpers or no return calls to help unwind or EH region, but we might want to keep it since we really don't expect control to return.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

[AndyAyersMS]

For calls with managed conventions, pass a faked-up PE pointer as the last argument to match the expected signature.

If the last instruction in the main method or funclet is a call that does not return, make sure to emit an end after any unreachable.

[Copilot]

Pull request overview

This PR implements support for WASM RyuJIT managed call conventions by adding two special arguments (shadow stack pointer and portable entry point) and ensuring proper WASM control flow structure with end instructions after unreachable code.

Changes:

• Added WasmPortableEntryPoint argument (zero pointer stub) to managed WASM calls
• Updated non-standard argument count from 1 to 2 for WASM managed calls
• Added WASM-specific logic to emit end instruction after unreachable (breakpoint) at function/funclet boundaries

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/jit/morph.cpp	Adds portable entry point argument to WASM managed calls alongside existing stack pointer argument
src/coreclr/jit/gentree.cpp	Updates GetNonStandardAddedArgCount to return 2 instead of 1 for WASM managed calls
src/coreclr/jit/codegenlinear.cpp	Adds WASM-specific logic to emit end instruction after unreachable when at function/funclet boundaries

[AndyAyersMS]

PTAL @dotnet/jit-contrib

This depends (somewhat) on #123738 -- which fixes some issues with signature generation. I will work on passing a proper PE arg soonish, but for now nothing depends on it having the right value.

We won't need the unreachable (which is what INS_BREAKPOINT maps to) after throw helpers or no return calls to help unwind or EH region, but we might want to keep it since we really don't expect control to return.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

[AndyAyersMS]

For calls with managed conventions, pass a faked-up PE pointer as the last argument to match the expected signature.

If the last instruction in the main method or funclet is a call that does not return, make sure to emit an end after any unreachable.

[Copilot]

Pull request overview

This PR implements support for WASM RyuJIT managed call conventions by adding two special arguments (shadow stack pointer and portable entry point) and ensuring proper WASM control flow structure with end instructions after unreachable code.

Changes:

• Added WasmPortableEntryPoint argument (zero pointer stub) to managed WASM calls
• Updated non-standard argument count from 1 to 2 for WASM managed calls
• Added WASM-specific logic to emit end instruction after unreachable (breakpoint) at function/funclet boundaries

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/jit/morph.cpp	Adds portable entry point argument to WASM managed calls alongside existing stack pointer argument
src/coreclr/jit/gentree.cpp	Updates GetNonStandardAddedArgCount to return 2 instead of 1 for WASM managed calls
src/coreclr/jit/codegenlinear.cpp	Adds WASM-specific logic to emit end instruction after unreachable when at function/funclet boundaries

[AndyAyersMS]

PTAL @dotnet/jit-contrib

This depends (somewhat) on #123738 -- which fixes some issues with signature generation. I will work on passing a proper PE arg soonish, but for now nothing depends on it having the right value.

We won't need the unreachable (which is what INS_BREAKPOINT maps to) after throw helpers or no return calls to help unwind or EH region, but we might want to keep it since we really don't expect control to return.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

[AndyAyersMS]

For calls with managed conventions, pass a faked-up PE pointer as the last argument to match the expected signature.

If the last instruction in the main method or funclet is a call that does not return, make sure to emit an end after any unreachable.

[Copilot]

Pull request overview

This PR implements support for WASM RyuJIT managed call conventions by adding two special arguments (shadow stack pointer and portable entry point) and ensuring proper WASM control flow structure with end instructions after unreachable code.

Changes:

• Added WasmPortableEntryPoint argument (zero pointer stub) to managed WASM calls
• Updated non-standard argument count from 1 to 2 for WASM managed calls
• Added WASM-specific logic to emit end instruction after unreachable (breakpoint) at function/funclet boundaries

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/jit/morph.cpp	Adds portable entry point argument to WASM managed calls alongside existing stack pointer argument
src/coreclr/jit/gentree.cpp	Updates GetNonStandardAddedArgCount to return 2 instead of 1 for WASM managed calls
src/coreclr/jit/codegenlinear.cpp	Adds WASM-specific logic to emit end instruction after unreachable when at function/funclet boundaries

[AndyAyersMS]

PTAL @dotnet/jit-contrib

This depends (somewhat) on #123738 -- which fixes some issues with signature generation. I will work on passing a proper PE arg soonish, but for now nothing depends on it having the right value.

We won't need the unreachable (which is what INS_BREAKPOINT maps to) after throw helpers or no return calls to help unwind or EH region, but we might want to keep it since we really don't expect control to return.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

[AndyAyersMS]

For calls with managed conventions, pass a faked-up PE pointer as the last argument to match the expected signature.

If the last instruction in the main method or funclet is a call that does not return, make sure to emit an end after any unreachable.

[Copilot]

Pull request overview

This PR implements support for WASM RyuJIT managed call conventions by adding two special arguments (shadow stack pointer and portable entry point) and ensuring proper WASM control flow structure with end instructions after unreachable code.

Changes:

• Added WasmPortableEntryPoint argument (zero pointer stub) to managed WASM calls
• Updated non-standard argument count from 1 to 2 for WASM managed calls
• Added WASM-specific logic to emit end instruction after unreachable (breakpoint) at function/funclet boundaries

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/jit/morph.cpp	Adds portable entry point argument to WASM managed calls alongside existing stack pointer argument
src/coreclr/jit/gentree.cpp	Updates GetNonStandardAddedArgCount to return 2 instead of 1 for WASM managed calls
src/coreclr/jit/codegenlinear.cpp	Adds WASM-specific logic to emit end instruction after unreachable when at function/funclet boundaries

[AndyAyersMS]

PTAL @dotnet/jit-contrib

This depends (somewhat) on #123738 -- which fixes some issues with signature generation. I will work on passing a proper PE arg soonish, but for now nothing depends on it having the right value.

We won't need the unreachable (which is what INS_BREAKPOINT maps to) after throw helpers or no return calls to help unwind or EH region, but we might want to keep it since we really don't expect control to return.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.