Add ActivityTraceFlags.RandomTraceId flag by Kielek · Pull Request #124851 · dotnet/runtime

Kielek · 2026-02-25T10:48:25Z

Brings support for RandomTraceId flag known from W3C context propagation level 2.
More details in linked issue.

dotnet-policy-service · 2026-02-25T10:53:38Z

Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Adds support for the W3C Trace Context Level 2 random trace-flags bit by introducing ActivityTraceFlags.RandomTraceId and ensuring Activities created with the default trace-id generator set/propagate this flag.

Changes:

Add ActivityTraceFlags.RandomTraceId to the public API surface.
Add Activity.RandomizedTraceId convenience property and set the flag when the default random trace-id generator is used.
Expand ActivityTests coverage for parsing/propagating the new flag and validating default generation behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs	Introduces `RandomizedTraceId`, sets `RandomTraceId` when using the default generator, and adds the new enum flag.
src/libraries/System.Diagnostics.DiagnosticSource/ref/System.Diagnostics.DiagnosticSourceActivity.cs	Updates reference assembly API surface for the new property and enum member.
src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs	Adds/extends unit tests for `RandomTraceId` parsing, propagation, and default generation behavior.

Comments suppressed due to low confidence (1)

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs:950

The XML documentation for RandomizedTraceId/Recorded refers to W3CIdFlags.*, but there is no public (or internal) W3CIdFlags type; the flag enum is ActivityTraceFlags. Update the docs to reference ActivityTraceFlags.RandomTraceId / ActivityTraceFlags.Recorded (or describe the W3C trace-flags field generically) to avoid misleading API docs.

 /// <summary>
/// True if the W3CIdFlags.RandomTraceId flag is set.
/// </summary>
public bool RandomizedTraceId { get => (ActivityTraceFlags & ActivityTraceFlags.RandomTraceId) != 0; }
/// <summary>
/// True if the W3CIdFlags.Recorded flag is set.
/// </summary>
public bool Recorded { get => (ActivityTraceFlags & ActivityTraceFlags.Recorded) != 0; }

tarekgh · 2026-02-25T16:30:43Z

@Kielek thanks for submitting it. We need to design review it before we proceed with the changes. I have converted this PR to be draft for now till we do that. If you like we can temporary close the PR and then reactive it back when ready.

dotnet-policy-service · 2026-03-27T21:03:23Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Kielek · 2026-04-08T04:41:52Z

@tarekgh, thank you for adjusting this PR to he API-review decision.

- Propagate RandomTraceId from parent to child activities in GenerateW3CId() so the flag follows the trace ID per W3C Trace Context Level 2. - Fix EventSourceLogger to use activity.Recorded instead of comparing ActivityTraceFlags to None, which broke with the new RandomTraceId flag. - Update test assertions in DiagnosticSourceEventSourceBridgeTests to expect RandomTraceId on activities using the default random generator.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

- Output full ActivityTraceFlags value instead of just Recorded bit in EventSourceLogger, so all flags are propagated to consumers. - Update EventSourceLoggerTest assertion to match. - Fix typo in test method name: Speciifc -> Specific.

tarekgh · 2026-04-09T01:23:09Z

/ba-g failures are unrelated and seen in other PRs.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

tarekgh

Thanks @Kielek!

…#124851) dotnet/runtime#124851 ("Add ActivityTraceFlags.RandomTraceId flag", W3C Trace Context Level 2) changes how ActivityTraceFlags are emitted into EventPipe events: - Microsoft.Extensions.Logging.EventSource now emits the flags field as the raw integer ("0".."3") rather than just "0"/"1", and emits string.Empty (instead of null) for trace/span IDs when no current Activity exists. - ActivitySource-created activities now have RandomTraceId set automatically, so DiagnosticSourceEventSource Stop events carry flag values this consumer did not recognize. - net 8 servicing runtimes now honor ParentRatioSampler in the FilterAndPayloadSpec, where they previously dropped it. Make the consumer tolerant of these wire-format shifts: * LogRecordFactory: IsNullOrEmpty for trace/span IDs; integer parse with bit-mask for trace flags via new ParseActivityTraceFlags helper. * TraceEventExtensions: tolerant ActivityTraceFlags parse that masks unknown bits (handles either integer or comma-separated name form). * DistributedTracesPipelineUnitTests: drop the obsolete net 8 carveout in TestTracesPipelineWithSamplingRatio; all supported TFMs now produce a single un-recorded activity here. Also bump MicrosoftExtensionsLoggingEventSourceVersion 8.0.3 -> 10.0.5 (the 8.0.3 pin does not exist on the public feeds and was being substituted to 9.0.0 with NU1603 treated as error). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Kielek · 2026-02-25T10:48:25Z

Fixes#124509

Brings support for RandomTraceId flag known from W3C context propagation level 2.
More details in linked issue.

dotnet-policy-service · 2026-02-25T10:53:38Z

Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Adds support for the W3C Trace Context Level 2 random trace-flags bit by introducing ActivityTraceFlags.RandomTraceId and ensuring Activities created with the default trace-id generator set/propagate this flag.

Changes:

Add ActivityTraceFlags.RandomTraceId to the public API surface.
Add Activity.RandomizedTraceId convenience property and set the flag when the default random trace-id generator is used.
Expand ActivityTests coverage for parsing/propagating the new flag and validating default generation behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs	Introduces `RandomizedTraceId`, sets `RandomTraceId` when using the default generator, and adds the new enum flag.
src/libraries/System.Diagnostics.DiagnosticSource/ref/System.Diagnostics.DiagnosticSourceActivity.cs	Updates reference assembly API surface for the new property and enum member.
src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs	Adds/extends unit tests for `RandomTraceId` parsing, propagation, and default generation behavior.

Comments suppressed due to low confidence (1)

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs:950

The XML documentation for RandomizedTraceId/Recorded refers to W3CIdFlags.*, but there is no public (or internal) W3CIdFlags type; the flag enum is ActivityTraceFlags. Update the docs to reference ActivityTraceFlags.RandomTraceId / ActivityTraceFlags.Recorded (or describe the W3C trace-flags field generically) to avoid misleading API docs.

 /// <summary>
/// True if the W3CIdFlags.RandomTraceId flag is set.
/// </summary>
public bool RandomizedTraceId { get => (ActivityTraceFlags & ActivityTraceFlags.RandomTraceId) != 0; }
/// <summary>
/// True if the W3CIdFlags.Recorded flag is set.
/// </summary>
public bool Recorded { get => (ActivityTraceFlags & ActivityTraceFlags.Recorded) != 0; }

tarekgh · 2026-02-25T16:30:43Z

@Kielek thanks for submitting it. We need to design review it before we proceed with the changes. I have converted this PR to be draft for now till we do that. If you like we can temporary close the PR and then reactive it back when ready.

dotnet-policy-service · 2026-03-27T21:03:23Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Kielek · 2026-04-08T04:41:52Z

@tarekgh, thank you for adjusting this PR to he API-review decision.

- Propagate RandomTraceId from parent to child activities in GenerateW3CId() so the flag follows the trace ID per W3C Trace Context Level 2. - Fix EventSourceLogger to use activity.Recorded instead of comparing ActivityTraceFlags to None, which broke with the new RandomTraceId flag. - Update test assertions in DiagnosticSourceEventSourceBridgeTests to expect RandomTraceId on activities using the default random generator.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

- Output full ActivityTraceFlags value instead of just Recorded bit in EventSourceLogger, so all flags are propagated to consumers. - Update EventSourceLoggerTest assertion to match. - Fix typo in test method name: Speciifc -> Specific.

tarekgh · 2026-04-09T01:23:09Z

/ba-g failures are unrelated and seen in other PRs.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

tarekgh

Thanks @Kielek!

…#124851) dotnet/runtime#124851 ("Add ActivityTraceFlags.RandomTraceId flag", W3C Trace Context Level 2) changes how ActivityTraceFlags are emitted into EventPipe events: - Microsoft.Extensions.Logging.EventSource now emits the flags field as the raw integer ("0".."3") rather than just "0"/"1", and emits string.Empty (instead of null) for trace/span IDs when no current Activity exists. - ActivitySource-created activities now have RandomTraceId set automatically, so DiagnosticSourceEventSource Stop events carry flag values this consumer did not recognize. - net 8 servicing runtimes now honor ParentRatioSampler in the FilterAndPayloadSpec, where they previously dropped it. Make the consumer tolerant of these wire-format shifts: * LogRecordFactory: IsNullOrEmpty for trace/span IDs; integer parse with bit-mask for trace flags via new ParseActivityTraceFlags helper. * TraceEventExtensions: tolerant ActivityTraceFlags parse that masks unknown bits (handles either integer or comma-separated name form). * DistributedTracesPipelineUnitTests: drop the obsolete net 8 carveout in TestTracesPipelineWithSamplingRatio; all supported TFMs now produce a single un-recorded activity here. Also bump MicrosoftExtensionsLoggingEventSourceVersion 8.0.3 -> 10.0.5 (the 8.0.3 pin does not exist on the public feeds and was being substituted to 9.0.0 with NU1603 treated as error). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Kielek · 2026-02-25T10:48:25Z

Fixes#124509

Brings support for RandomTraceId flag known from W3C context propagation level 2.
More details in linked issue.

dotnet-policy-service · 2026-02-25T10:53:38Z

Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Adds support for the W3C Trace Context Level 2 random trace-flags bit by introducing ActivityTraceFlags.RandomTraceId and ensuring Activities created with the default trace-id generator set/propagate this flag.

Changes:

Add ActivityTraceFlags.RandomTraceId to the public API surface.
Add Activity.RandomizedTraceId convenience property and set the flag when the default random trace-id generator is used.
Expand ActivityTests coverage for parsing/propagating the new flag and validating default generation behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs	Introduces `RandomizedTraceId`, sets `RandomTraceId` when using the default generator, and adds the new enum flag.
src/libraries/System.Diagnostics.DiagnosticSource/ref/System.Diagnostics.DiagnosticSourceActivity.cs	Updates reference assembly API surface for the new property and enum member.
src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs	Adds/extends unit tests for `RandomTraceId` parsing, propagation, and default generation behavior.

Comments suppressed due to low confidence (1)

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs:950

The XML documentation for RandomizedTraceId/Recorded refers to W3CIdFlags.*, but there is no public (or internal) W3CIdFlags type; the flag enum is ActivityTraceFlags. Update the docs to reference ActivityTraceFlags.RandomTraceId / ActivityTraceFlags.Recorded (or describe the W3C trace-flags field generically) to avoid misleading API docs.

 /// <summary>
/// True if the W3CIdFlags.RandomTraceId flag is set.
/// </summary>
public bool RandomizedTraceId { get => (ActivityTraceFlags & ActivityTraceFlags.RandomTraceId) != 0; }
/// <summary>
/// True if the W3CIdFlags.Recorded flag is set.
/// </summary>
public bool Recorded { get => (ActivityTraceFlags & ActivityTraceFlags.Recorded) != 0; }

tarekgh · 2026-02-25T16:30:43Z

@Kielek thanks for submitting it. We need to design review it before we proceed with the changes. I have converted this PR to be draft for now till we do that. If you like we can temporary close the PR and then reactive it back when ready.

dotnet-policy-service · 2026-03-27T21:03:23Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Kielek · 2026-04-08T04:41:52Z

@tarekgh, thank you for adjusting this PR to he API-review decision.

- Propagate RandomTraceId from parent to child activities in GenerateW3CId() so the flag follows the trace ID per W3C Trace Context Level 2. - Fix EventSourceLogger to use activity.Recorded instead of comparing ActivityTraceFlags to None, which broke with the new RandomTraceId flag. - Update test assertions in DiagnosticSourceEventSourceBridgeTests to expect RandomTraceId on activities using the default random generator.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

- Output full ActivityTraceFlags value instead of just Recorded bit in EventSourceLogger, so all flags are propagated to consumers. - Update EventSourceLoggerTest assertion to match. - Fix typo in test method name: Speciifc -> Specific.

tarekgh · 2026-04-09T01:23:09Z

/ba-g failures are unrelated and seen in other PRs.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

tarekgh

Thanks @Kielek!

…#124851) dotnet/runtime#124851 ("Add ActivityTraceFlags.RandomTraceId flag", W3C Trace Context Level 2) changes how ActivityTraceFlags are emitted into EventPipe events: - Microsoft.Extensions.Logging.EventSource now emits the flags field as the raw integer ("0".."3") rather than just "0"/"1", and emits string.Empty (instead of null) for trace/span IDs when no current Activity exists. - ActivitySource-created activities now have RandomTraceId set automatically, so DiagnosticSourceEventSource Stop events carry flag values this consumer did not recognize. - net 8 servicing runtimes now honor ParentRatioSampler in the FilterAndPayloadSpec, where they previously dropped it. Make the consumer tolerant of these wire-format shifts: * LogRecordFactory: IsNullOrEmpty for trace/span IDs; integer parse with bit-mask for trace flags via new ParseActivityTraceFlags helper. * TraceEventExtensions: tolerant ActivityTraceFlags parse that masks unknown bits (handles either integer or comma-separated name form). * DistributedTracesPipelineUnitTests: drop the obsolete net 8 carveout in TestTracesPipelineWithSamplingRatio; all supported TFMs now produce a single un-recorded activity here. Also bump MicrosoftExtensionsLoggingEventSourceVersion 8.0.3 -> 10.0.5 (the 8.0.3 pin does not exist on the public feeds and was being substituted to 9.0.0 with NU1603 treated as error). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Kielek · 2026-02-25T10:48:25Z

Fixes#124509

Brings support for RandomTraceId flag known from W3C context propagation level 2.
More details in linked issue.

dotnet-policy-service · 2026-02-25T10:53:38Z

Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Adds support for the W3C Trace Context Level 2 random trace-flags bit by introducing ActivityTraceFlags.RandomTraceId and ensuring Activities created with the default trace-id generator set/propagate this flag.

Changes:

Add ActivityTraceFlags.RandomTraceId to the public API surface.
Add Activity.RandomizedTraceId convenience property and set the flag when the default random trace-id generator is used.
Expand ActivityTests coverage for parsing/propagating the new flag and validating default generation behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs	Introduces `RandomizedTraceId`, sets `RandomTraceId` when using the default generator, and adds the new enum flag.
src/libraries/System.Diagnostics.DiagnosticSource/ref/System.Diagnostics.DiagnosticSourceActivity.cs	Updates reference assembly API surface for the new property and enum member.
src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs	Adds/extends unit tests for `RandomTraceId` parsing, propagation, and default generation behavior.

Comments suppressed due to low confidence (1)

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs:950

The XML documentation for RandomizedTraceId/Recorded refers to W3CIdFlags.*, but there is no public (or internal) W3CIdFlags type; the flag enum is ActivityTraceFlags. Update the docs to reference ActivityTraceFlags.RandomTraceId / ActivityTraceFlags.Recorded (or describe the W3C trace-flags field generically) to avoid misleading API docs.

 /// <summary>
/// True if the W3CIdFlags.RandomTraceId flag is set.
/// </summary>
public bool RandomizedTraceId { get => (ActivityTraceFlags & ActivityTraceFlags.RandomTraceId) != 0; }
/// <summary>
/// True if the W3CIdFlags.Recorded flag is set.
/// </summary>
public bool Recorded { get => (ActivityTraceFlags & ActivityTraceFlags.Recorded) != 0; }

tarekgh · 2026-02-25T16:30:43Z

@Kielek thanks for submitting it. We need to design review it before we proceed with the changes. I have converted this PR to be draft for now till we do that. If you like we can temporary close the PR and then reactive it back when ready.

dotnet-policy-service · 2026-03-27T21:03:23Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Kielek · 2026-04-08T04:41:52Z

@tarekgh, thank you for adjusting this PR to he API-review decision.

- Propagate RandomTraceId from parent to child activities in GenerateW3CId() so the flag follows the trace ID per W3C Trace Context Level 2. - Fix EventSourceLogger to use activity.Recorded instead of comparing ActivityTraceFlags to None, which broke with the new RandomTraceId flag. - Update test assertions in DiagnosticSourceEventSourceBridgeTests to expect RandomTraceId on activities using the default random generator.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

- Output full ActivityTraceFlags value instead of just Recorded bit in EventSourceLogger, so all flags are propagated to consumers. - Update EventSourceLoggerTest assertion to match. - Fix typo in test method name: Speciifc -> Specific.

tarekgh · 2026-04-09T01:23:09Z

/ba-g failures are unrelated and seen in other PRs.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

tarekgh

Thanks @Kielek!

…#124851) dotnet/runtime#124851 ("Add ActivityTraceFlags.RandomTraceId flag", W3C Trace Context Level 2) changes how ActivityTraceFlags are emitted into EventPipe events: - Microsoft.Extensions.Logging.EventSource now emits the flags field as the raw integer ("0".."3") rather than just "0"/"1", and emits string.Empty (instead of null) for trace/span IDs when no current Activity exists. - ActivitySource-created activities now have RandomTraceId set automatically, so DiagnosticSourceEventSource Stop events carry flag values this consumer did not recognize. - net 8 servicing runtimes now honor ParentRatioSampler in the FilterAndPayloadSpec, where they previously dropped it. Make the consumer tolerant of these wire-format shifts: * LogRecordFactory: IsNullOrEmpty for trace/span IDs; integer parse with bit-mask for trace flags via new ParseActivityTraceFlags helper. * TraceEventExtensions: tolerant ActivityTraceFlags parse that masks unknown bits (handles either integer or comma-separated name form). * DistributedTracesPipelineUnitTests: drop the obsolete net 8 carveout in TestTracesPipelineWithSamplingRatio; all supported TFMs now produce a single un-recorded activity here. Also bump MicrosoftExtensionsLoggingEventSourceVersion 8.0.3 -> 10.0.5 (the 8.0.3 pin does not exist on the public feeds and was being substituted to 9.0.0 with NU1603 treated as error). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Kielek · 2026-02-25T10:48:25Z

Fixes#124509

Brings support for RandomTraceId flag known from W3C context propagation level 2.
More details in linked issue.

dotnet-policy-service · 2026-02-25T10:53:38Z

Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Adds support for the W3C Trace Context Level 2 random trace-flags bit by introducing ActivityTraceFlags.RandomTraceId and ensuring Activities created with the default trace-id generator set/propagate this flag.

Changes:

Add ActivityTraceFlags.RandomTraceId to the public API surface.
Add Activity.RandomizedTraceId convenience property and set the flag when the default random trace-id generator is used.
Expand ActivityTests coverage for parsing/propagating the new flag and validating default generation behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs	Introduces `RandomizedTraceId`, sets `RandomTraceId` when using the default generator, and adds the new enum flag.
src/libraries/System.Diagnostics.DiagnosticSource/ref/System.Diagnostics.DiagnosticSourceActivity.cs	Updates reference assembly API surface for the new property and enum member.
src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs	Adds/extends unit tests for `RandomTraceId` parsing, propagation, and default generation behavior.

Comments suppressed due to low confidence (1)

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs:950

The XML documentation for RandomizedTraceId/Recorded refers to W3CIdFlags.*, but there is no public (or internal) W3CIdFlags type; the flag enum is ActivityTraceFlags. Update the docs to reference ActivityTraceFlags.RandomTraceId / ActivityTraceFlags.Recorded (or describe the W3C trace-flags field generically) to avoid misleading API docs.

 /// <summary>
/// True if the W3CIdFlags.RandomTraceId flag is set.
/// </summary>
public bool RandomizedTraceId { get => (ActivityTraceFlags & ActivityTraceFlags.RandomTraceId) != 0; }
/// <summary>
/// True if the W3CIdFlags.Recorded flag is set.
/// </summary>
public bool Recorded { get => (ActivityTraceFlags & ActivityTraceFlags.Recorded) != 0; }

tarekgh · 2026-02-25T16:30:43Z

@Kielek thanks for submitting it. We need to design review it before we proceed with the changes. I have converted this PR to be draft for now till we do that. If you like we can temporary close the PR and then reactive it back when ready.

dotnet-policy-service · 2026-03-27T21:03:23Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Kielek · 2026-04-08T04:41:52Z

@tarekgh, thank you for adjusting this PR to he API-review decision.

- Propagate RandomTraceId from parent to child activities in GenerateW3CId() so the flag follows the trace ID per W3C Trace Context Level 2. - Fix EventSourceLogger to use activity.Recorded instead of comparing ActivityTraceFlags to None, which broke with the new RandomTraceId flag. - Update test assertions in DiagnosticSourceEventSourceBridgeTests to expect RandomTraceId on activities using the default random generator.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

- Output full ActivityTraceFlags value instead of just Recorded bit in EventSourceLogger, so all flags are propagated to consumers. - Update EventSourceLoggerTest assertion to match. - Fix typo in test method name: Speciifc -> Specific.

tarekgh · 2026-04-09T01:23:09Z

/ba-g failures are unrelated and seen in other PRs.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

tarekgh

Thanks @Kielek!

…#124851) dotnet/runtime#124851 ("Add ActivityTraceFlags.RandomTraceId flag", W3C Trace Context Level 2) changes how ActivityTraceFlags are emitted into EventPipe events: - Microsoft.Extensions.Logging.EventSource now emits the flags field as the raw integer ("0".."3") rather than just "0"/"1", and emits string.Empty (instead of null) for trace/span IDs when no current Activity exists. - ActivitySource-created activities now have RandomTraceId set automatically, so DiagnosticSourceEventSource Stop events carry flag values this consumer did not recognize. - net 8 servicing runtimes now honor ParentRatioSampler in the FilterAndPayloadSpec, where they previously dropped it. Make the consumer tolerant of these wire-format shifts: * LogRecordFactory: IsNullOrEmpty for trace/span IDs; integer parse with bit-mask for trace flags via new ParseActivityTraceFlags helper. * TraceEventExtensions: tolerant ActivityTraceFlags parse that masks unknown bits (handles either integer or comma-separated name form). * DistributedTracesPipelineUnitTests: drop the obsolete net 8 carveout in TestTracesPipelineWithSamplingRatio; all supported TFMs now produce a single un-recorded activity here. Also bump MicrosoftExtensionsLoggingEventSourceVersion 8.0.3 -> 10.0.5 (the 8.0.3 pin does not exist on the public feeds and was being substituted to 9.0.0 with NU1603 treated as error). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Kielek · 2026-02-25T10:48:25Z

Fixes#124509

Brings support for RandomTraceId flag known from W3C context propagation level 2.
More details in linked issue.

dotnet-policy-service · 2026-02-25T10:53:38Z

Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Adds support for the W3C Trace Context Level 2 random trace-flags bit by introducing ActivityTraceFlags.RandomTraceId and ensuring Activities created with the default trace-id generator set/propagate this flag.

Changes:

Add ActivityTraceFlags.RandomTraceId to the public API surface.
Add Activity.RandomizedTraceId convenience property and set the flag when the default random trace-id generator is used.
Expand ActivityTests coverage for parsing/propagating the new flag and validating default generation behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs	Introduces `RandomizedTraceId`, sets `RandomTraceId` when using the default generator, and adds the new enum flag.
src/libraries/System.Diagnostics.DiagnosticSource/ref/System.Diagnostics.DiagnosticSourceActivity.cs	Updates reference assembly API surface for the new property and enum member.
src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs	Adds/extends unit tests for `RandomTraceId` parsing, propagation, and default generation behavior.

Comments suppressed due to low confidence (1)

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs:950

The XML documentation for RandomizedTraceId/Recorded refers to W3CIdFlags.*, but there is no public (or internal) W3CIdFlags type; the flag enum is ActivityTraceFlags. Update the docs to reference ActivityTraceFlags.RandomTraceId / ActivityTraceFlags.Recorded (or describe the W3C trace-flags field generically) to avoid misleading API docs.

 /// <summary>
/// True if the W3CIdFlags.RandomTraceId flag is set.
/// </summary>
public bool RandomizedTraceId { get => (ActivityTraceFlags & ActivityTraceFlags.RandomTraceId) != 0; }
/// <summary>
/// True if the W3CIdFlags.Recorded flag is set.
/// </summary>
public bool Recorded { get => (ActivityTraceFlags & ActivityTraceFlags.Recorded) != 0; }

tarekgh · 2026-02-25T16:30:43Z

@Kielek thanks for submitting it. We need to design review it before we proceed with the changes. I have converted this PR to be draft for now till we do that. If you like we can temporary close the PR and then reactive it back when ready.

dotnet-policy-service · 2026-03-27T21:03:23Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Kielek · 2026-04-08T04:41:52Z

@tarekgh, thank you for adjusting this PR to he API-review decision.

- Propagate RandomTraceId from parent to child activities in GenerateW3CId() so the flag follows the trace ID per W3C Trace Context Level 2. - Fix EventSourceLogger to use activity.Recorded instead of comparing ActivityTraceFlags to None, which broke with the new RandomTraceId flag. - Update test assertions in DiagnosticSourceEventSourceBridgeTests to expect RandomTraceId on activities using the default random generator.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

- Output full ActivityTraceFlags value instead of just Recorded bit in EventSourceLogger, so all flags are propagated to consumers. - Update EventSourceLoggerTest assertion to match. - Fix typo in test method name: Speciifc -> Specific.

tarekgh · 2026-04-09T01:23:09Z

/ba-g failures are unrelated and seen in other PRs.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

tarekgh

Thanks @Kielek!

…#124851) dotnet/runtime#124851 ("Add ActivityTraceFlags.RandomTraceId flag", W3C Trace Context Level 2) changes how ActivityTraceFlags are emitted into EventPipe events: - Microsoft.Extensions.Logging.EventSource now emits the flags field as the raw integer ("0".."3") rather than just "0"/"1", and emits string.Empty (instead of null) for trace/span IDs when no current Activity exists. - ActivitySource-created activities now have RandomTraceId set automatically, so DiagnosticSourceEventSource Stop events carry flag values this consumer did not recognize. - net 8 servicing runtimes now honor ParentRatioSampler in the FilterAndPayloadSpec, where they previously dropped it. Make the consumer tolerant of these wire-format shifts: * LogRecordFactory: IsNullOrEmpty for trace/span IDs; integer parse with bit-mask for trace flags via new ParseActivityTraceFlags helper. * TraceEventExtensions: tolerant ActivityTraceFlags parse that masks unknown bits (handles either integer or comma-separated name form). * DistributedTracesPipelineUnitTests: drop the obsolete net 8 carveout in TestTracesPipelineWithSamplingRatio; all supported TFMs now produce a single un-recorded activity here. Also bump MicrosoftExtensionsLoggingEventSourceVersion 8.0.3 -> 10.0.5 (the 8.0.3 pin does not exist on the public feeds and was being substituted to 9.0.0 with NU1603 treated as error). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Kielek · 2026-02-25T10:48:25Z

Fixes#124509

Brings support for RandomTraceId flag known from W3C context propagation level 2.
More details in linked issue.

dotnet-policy-service · 2026-02-25T10:53:38Z

Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Adds support for the W3C Trace Context Level 2 random trace-flags bit by introducing ActivityTraceFlags.RandomTraceId and ensuring Activities created with the default trace-id generator set/propagate this flag.

Changes:

Add ActivityTraceFlags.RandomTraceId to the public API surface.
Add Activity.RandomizedTraceId convenience property and set the flag when the default random trace-id generator is used.
Expand ActivityTests coverage for parsing/propagating the new flag and validating default generation behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs	Introduces `RandomizedTraceId`, sets `RandomTraceId` when using the default generator, and adds the new enum flag.
src/libraries/System.Diagnostics.DiagnosticSource/ref/System.Diagnostics.DiagnosticSourceActivity.cs	Updates reference assembly API surface for the new property and enum member.
src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs	Adds/extends unit tests for `RandomTraceId` parsing, propagation, and default generation behavior.

Comments suppressed due to low confidence (1)

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs:950

The XML documentation for RandomizedTraceId/Recorded refers to W3CIdFlags.*, but there is no public (or internal) W3CIdFlags type; the flag enum is ActivityTraceFlags. Update the docs to reference ActivityTraceFlags.RandomTraceId / ActivityTraceFlags.Recorded (or describe the W3C trace-flags field generically) to avoid misleading API docs.

 /// <summary>
/// True if the W3CIdFlags.RandomTraceId flag is set.
/// </summary>
public bool RandomizedTraceId { get => (ActivityTraceFlags & ActivityTraceFlags.RandomTraceId) != 0; }
/// <summary>
/// True if the W3CIdFlags.Recorded flag is set.
/// </summary>
public bool Recorded { get => (ActivityTraceFlags & ActivityTraceFlags.Recorded) != 0; }

tarekgh · 2026-02-25T16:30:43Z

@Kielek thanks for submitting it. We need to design review it before we proceed with the changes. I have converted this PR to be draft for now till we do that. If you like we can temporary close the PR and then reactive it back when ready.

dotnet-policy-service · 2026-03-27T21:03:23Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Kielek · 2026-04-08T04:41:52Z

@tarekgh, thank you for adjusting this PR to he API-review decision.

- Propagate RandomTraceId from parent to child activities in GenerateW3CId() so the flag follows the trace ID per W3C Trace Context Level 2. - Fix EventSourceLogger to use activity.Recorded instead of comparing ActivityTraceFlags to None, which broke with the new RandomTraceId flag. - Update test assertions in DiagnosticSourceEventSourceBridgeTests to expect RandomTraceId on activities using the default random generator.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

- Output full ActivityTraceFlags value instead of just Recorded bit in EventSourceLogger, so all flags are propagated to consumers. - Update EventSourceLoggerTest assertion to match. - Fix typo in test method name: Speciifc -> Specific.

tarekgh · 2026-04-09T01:23:09Z

/ba-g failures are unrelated and seen in other PRs.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

tarekgh

Thanks @Kielek!

…#124851) dotnet/runtime#124851 ("Add ActivityTraceFlags.RandomTraceId flag", W3C Trace Context Level 2) changes how ActivityTraceFlags are emitted into EventPipe events: - Microsoft.Extensions.Logging.EventSource now emits the flags field as the raw integer ("0".."3") rather than just "0"/"1", and emits string.Empty (instead of null) for trace/span IDs when no current Activity exists. - ActivitySource-created activities now have RandomTraceId set automatically, so DiagnosticSourceEventSource Stop events carry flag values this consumer did not recognize. - net 8 servicing runtimes now honor ParentRatioSampler in the FilterAndPayloadSpec, where they previously dropped it. Make the consumer tolerant of these wire-format shifts: * LogRecordFactory: IsNullOrEmpty for trace/span IDs; integer parse with bit-mask for trace flags via new ParseActivityTraceFlags helper. * TraceEventExtensions: tolerant ActivityTraceFlags parse that masks unknown bits (handles either integer or comma-separated name form). * DistributedTracesPipelineUnitTests: drop the obsolete net 8 carveout in TestTracesPipelineWithSamplingRatio; all supported TFMs now produce a single un-recorded activity here. Also bump MicrosoftExtensionsLoggingEventSourceVersion 8.0.3 -> 10.0.5 (the 8.0.3 pin does not exist on the public feeds and was being substituted to 9.0.0 with NU1603 treated as error). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Kielek · 2026-02-25T10:48:25Z

Fixes#124509

Brings support for RandomTraceId flag known from W3C context propagation level 2.
More details in linked issue.

dotnet-policy-service · 2026-02-25T10:53:38Z

Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Adds support for the W3C Trace Context Level 2 random trace-flags bit by introducing ActivityTraceFlags.RandomTraceId and ensuring Activities created with the default trace-id generator set/propagate this flag.

Changes:

Add ActivityTraceFlags.RandomTraceId to the public API surface.
Add Activity.RandomizedTraceId convenience property and set the flag when the default random trace-id generator is used.
Expand ActivityTests coverage for parsing/propagating the new flag and validating default generation behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs	Introduces `RandomizedTraceId`, sets `RandomTraceId` when using the default generator, and adds the new enum flag.
src/libraries/System.Diagnostics.DiagnosticSource/ref/System.Diagnostics.DiagnosticSourceActivity.cs	Updates reference assembly API surface for the new property and enum member.
src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs	Adds/extends unit tests for `RandomTraceId` parsing, propagation, and default generation behavior.

Comments suppressed due to low confidence (1)

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs:950

The XML documentation for RandomizedTraceId/Recorded refers to W3CIdFlags.*, but there is no public (or internal) W3CIdFlags type; the flag enum is ActivityTraceFlags. Update the docs to reference ActivityTraceFlags.RandomTraceId / ActivityTraceFlags.Recorded (or describe the W3C trace-flags field generically) to avoid misleading API docs.

 /// <summary>
/// True if the W3CIdFlags.RandomTraceId flag is set.
/// </summary>
public bool RandomizedTraceId { get => (ActivityTraceFlags & ActivityTraceFlags.RandomTraceId) != 0; }
/// <summary>
/// True if the W3CIdFlags.Recorded flag is set.
/// </summary>
public bool Recorded { get => (ActivityTraceFlags & ActivityTraceFlags.Recorded) != 0; }

tarekgh · 2026-02-25T16:30:43Z

@Kielek thanks for submitting it. We need to design review it before we proceed with the changes. I have converted this PR to be draft for now till we do that. If you like we can temporary close the PR and then reactive it back when ready.

dotnet-policy-service · 2026-03-27T21:03:23Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Kielek · 2026-04-08T04:41:52Z

@tarekgh, thank you for adjusting this PR to he API-review decision.

- Propagate RandomTraceId from parent to child activities in GenerateW3CId() so the flag follows the trace ID per W3C Trace Context Level 2. - Fix EventSourceLogger to use activity.Recorded instead of comparing ActivityTraceFlags to None, which broke with the new RandomTraceId flag. - Update test assertions in DiagnosticSourceEventSourceBridgeTests to expect RandomTraceId on activities using the default random generator.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

- Output full ActivityTraceFlags value instead of just Recorded bit in EventSourceLogger, so all flags are propagated to consumers. - Update EventSourceLoggerTest assertion to match. - Fix typo in test method name: Speciifc -> Specific.

tarekgh · 2026-04-09T01:23:09Z

/ba-g failures are unrelated and seen in other PRs.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

tarekgh

Thanks @Kielek!

…#124851) dotnet/runtime#124851 ("Add ActivityTraceFlags.RandomTraceId flag", W3C Trace Context Level 2) changes how ActivityTraceFlags are emitted into EventPipe events: - Microsoft.Extensions.Logging.EventSource now emits the flags field as the raw integer ("0".."3") rather than just "0"/"1", and emits string.Empty (instead of null) for trace/span IDs when no current Activity exists. - ActivitySource-created activities now have RandomTraceId set automatically, so DiagnosticSourceEventSource Stop events carry flag values this consumer did not recognize. - net 8 servicing runtimes now honor ParentRatioSampler in the FilterAndPayloadSpec, where they previously dropped it. Make the consumer tolerant of these wire-format shifts: * LogRecordFactory: IsNullOrEmpty for trace/span IDs; integer parse with bit-mask for trace flags via new ParseActivityTraceFlags helper. * TraceEventExtensions: tolerant ActivityTraceFlags parse that masks unknown bits (handles either integer or comma-separated name form). * DistributedTracesPipelineUnitTests: drop the obsolete net 8 carveout in TestTracesPipelineWithSamplingRatio; all supported TFMs now produce a single un-recorded activity here. Also bump MicrosoftExtensionsLoggingEventSourceVersion 8.0.3 -> 10.0.5 (the 8.0.3 pin does not exist on the public feeds and was being substituted to 9.0.0 with NU1603 treated as error). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add ActivityTraceFlags.RandomTraceId flag
79fb488

CopilotAI review requested due to automatic review settings February 25, 2026 10:48

github-actionsBot added the area-System.Diagnostics.Activity label Feb 25, 2026

Copilotstarted reviewing on behalf of Kielek February 25, 2026 10:49 View session

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Feb 25, 2026

CopilotAI reviewed Feb 25, 2026
View reviewed changes

This was referenced Feb 25, 2026
[Android][CoreCLR] System.Security.Cryptography.Tests killed by lowmemorykiller #118603
Open
[android][clr] No peer certificates when executing System.Net.Http.Functional.Tests on Android emulator #124526
Closed

jkotas requested a review from tarekgh February 25, 2026 14:27

tarekgh marked this pull request as draft February 25, 2026 16:24

tarekgh added this to the 11.0.0 milestone Feb 25, 2026

tarekgh added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 25, 2026

tarekgh self-assigned this Feb 25, 2026

dotnet-policy-serviceBot removed this from the 11.0.0 milestone Mar 27, 2026

dotnet-policy-serviceBot closed this Mar 27, 2026

tarekgh reopened this Mar 27, 2026

tarekgh added this to the 11.0.0 milestone Mar 27, 2026

Rename RandomizedTraceId to HasRandomizedTraceId
490c33d

tarekgh removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 7, 2026

tarekgh marked this pull request as ready for review April 7, 2026 21:20

CopilotAI review requested due to automatic review settings April 7, 2026 21:20

Merge branch 'main' into activity-traceidrandom
1366807

Copilotstarted reviewing on behalf of tarekgh April 7, 2026 21:21 View session

CopilotAI reviewed Apr 7, 2026
View reviewed changes

tarekgh force-pushed the activity-traceidrandom branch from 4c37109 to 3c0d7fcCompare April 8, 2026 19:19

CopilotAI review requested due to automatic review settings April 8, 2026 19:19

Copilotstarted reviewing on behalf of tarekgh April 8, 2026 19:20 View session

Kielek commented Apr 8, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

CopilotAI reviewed Apr 8, 2026
View reviewed changes

Comment thread...ibraries/System.Diagnostics.DiagnosticSource/tests/DiagnosticSourceEventSourceBridgeTests.cs Outdated

Address review feedback
3c0104a
- Output full ActivityTraceFlags value instead of just Recorded bit in EventSourceLogger, so all flags are propagated to consumers. - Update EventSourceLoggerTest assertion to match. - Fix typo in test method name: Speciifc -> Specific.

noahfalk reviewed Apr 8, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

martincostello reviewed Apr 9, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

Use CultureInfo.InvariantCulture in ToString for ActivityTraceFlags
49cef15

CopilotAI review requested due to automatic review settings April 9, 2026 17:20

Copilotstarted reviewing on behalf of tarekgh April 9, 2026 17:22 View session

CopilotAI reviewed Apr 9, 2026
View reviewed changes

tarekgh approved these changes Apr 10, 2026
View reviewed changes

tarekgh merged commit cc78323 into dotnet:mainApr 10, 2026
85 of 97 checks passed

dotnet-maestroBot mentioned this pull request Apr 10, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5969
Merged

Kielek deleted the activity-traceidrandom branch April 10, 2026 04:28

CopilotAI mentioned this pull request Apr 11, 2026
Fix WasmTestOnChrome: exclude browser/wasi from gen-debug-dump-docs.py helix post-command #126789
Merged
1 task

github-actionsBot locked and limited conversation to collaborators May 10, 2026

Add ActivityTraceFlags.RandomTraceId flag
79fb488

CopilotAI review requested due to automatic review settings February 25, 2026 10:48

github-actionsBot added the area-System.Diagnostics.Activity label Feb 25, 2026

Copilotstarted reviewing on behalf of Kielek February 25, 2026 10:49 View session

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Feb 25, 2026

CopilotAI reviewed Feb 25, 2026
View reviewed changes

This was referenced Feb 25, 2026
[Android][CoreCLR] System.Security.Cryptography.Tests killed by lowmemorykiller #118603
Open
[android][clr] No peer certificates when executing System.Net.Http.Functional.Tests on Android emulator #124526
Closed

jkotas requested a review from tarekgh February 25, 2026 14:27

tarekgh marked this pull request as draft February 25, 2026 16:24

tarekgh added this to the 11.0.0 milestone Feb 25, 2026

tarekgh added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 25, 2026

tarekgh self-assigned this Feb 25, 2026

dotnet-policy-serviceBot removed this from the 11.0.0 milestone Mar 27, 2026

dotnet-policy-serviceBot closed this Mar 27, 2026

tarekgh reopened this Mar 27, 2026

tarekgh added this to the 11.0.0 milestone Mar 27, 2026

Rename RandomizedTraceId to HasRandomizedTraceId
490c33d

tarekgh removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 7, 2026

tarekgh marked this pull request as ready for review April 7, 2026 21:20

CopilotAI review requested due to automatic review settings April 7, 2026 21:20

Merge branch 'main' into activity-traceidrandom
1366807

Copilotstarted reviewing on behalf of tarekgh April 7, 2026 21:21 View session

CopilotAI reviewed Apr 7, 2026
View reviewed changes

tarekgh force-pushed the activity-traceidrandom branch from 4c37109 to 3c0d7fcCompare April 8, 2026 19:19

CopilotAI review requested due to automatic review settings April 8, 2026 19:19

Copilotstarted reviewing on behalf of tarekgh April 8, 2026 19:20 View session

Kielek commented Apr 8, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

CopilotAI reviewed Apr 8, 2026
View reviewed changes

Comment thread...ibraries/System.Diagnostics.DiagnosticSource/tests/DiagnosticSourceEventSourceBridgeTests.cs Outdated

Address review feedback
3c0104a
- Output full ActivityTraceFlags value instead of just Recorded bit in EventSourceLogger, so all flags are propagated to consumers. - Update EventSourceLoggerTest assertion to match. - Fix typo in test method name: Speciifc -> Specific.

noahfalk reviewed Apr 8, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

martincostello reviewed Apr 9, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

Use CultureInfo.InvariantCulture in ToString for ActivityTraceFlags
49cef15

CopilotAI review requested due to automatic review settings April 9, 2026 17:20

Copilotstarted reviewing on behalf of tarekgh April 9, 2026 17:22 View session

CopilotAI reviewed Apr 9, 2026
View reviewed changes

tarekgh approved these changes Apr 10, 2026
View reviewed changes

tarekgh merged commit cc78323 into dotnet:mainApr 10, 2026
85 of 97 checks passed

dotnet-maestroBot mentioned this pull request Apr 10, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5969
Merged

Kielek deleted the activity-traceidrandom branch April 10, 2026 04:28

CopilotAI mentioned this pull request Apr 11, 2026
Fix WasmTestOnChrome: exclude browser/wasi from gen-debug-dump-docs.py helix post-command #126789
Merged
1 task

github-actionsBot locked and limited conversation to collaborators May 10, 2026

Add ActivityTraceFlags.RandomTraceId flag
79fb488

CopilotAI review requested due to automatic review settings February 25, 2026 10:48

github-actionsBot added the area-System.Diagnostics.Activity label Feb 25, 2026

Copilotstarted reviewing on behalf of Kielek February 25, 2026 10:49 View session

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Feb 25, 2026

CopilotAI reviewed Feb 25, 2026
View reviewed changes

This was referenced Feb 25, 2026
[Android][CoreCLR] System.Security.Cryptography.Tests killed by lowmemorykiller #118603
Open
[android][clr] No peer certificates when executing System.Net.Http.Functional.Tests on Android emulator #124526
Closed

jkotas requested a review from tarekgh February 25, 2026 14:27

tarekgh marked this pull request as draft February 25, 2026 16:24

tarekgh added this to the 11.0.0 milestone Feb 25, 2026

tarekgh added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 25, 2026

tarekgh self-assigned this Feb 25, 2026

dotnet-policy-serviceBot removed this from the 11.0.0 milestone Mar 27, 2026

dotnet-policy-serviceBot closed this Mar 27, 2026

tarekgh reopened this Mar 27, 2026

tarekgh added this to the 11.0.0 milestone Mar 27, 2026

Rename RandomizedTraceId to HasRandomizedTraceId
490c33d

tarekgh removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 7, 2026

tarekgh marked this pull request as ready for review April 7, 2026 21:20

CopilotAI review requested due to automatic review settings April 7, 2026 21:20

Merge branch 'main' into activity-traceidrandom
1366807

Copilotstarted reviewing on behalf of tarekgh April 7, 2026 21:21 View session

CopilotAI reviewed Apr 7, 2026
View reviewed changes

tarekgh force-pushed the activity-traceidrandom branch from 4c37109 to 3c0d7fcCompare April 8, 2026 19:19

CopilotAI review requested due to automatic review settings April 8, 2026 19:19

Copilotstarted reviewing on behalf of tarekgh April 8, 2026 19:20 View session

Kielek commented Apr 8, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

CopilotAI reviewed Apr 8, 2026
View reviewed changes

Comment thread...ibraries/System.Diagnostics.DiagnosticSource/tests/DiagnosticSourceEventSourceBridgeTests.cs Outdated

Address review feedback
3c0104a
- Output full ActivityTraceFlags value instead of just Recorded bit in EventSourceLogger, so all flags are propagated to consumers. - Update EventSourceLoggerTest assertion to match. - Fix typo in test method name: Speciifc -> Specific.

noahfalk reviewed Apr 8, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

martincostello reviewed Apr 9, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

Use CultureInfo.InvariantCulture in ToString for ActivityTraceFlags
49cef15

CopilotAI review requested due to automatic review settings April 9, 2026 17:20

Copilotstarted reviewing on behalf of tarekgh April 9, 2026 17:22 View session

CopilotAI reviewed Apr 9, 2026
View reviewed changes

tarekgh approved these changes Apr 10, 2026
View reviewed changes

tarekgh merged commit cc78323 into dotnet:mainApr 10, 2026
85 of 97 checks passed

dotnet-maestroBot mentioned this pull request Apr 10, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5969
Merged

Kielek deleted the activity-traceidrandom branch April 10, 2026 04:28

CopilotAI mentioned this pull request Apr 11, 2026
Fix WasmTestOnChrome: exclude browser/wasi from gen-debug-dump-docs.py helix post-command #126789
Merged
1 task

github-actionsBot locked and limited conversation to collaborators May 10, 2026

Add ActivityTraceFlags.RandomTraceId flag
79fb488

CopilotAI review requested due to automatic review settings February 25, 2026 10:48

github-actionsBot added the area-System.Diagnostics.Activity label Feb 25, 2026

Copilotstarted reviewing on behalf of Kielek February 25, 2026 10:49 View session

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Feb 25, 2026

CopilotAI reviewed Feb 25, 2026
View reviewed changes

This was referenced Feb 25, 2026
[Android][CoreCLR] System.Security.Cryptography.Tests killed by lowmemorykiller #118603
Open
[android][clr] No peer certificates when executing System.Net.Http.Functional.Tests on Android emulator #124526
Closed

jkotas requested a review from tarekgh February 25, 2026 14:27

tarekgh marked this pull request as draft February 25, 2026 16:24

tarekgh added this to the 11.0.0 milestone Feb 25, 2026

tarekgh added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 25, 2026

tarekgh self-assigned this Feb 25, 2026

dotnet-policy-serviceBot removed this from the 11.0.0 milestone Mar 27, 2026

dotnet-policy-serviceBot closed this Mar 27, 2026

tarekgh reopened this Mar 27, 2026

tarekgh added this to the 11.0.0 milestone Mar 27, 2026

Rename RandomizedTraceId to HasRandomizedTraceId
490c33d

tarekgh removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 7, 2026

tarekgh marked this pull request as ready for review April 7, 2026 21:20

CopilotAI review requested due to automatic review settings April 7, 2026 21:20

Merge branch 'main' into activity-traceidrandom
1366807

Copilotstarted reviewing on behalf of tarekgh April 7, 2026 21:21 View session

CopilotAI reviewed Apr 7, 2026
View reviewed changes

tarekgh force-pushed the activity-traceidrandom branch from 4c37109 to 3c0d7fcCompare April 8, 2026 19:19

CopilotAI review requested due to automatic review settings April 8, 2026 19:19

Copilotstarted reviewing on behalf of tarekgh April 8, 2026 19:20 View session

Kielek commented Apr 8, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

CopilotAI reviewed Apr 8, 2026
View reviewed changes

Comment thread...ibraries/System.Diagnostics.DiagnosticSource/tests/DiagnosticSourceEventSourceBridgeTests.cs Outdated

Address review feedback
3c0104a
- Output full ActivityTraceFlags value instead of just Recorded bit in EventSourceLogger, so all flags are propagated to consumers. - Update EventSourceLoggerTest assertion to match. - Fix typo in test method name: Speciifc -> Specific.

noahfalk reviewed Apr 8, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

martincostello reviewed Apr 9, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

Use CultureInfo.InvariantCulture in ToString for ActivityTraceFlags
49cef15

CopilotAI review requested due to automatic review settings April 9, 2026 17:20

Copilotstarted reviewing on behalf of tarekgh April 9, 2026 17:22 View session

CopilotAI reviewed Apr 9, 2026
View reviewed changes

tarekgh approved these changes Apr 10, 2026
View reviewed changes

tarekgh merged commit cc78323 into dotnet:mainApr 10, 2026
85 of 97 checks passed

dotnet-maestroBot mentioned this pull request Apr 10, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5969
Merged

Kielek deleted the activity-traceidrandom branch April 10, 2026 04:28

CopilotAI mentioned this pull request Apr 11, 2026
Fix WasmTestOnChrome: exclude browser/wasi from gen-debug-dump-docs.py helix post-command #126789
Merged
1 task

github-actionsBot locked and limited conversation to collaborators May 10, 2026

Add ActivityTraceFlags.RandomTraceId flag
79fb488

CopilotAI review requested due to automatic review settings February 25, 2026 10:48

github-actionsBot added the area-System.Diagnostics.Activity label Feb 25, 2026

Copilotstarted reviewing on behalf of Kielek February 25, 2026 10:49 View session

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Feb 25, 2026

CopilotAI reviewed Feb 25, 2026
View reviewed changes

This was referenced Feb 25, 2026
[Android][CoreCLR] System.Security.Cryptography.Tests killed by lowmemorykiller #118603
Open
[android][clr] No peer certificates when executing System.Net.Http.Functional.Tests on Android emulator #124526
Closed

jkotas requested a review from tarekgh February 25, 2026 14:27

tarekgh marked this pull request as draft February 25, 2026 16:24

tarekgh added this to the 11.0.0 milestone Feb 25, 2026

tarekgh added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 25, 2026

tarekgh self-assigned this Feb 25, 2026

dotnet-policy-serviceBot removed this from the 11.0.0 milestone Mar 27, 2026

dotnet-policy-serviceBot closed this Mar 27, 2026

tarekgh reopened this Mar 27, 2026

tarekgh added this to the 11.0.0 milestone Mar 27, 2026

Rename RandomizedTraceId to HasRandomizedTraceId
490c33d

tarekgh removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 7, 2026

tarekgh marked this pull request as ready for review April 7, 2026 21:20

CopilotAI review requested due to automatic review settings April 7, 2026 21:20

Merge branch 'main' into activity-traceidrandom
1366807

Copilotstarted reviewing on behalf of tarekgh April 7, 2026 21:21 View session

CopilotAI reviewed Apr 7, 2026
View reviewed changes

tarekgh force-pushed the activity-traceidrandom branch from 4c37109 to 3c0d7fcCompare April 8, 2026 19:19

CopilotAI review requested due to automatic review settings April 8, 2026 19:19

Copilotstarted reviewing on behalf of tarekgh April 8, 2026 19:20 View session

Kielek commented Apr 8, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

CopilotAI reviewed Apr 8, 2026
View reviewed changes

Comment thread...ibraries/System.Diagnostics.DiagnosticSource/tests/DiagnosticSourceEventSourceBridgeTests.cs Outdated

Address review feedback
3c0104a
- Output full ActivityTraceFlags value instead of just Recorded bit in EventSourceLogger, so all flags are propagated to consumers. - Update EventSourceLoggerTest assertion to match. - Fix typo in test method name: Speciifc -> Specific.

noahfalk reviewed Apr 8, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

martincostello reviewed Apr 9, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

Use CultureInfo.InvariantCulture in ToString for ActivityTraceFlags
49cef15

CopilotAI review requested due to automatic review settings April 9, 2026 17:20

Copilotstarted reviewing on behalf of tarekgh April 9, 2026 17:22 View session

CopilotAI reviewed Apr 9, 2026
View reviewed changes

tarekgh approved these changes Apr 10, 2026
View reviewed changes

tarekgh merged commit cc78323 into dotnet:mainApr 10, 2026
85 of 97 checks passed

dotnet-maestroBot mentioned this pull request Apr 10, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5969
Merged

Kielek deleted the activity-traceidrandom branch April 10, 2026 04:28

CopilotAI mentioned this pull request Apr 11, 2026
Fix WasmTestOnChrome: exclude browser/wasi from gen-debug-dump-docs.py helix post-command #126789
Merged
1 task

github-actionsBot locked and limited conversation to collaborators May 10, 2026

Add ActivityTraceFlags.RandomTraceId flag
79fb488

CopilotAI review requested due to automatic review settings February 25, 2026 10:48

github-actionsBot added the area-System.Diagnostics.Activity label Feb 25, 2026

Copilotstarted reviewing on behalf of Kielek February 25, 2026 10:49 View session

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Feb 25, 2026

CopilotAI reviewed Feb 25, 2026
View reviewed changes

This was referenced Feb 25, 2026
[Android][CoreCLR] System.Security.Cryptography.Tests killed by lowmemorykiller #118603
Open
[android][clr] No peer certificates when executing System.Net.Http.Functional.Tests on Android emulator #124526
Closed

jkotas requested a review from tarekgh February 25, 2026 14:27

tarekgh marked this pull request as draft February 25, 2026 16:24

tarekgh added this to the 11.0.0 milestone Feb 25, 2026

tarekgh added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 25, 2026

tarekgh self-assigned this Feb 25, 2026

dotnet-policy-serviceBot removed this from the 11.0.0 milestone Mar 27, 2026

dotnet-policy-serviceBot closed this Mar 27, 2026

tarekgh reopened this Mar 27, 2026

tarekgh added this to the 11.0.0 milestone Mar 27, 2026

Rename RandomizedTraceId to HasRandomizedTraceId
490c33d

tarekgh removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 7, 2026

tarekgh marked this pull request as ready for review April 7, 2026 21:20

CopilotAI review requested due to automatic review settings April 7, 2026 21:20

Merge branch 'main' into activity-traceidrandom
1366807

Copilotstarted reviewing on behalf of tarekgh April 7, 2026 21:21 View session

CopilotAI reviewed Apr 7, 2026
View reviewed changes

tarekgh force-pushed the activity-traceidrandom branch from 4c37109 to 3c0d7fcCompare April 8, 2026 19:19

CopilotAI review requested due to automatic review settings April 8, 2026 19:19

Copilotstarted reviewing on behalf of tarekgh April 8, 2026 19:20 View session

Kielek commented Apr 8, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

CopilotAI reviewed Apr 8, 2026
View reviewed changes

Comment thread...ibraries/System.Diagnostics.DiagnosticSource/tests/DiagnosticSourceEventSourceBridgeTests.cs Outdated

Address review feedback
3c0104a
- Output full ActivityTraceFlags value instead of just Recorded bit in EventSourceLogger, so all flags are propagated to consumers. - Update EventSourceLoggerTest assertion to match. - Fix typo in test method name: Speciifc -> Specific.

noahfalk reviewed Apr 8, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

martincostello reviewed Apr 9, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

Use CultureInfo.InvariantCulture in ToString for ActivityTraceFlags
49cef15

CopilotAI review requested due to automatic review settings April 9, 2026 17:20

Copilotstarted reviewing on behalf of tarekgh April 9, 2026 17:22 View session

CopilotAI reviewed Apr 9, 2026
View reviewed changes

tarekgh approved these changes Apr 10, 2026
View reviewed changes

tarekgh merged commit cc78323 into dotnet:mainApr 10, 2026
85 of 97 checks passed

dotnet-maestroBot mentioned this pull request Apr 10, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5969
Merged

Kielek deleted the activity-traceidrandom branch April 10, 2026 04:28

CopilotAI mentioned this pull request Apr 11, 2026
Fix WasmTestOnChrome: exclude browser/wasi from gen-debug-dump-docs.py helix post-command #126789
Merged
1 task

github-actionsBot locked and limited conversation to collaborators May 10, 2026

Add ActivityTraceFlags.RandomTraceId flag
79fb488

CopilotAI review requested due to automatic review settings February 25, 2026 10:48

github-actionsBot added the area-System.Diagnostics.Activity label Feb 25, 2026

Copilotstarted reviewing on behalf of Kielek February 25, 2026 10:49 View session

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Feb 25, 2026

CopilotAI reviewed Feb 25, 2026
View reviewed changes

This was referenced Feb 25, 2026
[Android][CoreCLR] System.Security.Cryptography.Tests killed by lowmemorykiller #118603
Open
[android][clr] No peer certificates when executing System.Net.Http.Functional.Tests on Android emulator #124526
Closed

jkotas requested a review from tarekgh February 25, 2026 14:27

tarekgh marked this pull request as draft February 25, 2026 16:24

tarekgh added this to the 11.0.0 milestone Feb 25, 2026

tarekgh added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 25, 2026

tarekgh self-assigned this Feb 25, 2026

dotnet-policy-serviceBot removed this from the 11.0.0 milestone Mar 27, 2026

dotnet-policy-serviceBot closed this Mar 27, 2026

tarekgh reopened this Mar 27, 2026

tarekgh added this to the 11.0.0 milestone Mar 27, 2026

Rename RandomizedTraceId to HasRandomizedTraceId
490c33d

tarekgh removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 7, 2026

tarekgh marked this pull request as ready for review April 7, 2026 21:20

CopilotAI review requested due to automatic review settings April 7, 2026 21:20

Merge branch 'main' into activity-traceidrandom
1366807

Copilotstarted reviewing on behalf of tarekgh April 7, 2026 21:21 View session

CopilotAI reviewed Apr 7, 2026
View reviewed changes

tarekgh force-pushed the activity-traceidrandom branch from 4c37109 to 3c0d7fcCompare April 8, 2026 19:19

CopilotAI review requested due to automatic review settings April 8, 2026 19:19

Copilotstarted reviewing on behalf of tarekgh April 8, 2026 19:20 View session

Kielek commented Apr 8, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

CopilotAI reviewed Apr 8, 2026
View reviewed changes

Comment thread...ibraries/System.Diagnostics.DiagnosticSource/tests/DiagnosticSourceEventSourceBridgeTests.cs Outdated

Address review feedback
3c0104a
- Output full ActivityTraceFlags value instead of just Recorded bit in EventSourceLogger, so all flags are propagated to consumers. - Update EventSourceLoggerTest assertion to match. - Fix typo in test method name: Speciifc -> Specific.

noahfalk reviewed Apr 8, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

martincostello reviewed Apr 9, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

Use CultureInfo.InvariantCulture in ToString for ActivityTraceFlags
49cef15

CopilotAI review requested due to automatic review settings April 9, 2026 17:20

Copilotstarted reviewing on behalf of tarekgh April 9, 2026 17:22 View session

CopilotAI reviewed Apr 9, 2026
View reviewed changes

tarekgh approved these changes Apr 10, 2026
View reviewed changes

tarekgh merged commit cc78323 into dotnet:mainApr 10, 2026
85 of 97 checks passed

dotnet-maestroBot mentioned this pull request Apr 10, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5969
Merged

Kielek deleted the activity-traceidrandom branch April 10, 2026 04:28

CopilotAI mentioned this pull request Apr 11, 2026
Fix WasmTestOnChrome: exclude browser/wasi from gen-debug-dump-docs.py helix post-command #126789
Merged
1 task

github-actionsBot locked and limited conversation to collaborators May 10, 2026

Add ActivityTraceFlags.RandomTraceId flag
79fb488

CopilotAI review requested due to automatic review settings February 25, 2026 10:48

github-actionsBot added the area-System.Diagnostics.Activity label Feb 25, 2026

Copilotstarted reviewing on behalf of Kielek February 25, 2026 10:49 View session

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Feb 25, 2026

CopilotAI reviewed Feb 25, 2026
View reviewed changes

This was referenced Feb 25, 2026
[Android][CoreCLR] System.Security.Cryptography.Tests killed by lowmemorykiller #118603
Open
[android][clr] No peer certificates when executing System.Net.Http.Functional.Tests on Android emulator #124526
Closed

jkotas requested a review from tarekgh February 25, 2026 14:27

tarekgh marked this pull request as draft February 25, 2026 16:24

tarekgh added this to the 11.0.0 milestone Feb 25, 2026

tarekgh added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 25, 2026

tarekgh self-assigned this Feb 25, 2026

dotnet-policy-serviceBot removed this from the 11.0.0 milestone Mar 27, 2026

dotnet-policy-serviceBot closed this Mar 27, 2026

tarekgh reopened this Mar 27, 2026

tarekgh added this to the 11.0.0 milestone Mar 27, 2026

Rename RandomizedTraceId to HasRandomizedTraceId
490c33d

tarekgh removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 7, 2026

tarekgh marked this pull request as ready for review April 7, 2026 21:20

CopilotAI review requested due to automatic review settings April 7, 2026 21:20

Merge branch 'main' into activity-traceidrandom
1366807

Copilotstarted reviewing on behalf of tarekgh April 7, 2026 21:21 View session

CopilotAI reviewed Apr 7, 2026
View reviewed changes

tarekgh force-pushed the activity-traceidrandom branch from 4c37109 to 3c0d7fcCompare April 8, 2026 19:19

CopilotAI review requested due to automatic review settings April 8, 2026 19:19

Copilotstarted reviewing on behalf of tarekgh April 8, 2026 19:20 View session

Kielek commented Apr 8, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

CopilotAI reviewed Apr 8, 2026
View reviewed changes

Comment thread...ibraries/System.Diagnostics.DiagnosticSource/tests/DiagnosticSourceEventSourceBridgeTests.cs Outdated

Address review feedback
3c0104a
- Output full ActivityTraceFlags value instead of just Recorded bit in EventSourceLogger, so all flags are propagated to consumers. - Update EventSourceLoggerTest assertion to match. - Fix typo in test method name: Speciifc -> Specific.

noahfalk reviewed Apr 8, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

martincostello reviewed Apr 9, 2026
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs Outdated

Use CultureInfo.InvariantCulture in ToString for ActivityTraceFlags
49cef15

CopilotAI review requested due to automatic review settings April 9, 2026 17:20

Copilotstarted reviewing on behalf of tarekgh April 9, 2026 17:22 View session

CopilotAI reviewed Apr 9, 2026
View reviewed changes

tarekgh approved these changes Apr 10, 2026
View reviewed changes

tarekgh merged commit cc78323 into dotnet:mainApr 10, 2026
85 of 97 checks passed

dotnet-maestroBot mentioned this pull request Apr 10, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5969
Merged

Kielek deleted the activity-traceidrandom branch April 10, 2026 04:28

CopilotAI mentioned this pull request Apr 11, 2026
Fix WasmTestOnChrome: exclude browser/wasi from gen-debug-dump-docs.py helix post-command #126789
Merged
1 task

github-actionsBot locked and limited conversation to collaborators May 10, 2026

Uh oh!

Conversation

Kielek commented Feb 25, 2026

Uh oh!

dotnet-policy-serviceBot commented Feb 25, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

tarekgh commented Feb 25, 2026

Uh oh!

dotnet-policy-serviceBot commented Mar 27, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kielek commented Apr 8, 2026

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

tarekgh commented Apr 9, 2026

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

tarekgh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Kielek commented Feb 25, 2026

Uh oh!

dotnet-policy-serviceBot commented Feb 25, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

tarekgh commented Feb 25, 2026

Uh oh!

dotnet-policy-serviceBot commented Mar 27, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kielek commented Apr 8, 2026

Uh oh!

Uh oh!

CopilotAI left a comment