[Apple mobile] Skip unsupported tests on Apple mobile platforms

[kotlarmilos]

Summary

Skip unsupported tests on Apple mobile platforms.

Changes

• Exclude System.Diagnostics.TraceSource.Config.Tests.csproj
• CustomMethodInfoTests.GetMethodImplementationFlags_ReturnsIL and CustomConstructorInfoTests.GetMethodImplementationFlags_ReturnsIL not supported on Mono
• Set RestoreUseStaticGraphEvaluation=false to workaround known nuget issue

[dotnet-policy-service]

Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

Fixes test failures on Apple mobile platforms (iOS/tvOS/MacCatalyst) caused by Mono AOT IL stripping altering/removing method bodies, by skipping or conditioning affected tests.

Changes:

• Update IsMethodBodySupported to account for aggressively-trimmed builds (incl. Apple mobile).
• Make GetMethodImplementationFlags_ReturnsIL tests conditional on method-body availability.
• Skip ProcessTests.Start_Disposed_ThrowsObjectDisposedException on Apple mobile platforms.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs	Makes the implementation-flags assertion conditional on PlatformDetection.IsMethodBodySupported.
src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs	Same conditional gating for constructor implementation-flags test.
src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs	Skips a disposed-start exception test on select Apple platforms.
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs	Broadens IsMethodBodySupported to treat aggressively trimmed builds as unsupported for method-body-based tests.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

[kotlarmilos]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vitek-karas]

Looks good
@adamsitnik can you quickly review the process test changes just to be sure?

[vitek-karas]

I'm also trying to add #126635 into this since it looks like the same root cause (agressive trimming)

[adamsitnik]

Process part LGTM, thank you @kotlarmilos !

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs:194

• GetMethodImplementationFlags_ReturnsIL is now conditioned on PlatformDetection.IsNotMonoRuntime, which will still run on NativeAOT and on CoreCLR-based Apple mobile runs. Those are exactly the environments where aggressive trimming/AOT can change MethodImplAttributes away from IL, so this test may still fail. If the intent is to skip when method bodies/IL are stripped, gate this on PlatformDetection.IsMethodBodySupported (or IsNotBuiltWithAggressiveTrimming) instead of IsNotMonoRuntime, or update the assertion to accept the trimmed/AOT flags when appropriate.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customMethod.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);

src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs:162

• Same issue as CustomMethodInfoTests: conditioning this test on PlatformDetection.IsNotMonoRuntime will still execute it on NativeAOT (and potentially CoreCLR-based Apple mobile), where trimming/AOT can change GetMethodImplementationFlags() away from MethodImplAttributes.IL. Consider gating on PlatformDetection.IsMethodBodySupported / IsNotBuiltWithAggressiveTrimming, or broaden the expected flags for trimmed/AOT builds.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customConstructor.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs:195

• Using PlatformDetection.IsNotMonoRuntime here skips the test on all Mono configurations, but it still runs on NativeAOT (which is also affected by aggressive trimming/IL stripping). If the intent is to avoid failures when method bodies are stripped and the implementation flags change, consider conditioning on PlatformDetection.IsNotBuiltWithAggressiveTrimming (or another trimming/AOT-specific predicate) instead so the test continues to run on non-trimmed Mono and is skipped on NativeAOT/Apple-mobile where it’s known to differ.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customMethod.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);
}

src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs:163

• Same issue as CustomMethodInfoTests: PlatformDetection.IsNotMonoRuntime will skip on all Mono configurations but still run on NativeAOT. If this assertion is only valid when method bodies aren’t aggressively trimmed, condition it on PlatformDetection.IsNotBuiltWithAggressiveTrimming (or similar) so it’s skipped on NativeAOT/Apple-mobile but still exercised on non-trimmed Mono.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customConstructor.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);
}

[kotlarmilos]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kotlarmilos]

/ba-g #126744

[kotlarmilos]

Summary

Skip unsupported tests on Apple mobile platforms.

Changes

• Exclude System.Diagnostics.TraceSource.Config.Tests.csproj
• CustomMethodInfoTests.GetMethodImplementationFlags_ReturnsIL and CustomConstructorInfoTests.GetMethodImplementationFlags_ReturnsIL not supported on Mono
• Set RestoreUseStaticGraphEvaluation=false to workaround known nuget issue

[dotnet-policy-service]

Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

Fixes test failures on Apple mobile platforms (iOS/tvOS/MacCatalyst) caused by Mono AOT IL stripping altering/removing method bodies, by skipping or conditioning affected tests.

Changes:

• Update IsMethodBodySupported to account for aggressively-trimmed builds (incl. Apple mobile).
• Make GetMethodImplementationFlags_ReturnsIL tests conditional on method-body availability.
• Skip ProcessTests.Start_Disposed_ThrowsObjectDisposedException on Apple mobile platforms.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs	Makes the implementation-flags assertion conditional on PlatformDetection.IsMethodBodySupported.
src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs	Same conditional gating for constructor implementation-flags test.
src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs	Skips a disposed-start exception test on select Apple platforms.
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs	Broadens IsMethodBodySupported to treat aggressively trimmed builds as unsupported for method-body-based tests.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

[kotlarmilos]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vitek-karas]

Looks good
@adamsitnik can you quickly review the process test changes just to be sure?

[vitek-karas]

I'm also trying to add #126635 into this since it looks like the same root cause (agressive trimming)

[adamsitnik]

Process part LGTM, thank you @kotlarmilos !

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs:194

• GetMethodImplementationFlags_ReturnsIL is now conditioned on PlatformDetection.IsNotMonoRuntime, which will still run on NativeAOT and on CoreCLR-based Apple mobile runs. Those are exactly the environments where aggressive trimming/AOT can change MethodImplAttributes away from IL, so this test may still fail. If the intent is to skip when method bodies/IL are stripped, gate this on PlatformDetection.IsMethodBodySupported (or IsNotBuiltWithAggressiveTrimming) instead of IsNotMonoRuntime, or update the assertion to accept the trimmed/AOT flags when appropriate.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customMethod.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);

src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs:162

• Same issue as CustomMethodInfoTests: conditioning this test on PlatformDetection.IsNotMonoRuntime will still execute it on NativeAOT (and potentially CoreCLR-based Apple mobile), where trimming/AOT can change GetMethodImplementationFlags() away from MethodImplAttributes.IL. Consider gating on PlatformDetection.IsMethodBodySupported / IsNotBuiltWithAggressiveTrimming, or broaden the expected flags for trimmed/AOT builds.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customConstructor.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs:195

• Using PlatformDetection.IsNotMonoRuntime here skips the test on all Mono configurations, but it still runs on NativeAOT (which is also affected by aggressive trimming/IL stripping). If the intent is to avoid failures when method bodies are stripped and the implementation flags change, consider conditioning on PlatformDetection.IsNotBuiltWithAggressiveTrimming (or another trimming/AOT-specific predicate) instead so the test continues to run on non-trimmed Mono and is skipped on NativeAOT/Apple-mobile where it’s known to differ.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customMethod.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);
}

src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs:163

• Same issue as CustomMethodInfoTests: PlatformDetection.IsNotMonoRuntime will skip on all Mono configurations but still run on NativeAOT. If this assertion is only valid when method bodies aren’t aggressively trimmed, condition it on PlatformDetection.IsNotBuiltWithAggressiveTrimming (or similar) so it’s skipped on NativeAOT/Apple-mobile but still exercised on non-trimmed Mono.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customConstructor.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);
}

[kotlarmilos]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kotlarmilos]

/ba-g #126744

[kotlarmilos]

Summary

Skip unsupported tests on Apple mobile platforms.

Changes

• Exclude System.Diagnostics.TraceSource.Config.Tests.csproj
• CustomMethodInfoTests.GetMethodImplementationFlags_ReturnsIL and CustomConstructorInfoTests.GetMethodImplementationFlags_ReturnsIL not supported on Mono
• Set RestoreUseStaticGraphEvaluation=false to workaround known nuget issue

[dotnet-policy-service]

Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

Fixes test failures on Apple mobile platforms (iOS/tvOS/MacCatalyst) caused by Mono AOT IL stripping altering/removing method bodies, by skipping or conditioning affected tests.

Changes:

• Update IsMethodBodySupported to account for aggressively-trimmed builds (incl. Apple mobile).
• Make GetMethodImplementationFlags_ReturnsIL tests conditional on method-body availability.
• Skip ProcessTests.Start_Disposed_ThrowsObjectDisposedException on Apple mobile platforms.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs	Makes the implementation-flags assertion conditional on PlatformDetection.IsMethodBodySupported.
src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs	Same conditional gating for constructor implementation-flags test.
src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs	Skips a disposed-start exception test on select Apple platforms.
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs	Broadens IsMethodBodySupported to treat aggressively trimmed builds as unsupported for method-body-based tests.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

[kotlarmilos]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vitek-karas]

Looks good
@adamsitnik can you quickly review the process test changes just to be sure?

[vitek-karas]

I'm also trying to add #126635 into this since it looks like the same root cause (agressive trimming)

[adamsitnik]

Process part LGTM, thank you @kotlarmilos !

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs:194

• GetMethodImplementationFlags_ReturnsIL is now conditioned on PlatformDetection.IsNotMonoRuntime, which will still run on NativeAOT and on CoreCLR-based Apple mobile runs. Those are exactly the environments where aggressive trimming/AOT can change MethodImplAttributes away from IL, so this test may still fail. If the intent is to skip when method bodies/IL are stripped, gate this on PlatformDetection.IsMethodBodySupported (or IsNotBuiltWithAggressiveTrimming) instead of IsNotMonoRuntime, or update the assertion to accept the trimmed/AOT flags when appropriate.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customMethod.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);

src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs:162

• Same issue as CustomMethodInfoTests: conditioning this test on PlatformDetection.IsNotMonoRuntime will still execute it on NativeAOT (and potentially CoreCLR-based Apple mobile), where trimming/AOT can change GetMethodImplementationFlags() away from MethodImplAttributes.IL. Consider gating on PlatformDetection.IsMethodBodySupported / IsNotBuiltWithAggressiveTrimming, or broaden the expected flags for trimmed/AOT builds.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customConstructor.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs:195

• Using PlatformDetection.IsNotMonoRuntime here skips the test on all Mono configurations, but it still runs on NativeAOT (which is also affected by aggressive trimming/IL stripping). If the intent is to avoid failures when method bodies are stripped and the implementation flags change, consider conditioning on PlatformDetection.IsNotBuiltWithAggressiveTrimming (or another trimming/AOT-specific predicate) instead so the test continues to run on non-trimmed Mono and is skipped on NativeAOT/Apple-mobile where it’s known to differ.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customMethod.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);
}

src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs:163

• Same issue as CustomMethodInfoTests: PlatformDetection.IsNotMonoRuntime will skip on all Mono configurations but still run on NativeAOT. If this assertion is only valid when method bodies aren’t aggressively trimmed, condition it on PlatformDetection.IsNotBuiltWithAggressiveTrimming (or similar) so it’s skipped on NativeAOT/Apple-mobile but still exercised on non-trimmed Mono.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customConstructor.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);
}

[kotlarmilos]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kotlarmilos]

/ba-g #126744

[kotlarmilos]

Summary

Skip unsupported tests on Apple mobile platforms.

Changes

• Exclude System.Diagnostics.TraceSource.Config.Tests.csproj
• CustomMethodInfoTests.GetMethodImplementationFlags_ReturnsIL and CustomConstructorInfoTests.GetMethodImplementationFlags_ReturnsIL not supported on Mono
• Set RestoreUseStaticGraphEvaluation=false to workaround known nuget issue

[dotnet-policy-service]

Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

Fixes test failures on Apple mobile platforms (iOS/tvOS/MacCatalyst) caused by Mono AOT IL stripping altering/removing method bodies, by skipping or conditioning affected tests.

Changes:

• Update IsMethodBodySupported to account for aggressively-trimmed builds (incl. Apple mobile).
• Make GetMethodImplementationFlags_ReturnsIL tests conditional on method-body availability.
• Skip ProcessTests.Start_Disposed_ThrowsObjectDisposedException on Apple mobile platforms.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs	Makes the implementation-flags assertion conditional on PlatformDetection.IsMethodBodySupported.
src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs	Same conditional gating for constructor implementation-flags test.
src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs	Skips a disposed-start exception test on select Apple platforms.
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs	Broadens IsMethodBodySupported to treat aggressively trimmed builds as unsupported for method-body-based tests.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

[kotlarmilos]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vitek-karas]

Looks good
@adamsitnik can you quickly review the process test changes just to be sure?

[vitek-karas]

I'm also trying to add #126635 into this since it looks like the same root cause (agressive trimming)

[adamsitnik]

Process part LGTM, thank you @kotlarmilos !

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs:194

• GetMethodImplementationFlags_ReturnsIL is now conditioned on PlatformDetection.IsNotMonoRuntime, which will still run on NativeAOT and on CoreCLR-based Apple mobile runs. Those are exactly the environments where aggressive trimming/AOT can change MethodImplAttributes away from IL, so this test may still fail. If the intent is to skip when method bodies/IL are stripped, gate this on PlatformDetection.IsMethodBodySupported (or IsNotBuiltWithAggressiveTrimming) instead of IsNotMonoRuntime, or update the assertion to accept the trimmed/AOT flags when appropriate.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customMethod.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);

src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs:162

• Same issue as CustomMethodInfoTests: conditioning this test on PlatformDetection.IsNotMonoRuntime will still execute it on NativeAOT (and potentially CoreCLR-based Apple mobile), where trimming/AOT can change GetMethodImplementationFlags() away from MethodImplAttributes.IL. Consider gating on PlatformDetection.IsMethodBodySupported / IsNotBuiltWithAggressiveTrimming, or broaden the expected flags for trimmed/AOT builds.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customConstructor.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs:195

• Using PlatformDetection.IsNotMonoRuntime here skips the test on all Mono configurations, but it still runs on NativeAOT (which is also affected by aggressive trimming/IL stripping). If the intent is to avoid failures when method bodies are stripped and the implementation flags change, consider conditioning on PlatformDetection.IsNotBuiltWithAggressiveTrimming (or another trimming/AOT-specific predicate) instead so the test continues to run on non-trimmed Mono and is skipped on NativeAOT/Apple-mobile where it’s known to differ.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customMethod.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);
}

src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs:163

• Same issue as CustomMethodInfoTests: PlatformDetection.IsNotMonoRuntime will skip on all Mono configurations but still run on NativeAOT. If this assertion is only valid when method bodies aren’t aggressively trimmed, condition it on PlatformDetection.IsNotBuiltWithAggressiveTrimming (or similar) so it’s skipped on NativeAOT/Apple-mobile but still exercised on non-trimmed Mono.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customConstructor.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);
}

[kotlarmilos]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kotlarmilos]

/ba-g #126744

[kotlarmilos]

Summary

Skip unsupported tests on Apple mobile platforms.

Changes

• Exclude System.Diagnostics.TraceSource.Config.Tests.csproj
• CustomMethodInfoTests.GetMethodImplementationFlags_ReturnsIL and CustomConstructorInfoTests.GetMethodImplementationFlags_ReturnsIL not supported on Mono
• Set RestoreUseStaticGraphEvaluation=false to workaround known nuget issue

[dotnet-policy-service]

Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

Fixes test failures on Apple mobile platforms (iOS/tvOS/MacCatalyst) caused by Mono AOT IL stripping altering/removing method bodies, by skipping or conditioning affected tests.

Changes:

• Update IsMethodBodySupported to account for aggressively-trimmed builds (incl. Apple mobile).
• Make GetMethodImplementationFlags_ReturnsIL tests conditional on method-body availability.
• Skip ProcessTests.Start_Disposed_ThrowsObjectDisposedException on Apple mobile platforms.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs	Makes the implementation-flags assertion conditional on PlatformDetection.IsMethodBodySupported.
src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs	Same conditional gating for constructor implementation-flags test.
src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs	Skips a disposed-start exception test on select Apple platforms.
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs	Broadens IsMethodBodySupported to treat aggressively trimmed builds as unsupported for method-body-based tests.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

[kotlarmilos]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vitek-karas]

Looks good
@adamsitnik can you quickly review the process test changes just to be sure?

[vitek-karas]

I'm also trying to add #126635 into this since it looks like the same root cause (agressive trimming)

[adamsitnik]

Process part LGTM, thank you @kotlarmilos !

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs:194

• GetMethodImplementationFlags_ReturnsIL is now conditioned on PlatformDetection.IsNotMonoRuntime, which will still run on NativeAOT and on CoreCLR-based Apple mobile runs. Those are exactly the environments where aggressive trimming/AOT can change MethodImplAttributes away from IL, so this test may still fail. If the intent is to skip when method bodies/IL are stripped, gate this on PlatformDetection.IsMethodBodySupported (or IsNotBuiltWithAggressiveTrimming) instead of IsNotMonoRuntime, or update the assertion to accept the trimmed/AOT flags when appropriate.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customMethod.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);

src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs:162

• Same issue as CustomMethodInfoTests: conditioning this test on PlatformDetection.IsNotMonoRuntime will still execute it on NativeAOT (and potentially CoreCLR-based Apple mobile), where trimming/AOT can change GetMethodImplementationFlags() away from MethodImplAttributes.IL. Consider gating on PlatformDetection.IsMethodBodySupported / IsNotBuiltWithAggressiveTrimming, or broaden the expected flags for trimmed/AOT builds.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customConstructor.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs:195

• Using PlatformDetection.IsNotMonoRuntime here skips the test on all Mono configurations, but it still runs on NativeAOT (which is also affected by aggressive trimming/IL stripping). If the intent is to avoid failures when method bodies are stripped and the implementation flags change, consider conditioning on PlatformDetection.IsNotBuiltWithAggressiveTrimming (or another trimming/AOT-specific predicate) instead so the test continues to run on non-trimmed Mono and is skipped on NativeAOT/Apple-mobile where it’s known to differ.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customMethod.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);
}

src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs:163

• Same issue as CustomMethodInfoTests: PlatformDetection.IsNotMonoRuntime will skip on all Mono configurations but still run on NativeAOT. If this assertion is only valid when method bodies aren’t aggressively trimmed, condition it on PlatformDetection.IsNotBuiltWithAggressiveTrimming (or similar) so it’s skipped on NativeAOT/Apple-mobile but still exercised on non-trimmed Mono.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customConstructor.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);
}

[kotlarmilos]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kotlarmilos]

/ba-g #126744

[kotlarmilos]

Summary

Skip unsupported tests on Apple mobile platforms.

Changes

• Exclude System.Diagnostics.TraceSource.Config.Tests.csproj
• CustomMethodInfoTests.GetMethodImplementationFlags_ReturnsIL and CustomConstructorInfoTests.GetMethodImplementationFlags_ReturnsIL not supported on Mono
• Set RestoreUseStaticGraphEvaluation=false to workaround known nuget issue

[dotnet-policy-service]

Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

Fixes test failures on Apple mobile platforms (iOS/tvOS/MacCatalyst) caused by Mono AOT IL stripping altering/removing method bodies, by skipping or conditioning affected tests.

Changes:

• Update IsMethodBodySupported to account for aggressively-trimmed builds (incl. Apple mobile).
• Make GetMethodImplementationFlags_ReturnsIL tests conditional on method-body availability.
• Skip ProcessTests.Start_Disposed_ThrowsObjectDisposedException on Apple mobile platforms.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs	Makes the implementation-flags assertion conditional on PlatformDetection.IsMethodBodySupported.
src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs	Same conditional gating for constructor implementation-flags test.
src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs	Skips a disposed-start exception test on select Apple platforms.
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs	Broadens IsMethodBodySupported to treat aggressively trimmed builds as unsupported for method-body-based tests.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

[kotlarmilos]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vitek-karas]

Looks good
@adamsitnik can you quickly review the process test changes just to be sure?

[vitek-karas]

I'm also trying to add #126635 into this since it looks like the same root cause (agressive trimming)

[adamsitnik]

Process part LGTM, thank you @kotlarmilos !

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs:194

• GetMethodImplementationFlags_ReturnsIL is now conditioned on PlatformDetection.IsNotMonoRuntime, which will still run on NativeAOT and on CoreCLR-based Apple mobile runs. Those are exactly the environments where aggressive trimming/AOT can change MethodImplAttributes away from IL, so this test may still fail. If the intent is to skip when method bodies/IL are stripped, gate this on PlatformDetection.IsMethodBodySupported (or IsNotBuiltWithAggressiveTrimming) instead of IsNotMonoRuntime, or update the assertion to accept the trimmed/AOT flags when appropriate.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customMethod.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);

src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs:162

• Same issue as CustomMethodInfoTests: conditioning this test on PlatformDetection.IsNotMonoRuntime will still execute it on NativeAOT (and potentially CoreCLR-based Apple mobile), where trimming/AOT can change GetMethodImplementationFlags() away from MethodImplAttributes.IL. Consider gating on PlatformDetection.IsMethodBodySupported / IsNotBuiltWithAggressiveTrimming, or broaden the expected flags for trimmed/AOT builds.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customConstructor.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs:195

• Using PlatformDetection.IsNotMonoRuntime here skips the test on all Mono configurations, but it still runs on NativeAOT (which is also affected by aggressive trimming/IL stripping). If the intent is to avoid failures when method bodies are stripped and the implementation flags change, consider conditioning on PlatformDetection.IsNotBuiltWithAggressiveTrimming (or another trimming/AOT-specific predicate) instead so the test continues to run on non-trimmed Mono and is skipped on NativeAOT/Apple-mobile where it’s known to differ.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customMethod.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);
}

src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs:163

• Same issue as CustomMethodInfoTests: PlatformDetection.IsNotMonoRuntime will skip on all Mono configurations but still run on NativeAOT. If this assertion is only valid when method bodies aren’t aggressively trimmed, condition it on PlatformDetection.IsNotBuiltWithAggressiveTrimming (or similar) so it’s skipped on NativeAOT/Apple-mobile but still exercised on non-trimmed Mono.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customConstructor.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);
}

[kotlarmilos]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kotlarmilos]

/ba-g #126744

[kotlarmilos]

Summary

Skip unsupported tests on Apple mobile platforms.

Changes

• Exclude System.Diagnostics.TraceSource.Config.Tests.csproj
• CustomMethodInfoTests.GetMethodImplementationFlags_ReturnsIL and CustomConstructorInfoTests.GetMethodImplementationFlags_ReturnsIL not supported on Mono
• Set RestoreUseStaticGraphEvaluation=false to workaround known nuget issue

[dotnet-policy-service]

Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

Fixes test failures on Apple mobile platforms (iOS/tvOS/MacCatalyst) caused by Mono AOT IL stripping altering/removing method bodies, by skipping or conditioning affected tests.

Changes:

• Update IsMethodBodySupported to account for aggressively-trimmed builds (incl. Apple mobile).
• Make GetMethodImplementationFlags_ReturnsIL tests conditional on method-body availability.
• Skip ProcessTests.Start_Disposed_ThrowsObjectDisposedException on Apple mobile platforms.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs	Makes the implementation-flags assertion conditional on PlatformDetection.IsMethodBodySupported.
src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs	Same conditional gating for constructor implementation-flags test.
src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs	Skips a disposed-start exception test on select Apple platforms.
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs	Broadens IsMethodBodySupported to treat aggressively trimmed builds as unsupported for method-body-based tests.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

[kotlarmilos]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vitek-karas]

Looks good
@adamsitnik can you quickly review the process test changes just to be sure?

[vitek-karas]

I'm also trying to add #126635 into this since it looks like the same root cause (agressive trimming)

[adamsitnik]

Process part LGTM, thank you @kotlarmilos !

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs:194

• GetMethodImplementationFlags_ReturnsIL is now conditioned on PlatformDetection.IsNotMonoRuntime, which will still run on NativeAOT and on CoreCLR-based Apple mobile runs. Those are exactly the environments where aggressive trimming/AOT can change MethodImplAttributes away from IL, so this test may still fail. If the intent is to skip when method bodies/IL are stripped, gate this on PlatformDetection.IsMethodBodySupported (or IsNotBuiltWithAggressiveTrimming) instead of IsNotMonoRuntime, or update the assertion to accept the trimmed/AOT flags when appropriate.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customMethod.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);

src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs:162

• Same issue as CustomMethodInfoTests: conditioning this test on PlatformDetection.IsNotMonoRuntime will still execute it on NativeAOT (and potentially CoreCLR-based Apple mobile), where trimming/AOT can change GetMethodImplementationFlags() away from MethodImplAttributes.IL. Consider gating on PlatformDetection.IsMethodBodySupported / IsNotBuiltWithAggressiveTrimming, or broaden the expected flags for trimmed/AOT builds.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customConstructor.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs:195

• Using PlatformDetection.IsNotMonoRuntime here skips the test on all Mono configurations, but it still runs on NativeAOT (which is also affected by aggressive trimming/IL stripping). If the intent is to avoid failures when method bodies are stripped and the implementation flags change, consider conditioning on PlatformDetection.IsNotBuiltWithAggressiveTrimming (or another trimming/AOT-specific predicate) instead so the test continues to run on non-trimmed Mono and is skipped on NativeAOT/Apple-mobile where it’s known to differ.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customMethod.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);
}

src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs:163

• Same issue as CustomMethodInfoTests: PlatformDetection.IsNotMonoRuntime will skip on all Mono configurations but still run on NativeAOT. If this assertion is only valid when method bodies aren’t aggressively trimmed, condition it on PlatformDetection.IsNotBuiltWithAggressiveTrimming (or similar) so it’s skipped on NativeAOT/Apple-mobile but still exercised on non-trimmed Mono.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customConstructor.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);
}

[kotlarmilos]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kotlarmilos]

/ba-g #126744

[kotlarmilos]

Summary

Skip unsupported tests on Apple mobile platforms.

Changes

• Exclude System.Diagnostics.TraceSource.Config.Tests.csproj
• CustomMethodInfoTests.GetMethodImplementationFlags_ReturnsIL and CustomConstructorInfoTests.GetMethodImplementationFlags_ReturnsIL not supported on Mono
• Set RestoreUseStaticGraphEvaluation=false to workaround known nuget issue

[dotnet-policy-service]

Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

Fixes test failures on Apple mobile platforms (iOS/tvOS/MacCatalyst) caused by Mono AOT IL stripping altering/removing method bodies, by skipping or conditioning affected tests.

Changes:

• Update IsMethodBodySupported to account for aggressively-trimmed builds (incl. Apple mobile).
• Make GetMethodImplementationFlags_ReturnsIL tests conditional on method-body availability.
• Skip ProcessTests.Start_Disposed_ThrowsObjectDisposedException on Apple mobile platforms.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs	Makes the implementation-flags assertion conditional on PlatformDetection.IsMethodBodySupported.
src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs	Same conditional gating for constructor implementation-flags test.
src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs	Skips a disposed-start exception test on select Apple platforms.
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs	Broadens IsMethodBodySupported to treat aggressively trimmed builds as unsupported for method-body-based tests.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

[kotlarmilos]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vitek-karas]

Looks good
@adamsitnik can you quickly review the process test changes just to be sure?

[vitek-karas]

I'm also trying to add #126635 into this since it looks like the same root cause (agressive trimming)

[adamsitnik]

Process part LGTM, thank you @kotlarmilos !

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs:194

• GetMethodImplementationFlags_ReturnsIL is now conditioned on PlatformDetection.IsNotMonoRuntime, which will still run on NativeAOT and on CoreCLR-based Apple mobile runs. Those are exactly the environments where aggressive trimming/AOT can change MethodImplAttributes away from IL, so this test may still fail. If the intent is to skip when method bodies/IL are stripped, gate this on PlatformDetection.IsMethodBodySupported (or IsNotBuiltWithAggressiveTrimming) instead of IsNotMonoRuntime, or update the assertion to accept the trimmed/AOT flags when appropriate.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customMethod.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);

src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs:162

• Same issue as CustomMethodInfoTests: conditioning this test on PlatformDetection.IsNotMonoRuntime will still execute it on NativeAOT (and potentially CoreCLR-based Apple mobile), where trimming/AOT can change GetMethodImplementationFlags() away from MethodImplAttributes.IL. Consider gating on PlatformDetection.IsMethodBodySupported / IsNotBuiltWithAggressiveTrimming, or broaden the expected flags for trimmed/AOT builds.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customConstructor.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs:195

• Using PlatformDetection.IsNotMonoRuntime here skips the test on all Mono configurations, but it still runs on NativeAOT (which is also affected by aggressive trimming/IL stripping). If the intent is to avoid failures when method bodies are stripped and the implementation flags change, consider conditioning on PlatformDetection.IsNotBuiltWithAggressiveTrimming (or another trimming/AOT-specific predicate) instead so the test continues to run on non-trimmed Mono and is skipped on NativeAOT/Apple-mobile where it’s known to differ.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customMethod.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);
}

src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs:163

• Same issue as CustomMethodInfoTests: PlatformDetection.IsNotMonoRuntime will skip on all Mono configurations but still run on NativeAOT. If this assertion is only valid when method bodies aren’t aggressively trimmed, condition it on PlatformDetection.IsNotBuiltWithAggressiveTrimming (or similar) so it’s skipped on NativeAOT/Apple-mobile but still exercised on non-trimmed Mono.

 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customConstructor.GetMethodImplementationFlags();
Assert.Equal(MethodImplAttributes.IL, flags);
}

[kotlarmilos]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kotlarmilos]

/ba-g #126744