Enable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT) - #126680

Merged
jkotas merged 3 commits into
mainfrom
copilot/enable-runtime-async-debug-builds
Apr 10, 2026
Merged

Enable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT)#126680
jkotas merged 3 commits into
mainfrom
copilot/enable-runtime-async-debug-builds

Conversation

CopilotAI commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

runtime-async=on was only set for Release builds of CoreCLR's System.Private.CoreLib, and was gated behind a riscv64/loongarch64 exclusion in NativeAOT's System.Private.CoreLib. This enables it unconditionally in both projects.

Changes

  • src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj: Moved <Features>$(Features);runtime-async=on</Features> into the configuration-independent properties block, next to <Nullable>enable</Nullable>, so Debug, Checked, and Release builds all compile with the runtime-async feature.
  • src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj: Removed the riscv64/loongarch64 architecture exclusion condition and the associated stale issue-reference comments. runtime-async=on is now enabled unconditionally, consistent with the CoreCLR change (riscv64 and loongarch64 support were resolved in Improve runtime-async support on linux-riscv64 #125446 and [LoongArch64] Enable Runtime Async. (issue#124935) #125114).

CopilotAI review requested due to automatic review settings April 9, 2026 01:07
CopilotAI removed the request for review from CopilotApril 9, 2026 01:08
@agocke
agocke marked this pull request as ready for review April 9, 2026 01:08
CopilotAI review requested due to automatic review settings April 9, 2026 01:08
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables runtime-async=on for System.Private.CoreLib in all build configurations (Debug/Checked/Release) by making the feature flag unconditional.

Changes:

  • Moves <Features>$(Features);runtime-async=on</Features> out of the Release-only PropertyGroup into an unconditional PropertyGroup.
  • Keeps Release-specific settings limited to <Optimize>.

Comment threadsrc/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj Outdated
CopilotAI requested a review from jkotasApril 9, 2026 01:35
@MichalStrehovsky

Copy link
Copy Markdown
Member

This was not the only piece of unaddressed feedback. @copilot also address the native AOT CoreLib comments from #126594

…async feature
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/172afd3b-48af-4fc5-a77d-9be94dec0db4
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
CopilotAI review requested due to automatic review settings April 9, 2026 02:20
CopilotAI removed the request for review from CopilotApril 9, 2026 02:20

CopilotAI commented Apr 9, 2026

Copy link
Copy Markdown
ContributorAuthor

This was not the only piece of unaddressed feedback. @copilot also address the native AOT CoreLib comments from #126594

Done in 3db9263 — removed the riscv64/loongarch64 exclusion condition and stale issue-reference comments from the NativeAOT System.Private.CoreLib.csproj (those issues were resolved in #125446 and #125114). runtime-async=on is now enabled unconditionally in both CoreCLR and NativeAOT CoreLib.

CopilotAI changed the title Enable runtime-async in Debug/Checked builds for System.Private.CoreLibEnable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT)Apr 9, 2026
@jkotas
jkotas merged commit ddba785 into mainApr 10, 2026
110 of 114 checks passed
@jkotas
jkotas deleted the copilot/enable-runtime-async-debug-builds branch April 10, 2026 03:08
wtgodbe added a commit to dotnet/aspnetcore that referenced this pull request Apr 15, 2026
All 18 StartupTests methods in IIS.NewShim.FunctionalTests are
failing after runtime-async was enabled unconditionally in CoreCLR
(dotnet/runtime#126680, dotnet/runtime#126594). The tests return
HTTP 500 even though the app starts successfully in-process.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wtgodbe added a commit to dotnet/aspnetcore that referenced this pull request Apr 15, 2026
* Backflow from https://github.com/dotnet/dotnet / 0cf6b19 build 309569
[[ commit created by automation ]]
* Update dependencies from build 309569
Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 11.0.0-preview.4.26203.108 -> 11.0.0-preview.4.26208.110)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 11.0.0-beta.26203.108 -> 11.0.0-beta.26208.110)
Microsoft.Web.Xdt (Version 3.3.0-preview.4.26203.108 -> 3.3.0-preview.4.26208.110)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.6.0-rc.20408 -> 7.6.0-rc.20910)
[[ commit created by automation ]]
* Add feed back into NuGet.config
* Backflow from https://github.com/dotnet/dotnet / 5bed449 build 309901
[[ commit created by automation ]]
* Update dependencies from build 309901
Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 11.0.0-preview.4.26208.110 -> 11.0.0-preview.4.26210.110)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 11.0.0-beta.26208.110 -> 11.0.0-beta.26210.110)
Microsoft.Web.Xdt (Version 3.3.0-preview.4.26208.110 -> 3.3.0-preview.4.26210.110)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.6.0-rc.20910 -> 7.6.0-rc.21110)
[[ commit created by automation ]]
* Add back package source for dotnet-extensions
* Remove DownloadFile task from RepoTasks
Removed the DownloadFile task from RepoTasks.
* Add quarantined test for AuthHeaderEnvironmentVariableRemoved
* Quarantine IIS NewShim StartupTests failing due to runtime-async
All 18 StartupTests methods in IIS.NewShim.FunctionalTests are
failing after runtime-async was enabled unconditionally in CoreCLR
(dotnet/runtime#126680, dotnet/runtime#126594). The tests return
HTTP 500 even though the app starts successfully in-process.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine IIS NewShim StartupTests only (not other IIS variants)
Only the NewShim variants of StartupTests are failing after
runtime-async was enabled in CoreCLR. Use a partial class to
apply [QuarantinedTest] only to the NewShim assembly, leaving
the IIS, IISExpress, and NewHandler variants unaffected.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Use #if NEWSHIM_FUNCTIONALS instead of partial class for quarantine
Simpler approach: conditionally apply [QuarantinedTest] using the
existing NEWSHIM_FUNCTIONALS define constant instead of adding a
partial class and a new file. No new files needed.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine ShutdownTests.OutOfProcessToInProcessHostingModelSwitchWorks for NewShim
This test hangs in the NewShim variant, blocking the entire work
item. Same runtime-async root cause as the StartupTests failures.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine entire ShutdownTests class for NewShim
Multiple ShutdownTests methods are failing/hanging in the NewShim
variant. Move to class-level quarantine instead of individual
method quarantine.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: wigodbe <wigodbe@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 10, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

@MichalStrehovsky@am11@jkotas@agocke
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Enable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT) - #126680

Merged
jkotas merged 3 commits into
mainfrom
copilot/enable-runtime-async-debug-builds
Apr 10, 2026
Merged

Enable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT)#126680
jkotas merged 3 commits into
mainfrom
copilot/enable-runtime-async-debug-builds

Conversation

CopilotAI commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

runtime-async=on was only set for Release builds of CoreCLR's System.Private.CoreLib, and was gated behind a riscv64/loongarch64 exclusion in NativeAOT's System.Private.CoreLib. This enables it unconditionally in both projects.

Changes

  • src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj: Moved <Features>$(Features);runtime-async=on</Features> into the configuration-independent properties block, next to <Nullable>enable</Nullable>, so Debug, Checked, and Release builds all compile with the runtime-async feature.
  • src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj: Removed the riscv64/loongarch64 architecture exclusion condition and the associated stale issue-reference comments. runtime-async=on is now enabled unconditionally, consistent with the CoreCLR change (riscv64 and loongarch64 support were resolved in Improve runtime-async support on linux-riscv64 #125446 and [LoongArch64] Enable Runtime Async. (issue#124935) #125114).

CopilotAI review requested due to automatic review settings April 9, 2026 01:07
CopilotAI removed the request for review from CopilotApril 9, 2026 01:08
@agocke
agocke marked this pull request as ready for review April 9, 2026 01:08
CopilotAI review requested due to automatic review settings April 9, 2026 01:08
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables runtime-async=on for System.Private.CoreLib in all build configurations (Debug/Checked/Release) by making the feature flag unconditional.

Changes:

  • Moves <Features>$(Features);runtime-async=on</Features> out of the Release-only PropertyGroup into an unconditional PropertyGroup.
  • Keeps Release-specific settings limited to <Optimize>.

Comment threadsrc/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj Outdated
CopilotAI requested a review from jkotasApril 9, 2026 01:35
@MichalStrehovsky

Copy link
Copy Markdown
Member

This was not the only piece of unaddressed feedback. @copilot also address the native AOT CoreLib comments from #126594

…async feature
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/172afd3b-48af-4fc5-a77d-9be94dec0db4
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
CopilotAI review requested due to automatic review settings April 9, 2026 02:20
CopilotAI removed the request for review from CopilotApril 9, 2026 02:20

CopilotAI commented Apr 9, 2026

Copy link
Copy Markdown
ContributorAuthor

This was not the only piece of unaddressed feedback. @copilot also address the native AOT CoreLib comments from #126594

Done in 3db9263 — removed the riscv64/loongarch64 exclusion condition and stale issue-reference comments from the NativeAOT System.Private.CoreLib.csproj (those issues were resolved in #125446 and #125114). runtime-async=on is now enabled unconditionally in both CoreCLR and NativeAOT CoreLib.

CopilotAI changed the title Enable runtime-async in Debug/Checked builds for System.Private.CoreLibEnable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT)Apr 9, 2026
@jkotas
jkotas merged commit ddba785 into mainApr 10, 2026
110 of 114 checks passed
@jkotas
jkotas deleted the copilot/enable-runtime-async-debug-builds branch April 10, 2026 03:08
wtgodbe added a commit to dotnet/aspnetcore that referenced this pull request Apr 15, 2026
All 18 StartupTests methods in IIS.NewShim.FunctionalTests are
failing after runtime-async was enabled unconditionally in CoreCLR
(dotnet/runtime#126680, dotnet/runtime#126594). The tests return
HTTP 500 even though the app starts successfully in-process.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wtgodbe added a commit to dotnet/aspnetcore that referenced this pull request Apr 15, 2026
* Backflow from https://github.com/dotnet/dotnet / 0cf6b19 build 309569
[[ commit created by automation ]]
* Update dependencies from build 309569
Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 11.0.0-preview.4.26203.108 -> 11.0.0-preview.4.26208.110)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 11.0.0-beta.26203.108 -> 11.0.0-beta.26208.110)
Microsoft.Web.Xdt (Version 3.3.0-preview.4.26203.108 -> 3.3.0-preview.4.26208.110)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.6.0-rc.20408 -> 7.6.0-rc.20910)
[[ commit created by automation ]]
* Add feed back into NuGet.config
* Backflow from https://github.com/dotnet/dotnet / 5bed449 build 309901
[[ commit created by automation ]]
* Update dependencies from build 309901
Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 11.0.0-preview.4.26208.110 -> 11.0.0-preview.4.26210.110)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 11.0.0-beta.26208.110 -> 11.0.0-beta.26210.110)
Microsoft.Web.Xdt (Version 3.3.0-preview.4.26208.110 -> 3.3.0-preview.4.26210.110)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.6.0-rc.20910 -> 7.6.0-rc.21110)
[[ commit created by automation ]]
* Add back package source for dotnet-extensions
* Remove DownloadFile task from RepoTasks
Removed the DownloadFile task from RepoTasks.
* Add quarantined test for AuthHeaderEnvironmentVariableRemoved
* Quarantine IIS NewShim StartupTests failing due to runtime-async
All 18 StartupTests methods in IIS.NewShim.FunctionalTests are
failing after runtime-async was enabled unconditionally in CoreCLR
(dotnet/runtime#126680, dotnet/runtime#126594). The tests return
HTTP 500 even though the app starts successfully in-process.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine IIS NewShim StartupTests only (not other IIS variants)
Only the NewShim variants of StartupTests are failing after
runtime-async was enabled in CoreCLR. Use a partial class to
apply [QuarantinedTest] only to the NewShim assembly, leaving
the IIS, IISExpress, and NewHandler variants unaffected.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Use #if NEWSHIM_FUNCTIONALS instead of partial class for quarantine
Simpler approach: conditionally apply [QuarantinedTest] using the
existing NEWSHIM_FUNCTIONALS define constant instead of adding a
partial class and a new file. No new files needed.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine ShutdownTests.OutOfProcessToInProcessHostingModelSwitchWorks for NewShim
This test hangs in the NewShim variant, blocking the entire work
item. Same runtime-async root cause as the StartupTests failures.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine entire ShutdownTests class for NewShim
Multiple ShutdownTests methods are failing/hanging in the NewShim
variant. Move to class-level quarantine instead of individual
method quarantine.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: wigodbe <wigodbe@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 10, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

@MichalStrehovsky@am11@jkotas@agocke
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Enable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT) - #126680

Merged
jkotas merged 3 commits into
mainfrom
copilot/enable-runtime-async-debug-builds
Apr 10, 2026
Merged

Enable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT)#126680
jkotas merged 3 commits into
mainfrom
copilot/enable-runtime-async-debug-builds

Conversation

CopilotAI commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

runtime-async=on was only set for Release builds of CoreCLR's System.Private.CoreLib, and was gated behind a riscv64/loongarch64 exclusion in NativeAOT's System.Private.CoreLib. This enables it unconditionally in both projects.

Changes

  • src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj: Moved <Features>$(Features);runtime-async=on</Features> into the configuration-independent properties block, next to <Nullable>enable</Nullable>, so Debug, Checked, and Release builds all compile with the runtime-async feature.
  • src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj: Removed the riscv64/loongarch64 architecture exclusion condition and the associated stale issue-reference comments. runtime-async=on is now enabled unconditionally, consistent with the CoreCLR change (riscv64 and loongarch64 support were resolved in Improve runtime-async support on linux-riscv64 #125446 and [LoongArch64] Enable Runtime Async. (issue#124935) #125114).

CopilotAI review requested due to automatic review settings April 9, 2026 01:07
CopilotAI removed the request for review from CopilotApril 9, 2026 01:08
@agocke
agocke marked this pull request as ready for review April 9, 2026 01:08
CopilotAI review requested due to automatic review settings April 9, 2026 01:08
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables runtime-async=on for System.Private.CoreLib in all build configurations (Debug/Checked/Release) by making the feature flag unconditional.

Changes:

  • Moves <Features>$(Features);runtime-async=on</Features> out of the Release-only PropertyGroup into an unconditional PropertyGroup.
  • Keeps Release-specific settings limited to <Optimize>.

Comment threadsrc/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj Outdated
CopilotAI requested a review from jkotasApril 9, 2026 01:35
@MichalStrehovsky

Copy link
Copy Markdown
Member

This was not the only piece of unaddressed feedback. @copilot also address the native AOT CoreLib comments from #126594

…async feature
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/172afd3b-48af-4fc5-a77d-9be94dec0db4
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
CopilotAI review requested due to automatic review settings April 9, 2026 02:20
CopilotAI removed the request for review from CopilotApril 9, 2026 02:20

CopilotAI commented Apr 9, 2026

Copy link
Copy Markdown
ContributorAuthor

This was not the only piece of unaddressed feedback. @copilot also address the native AOT CoreLib comments from #126594

Done in 3db9263 — removed the riscv64/loongarch64 exclusion condition and stale issue-reference comments from the NativeAOT System.Private.CoreLib.csproj (those issues were resolved in #125446 and #125114). runtime-async=on is now enabled unconditionally in both CoreCLR and NativeAOT CoreLib.

CopilotAI changed the title Enable runtime-async in Debug/Checked builds for System.Private.CoreLibEnable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT)Apr 9, 2026
@jkotas
jkotas merged commit ddba785 into mainApr 10, 2026
110 of 114 checks passed
@jkotas
jkotas deleted the copilot/enable-runtime-async-debug-builds branch April 10, 2026 03:08
wtgodbe added a commit to dotnet/aspnetcore that referenced this pull request Apr 15, 2026
All 18 StartupTests methods in IIS.NewShim.FunctionalTests are
failing after runtime-async was enabled unconditionally in CoreCLR
(dotnet/runtime#126680, dotnet/runtime#126594). The tests return
HTTP 500 even though the app starts successfully in-process.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wtgodbe added a commit to dotnet/aspnetcore that referenced this pull request Apr 15, 2026
* Backflow from https://github.com/dotnet/dotnet / 0cf6b19 build 309569
[[ commit created by automation ]]
* Update dependencies from build 309569
Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 11.0.0-preview.4.26203.108 -> 11.0.0-preview.4.26208.110)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 11.0.0-beta.26203.108 -> 11.0.0-beta.26208.110)
Microsoft.Web.Xdt (Version 3.3.0-preview.4.26203.108 -> 3.3.0-preview.4.26208.110)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.6.0-rc.20408 -> 7.6.0-rc.20910)
[[ commit created by automation ]]
* Add feed back into NuGet.config
* Backflow from https://github.com/dotnet/dotnet / 5bed449 build 309901
[[ commit created by automation ]]
* Update dependencies from build 309901
Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 11.0.0-preview.4.26208.110 -> 11.0.0-preview.4.26210.110)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 11.0.0-beta.26208.110 -> 11.0.0-beta.26210.110)
Microsoft.Web.Xdt (Version 3.3.0-preview.4.26208.110 -> 3.3.0-preview.4.26210.110)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.6.0-rc.20910 -> 7.6.0-rc.21110)
[[ commit created by automation ]]
* Add back package source for dotnet-extensions
* Remove DownloadFile task from RepoTasks
Removed the DownloadFile task from RepoTasks.
* Add quarantined test for AuthHeaderEnvironmentVariableRemoved
* Quarantine IIS NewShim StartupTests failing due to runtime-async
All 18 StartupTests methods in IIS.NewShim.FunctionalTests are
failing after runtime-async was enabled unconditionally in CoreCLR
(dotnet/runtime#126680, dotnet/runtime#126594). The tests return
HTTP 500 even though the app starts successfully in-process.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine IIS NewShim StartupTests only (not other IIS variants)
Only the NewShim variants of StartupTests are failing after
runtime-async was enabled in CoreCLR. Use a partial class to
apply [QuarantinedTest] only to the NewShim assembly, leaving
the IIS, IISExpress, and NewHandler variants unaffected.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Use #if NEWSHIM_FUNCTIONALS instead of partial class for quarantine
Simpler approach: conditionally apply [QuarantinedTest] using the
existing NEWSHIM_FUNCTIONALS define constant instead of adding a
partial class and a new file. No new files needed.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine ShutdownTests.OutOfProcessToInProcessHostingModelSwitchWorks for NewShim
This test hangs in the NewShim variant, blocking the entire work
item. Same runtime-async root cause as the StartupTests failures.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine entire ShutdownTests class for NewShim
Multiple ShutdownTests methods are failing/hanging in the NewShim
variant. Move to class-level quarantine instead of individual
method quarantine.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: wigodbe <wigodbe@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 10, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

@MichalStrehovsky@am11@jkotas@agocke
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Enable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT) - #126680

Merged
jkotas merged 3 commits into
mainfrom
copilot/enable-runtime-async-debug-builds
Apr 10, 2026
Merged

Enable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT)#126680
jkotas merged 3 commits into
mainfrom
copilot/enable-runtime-async-debug-builds

Conversation

CopilotAI commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

runtime-async=on was only set for Release builds of CoreCLR's System.Private.CoreLib, and was gated behind a riscv64/loongarch64 exclusion in NativeAOT's System.Private.CoreLib. This enables it unconditionally in both projects.

Changes

  • src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj: Moved <Features>$(Features);runtime-async=on</Features> into the configuration-independent properties block, next to <Nullable>enable</Nullable>, so Debug, Checked, and Release builds all compile with the runtime-async feature.
  • src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj: Removed the riscv64/loongarch64 architecture exclusion condition and the associated stale issue-reference comments. runtime-async=on is now enabled unconditionally, consistent with the CoreCLR change (riscv64 and loongarch64 support were resolved in Improve runtime-async support on linux-riscv64 #125446 and [LoongArch64] Enable Runtime Async. (issue#124935) #125114).

CopilotAI review requested due to automatic review settings April 9, 2026 01:07
CopilotAI removed the request for review from CopilotApril 9, 2026 01:08
@agocke
agocke marked this pull request as ready for review April 9, 2026 01:08
CopilotAI review requested due to automatic review settings April 9, 2026 01:08
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables runtime-async=on for System.Private.CoreLib in all build configurations (Debug/Checked/Release) by making the feature flag unconditional.

Changes:

  • Moves <Features>$(Features);runtime-async=on</Features> out of the Release-only PropertyGroup into an unconditional PropertyGroup.
  • Keeps Release-specific settings limited to <Optimize>.

Comment threadsrc/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj Outdated
CopilotAI requested a review from jkotasApril 9, 2026 01:35
@MichalStrehovsky

Copy link
Copy Markdown
Member

This was not the only piece of unaddressed feedback. @copilot also address the native AOT CoreLib comments from #126594

…async feature
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/172afd3b-48af-4fc5-a77d-9be94dec0db4
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
CopilotAI review requested due to automatic review settings April 9, 2026 02:20
CopilotAI removed the request for review from CopilotApril 9, 2026 02:20

CopilotAI commented Apr 9, 2026

Copy link
Copy Markdown
ContributorAuthor

This was not the only piece of unaddressed feedback. @copilot also address the native AOT CoreLib comments from #126594

Done in 3db9263 — removed the riscv64/loongarch64 exclusion condition and stale issue-reference comments from the NativeAOT System.Private.CoreLib.csproj (those issues were resolved in #125446 and #125114). runtime-async=on is now enabled unconditionally in both CoreCLR and NativeAOT CoreLib.

CopilotAI changed the title Enable runtime-async in Debug/Checked builds for System.Private.CoreLibEnable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT)Apr 9, 2026
@jkotas
jkotas merged commit ddba785 into mainApr 10, 2026
110 of 114 checks passed
@jkotas
jkotas deleted the copilot/enable-runtime-async-debug-builds branch April 10, 2026 03:08
wtgodbe added a commit to dotnet/aspnetcore that referenced this pull request Apr 15, 2026
All 18 StartupTests methods in IIS.NewShim.FunctionalTests are
failing after runtime-async was enabled unconditionally in CoreCLR
(dotnet/runtime#126680, dotnet/runtime#126594). The tests return
HTTP 500 even though the app starts successfully in-process.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wtgodbe added a commit to dotnet/aspnetcore that referenced this pull request Apr 15, 2026
* Backflow from https://github.com/dotnet/dotnet / 0cf6b19 build 309569
[[ commit created by automation ]]
* Update dependencies from build 309569
Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 11.0.0-preview.4.26203.108 -> 11.0.0-preview.4.26208.110)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 11.0.0-beta.26203.108 -> 11.0.0-beta.26208.110)
Microsoft.Web.Xdt (Version 3.3.0-preview.4.26203.108 -> 3.3.0-preview.4.26208.110)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.6.0-rc.20408 -> 7.6.0-rc.20910)
[[ commit created by automation ]]
* Add feed back into NuGet.config
* Backflow from https://github.com/dotnet/dotnet / 5bed449 build 309901
[[ commit created by automation ]]
* Update dependencies from build 309901
Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 11.0.0-preview.4.26208.110 -> 11.0.0-preview.4.26210.110)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 11.0.0-beta.26208.110 -> 11.0.0-beta.26210.110)
Microsoft.Web.Xdt (Version 3.3.0-preview.4.26208.110 -> 3.3.0-preview.4.26210.110)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.6.0-rc.20910 -> 7.6.0-rc.21110)
[[ commit created by automation ]]
* Add back package source for dotnet-extensions
* Remove DownloadFile task from RepoTasks
Removed the DownloadFile task from RepoTasks.
* Add quarantined test for AuthHeaderEnvironmentVariableRemoved
* Quarantine IIS NewShim StartupTests failing due to runtime-async
All 18 StartupTests methods in IIS.NewShim.FunctionalTests are
failing after runtime-async was enabled unconditionally in CoreCLR
(dotnet/runtime#126680, dotnet/runtime#126594). The tests return
HTTP 500 even though the app starts successfully in-process.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine IIS NewShim StartupTests only (not other IIS variants)
Only the NewShim variants of StartupTests are failing after
runtime-async was enabled in CoreCLR. Use a partial class to
apply [QuarantinedTest] only to the NewShim assembly, leaving
the IIS, IISExpress, and NewHandler variants unaffected.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Use #if NEWSHIM_FUNCTIONALS instead of partial class for quarantine
Simpler approach: conditionally apply [QuarantinedTest] using the
existing NEWSHIM_FUNCTIONALS define constant instead of adding a
partial class and a new file. No new files needed.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine ShutdownTests.OutOfProcessToInProcessHostingModelSwitchWorks for NewShim
This test hangs in the NewShim variant, blocking the entire work
item. Same runtime-async root cause as the StartupTests failures.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine entire ShutdownTests class for NewShim
Multiple ShutdownTests methods are failing/hanging in the NewShim
variant. Move to class-level quarantine instead of individual
method quarantine.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: wigodbe <wigodbe@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 10, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

@MichalStrehovsky@am11@jkotas@agocke
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Enable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT) - #126680

Merged
jkotas merged 3 commits into
mainfrom
copilot/enable-runtime-async-debug-builds
Apr 10, 2026
Merged

Enable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT)#126680
jkotas merged 3 commits into
mainfrom
copilot/enable-runtime-async-debug-builds

Conversation

CopilotAI commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

runtime-async=on was only set for Release builds of CoreCLR's System.Private.CoreLib, and was gated behind a riscv64/loongarch64 exclusion in NativeAOT's System.Private.CoreLib. This enables it unconditionally in both projects.

Changes

  • src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj: Moved <Features>$(Features);runtime-async=on</Features> into the configuration-independent properties block, next to <Nullable>enable</Nullable>, so Debug, Checked, and Release builds all compile with the runtime-async feature.
  • src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj: Removed the riscv64/loongarch64 architecture exclusion condition and the associated stale issue-reference comments. runtime-async=on is now enabled unconditionally, consistent with the CoreCLR change (riscv64 and loongarch64 support were resolved in Improve runtime-async support on linux-riscv64 #125446 and [LoongArch64] Enable Runtime Async. (issue#124935) #125114).

CopilotAI review requested due to automatic review settings April 9, 2026 01:07
CopilotAI removed the request for review from CopilotApril 9, 2026 01:08
@agocke
agocke marked this pull request as ready for review April 9, 2026 01:08
CopilotAI review requested due to automatic review settings April 9, 2026 01:08
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables runtime-async=on for System.Private.CoreLib in all build configurations (Debug/Checked/Release) by making the feature flag unconditional.

Changes:

  • Moves <Features>$(Features);runtime-async=on</Features> out of the Release-only PropertyGroup into an unconditional PropertyGroup.
  • Keeps Release-specific settings limited to <Optimize>.

Comment threadsrc/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj Outdated
CopilotAI requested a review from jkotasApril 9, 2026 01:35
@MichalStrehovsky

Copy link
Copy Markdown
Member

This was not the only piece of unaddressed feedback. @copilot also address the native AOT CoreLib comments from #126594

…async feature
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/172afd3b-48af-4fc5-a77d-9be94dec0db4
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
CopilotAI review requested due to automatic review settings April 9, 2026 02:20
CopilotAI removed the request for review from CopilotApril 9, 2026 02:20

CopilotAI commented Apr 9, 2026

Copy link
Copy Markdown
ContributorAuthor

This was not the only piece of unaddressed feedback. @copilot also address the native AOT CoreLib comments from #126594

Done in 3db9263 — removed the riscv64/loongarch64 exclusion condition and stale issue-reference comments from the NativeAOT System.Private.CoreLib.csproj (those issues were resolved in #125446 and #125114). runtime-async=on is now enabled unconditionally in both CoreCLR and NativeAOT CoreLib.

CopilotAI changed the title Enable runtime-async in Debug/Checked builds for System.Private.CoreLibEnable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT)Apr 9, 2026
@jkotas
jkotas merged commit ddba785 into mainApr 10, 2026
110 of 114 checks passed
@jkotas
jkotas deleted the copilot/enable-runtime-async-debug-builds branch April 10, 2026 03:08
wtgodbe added a commit to dotnet/aspnetcore that referenced this pull request Apr 15, 2026
All 18 StartupTests methods in IIS.NewShim.FunctionalTests are
failing after runtime-async was enabled unconditionally in CoreCLR
(dotnet/runtime#126680, dotnet/runtime#126594). The tests return
HTTP 500 even though the app starts successfully in-process.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wtgodbe added a commit to dotnet/aspnetcore that referenced this pull request Apr 15, 2026
* Backflow from https://github.com/dotnet/dotnet / 0cf6b19 build 309569
[[ commit created by automation ]]
* Update dependencies from build 309569
Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 11.0.0-preview.4.26203.108 -> 11.0.0-preview.4.26208.110)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 11.0.0-beta.26203.108 -> 11.0.0-beta.26208.110)
Microsoft.Web.Xdt (Version 3.3.0-preview.4.26203.108 -> 3.3.0-preview.4.26208.110)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.6.0-rc.20408 -> 7.6.0-rc.20910)
[[ commit created by automation ]]
* Add feed back into NuGet.config
* Backflow from https://github.com/dotnet/dotnet / 5bed449 build 309901
[[ commit created by automation ]]
* Update dependencies from build 309901
Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 11.0.0-preview.4.26208.110 -> 11.0.0-preview.4.26210.110)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 11.0.0-beta.26208.110 -> 11.0.0-beta.26210.110)
Microsoft.Web.Xdt (Version 3.3.0-preview.4.26208.110 -> 3.3.0-preview.4.26210.110)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.6.0-rc.20910 -> 7.6.0-rc.21110)
[[ commit created by automation ]]
* Add back package source for dotnet-extensions
* Remove DownloadFile task from RepoTasks
Removed the DownloadFile task from RepoTasks.
* Add quarantined test for AuthHeaderEnvironmentVariableRemoved
* Quarantine IIS NewShim StartupTests failing due to runtime-async
All 18 StartupTests methods in IIS.NewShim.FunctionalTests are
failing after runtime-async was enabled unconditionally in CoreCLR
(dotnet/runtime#126680, dotnet/runtime#126594). The tests return
HTTP 500 even though the app starts successfully in-process.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine IIS NewShim StartupTests only (not other IIS variants)
Only the NewShim variants of StartupTests are failing after
runtime-async was enabled in CoreCLR. Use a partial class to
apply [QuarantinedTest] only to the NewShim assembly, leaving
the IIS, IISExpress, and NewHandler variants unaffected.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Use #if NEWSHIM_FUNCTIONALS instead of partial class for quarantine
Simpler approach: conditionally apply [QuarantinedTest] using the
existing NEWSHIM_FUNCTIONALS define constant instead of adding a
partial class and a new file. No new files needed.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine ShutdownTests.OutOfProcessToInProcessHostingModelSwitchWorks for NewShim
This test hangs in the NewShim variant, blocking the entire work
item. Same runtime-async root cause as the StartupTests failures.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine entire ShutdownTests class for NewShim
Multiple ShutdownTests methods are failing/hanging in the NewShim
variant. Move to class-level quarantine instead of individual
method quarantine.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: wigodbe <wigodbe@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 10, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

@MichalStrehovsky@am11@jkotas@agocke
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Enable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT) - #126680

Merged
jkotas merged 3 commits into
mainfrom
copilot/enable-runtime-async-debug-builds
Apr 10, 2026
Merged

Enable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT)#126680
jkotas merged 3 commits into
mainfrom
copilot/enable-runtime-async-debug-builds

Conversation

CopilotAI commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

runtime-async=on was only set for Release builds of CoreCLR's System.Private.CoreLib, and was gated behind a riscv64/loongarch64 exclusion in NativeAOT's System.Private.CoreLib. This enables it unconditionally in both projects.

Changes

  • src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj: Moved <Features>$(Features);runtime-async=on</Features> into the configuration-independent properties block, next to <Nullable>enable</Nullable>, so Debug, Checked, and Release builds all compile with the runtime-async feature.
  • src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj: Removed the riscv64/loongarch64 architecture exclusion condition and the associated stale issue-reference comments. runtime-async=on is now enabled unconditionally, consistent with the CoreCLR change (riscv64 and loongarch64 support were resolved in Improve runtime-async support on linux-riscv64 #125446 and [LoongArch64] Enable Runtime Async. (issue#124935) #125114).

CopilotAI review requested due to automatic review settings April 9, 2026 01:07
CopilotAI removed the request for review from CopilotApril 9, 2026 01:08
@agocke
agocke marked this pull request as ready for review April 9, 2026 01:08
CopilotAI review requested due to automatic review settings April 9, 2026 01:08
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables runtime-async=on for System.Private.CoreLib in all build configurations (Debug/Checked/Release) by making the feature flag unconditional.

Changes:

  • Moves <Features>$(Features);runtime-async=on</Features> out of the Release-only PropertyGroup into an unconditional PropertyGroup.
  • Keeps Release-specific settings limited to <Optimize>.

Comment threadsrc/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj Outdated
CopilotAI requested a review from jkotasApril 9, 2026 01:35
@MichalStrehovsky

Copy link
Copy Markdown
Member

This was not the only piece of unaddressed feedback. @copilot also address the native AOT CoreLib comments from #126594

…async feature
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/172afd3b-48af-4fc5-a77d-9be94dec0db4
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
CopilotAI review requested due to automatic review settings April 9, 2026 02:20
CopilotAI removed the request for review from CopilotApril 9, 2026 02:20

CopilotAI commented Apr 9, 2026

Copy link
Copy Markdown
ContributorAuthor

This was not the only piece of unaddressed feedback. @copilot also address the native AOT CoreLib comments from #126594

Done in 3db9263 — removed the riscv64/loongarch64 exclusion condition and stale issue-reference comments from the NativeAOT System.Private.CoreLib.csproj (those issues were resolved in #125446 and #125114). runtime-async=on is now enabled unconditionally in both CoreCLR and NativeAOT CoreLib.

CopilotAI changed the title Enable runtime-async in Debug/Checked builds for System.Private.CoreLibEnable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT)Apr 9, 2026
@jkotas
jkotas merged commit ddba785 into mainApr 10, 2026
110 of 114 checks passed
@jkotas
jkotas deleted the copilot/enable-runtime-async-debug-builds branch April 10, 2026 03:08
wtgodbe added a commit to dotnet/aspnetcore that referenced this pull request Apr 15, 2026
All 18 StartupTests methods in IIS.NewShim.FunctionalTests are
failing after runtime-async was enabled unconditionally in CoreCLR
(dotnet/runtime#126680, dotnet/runtime#126594). The tests return
HTTP 500 even though the app starts successfully in-process.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wtgodbe added a commit to dotnet/aspnetcore that referenced this pull request Apr 15, 2026
* Backflow from https://github.com/dotnet/dotnet / 0cf6b19 build 309569
[[ commit created by automation ]]
* Update dependencies from build 309569
Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 11.0.0-preview.4.26203.108 -> 11.0.0-preview.4.26208.110)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 11.0.0-beta.26203.108 -> 11.0.0-beta.26208.110)
Microsoft.Web.Xdt (Version 3.3.0-preview.4.26203.108 -> 3.3.0-preview.4.26208.110)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.6.0-rc.20408 -> 7.6.0-rc.20910)
[[ commit created by automation ]]
* Add feed back into NuGet.config
* Backflow from https://github.com/dotnet/dotnet / 5bed449 build 309901
[[ commit created by automation ]]
* Update dependencies from build 309901
Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 11.0.0-preview.4.26208.110 -> 11.0.0-preview.4.26210.110)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 11.0.0-beta.26208.110 -> 11.0.0-beta.26210.110)
Microsoft.Web.Xdt (Version 3.3.0-preview.4.26208.110 -> 3.3.0-preview.4.26210.110)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.6.0-rc.20910 -> 7.6.0-rc.21110)
[[ commit created by automation ]]
* Add back package source for dotnet-extensions
* Remove DownloadFile task from RepoTasks
Removed the DownloadFile task from RepoTasks.
* Add quarantined test for AuthHeaderEnvironmentVariableRemoved
* Quarantine IIS NewShim StartupTests failing due to runtime-async
All 18 StartupTests methods in IIS.NewShim.FunctionalTests are
failing after runtime-async was enabled unconditionally in CoreCLR
(dotnet/runtime#126680, dotnet/runtime#126594). The tests return
HTTP 500 even though the app starts successfully in-process.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine IIS NewShim StartupTests only (not other IIS variants)
Only the NewShim variants of StartupTests are failing after
runtime-async was enabled in CoreCLR. Use a partial class to
apply [QuarantinedTest] only to the NewShim assembly, leaving
the IIS, IISExpress, and NewHandler variants unaffected.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Use #if NEWSHIM_FUNCTIONALS instead of partial class for quarantine
Simpler approach: conditionally apply [QuarantinedTest] using the
existing NEWSHIM_FUNCTIONALS define constant instead of adding a
partial class and a new file. No new files needed.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine ShutdownTests.OutOfProcessToInProcessHostingModelSwitchWorks for NewShim
This test hangs in the NewShim variant, blocking the entire work
item. Same runtime-async root cause as the StartupTests failures.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine entire ShutdownTests class for NewShim
Multiple ShutdownTests methods are failing/hanging in the NewShim
variant. Move to class-level quarantine instead of individual
method quarantine.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: wigodbe <wigodbe@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 10, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

@MichalStrehovsky@am11@jkotas@agocke
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Enable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT) - #126680

Merged
jkotas merged 3 commits into
mainfrom
copilot/enable-runtime-async-debug-builds
Apr 10, 2026
Merged

Enable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT)#126680
jkotas merged 3 commits into
mainfrom
copilot/enable-runtime-async-debug-builds

Conversation

CopilotAI commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

runtime-async=on was only set for Release builds of CoreCLR's System.Private.CoreLib, and was gated behind a riscv64/loongarch64 exclusion in NativeAOT's System.Private.CoreLib. This enables it unconditionally in both projects.

Changes

  • src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj: Moved <Features>$(Features);runtime-async=on</Features> into the configuration-independent properties block, next to <Nullable>enable</Nullable>, so Debug, Checked, and Release builds all compile with the runtime-async feature.
  • src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj: Removed the riscv64/loongarch64 architecture exclusion condition and the associated stale issue-reference comments. runtime-async=on is now enabled unconditionally, consistent with the CoreCLR change (riscv64 and loongarch64 support were resolved in Improve runtime-async support on linux-riscv64 #125446 and [LoongArch64] Enable Runtime Async. (issue#124935) #125114).

CopilotAI review requested due to automatic review settings April 9, 2026 01:07
CopilotAI removed the request for review from CopilotApril 9, 2026 01:08
@agocke
agocke marked this pull request as ready for review April 9, 2026 01:08
CopilotAI review requested due to automatic review settings April 9, 2026 01:08
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables runtime-async=on for System.Private.CoreLib in all build configurations (Debug/Checked/Release) by making the feature flag unconditional.

Changes:

  • Moves <Features>$(Features);runtime-async=on</Features> out of the Release-only PropertyGroup into an unconditional PropertyGroup.
  • Keeps Release-specific settings limited to <Optimize>.

Comment threadsrc/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj Outdated
CopilotAI requested a review from jkotasApril 9, 2026 01:35
@MichalStrehovsky

Copy link
Copy Markdown
Member

This was not the only piece of unaddressed feedback. @copilot also address the native AOT CoreLib comments from #126594

…async feature
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/172afd3b-48af-4fc5-a77d-9be94dec0db4
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
CopilotAI review requested due to automatic review settings April 9, 2026 02:20
CopilotAI removed the request for review from CopilotApril 9, 2026 02:20

CopilotAI commented Apr 9, 2026

Copy link
Copy Markdown
ContributorAuthor

This was not the only piece of unaddressed feedback. @copilot also address the native AOT CoreLib comments from #126594

Done in 3db9263 — removed the riscv64/loongarch64 exclusion condition and stale issue-reference comments from the NativeAOT System.Private.CoreLib.csproj (those issues were resolved in #125446 and #125114). runtime-async=on is now enabled unconditionally in both CoreCLR and NativeAOT CoreLib.

CopilotAI changed the title Enable runtime-async in Debug/Checked builds for System.Private.CoreLibEnable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT)Apr 9, 2026
@jkotas
jkotas merged commit ddba785 into mainApr 10, 2026
110 of 114 checks passed
@jkotas
jkotas deleted the copilot/enable-runtime-async-debug-builds branch April 10, 2026 03:08
wtgodbe added a commit to dotnet/aspnetcore that referenced this pull request Apr 15, 2026
All 18 StartupTests methods in IIS.NewShim.FunctionalTests are
failing after runtime-async was enabled unconditionally in CoreCLR
(dotnet/runtime#126680, dotnet/runtime#126594). The tests return
HTTP 500 even though the app starts successfully in-process.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wtgodbe added a commit to dotnet/aspnetcore that referenced this pull request Apr 15, 2026
* Backflow from https://github.com/dotnet/dotnet / 0cf6b19 build 309569
[[ commit created by automation ]]
* Update dependencies from build 309569
Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 11.0.0-preview.4.26203.108 -> 11.0.0-preview.4.26208.110)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 11.0.0-beta.26203.108 -> 11.0.0-beta.26208.110)
Microsoft.Web.Xdt (Version 3.3.0-preview.4.26203.108 -> 3.3.0-preview.4.26208.110)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.6.0-rc.20408 -> 7.6.0-rc.20910)
[[ commit created by automation ]]
* Add feed back into NuGet.config
* Backflow from https://github.com/dotnet/dotnet / 5bed449 build 309901
[[ commit created by automation ]]
* Update dependencies from build 309901
Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 11.0.0-preview.4.26208.110 -> 11.0.0-preview.4.26210.110)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 11.0.0-beta.26208.110 -> 11.0.0-beta.26210.110)
Microsoft.Web.Xdt (Version 3.3.0-preview.4.26208.110 -> 3.3.0-preview.4.26210.110)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.6.0-rc.20910 -> 7.6.0-rc.21110)
[[ commit created by automation ]]
* Add back package source for dotnet-extensions
* Remove DownloadFile task from RepoTasks
Removed the DownloadFile task from RepoTasks.
* Add quarantined test for AuthHeaderEnvironmentVariableRemoved
* Quarantine IIS NewShim StartupTests failing due to runtime-async
All 18 StartupTests methods in IIS.NewShim.FunctionalTests are
failing after runtime-async was enabled unconditionally in CoreCLR
(dotnet/runtime#126680, dotnet/runtime#126594). The tests return
HTTP 500 even though the app starts successfully in-process.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine IIS NewShim StartupTests only (not other IIS variants)
Only the NewShim variants of StartupTests are failing after
runtime-async was enabled in CoreCLR. Use a partial class to
apply [QuarantinedTest] only to the NewShim assembly, leaving
the IIS, IISExpress, and NewHandler variants unaffected.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Use #if NEWSHIM_FUNCTIONALS instead of partial class for quarantine
Simpler approach: conditionally apply [QuarantinedTest] using the
existing NEWSHIM_FUNCTIONALS define constant instead of adding a
partial class and a new file. No new files needed.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine ShutdownTests.OutOfProcessToInProcessHostingModelSwitchWorks for NewShim
This test hangs in the NewShim variant, blocking the entire work
item. Same runtime-async root cause as the StartupTests failures.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine entire ShutdownTests class for NewShim
Multiple ShutdownTests methods are failing/hanging in the NewShim
variant. Move to class-level quarantine instead of individual
method quarantine.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: wigodbe <wigodbe@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 10, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

@MichalStrehovsky@am11@jkotas@agocke
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Enable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT) - #126680

Merged
jkotas merged 3 commits into
mainfrom
copilot/enable-runtime-async-debug-builds
Apr 10, 2026
Merged

Enable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT)#126680
jkotas merged 3 commits into
mainfrom
copilot/enable-runtime-async-debug-builds

Conversation

CopilotAI commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

runtime-async=on was only set for Release builds of CoreCLR's System.Private.CoreLib, and was gated behind a riscv64/loongarch64 exclusion in NativeAOT's System.Private.CoreLib. This enables it unconditionally in both projects.

Changes

  • src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj: Moved <Features>$(Features);runtime-async=on</Features> into the configuration-independent properties block, next to <Nullable>enable</Nullable>, so Debug, Checked, and Release builds all compile with the runtime-async feature.
  • src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj: Removed the riscv64/loongarch64 architecture exclusion condition and the associated stale issue-reference comments. runtime-async=on is now enabled unconditionally, consistent with the CoreCLR change (riscv64 and loongarch64 support were resolved in Improve runtime-async support on linux-riscv64 #125446 and [LoongArch64] Enable Runtime Async. (issue#124935) #125114).

CopilotAI review requested due to automatic review settings April 9, 2026 01:07
CopilotAI removed the request for review from CopilotApril 9, 2026 01:08
@agocke
agocke marked this pull request as ready for review April 9, 2026 01:08
CopilotAI review requested due to automatic review settings April 9, 2026 01:08
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables runtime-async=on for System.Private.CoreLib in all build configurations (Debug/Checked/Release) by making the feature flag unconditional.

Changes:

  • Moves <Features>$(Features);runtime-async=on</Features> out of the Release-only PropertyGroup into an unconditional PropertyGroup.
  • Keeps Release-specific settings limited to <Optimize>.

Comment threadsrc/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj Outdated
CopilotAI requested a review from jkotasApril 9, 2026 01:35
@MichalStrehovsky

Copy link
Copy Markdown
Member

This was not the only piece of unaddressed feedback. @copilot also address the native AOT CoreLib comments from #126594

…async feature
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/172afd3b-48af-4fc5-a77d-9be94dec0db4
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
CopilotAI review requested due to automatic review settings April 9, 2026 02:20
CopilotAI removed the request for review from CopilotApril 9, 2026 02:20

CopilotAI commented Apr 9, 2026

Copy link
Copy Markdown
ContributorAuthor

This was not the only piece of unaddressed feedback. @copilot also address the native AOT CoreLib comments from #126594

Done in 3db9263 — removed the riscv64/loongarch64 exclusion condition and stale issue-reference comments from the NativeAOT System.Private.CoreLib.csproj (those issues were resolved in #125446 and #125114). runtime-async=on is now enabled unconditionally in both CoreCLR and NativeAOT CoreLib.

CopilotAI changed the title Enable runtime-async in Debug/Checked builds for System.Private.CoreLibEnable runtime-async unconditionally in System.Private.CoreLib (CoreCLR and NativeAOT)Apr 9, 2026
@jkotas
jkotas merged commit ddba785 into mainApr 10, 2026
110 of 114 checks passed
@jkotas
jkotas deleted the copilot/enable-runtime-async-debug-builds branch April 10, 2026 03:08
wtgodbe added a commit to dotnet/aspnetcore that referenced this pull request Apr 15, 2026
All 18 StartupTests methods in IIS.NewShim.FunctionalTests are
failing after runtime-async was enabled unconditionally in CoreCLR
(dotnet/runtime#126680, dotnet/runtime#126594). The tests return
HTTP 500 even though the app starts successfully in-process.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wtgodbe added a commit to dotnet/aspnetcore that referenced this pull request Apr 15, 2026
* Backflow from https://github.com/dotnet/dotnet / 0cf6b19 build 309569
[[ commit created by automation ]]
* Update dependencies from build 309569
Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 11.0.0-preview.4.26203.108 -> 11.0.0-preview.4.26208.110)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 11.0.0-beta.26203.108 -> 11.0.0-beta.26208.110)
Microsoft.Web.Xdt (Version 3.3.0-preview.4.26203.108 -> 3.3.0-preview.4.26208.110)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.6.0-rc.20408 -> 7.6.0-rc.20910)
[[ commit created by automation ]]
* Add feed back into NuGet.config
* Backflow from https://github.com/dotnet/dotnet / 5bed449 build 309901
[[ commit created by automation ]]
* Update dependencies from build 309901
Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 11.0.0-preview.4.26208.110 -> 11.0.0-preview.4.26210.110)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 11.0.0-beta.26208.110 -> 11.0.0-beta.26210.110)
Microsoft.Web.Xdt (Version 3.3.0-preview.4.26208.110 -> 3.3.0-preview.4.26210.110)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.6.0-rc.20910 -> 7.6.0-rc.21110)
[[ commit created by automation ]]
* Add back package source for dotnet-extensions
* Remove DownloadFile task from RepoTasks
Removed the DownloadFile task from RepoTasks.
* Add quarantined test for AuthHeaderEnvironmentVariableRemoved
* Quarantine IIS NewShim StartupTests failing due to runtime-async
All 18 StartupTests methods in IIS.NewShim.FunctionalTests are
failing after runtime-async was enabled unconditionally in CoreCLR
(dotnet/runtime#126680, dotnet/runtime#126594). The tests return
HTTP 500 even though the app starts successfully in-process.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine IIS NewShim StartupTests only (not other IIS variants)
Only the NewShim variants of StartupTests are failing after
runtime-async was enabled in CoreCLR. Use a partial class to
apply [QuarantinedTest] only to the NewShim assembly, leaving
the IIS, IISExpress, and NewHandler variants unaffected.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Use #if NEWSHIM_FUNCTIONALS instead of partial class for quarantine
Simpler approach: conditionally apply [QuarantinedTest] using the
existing NEWSHIM_FUNCTIONALS define constant instead of adding a
partial class and a new file. No new files needed.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine ShutdownTests.OutOfProcessToInProcessHostingModelSwitchWorks for NewShim
This test hangs in the NewShim variant, blocking the entire work
item. Same runtime-async root cause as the StartupTests failures.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Quarantine entire ShutdownTests class for NewShim
Multiple ShutdownTests methods are failing/hanging in the NewShim
variant. Move to class-level quarantine instead of individual
method quarantine.
Tracking issue: dotnet/runtime#126925
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: wigodbe <wigodbe@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 10, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

@MichalStrehovsky@am11@jkotas@agocke