Update .gitignore to include cache and dump files by jtschuster · Pull Request #126718 · dotnet/runtime

jtschuster · 2026-04-09T16:50:00Z

Add patterns to ignore C# Dev Kit caches and dump files.

The Dev Kit extension now creates .lscache files for each csproj loaded by the lsp. We should tell git to ignore them

Also ignore dump files because I imagine people often have them in the directory but never want to commit them.

Add patterns to ignore C# Dev Kit caches and dump files.

Copilot

Copilot wasn't able to review any files in this pull request.

dotnet-policy-service · 2026-04-09T16:51:19Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

github-actions · 2026-04-09T16:55:00Z

Note

This review was generated by Copilot.

🤖 Copilot Code Review — PR #126718

Holistic Assessment

Motivation: Justified — .lscache (C# Dev Kit), .dmp, and .dump files are common development/debugging artifacts that should not be committed. This is a quality-of-life improvement for contributors using VS Code with C# Dev Kit and anyone generating crash/memory dumps locally.

Approach: Correct — adding glob patterns to .gitignore is the standard approach. The entries are placed logically after the existing VS Code section, which makes sense since C# Dev Kit is a VS Code extension.

Summary: ✅ LGTM. This is a small, safe, well-placed addition to .gitignore. No existing tracked files match the new patterns, and the glob patterns are appropriately scoped. No code changes, no build/test impact.

Detailed Findings

✅ Correctness — No tracked files affected

Verified via git ls-files '*.lscache' '*.dmp' '*.dump' that no existing tracked files match these patterns. The new entries will only affect future untracked files.

✅ Placement — Logically organized

The .lscache entry is placed immediately after the VS Code section (.vscode entries), which is appropriate since C# Dev Kit is a VS Code extension. The dump file entries are grouped together with a clear comment. Both new blocks are between the VS Code and MonoDevelop sections, maintaining the file's organizational structure.

✅ Pattern scope — Appropriately broad

*.lscache is specific to C# Dev Kit language server caches.
*.dmp and *.dump are standard dump file extensions. While broad, these are universally recognized as debug/crash artifacts and the repo has no legitimate use of these extensions (no tracked files match). This is consistent with other broad patterns already in the file (e.g., *.log, *.tmp, *.pdb).

Generated by Code Review for issue #126718 · ◷

jtschuster · 2026-04-13T18:21:35Z

/ba-g unrelated failures

jtschuster · 2026-04-09T16:50:00Z

Add patterns to ignore C# Dev Kit caches and dump files.

The Dev Kit extension now creates .lscache files for each csproj loaded by the lsp. We should tell git to ignore them

Also ignore dump files because I imagine people often have them in the directory but never want to commit them.

Add patterns to ignore C# Dev Kit caches and dump files.

Copilot

Copilot wasn't able to review any files in this pull request.

dotnet-policy-service · 2026-04-09T16:51:19Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

github-actions · 2026-04-09T16:55:00Z

Note

This review was generated by Copilot.

🤖 Copilot Code Review — PR #126718

Holistic Assessment

Motivation: Justified — .lscache (C# Dev Kit), .dmp, and .dump files are common development/debugging artifacts that should not be committed. This is a quality-of-life improvement for contributors using VS Code with C# Dev Kit and anyone generating crash/memory dumps locally.

Approach: Correct — adding glob patterns to .gitignore is the standard approach. The entries are placed logically after the existing VS Code section, which makes sense since C# Dev Kit is a VS Code extension.

Summary: ✅ LGTM. This is a small, safe, well-placed addition to .gitignore. No existing tracked files match the new patterns, and the glob patterns are appropriately scoped. No code changes, no build/test impact.

Detailed Findings

✅ Correctness — No tracked files affected

Verified via git ls-files '*.lscache' '*.dmp' '*.dump' that no existing tracked files match these patterns. The new entries will only affect future untracked files.

✅ Placement — Logically organized

The .lscache entry is placed immediately after the VS Code section (.vscode entries), which is appropriate since C# Dev Kit is a VS Code extension. The dump file entries are grouped together with a clear comment. Both new blocks are between the VS Code and MonoDevelop sections, maintaining the file's organizational structure.

✅ Pattern scope — Appropriately broad

*.lscache is specific to C# Dev Kit language server caches.
*.dmp and *.dump are standard dump file extensions. While broad, these are universally recognized as debug/crash artifacts and the repo has no legitimate use of these extensions (no tracked files match). This is consistent with other broad patterns already in the file (e.g., *.log, *.tmp, *.pdb).

Generated by Code Review for issue #126718 · ◷

jtschuster · 2026-04-13T18:21:35Z

/ba-g unrelated failures

jtschuster · 2026-04-09T16:50:00Z

Add patterns to ignore C# Dev Kit caches and dump files.

The Dev Kit extension now creates .lscache files for each csproj loaded by the lsp. We should tell git to ignore them

Also ignore dump files because I imagine people often have them in the directory but never want to commit them.

Add patterns to ignore C# Dev Kit caches and dump files.

Copilot

Copilot wasn't able to review any files in this pull request.

dotnet-policy-service · 2026-04-09T16:51:19Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

github-actions · 2026-04-09T16:55:00Z

Note

This review was generated by Copilot.

🤖 Copilot Code Review — PR #126718

Holistic Assessment

Motivation: Justified — .lscache (C# Dev Kit), .dmp, and .dump files are common development/debugging artifacts that should not be committed. This is a quality-of-life improvement for contributors using VS Code with C# Dev Kit and anyone generating crash/memory dumps locally.

Approach: Correct — adding glob patterns to .gitignore is the standard approach. The entries are placed logically after the existing VS Code section, which makes sense since C# Dev Kit is a VS Code extension.

Summary: ✅ LGTM. This is a small, safe, well-placed addition to .gitignore. No existing tracked files match the new patterns, and the glob patterns are appropriately scoped. No code changes, no build/test impact.

Detailed Findings

✅ Correctness — No tracked files affected

Verified via git ls-files '*.lscache' '*.dmp' '*.dump' that no existing tracked files match these patterns. The new entries will only affect future untracked files.

✅ Placement — Logically organized

The .lscache entry is placed immediately after the VS Code section (.vscode entries), which is appropriate since C# Dev Kit is a VS Code extension. The dump file entries are grouped together with a clear comment. Both new blocks are between the VS Code and MonoDevelop sections, maintaining the file's organizational structure.

✅ Pattern scope — Appropriately broad

*.lscache is specific to C# Dev Kit language server caches.
*.dmp and *.dump are standard dump file extensions. While broad, these are universally recognized as debug/crash artifacts and the repo has no legitimate use of these extensions (no tracked files match). This is consistent with other broad patterns already in the file (e.g., *.log, *.tmp, *.pdb).

Generated by Code Review for issue #126718 · ◷

jtschuster · 2026-04-13T18:21:35Z

/ba-g unrelated failures

jtschuster · 2026-04-09T16:50:00Z

Add patterns to ignore C# Dev Kit caches and dump files.

The Dev Kit extension now creates .lscache files for each csproj loaded by the lsp. We should tell git to ignore them

Also ignore dump files because I imagine people often have them in the directory but never want to commit them.

Add patterns to ignore C# Dev Kit caches and dump files.

Copilot

Copilot wasn't able to review any files in this pull request.

dotnet-policy-service · 2026-04-09T16:51:19Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

github-actions · 2026-04-09T16:55:00Z

Note

This review was generated by Copilot.

🤖 Copilot Code Review — PR #126718

Holistic Assessment

Motivation: Justified — .lscache (C# Dev Kit), .dmp, and .dump files are common development/debugging artifacts that should not be committed. This is a quality-of-life improvement for contributors using VS Code with C# Dev Kit and anyone generating crash/memory dumps locally.

Approach: Correct — adding glob patterns to .gitignore is the standard approach. The entries are placed logically after the existing VS Code section, which makes sense since C# Dev Kit is a VS Code extension.

Summary: ✅ LGTM. This is a small, safe, well-placed addition to .gitignore. No existing tracked files match the new patterns, and the glob patterns are appropriately scoped. No code changes, no build/test impact.

Detailed Findings

✅ Correctness — No tracked files affected

Verified via git ls-files '*.lscache' '*.dmp' '*.dump' that no existing tracked files match these patterns. The new entries will only affect future untracked files.

✅ Placement — Logically organized

The .lscache entry is placed immediately after the VS Code section (.vscode entries), which is appropriate since C# Dev Kit is a VS Code extension. The dump file entries are grouped together with a clear comment. Both new blocks are between the VS Code and MonoDevelop sections, maintaining the file's organizational structure.

✅ Pattern scope — Appropriately broad

*.lscache is specific to C# Dev Kit language server caches.
*.dmp and *.dump are standard dump file extensions. While broad, these are universally recognized as debug/crash artifacts and the repo has no legitimate use of these extensions (no tracked files match). This is consistent with other broad patterns already in the file (e.g., *.log, *.tmp, *.pdb).

Generated by Code Review for issue #126718 · ◷

jtschuster · 2026-04-13T18:21:35Z

/ba-g unrelated failures

jtschuster · 2026-04-09T16:50:00Z

Add patterns to ignore C# Dev Kit caches and dump files.

The Dev Kit extension now creates .lscache files for each csproj loaded by the lsp. We should tell git to ignore them

Also ignore dump files because I imagine people often have them in the directory but never want to commit them.

Add patterns to ignore C# Dev Kit caches and dump files.

Copilot

Copilot wasn't able to review any files in this pull request.

dotnet-policy-service · 2026-04-09T16:51:19Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

github-actions · 2026-04-09T16:55:00Z

Note

This review was generated by Copilot.

🤖 Copilot Code Review — PR #126718

Holistic Assessment

Motivation: Justified — .lscache (C# Dev Kit), .dmp, and .dump files are common development/debugging artifacts that should not be committed. This is a quality-of-life improvement for contributors using VS Code with C# Dev Kit and anyone generating crash/memory dumps locally.

Approach: Correct — adding glob patterns to .gitignore is the standard approach. The entries are placed logically after the existing VS Code section, which makes sense since C# Dev Kit is a VS Code extension.

Summary: ✅ LGTM. This is a small, safe, well-placed addition to .gitignore. No existing tracked files match the new patterns, and the glob patterns are appropriately scoped. No code changes, no build/test impact.

Detailed Findings

✅ Correctness — No tracked files affected

Verified via git ls-files '*.lscache' '*.dmp' '*.dump' that no existing tracked files match these patterns. The new entries will only affect future untracked files.

✅ Placement — Logically organized

The .lscache entry is placed immediately after the VS Code section (.vscode entries), which is appropriate since C# Dev Kit is a VS Code extension. The dump file entries are grouped together with a clear comment. Both new blocks are between the VS Code and MonoDevelop sections, maintaining the file's organizational structure.

✅ Pattern scope — Appropriately broad

*.lscache is specific to C# Dev Kit language server caches.
*.dmp and *.dump are standard dump file extensions. While broad, these are universally recognized as debug/crash artifacts and the repo has no legitimate use of these extensions (no tracked files match). This is consistent with other broad patterns already in the file (e.g., *.log, *.tmp, *.pdb).

Generated by Code Review for issue #126718 · ◷

jtschuster · 2026-04-13T18:21:35Z

/ba-g unrelated failures

jtschuster · 2026-04-09T16:50:00Z

Add patterns to ignore C# Dev Kit caches and dump files.

The Dev Kit extension now creates .lscache files for each csproj loaded by the lsp. We should tell git to ignore them

Also ignore dump files because I imagine people often have them in the directory but never want to commit them.

Add patterns to ignore C# Dev Kit caches and dump files.

Copilot

Copilot wasn't able to review any files in this pull request.

dotnet-policy-service · 2026-04-09T16:51:19Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

github-actions · 2026-04-09T16:55:00Z

Note

This review was generated by Copilot.

🤖 Copilot Code Review — PR #126718

Holistic Assessment

Motivation: Justified — .lscache (C# Dev Kit), .dmp, and .dump files are common development/debugging artifacts that should not be committed. This is a quality-of-life improvement for contributors using VS Code with C# Dev Kit and anyone generating crash/memory dumps locally.

Approach: Correct — adding glob patterns to .gitignore is the standard approach. The entries are placed logically after the existing VS Code section, which makes sense since C# Dev Kit is a VS Code extension.

Summary: ✅ LGTM. This is a small, safe, well-placed addition to .gitignore. No existing tracked files match the new patterns, and the glob patterns are appropriately scoped. No code changes, no build/test impact.

Detailed Findings

✅ Correctness — No tracked files affected

Verified via git ls-files '*.lscache' '*.dmp' '*.dump' that no existing tracked files match these patterns. The new entries will only affect future untracked files.

✅ Placement — Logically organized

The .lscache entry is placed immediately after the VS Code section (.vscode entries), which is appropriate since C# Dev Kit is a VS Code extension. The dump file entries are grouped together with a clear comment. Both new blocks are between the VS Code and MonoDevelop sections, maintaining the file's organizational structure.

✅ Pattern scope — Appropriately broad

*.lscache is specific to C# Dev Kit language server caches.
*.dmp and *.dump are standard dump file extensions. While broad, these are universally recognized as debug/crash artifacts and the repo has no legitimate use of these extensions (no tracked files match). This is consistent with other broad patterns already in the file (e.g., *.log, *.tmp, *.pdb).

Generated by Code Review for issue #126718 · ◷

jtschuster · 2026-04-13T18:21:35Z

/ba-g unrelated failures

jtschuster · 2026-04-09T16:50:00Z

Add patterns to ignore C# Dev Kit caches and dump files.

The Dev Kit extension now creates .lscache files for each csproj loaded by the lsp. We should tell git to ignore them

Also ignore dump files because I imagine people often have them in the directory but never want to commit them.

Add patterns to ignore C# Dev Kit caches and dump files.

Copilot

Copilot wasn't able to review any files in this pull request.

dotnet-policy-service · 2026-04-09T16:51:19Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

github-actions · 2026-04-09T16:55:00Z

Note

This review was generated by Copilot.

🤖 Copilot Code Review — PR #126718

Holistic Assessment

Motivation: Justified — .lscache (C# Dev Kit), .dmp, and .dump files are common development/debugging artifacts that should not be committed. This is a quality-of-life improvement for contributors using VS Code with C# Dev Kit and anyone generating crash/memory dumps locally.

Approach: Correct — adding glob patterns to .gitignore is the standard approach. The entries are placed logically after the existing VS Code section, which makes sense since C# Dev Kit is a VS Code extension.

Summary: ✅ LGTM. This is a small, safe, well-placed addition to .gitignore. No existing tracked files match the new patterns, and the glob patterns are appropriately scoped. No code changes, no build/test impact.

Detailed Findings

✅ Correctness — No tracked files affected

Verified via git ls-files '*.lscache' '*.dmp' '*.dump' that no existing tracked files match these patterns. The new entries will only affect future untracked files.

✅ Placement — Logically organized

The .lscache entry is placed immediately after the VS Code section (.vscode entries), which is appropriate since C# Dev Kit is a VS Code extension. The dump file entries are grouped together with a clear comment. Both new blocks are between the VS Code and MonoDevelop sections, maintaining the file's organizational structure.

✅ Pattern scope — Appropriately broad

*.lscache is specific to C# Dev Kit language server caches.
*.dmp and *.dump are standard dump file extensions. While broad, these are universally recognized as debug/crash artifacts and the repo has no legitimate use of these extensions (no tracked files match). This is consistent with other broad patterns already in the file (e.g., *.log, *.tmp, *.pdb).

Generated by Code Review for issue #126718 · ◷

jtschuster · 2026-04-13T18:21:35Z

/ba-g unrelated failures

jtschuster · 2026-04-09T16:50:00Z

Add patterns to ignore C# Dev Kit caches and dump files.

The Dev Kit extension now creates .lscache files for each csproj loaded by the lsp. We should tell git to ignore them

Also ignore dump files because I imagine people often have them in the directory but never want to commit them.

Add patterns to ignore C# Dev Kit caches and dump files.

Copilot

Copilot wasn't able to review any files in this pull request.

dotnet-policy-service · 2026-04-09T16:51:19Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

github-actions · 2026-04-09T16:55:00Z

Note

This review was generated by Copilot.

🤖 Copilot Code Review — PR #126718

Holistic Assessment

Motivation: Justified — .lscache (C# Dev Kit), .dmp, and .dump files are common development/debugging artifacts that should not be committed. This is a quality-of-life improvement for contributors using VS Code with C# Dev Kit and anyone generating crash/memory dumps locally.

Approach: Correct — adding glob patterns to .gitignore is the standard approach. The entries are placed logically after the existing VS Code section, which makes sense since C# Dev Kit is a VS Code extension.

Summary: ✅ LGTM. This is a small, safe, well-placed addition to .gitignore. No existing tracked files match the new patterns, and the glob patterns are appropriately scoped. No code changes, no build/test impact.

Detailed Findings

✅ Correctness — No tracked files affected

Verified via git ls-files '*.lscache' '*.dmp' '*.dump' that no existing tracked files match these patterns. The new entries will only affect future untracked files.

✅ Placement — Logically organized

The .lscache entry is placed immediately after the VS Code section (.vscode entries), which is appropriate since C# Dev Kit is a VS Code extension. The dump file entries are grouped together with a clear comment. Both new blocks are between the VS Code and MonoDevelop sections, maintaining the file's organizational structure.

✅ Pattern scope — Appropriately broad

*.lscache is specific to C# Dev Kit language server caches.
*.dmp and *.dump are standard dump file extensions. While broad, these are universally recognized as debug/crash artifacts and the repo has no legitimate use of these extensions (no tracked files match). This is consistent with other broad patterns already in the file (e.g., *.log, *.tmp, *.pdb).

Generated by Code Review for issue #126718 · ◷

jtschuster · 2026-04-13T18:21:35Z

/ba-g unrelated failures

Update .gitignore to include cache and dump files
a0e40b9
Add patterns to ignore C# Dev Kit caches and dump files.

jtschuster requested review from agocke, jkoritzinsky and sbomer April 9, 2026 16:50

jtschuster self-assigned this Apr 9, 2026

CopilotAI review requested due to automatic review settings April 9, 2026 16:50

github-project-automationBot added this to AppModel Apr 9, 2026

CopilotAI reviewed Apr 9, 2026
View reviewed changes

github-actionsBot added the area-Infrastructure label Apr 9, 2026

github-project-automationBot added this to Runtime Infra Apr 9, 2026

akoeplinger mentioned this pull request Apr 9, 2026
[Preview] Add setting to move .lscache files to $HOME/.cache microsoft/vscode-dotnettools#2952
Open

steveisok approved these changes Apr 9, 2026
View reviewed changes

jtschuster enabled auto-merge (squash) April 9, 2026 17:32

CopilotAI mentioned this pull request Apr 11, 2026
Fix WasmTestOnChrome: exclude browser/wasi from gen-debug-dump-docs.py helix post-command #126789
Merged
1 task

jtschuster disabled auto-merge April 13, 2026 18:21

jtschuster merged commit 422c41a into mainApr 13, 2026
146 of 160 checks passed

jtschuster deleted the users/jtschuster/gitignore-lscache-and-dumps branch April 13, 2026 18:21

github-project-automationBot moved this to Done in AppModel Apr 13, 2026

github-project-automationBot moved this to Done in Runtime Infra Apr 13, 2026

dotnet-maestroBot mentioned this pull request Apr 15, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#6035
Merged

github-actionsBot locked and limited conversation to collaborators May 14, 2026