Uh oh!
There was an error while loading. Please reload this page.
Haiku: Native support - #126805
Closed
trungnt2910 wants to merge 2 commits into
Closed
Conversation
Uh oh!
There was an error while loading. Please reload this page.
trungnt2910force-pushed
the
dev/trungnt2910/haiku-misc-native
branch
from
April 12, 2026 06:37
3944abc to
646589bCompaream11
commented
Apr 12, 2026
Member
Mono portion of this repo is only for mobile and browser/wasm platforms and it will eventually go away when CoreCLR replaces them, which is actively being worked on. For desktop platforms, CoreCLR and NativeAOT are the main focus going forward. |
This was referenced Apr 22, 2026
kotlarmilos pushed a commit
that referenced
this pull request
Apr 27, 2026
#127274) Fixes System.Console.Tests failures on MacCatalyst discovered in runtime-extra-platforms build [#1388505](https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=1388505). ## Failure **Build**: [#1388505](https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=1388505) (2026-04-21) **Job**: `maccatalyst-arm64 Release AllSubsets_Mono` **Helix job**: `f4caa84e-1526-4c12-a872-6f24ac6f3ba1` **Work item**: System.Console.Tests **Platform**: MacCatalyst arm64 (also affects maccatalyst-x64) ### Failed tests Four tests failed with `PlatformNotSupportedException`: 1. `OpenStandardInputHandle_ReturnsValidHandle` 2. `OpenStandardOutputHandle_ReturnsValidHandle` 3. `OpenStandardErrorHandle_ReturnsValidHandle` 4. `OpenStandardHandles_DoNotOwnHandle` ````text [FAIL] System.Tests.ConsoleTests.OpenStandardInputHandle_ReturnsValidHandle System.PlatformNotSupportedException : Operation is not supported on this platform. at System.ConsolePal.OpenStandardInputHandle() at System.Console.OpenStandardInputHandle() ```` ### Root cause The `Console.OpenStandardXXXHandle()` methods throw `PlatformNotSupportedException` on mobile platforms (iOS, tvOS, Android, MacCatalyst) because these platforms do not expose the underlying file handles for standard streams. The existing tests already had `[PlatformSpecific]` attributes excluding iOS, tvOS, and Android, but **MacCatalyst was missing** from the exclusion list. This is an oversight because MacCatalyst has the same limitation as other Apple mobile platforms. ### Fix Add `TestPlatforms.MacCatalyst` to the exclusion list (using `& ~TestPlatforms.MacCatalyst`) on all five tests that attempt to use these APIs, and add it to the inclusion list on the three "ThrowsOnUnsupportedPlatforms" tests that validate the exception is thrown. This makes the skip coverage consistent across all mobile platforms: - Skip on: iOS, tvOS, MacCatalyst, Android, Browser (where applicable) - Run on: Windows, Linux, macOS desktop ## Testing After this fix, the four failing tests will be skipped on MacCatalyst in the `runtime-extra-platforms` pipeline, matching the behavior on iOS, tvOS, and Android. --- > [!NOTE] > This PR was created by GitHub Copilot after analyzing mobile platform CI failures in the runtime-extra-platforms pipeline (build 1388505). > [!NOTE] > <details> > <summary>🔒 Integrity filter blocked 1 item</summary> > > The following item were blocked because they don't meet the GitHub integrity level. > > - [#126805](#126805) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > > To allow these resources, lower `min-integrity` in your GitHub frontmatter: > > ```yaml > tools: > github: > min-integrity: approved # merged | approved | unapproved | none > ``` > > </details> > Generated by [Mobile Platform Failure Scanner](https://github.com/dotnet/runtime/actions/runs/24774805343/agentic_workflow) · ● 2.2M · [◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+mobile-scan%22&type=pullrequests) <!-- gh-aw-agentic-workflow: Mobile Platform Failure Scanner, engine: copilot, model: claude-sonnet-4.5, id: 24774805343, workflow_id: mobile-scan, run: https://github.com/dotnet/runtime/actions/runs/24774805343 --> <!-- gh-aw-workflow-id: mobile-scan --> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotlarmilos added a commit
that referenced
this pull request
Apr 28, 2026
> [!NOTE] > This content was generated by GitHub Copilot. ## Summary Fixes `System.Net.NameResolution.Functional.Tests.GetHostEntryTest.DnsGetHostEntry_LocalHost_ReturnsFqdnAndLoopbackIPs` test failure on Android by skipping the test on that platform. ## Background The test assumes that resolving "localhost" returns only loopback IP addresses (`127.0.0.1` and `::1`). However, on Android Helix machines (emulators), the DNS resolution for "localhost" returns actual network interfaces in addition to loopback addresses, causing the test to fail with assertions like: ````` Assert.All() Failure: 5 out of 6 items in the collection did not pass. [1]: Item: fe80::e05a:f2ff:fee9:6ae6%47 Error: Not a loopback address: fe80::e05a:f2ff:fee9:6ae6%47 [2]: Item: 2001:4898:502:2:e05a:f2ff:fee9:6ae6 Error: Not a loopback address: 2001:4898:502:2:e05a:f2ff:fee9:6ae6 [5]: Item: 10.64.32.211 Error: Not a loopback address: 10.64.32.211 ```` ## Changes Added `[SkipOnPlatform(TestPlatforms.Android, ...)]` attribute to the failing test, consistent with existing skips for iOS, tvOS, and MacCatalyst on the same test (which have similar issues). ## Failure Details **Build:** https://dev.azure.com/dnceng-public/public/_build/results?buildId=1396313 **Job:** `android-arm64 Release AllSubsets_Mono` **Helix Work Item:** System.Net.NameResolution.Functional.Tests - Job ID: `93091357-214b-436d-a5c4-a31ee456a876` - Console log: https://helix.dot.net/api/2019-06-17/jobs/93091357-214b-436d-a5c4-a31ee456a876/workitems/System.Net.NameResolution.Functional.Tests/console **Log excerpt (sanitized):** ```` 04-25 00:03:35.029 DOTNET : [FAIL] System.Net.NameResolution.Tests.GetHostEntryTest.DnsGetHostEntry_LocalHost_ReturnsFqdnAndLoopbackIPs(mode: 0) 04-25 00:03:35.029 DOTNET : Assert.All() Failure: 5 out of 6 items in the collection did not pass. 04-25 00:03:35.029 DOTNET : [5]: Item: 10.64.32.211 04-25 00:03:35.029 DOTNET : Error: Not a loopback address: 10.64.32.211 ````` ## Related - Existing skip on iOS/tvOS/MacCatalyst: #124079 - Similar Wasi skip: #107339 > [!NOTE] > <details> > <summary>🔒 Integrity filter blocked 1 item</summary> > > The following item were blocked because they don't meet the GitHub integrity level. > > - [#126805](#126805) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > > To allow these resources, lower `min-integrity` in your GitHub frontmatter: > > ```yaml > tools: > github: > min-integrity: approved # merged | approved | unapproved | none > ``` > > </details> > Generated by [Mobile Platform Failure Scanner](https://github.com/dotnet/runtime/actions/runs/24929356562/agentic_workflow) · ● 4.1M · [◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+mobile-scan%22&type=pullrequests) <!-- gh-aw-agentic-workflow: Mobile Platform Failure Scanner, engine: copilot, model: claude-sonnet-4.5, id: 24929356562, workflow_id: mobile-scan, run: https://github.com/dotnet/runtime/actions/runs/24929356562 --> <!-- gh-aw-workflow-id: mobile-scan --> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>
This is the rest of the changes to the native code of .NET from the initial porting effort in 2023.
trungnt2910force-pushed
the
dev/trungnt2910/haiku-misc-native
branch
from
April 29, 2026 13:44
646589b to
caef932Compare
This was referenced Apr 29, 2026
Open
This was referenced May 4, 2026
kotlarmilos added a commit
that referenced
this pull request
May 5, 2026
## Summary Fixes failing `System.Net.NameResolution` tests on Android by adding `ActiveIssue` attributes to skip tests that expect localhost subdomain resolution to return loopback addresses. ## Details On Android, DNS resolution for `.localhost` subdomains (e.g., `foo.localhost`, `test.localhost`) returns link-local IPv6 addresses (`fe80::/10`) instead of loopback addresses, causing test failures. ### Tests Fixed - `DnsGetHostEntry_LocalhostSubdomain_ReturnsLoopback` - `DnsGetHostAddresses_LocalhostSubdomain_ReturnsLoopback` These tests are now skipped on Android with reference to existing issue #124751, which already tracks the same underlying problem for the `RespectsAddressFamily` variants of these tests. ### Build Information - **Build**: [1406427](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1406427) - **Date**: 2026-05-03 - **Job**: android-arm Release AllSubsets_Mono - **Helix Job**: 6255e58e-bf4f-4c25-ba48-27c957d4ea3e - **Work Item**: System.Net.NameResolution.Functional.Tests ### Console Log Excerpt (sanitized) ``` [20:56:01] info: Instrumentation finished normally with exit code 1 [FAIL] System.Net.NameResolution.Tests.GetHostAddressesTest.DnsGetHostAddresses_LocalhostSubdomain_ReturnsLoopback(hostName: "foo.localhost") Assert.All() Failure: 2 out of 3 items in the collection did not pass. Error: Expected loopback address but got: fe80::cb7c:d6fd:eb1f:6f44%10 Error: Expected loopback address but got: fe80::b4f2:efff:fea1:dbef%3 [FAIL] System.Net.NameResolution.Tests.GetHostAddressesTest.DnsGetHostAddresses_LocalhostSubdomain_ReturnsLoopback(hostName: "test.localhost") Assert.All() Failure: 2 out of 3 items in the collection did not pass. Error: Expected loopback address but got: fe80::cb7c:d6fd:eb1f:6f44%10 Error: Expected loopback address but got: fe80::b4f2:efff:fea1:dbef%3 ``` The tests receive link-local IPv6 addresses instead of the expected loopback addresses (127.0.0.1 or ::1). ### Root Cause Android's DNS resolver behavior for RFC 6761 localhost subdomains differs from desktop platforms. When the OS resolver fallback tries to resolve plain "localhost" with or without an address family filter, Android may return the device's network interface addresses instead of loopback addresses. ### Related Issue Closes: #124751 > [!NOTE] > This content was generated by GitHub Copilot and may contain AI-generated content. > [!NOTE] > <details> > <summary>🔒 Integrity filter blocked 2 items</summary> > > The following items were blocked because they don't meet the GitHub integrity level. > > - [#19443](#19443) `search_issues`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - [#126805](#126805) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > > To allow these resources, lower `min-integrity` in your GitHub frontmatter: > > ```yaml > tools: > github: > min-integrity: approved # merged | approved | unapproved | none > ``` > > </details> > Generated by [Mobile Platform Failure Scanner](https://github.com/dotnet/runtime/actions/runs/25316071096/agentic_workflow) · ● 3.6M · [◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+mobile-scan%22&type=pullrequests) <!-- gh-aw-agentic-workflow: Mobile Platform Failure Scanner, engine: copilot, model: claude-sonnet-4.5, id: 25316071096, workflow_id: mobile-scan, run: https://github.com/dotnet/runtime/actions/runs/25316071096 --> <!-- gh-aw-workflow-id: mobile-scan --> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Milos Kotlar <kotlarmilos@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
steveisok
approved these changes
Jun 8, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
#127274) Fixes System.Console.Tests failures on MacCatalyst discovered in runtime-extra-platforms build [#1388505](https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=1388505). ## Failure **Build**: [#1388505](https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=1388505) (2026-04-21) **Job**: `maccatalyst-arm64 Release AllSubsets_Mono` **Helix job**: `f4caa84e-1526-4c12-a872-6f24ac6f3ba1` **Work item**: System.Console.Tests **Platform**: MacCatalyst arm64 (also affects maccatalyst-x64) ### Failed tests Four tests failed with `PlatformNotSupportedException`: 1. `OpenStandardInputHandle_ReturnsValidHandle` 2. `OpenStandardOutputHandle_ReturnsValidHandle` 3. `OpenStandardErrorHandle_ReturnsValidHandle` 4. `OpenStandardHandles_DoNotOwnHandle` ````text [FAIL] System.Tests.ConsoleTests.OpenStandardInputHandle_ReturnsValidHandle System.PlatformNotSupportedException : Operation is not supported on this platform. at System.ConsolePal.OpenStandardInputHandle() at System.Console.OpenStandardInputHandle() ```` ### Root cause The `Console.OpenStandardXXXHandle()` methods throw `PlatformNotSupportedException` on mobile platforms (iOS, tvOS, Android, MacCatalyst) because these platforms do not expose the underlying file handles for standard streams. The existing tests already had `[PlatformSpecific]` attributes excluding iOS, tvOS, and Android, but **MacCatalyst was missing** from the exclusion list. This is an oversight because MacCatalyst has the same limitation as other Apple mobile platforms. ### Fix Add `TestPlatforms.MacCatalyst` to the exclusion list (using `& ~TestPlatforms.MacCatalyst`) on all five tests that attempt to use these APIs, and add it to the inclusion list on the three "ThrowsOnUnsupportedPlatforms" tests that validate the exception is thrown. This makes the skip coverage consistent across all mobile platforms: - Skip on: iOS, tvOS, MacCatalyst, Android, Browser (where applicable) - Run on: Windows, Linux, macOS desktop ## Testing After this fix, the four failing tests will be skipped on MacCatalyst in the `runtime-extra-platforms` pipeline, matching the behavior on iOS, tvOS, and Android. --- > [!NOTE] > This PR was created by GitHub Copilot after analyzing mobile platform CI failures in the runtime-extra-platforms pipeline (build 1388505). > [!NOTE] > <details> > <summary>🔒 Integrity filter blocked 1 item</summary> > > The following item were blocked because they don't meet the GitHub integrity level. > > - [#126805](#126805) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > > To allow these resources, lower `min-integrity` in your GitHub frontmatter: > > ```yaml > tools: > github: > min-integrity: approved # merged | approved | unapproved | none > ``` > > </details> > Generated by [Mobile Platform Failure Scanner](https://github.com/dotnet/runtime/actions/runs/24774805343/agentic_workflow) · ● 2.2M · [◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+mobile-scan%22&type=pullrequests) <!-- gh-aw-agentic-workflow: Mobile Platform Failure Scanner, engine: copilot, model: claude-sonnet-4.5, id: 24774805343, workflow_id: mobile-scan, run: https://github.com/dotnet/runtime/actions/runs/24774805343 --> <!-- gh-aw-workflow-id: mobile-scan --> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
> [!NOTE] > This content was generated by GitHub Copilot. ## Summary Fixes `System.Net.NameResolution.Functional.Tests.GetHostEntryTest.DnsGetHostEntry_LocalHost_ReturnsFqdnAndLoopbackIPs` test failure on Android by skipping the test on that platform. ## Background The test assumes that resolving "localhost" returns only loopback IP addresses (`127.0.0.1` and `::1`). However, on Android Helix machines (emulators), the DNS resolution for "localhost" returns actual network interfaces in addition to loopback addresses, causing the test to fail with assertions like: ````` Assert.All() Failure: 5 out of 6 items in the collection did not pass. [1]: Item: fe80::e05a:f2ff:fee9:6ae6%47 Error: Not a loopback address: fe80::e05a:f2ff:fee9:6ae6%47 [2]: Item: 2001:4898:502:2:e05a:f2ff:fee9:6ae6 Error: Not a loopback address: 2001:4898:502:2:e05a:f2ff:fee9:6ae6 [5]: Item: 10.64.32.211 Error: Not a loopback address: 10.64.32.211 ```` ## Changes Added `[SkipOnPlatform(TestPlatforms.Android, ...)]` attribute to the failing test, consistent with existing skips for iOS, tvOS, and MacCatalyst on the same test (which have similar issues). ## Failure Details **Build:** https://dev.azure.com/dnceng-public/public/_build/results?buildId=1396313 **Job:** `android-arm64 Release AllSubsets_Mono` **Helix Work Item:** System.Net.NameResolution.Functional.Tests - Job ID: `93091357-214b-436d-a5c4-a31ee456a876` - Console log: https://helix.dot.net/api/2019-06-17/jobs/93091357-214b-436d-a5c4-a31ee456a876/workitems/System.Net.NameResolution.Functional.Tests/console **Log excerpt (sanitized):** ```` 04-25 00:03:35.029 DOTNET : [FAIL] System.Net.NameResolution.Tests.GetHostEntryTest.DnsGetHostEntry_LocalHost_ReturnsFqdnAndLoopbackIPs(mode: 0) 04-25 00:03:35.029 DOTNET : Assert.All() Failure: 5 out of 6 items in the collection did not pass. 04-25 00:03:35.029 DOTNET : [5]: Item: 10.64.32.211 04-25 00:03:35.029 DOTNET : Error: Not a loopback address: 10.64.32.211 ````` ## Related - Existing skip on iOS/tvOS/MacCatalyst: #124079 - Similar Wasi skip: #107339 > [!NOTE] > <details> > <summary>🔒 Integrity filter blocked 1 item</summary> > > The following item were blocked because they don't meet the GitHub integrity level. > > - [#126805](#126805) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > > To allow these resources, lower `min-integrity` in your GitHub frontmatter: > > ```yaml > tools: > github: > min-integrity: approved # merged | approved | unapproved | none > ``` > > </details> > Generated by [Mobile Platform Failure Scanner](https://github.com/dotnet/runtime/actions/runs/24929356562/agentic_workflow) · ● 4.1M · [◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+mobile-scan%22&type=pullrequests) <!-- gh-aw-agentic-workflow: Mobile Platform Failure Scanner, engine: copilot, model: claude-sonnet-4.5, id: 24929356562, workflow_id: mobile-scan, run: https://github.com/dotnet/runtime/actions/runs/24929356562 --> <!-- gh-aw-workflow-id: mobile-scan --> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
## Summary Fixes failing `System.Net.NameResolution` tests on Android by adding `ActiveIssue` attributes to skip tests that expect localhost subdomain resolution to return loopback addresses. ## Details On Android, DNS resolution for `.localhost` subdomains (e.g., `foo.localhost`, `test.localhost`) returns link-local IPv6 addresses (`fe80::/10`) instead of loopback addresses, causing test failures. ### Tests Fixed - `DnsGetHostEntry_LocalhostSubdomain_ReturnsLoopback` - `DnsGetHostAddresses_LocalhostSubdomain_ReturnsLoopback` These tests are now skipped on Android with reference to existing issue #124751, which already tracks the same underlying problem for the `RespectsAddressFamily` variants of these tests. ### Build Information - **Build**: [1406427](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1406427) - **Date**: 2026-05-03 - **Job**: android-arm Release AllSubsets_Mono - **Helix Job**: 6255e58e-bf4f-4c25-ba48-27c957d4ea3e - **Work Item**: System.Net.NameResolution.Functional.Tests ### Console Log Excerpt (sanitized) ``` [20:56:01] info: Instrumentation finished normally with exit code 1 [FAIL] System.Net.NameResolution.Tests.GetHostAddressesTest.DnsGetHostAddresses_LocalhostSubdomain_ReturnsLoopback(hostName: "foo.localhost") Assert.All() Failure: 2 out of 3 items in the collection did not pass. Error: Expected loopback address but got: fe80::cb7c:d6fd:eb1f:6f44%10 Error: Expected loopback address but got: fe80::b4f2:efff:fea1:dbef%3 [FAIL] System.Net.NameResolution.Tests.GetHostAddressesTest.DnsGetHostAddresses_LocalhostSubdomain_ReturnsLoopback(hostName: "test.localhost") Assert.All() Failure: 2 out of 3 items in the collection did not pass. Error: Expected loopback address but got: fe80::cb7c:d6fd:eb1f:6f44%10 Error: Expected loopback address but got: fe80::b4f2:efff:fea1:dbef%3 ``` The tests receive link-local IPv6 addresses instead of the expected loopback addresses (127.0.0.1 or ::1). ### Root Cause Android's DNS resolver behavior for RFC 6761 localhost subdomains differs from desktop platforms. When the OS resolver fallback tries to resolve plain "localhost" with or without an address family filter, Android may return the device's network interface addresses instead of loopback addresses. ### Related Issue Closes: #124751 > [!NOTE] > This content was generated by GitHub Copilot and may contain AI-generated content. > [!NOTE] > <details> > <summary>🔒 Integrity filter blocked 2 items</summary> > > The following items were blocked because they don't meet the GitHub integrity level. > > - [#19443](#19443) `search_issues`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - [#126805](#126805) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > > To allow these resources, lower `min-integrity` in your GitHub frontmatter: > > ```yaml > tools: > github: > min-integrity: approved # merged | approved | unapproved | none > ``` > > </details> > Generated by [Mobile Platform Failure Scanner](https://github.com/dotnet/runtime/actions/runs/25316071096/agentic_workflow) · ● 3.6M · [◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+mobile-scan%22&type=pullrequests) <!-- gh-aw-agentic-workflow: Mobile Platform Failure Scanner, engine: copilot, model: claude-sonnet-4.5, id: 25316071096, workflow_id: mobile-scan, run: https://github.com/dotnet/runtime/actions/runs/25316071096 --> <!-- gh-aw-workflow-id: mobile-scan --> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Milos Kotlar <kotlarmilos@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Workflow state for the Holistic Review Orchestrator. {
"version": 5,
"last_dispatched_commit": "f8231a1b52eebfadb39ff4c7bba80459ea99c1fc",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "1547c9a611355b6ac0e958f5aa9299ed70e14665",
"last_reviewed_commit": "f8231a1b52eebfadb39ff4c7bba80459ea99c1fc",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "1547c9a611355b6ac0e958f5aa9299ed70e14665",
"last_recorded_worker_run_id": "29675346580",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "f8231a1b52eebfadb39ff4c7bba80459ea99c1fc",
"review_id": 4730522067
}
]
} |
Contributor
There was a problem hiding this comment.
Holistic Review
Motivation: This PR continues the Haiku OS native porting effort for the Mono runtime (part of #55803). It adds the correct libc mapping for Haiku so that runtime code requesting "libc" resolves to Haiku's actual C library.
Approach: A single two-line addition to fix_libc_name in mono-dl.c adds an #elif defined (__HAIKU__) branch returning "libroot.so", inserted into the existing platform-specific ifdef chain before the generic LIBC_SO/libc.so fallbacks.
Summary: The change is correct, minimal, and well-scoped. On Haiku the standard C library is provided by libroot.so (Haiku bundles libc, libm, libpthread, etc. into libroot), so mapping the logical name libc to libroot.so is the right behavior. The placement is consistent with the surrounding OS-specific branches, and __HAIKU__ is the standard predefined macro for the Haiku toolchain. Since libroot.so is always present on Haiku, no additional error handling is needed. No functional, portability, or style concerns. LGTM.
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 31.5 AIC · ⌖ 10.1 AIC · ⊞ 10K
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the rest of the changes to the native code of .NET from the initial porting effort in 2023.
Part of #55803.