[mobile] Add MacCatalyst to Console OpenStandardHandle test exclusions - #127274

Merged
kotlarmilos merged 2 commits into
mainfrom
mobile-fix-console-maccatalyst-2f64009d55531485
Apr 27, 2026
Merged

[mobile] Add MacCatalyst to Console OpenStandardHandle test exclusions#127274
kotlarmilos merged 2 commits into
mainfrom
mobile-fix-console-maccatalyst-2f64009d55531485

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Fixes System.Console.Tests failures on MacCatalyst discovered in runtime-extra-platforms build #1388505.

Failure

Build: #1388505 (2026-04-21)
Job: maccatalyst-arm64 Release AllSubsets_Mono
Helix job: f4caa84e-1526-4c12-a872-6f24ac6f3ba1
Work item: System.Console.Tests
Platform: MacCatalyst arm64 (also affects maccatalyst-x64)

Failed tests

Four tests failed with PlatformNotSupportedException:

  1. OpenStandardInputHandle_ReturnsValidHandle
  2. OpenStandardOutputHandle_ReturnsValidHandle
  3. OpenStandardErrorHandle_ReturnsValidHandle
  4. OpenStandardHandles_DoNotOwnHandle
[FAIL] System.Tests.ConsoleTests.OpenStandardInputHandle_ReturnsValidHandle
System.PlatformNotSupportedException : Operation is not supported on this platform.
at System.ConsolePal.OpenStandardInputHandle()
at System.Console.OpenStandardInputHandle()

Root cause

The Console.OpenStandardXXXHandle() methods throw PlatformNotSupportedException on mobile platforms (iOS, tvOS, Android, MacCatalyst) because these platforms do not expose the underlying file handles for standard streams.

The existing tests already had [PlatformSpecific] attributes excluding iOS, tvOS, and Android, but MacCatalyst was missing from the exclusion list. This is an oversight because MacCatalyst has the same limitation as other Apple mobile platforms.

Fix

Add TestPlatforms.MacCatalyst to the exclusion list (using & ~TestPlatforms.MacCatalyst) on all five tests that attempt to use these APIs, and add it to the inclusion list on the three "ThrowsOnUnsupportedPlatforms" tests that validate the exception is thrown.

This makes the skip coverage consistent across all mobile platforms:

  • Skip on: iOS, tvOS, MacCatalyst, Android, Browser (where applicable)
  • Run on: Windows, Linux, macOS desktop

Testing

After this fix, the four failing tests will be skipped on MacCatalyst in the runtime-extra-platforms pipeline, matching the behavior on iOS, tvOS, and Android.


Note

This PR was created by GitHub Copilot after analyzing mobile platform CI failures in the runtime-extra-platforms pipeline (build 1388505).

Note

🔒 Integrity filter blocked 1 item

The following item were blocked because they don't meet the GitHub integrity level.

  • #126805search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
github:
min-integrity: approved # merged | approved | unapproved | none

Generated by Mobile Platform Failure Scanner · ● 2.2M ·

Fixes System.Console.Tests failures on MacCatalyst discovered in build #1388505.
The tests for Console.OpenStandardInputHandle(), OpenStandardOutputHandle(),
and OpenStandardErrorHandle() were already excluding iOS, tvOS, and Android
(where these APIs throw PlatformNotSupportedException), but were missing
MacCatalyst from the exclusion list.
This caused 4 test failures on maccatalyst-arm64:
- OpenStandardInputHandle_ReturnsValidHandle
- OpenStandardOutputHandle_ReturnsValidHandle
- OpenStandardErrorHandle_ReturnsValidHandle
- OpenStandardHandles_DoNotOwnHandle
The fix adds TestPlatforms.MacCatalyst to the exclusion list on all affected
tests, and adds it to the inclusion list on the corresponding "ThrowsOnUnsupportedPlatforms" tests.
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=1388505
Job: maccatalyst-arm64 Release AllSubsets_Mono
Work item: System.Console.Tests
Helix job: f4caa84e-1526-4c12-a872-6f24ac6f3ba1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

@kotlarmilos
kotlarmilos marked this pull request as ready for review April 22, 2026 11:32
@kotlarmiloskotlarmilos added this to the 11.0.0 milestone Apr 22, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes System.Console.Tests failures on MacCatalyst by aligning the PlatformSpecific test filters with other mobile platforms where Console.OpenStandard*Handle() is not supported.

Changes:

  • Exclude TestPlatforms.MacCatalyst from tests that expect standard handles to be available/usable.
  • Include TestPlatforms.MacCatalyst in tests that validate PlatformNotSupportedException is thrown on unsupported platforms.

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to update the code review skill to require the tests to be annotated when testing APIs that are not available on every platform

@kotlarmilos

Copy link
Copy Markdown
Member

/ba-g wasm job takes longer than the maximum time of 240 minutes

@kotlarmilos
kotlarmilos merged commit 24c5e6f into mainApr 27, 2026
92 of 100 checks passed
@kotlarmilos
kotlarmilos deleted the mobile-fix-console-maccatalyst-2f64009d55531485 branch April 27, 2026 08:54
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 27, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@adamsitnik
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

[mobile] Add MacCatalyst to Console OpenStandardHandle test exclusions - #127274

Merged
kotlarmilos merged 2 commits into
mainfrom
mobile-fix-console-maccatalyst-2f64009d55531485
Apr 27, 2026
Merged

[mobile] Add MacCatalyst to Console OpenStandardHandle test exclusions#127274
kotlarmilos merged 2 commits into
mainfrom
mobile-fix-console-maccatalyst-2f64009d55531485

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Fixes System.Console.Tests failures on MacCatalyst discovered in runtime-extra-platforms build #1388505.

Failure

Build: #1388505 (2026-04-21)
Job: maccatalyst-arm64 Release AllSubsets_Mono
Helix job: f4caa84e-1526-4c12-a872-6f24ac6f3ba1
Work item: System.Console.Tests
Platform: MacCatalyst arm64 (also affects maccatalyst-x64)

Failed tests

Four tests failed with PlatformNotSupportedException:

  1. OpenStandardInputHandle_ReturnsValidHandle
  2. OpenStandardOutputHandle_ReturnsValidHandle
  3. OpenStandardErrorHandle_ReturnsValidHandle
  4. OpenStandardHandles_DoNotOwnHandle
[FAIL] System.Tests.ConsoleTests.OpenStandardInputHandle_ReturnsValidHandle
System.PlatformNotSupportedException : Operation is not supported on this platform.
at System.ConsolePal.OpenStandardInputHandle()
at System.Console.OpenStandardInputHandle()

Root cause

The Console.OpenStandardXXXHandle() methods throw PlatformNotSupportedException on mobile platforms (iOS, tvOS, Android, MacCatalyst) because these platforms do not expose the underlying file handles for standard streams.

The existing tests already had [PlatformSpecific] attributes excluding iOS, tvOS, and Android, but MacCatalyst was missing from the exclusion list. This is an oversight because MacCatalyst has the same limitation as other Apple mobile platforms.

Fix

Add TestPlatforms.MacCatalyst to the exclusion list (using & ~TestPlatforms.MacCatalyst) on all five tests that attempt to use these APIs, and add it to the inclusion list on the three "ThrowsOnUnsupportedPlatforms" tests that validate the exception is thrown.

This makes the skip coverage consistent across all mobile platforms:

  • Skip on: iOS, tvOS, MacCatalyst, Android, Browser (where applicable)
  • Run on: Windows, Linux, macOS desktop

Testing

After this fix, the four failing tests will be skipped on MacCatalyst in the runtime-extra-platforms pipeline, matching the behavior on iOS, tvOS, and Android.


Note

This PR was created by GitHub Copilot after analyzing mobile platform CI failures in the runtime-extra-platforms pipeline (build 1388505).

Note

🔒 Integrity filter blocked 1 item

The following item were blocked because they don't meet the GitHub integrity level.

  • #126805search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
github:
min-integrity: approved # merged | approved | unapproved | none

Generated by Mobile Platform Failure Scanner · ● 2.2M ·

Fixes System.Console.Tests failures on MacCatalyst discovered in build #1388505.
The tests for Console.OpenStandardInputHandle(), OpenStandardOutputHandle(),
and OpenStandardErrorHandle() were already excluding iOS, tvOS, and Android
(where these APIs throw PlatformNotSupportedException), but were missing
MacCatalyst from the exclusion list.
This caused 4 test failures on maccatalyst-arm64:
- OpenStandardInputHandle_ReturnsValidHandle
- OpenStandardOutputHandle_ReturnsValidHandle
- OpenStandardErrorHandle_ReturnsValidHandle
- OpenStandardHandles_DoNotOwnHandle
The fix adds TestPlatforms.MacCatalyst to the exclusion list on all affected
tests, and adds it to the inclusion list on the corresponding "ThrowsOnUnsupportedPlatforms" tests.
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=1388505
Job: maccatalyst-arm64 Release AllSubsets_Mono
Work item: System.Console.Tests
Helix job: f4caa84e-1526-4c12-a872-6f24ac6f3ba1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

@kotlarmilos
kotlarmilos marked this pull request as ready for review April 22, 2026 11:32
@kotlarmiloskotlarmilos added this to the 11.0.0 milestone Apr 22, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes System.Console.Tests failures on MacCatalyst by aligning the PlatformSpecific test filters with other mobile platforms where Console.OpenStandard*Handle() is not supported.

Changes:

  • Exclude TestPlatforms.MacCatalyst from tests that expect standard handles to be available/usable.
  • Include TestPlatforms.MacCatalyst in tests that validate PlatformNotSupportedException is thrown on unsupported platforms.

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to update the code review skill to require the tests to be annotated when testing APIs that are not available on every platform

@kotlarmilos

Copy link
Copy Markdown
Member

/ba-g wasm job takes longer than the maximum time of 240 minutes

@kotlarmilos
kotlarmilos merged commit 24c5e6f into mainApr 27, 2026
92 of 100 checks passed
@kotlarmilos
kotlarmilos deleted the mobile-fix-console-maccatalyst-2f64009d55531485 branch April 27, 2026 08:54
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 27, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@adamsitnik
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[mobile] Add MacCatalyst to Console OpenStandardHandle test exclusions - #127274

Merged
kotlarmilos merged 2 commits into
mainfrom
mobile-fix-console-maccatalyst-2f64009d55531485
Apr 27, 2026
Merged

[mobile] Add MacCatalyst to Console OpenStandardHandle test exclusions#127274
kotlarmilos merged 2 commits into
mainfrom
mobile-fix-console-maccatalyst-2f64009d55531485

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Fixes System.Console.Tests failures on MacCatalyst discovered in runtime-extra-platforms build #1388505.

Failure

Build: #1388505 (2026-04-21)
Job: maccatalyst-arm64 Release AllSubsets_Mono
Helix job: f4caa84e-1526-4c12-a872-6f24ac6f3ba1
Work item: System.Console.Tests
Platform: MacCatalyst arm64 (also affects maccatalyst-x64)

Failed tests

Four tests failed with PlatformNotSupportedException:

  1. OpenStandardInputHandle_ReturnsValidHandle
  2. OpenStandardOutputHandle_ReturnsValidHandle
  3. OpenStandardErrorHandle_ReturnsValidHandle
  4. OpenStandardHandles_DoNotOwnHandle
[FAIL] System.Tests.ConsoleTests.OpenStandardInputHandle_ReturnsValidHandle
System.PlatformNotSupportedException : Operation is not supported on this platform.
at System.ConsolePal.OpenStandardInputHandle()
at System.Console.OpenStandardInputHandle()

Root cause

The Console.OpenStandardXXXHandle() methods throw PlatformNotSupportedException on mobile platforms (iOS, tvOS, Android, MacCatalyst) because these platforms do not expose the underlying file handles for standard streams.

The existing tests already had [PlatformSpecific] attributes excluding iOS, tvOS, and Android, but MacCatalyst was missing from the exclusion list. This is an oversight because MacCatalyst has the same limitation as other Apple mobile platforms.

Fix

Add TestPlatforms.MacCatalyst to the exclusion list (using & ~TestPlatforms.MacCatalyst) on all five tests that attempt to use these APIs, and add it to the inclusion list on the three "ThrowsOnUnsupportedPlatforms" tests that validate the exception is thrown.

This makes the skip coverage consistent across all mobile platforms:

  • Skip on: iOS, tvOS, MacCatalyst, Android, Browser (where applicable)
  • Run on: Windows, Linux, macOS desktop

Testing

After this fix, the four failing tests will be skipped on MacCatalyst in the runtime-extra-platforms pipeline, matching the behavior on iOS, tvOS, and Android.


Note

This PR was created by GitHub Copilot after analyzing mobile platform CI failures in the runtime-extra-platforms pipeline (build 1388505).

Note

🔒 Integrity filter blocked 1 item

The following item were blocked because they don't meet the GitHub integrity level.

  • #126805search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
github:
min-integrity: approved # merged | approved | unapproved | none

Generated by Mobile Platform Failure Scanner · ● 2.2M ·

Fixes System.Console.Tests failures on MacCatalyst discovered in build #1388505.
The tests for Console.OpenStandardInputHandle(), OpenStandardOutputHandle(),
and OpenStandardErrorHandle() were already excluding iOS, tvOS, and Android
(where these APIs throw PlatformNotSupportedException), but were missing
MacCatalyst from the exclusion list.
This caused 4 test failures on maccatalyst-arm64:
- OpenStandardInputHandle_ReturnsValidHandle
- OpenStandardOutputHandle_ReturnsValidHandle
- OpenStandardErrorHandle_ReturnsValidHandle
- OpenStandardHandles_DoNotOwnHandle
The fix adds TestPlatforms.MacCatalyst to the exclusion list on all affected
tests, and adds it to the inclusion list on the corresponding "ThrowsOnUnsupportedPlatforms" tests.
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=1388505
Job: maccatalyst-arm64 Release AllSubsets_Mono
Work item: System.Console.Tests
Helix job: f4caa84e-1526-4c12-a872-6f24ac6f3ba1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

@kotlarmilos
kotlarmilos marked this pull request as ready for review April 22, 2026 11:32
@kotlarmiloskotlarmilos added this to the 11.0.0 milestone Apr 22, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes System.Console.Tests failures on MacCatalyst by aligning the PlatformSpecific test filters with other mobile platforms where Console.OpenStandard*Handle() is not supported.

Changes:

  • Exclude TestPlatforms.MacCatalyst from tests that expect standard handles to be available/usable.
  • Include TestPlatforms.MacCatalyst in tests that validate PlatformNotSupportedException is thrown on unsupported platforms.

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to update the code review skill to require the tests to be annotated when testing APIs that are not available on every platform

@kotlarmilos

Copy link
Copy Markdown
Member

/ba-g wasm job takes longer than the maximum time of 240 minutes

@kotlarmilos
kotlarmilos merged commit 24c5e6f into mainApr 27, 2026
92 of 100 checks passed
@kotlarmilos
kotlarmilos deleted the mobile-fix-console-maccatalyst-2f64009d55531485 branch April 27, 2026 08:54
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 27, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@adamsitnik
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[mobile] Add MacCatalyst to Console OpenStandardHandle test exclusions - #127274

Merged
kotlarmilos merged 2 commits into
mainfrom
mobile-fix-console-maccatalyst-2f64009d55531485
Apr 27, 2026
Merged

[mobile] Add MacCatalyst to Console OpenStandardHandle test exclusions#127274
kotlarmilos merged 2 commits into
mainfrom
mobile-fix-console-maccatalyst-2f64009d55531485

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Fixes System.Console.Tests failures on MacCatalyst discovered in runtime-extra-platforms build #1388505.

Failure

Build: #1388505 (2026-04-21)
Job: maccatalyst-arm64 Release AllSubsets_Mono
Helix job: f4caa84e-1526-4c12-a872-6f24ac6f3ba1
Work item: System.Console.Tests
Platform: MacCatalyst arm64 (also affects maccatalyst-x64)

Failed tests

Four tests failed with PlatformNotSupportedException:

  1. OpenStandardInputHandle_ReturnsValidHandle
  2. OpenStandardOutputHandle_ReturnsValidHandle
  3. OpenStandardErrorHandle_ReturnsValidHandle
  4. OpenStandardHandles_DoNotOwnHandle
[FAIL] System.Tests.ConsoleTests.OpenStandardInputHandle_ReturnsValidHandle
System.PlatformNotSupportedException : Operation is not supported on this platform.
at System.ConsolePal.OpenStandardInputHandle()
at System.Console.OpenStandardInputHandle()

Root cause

The Console.OpenStandardXXXHandle() methods throw PlatformNotSupportedException on mobile platforms (iOS, tvOS, Android, MacCatalyst) because these platforms do not expose the underlying file handles for standard streams.

The existing tests already had [PlatformSpecific] attributes excluding iOS, tvOS, and Android, but MacCatalyst was missing from the exclusion list. This is an oversight because MacCatalyst has the same limitation as other Apple mobile platforms.

Fix

Add TestPlatforms.MacCatalyst to the exclusion list (using & ~TestPlatforms.MacCatalyst) on all five tests that attempt to use these APIs, and add it to the inclusion list on the three "ThrowsOnUnsupportedPlatforms" tests that validate the exception is thrown.

This makes the skip coverage consistent across all mobile platforms:

  • Skip on: iOS, tvOS, MacCatalyst, Android, Browser (where applicable)
  • Run on: Windows, Linux, macOS desktop

Testing

After this fix, the four failing tests will be skipped on MacCatalyst in the runtime-extra-platforms pipeline, matching the behavior on iOS, tvOS, and Android.


Note

This PR was created by GitHub Copilot after analyzing mobile platform CI failures in the runtime-extra-platforms pipeline (build 1388505).

Note

🔒 Integrity filter blocked 1 item

The following item were blocked because they don't meet the GitHub integrity level.

  • #126805search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
github:
min-integrity: approved # merged | approved | unapproved | none

Generated by Mobile Platform Failure Scanner · ● 2.2M ·

Fixes System.Console.Tests failures on MacCatalyst discovered in build #1388505.
The tests for Console.OpenStandardInputHandle(), OpenStandardOutputHandle(),
and OpenStandardErrorHandle() were already excluding iOS, tvOS, and Android
(where these APIs throw PlatformNotSupportedException), but were missing
MacCatalyst from the exclusion list.
This caused 4 test failures on maccatalyst-arm64:
- OpenStandardInputHandle_ReturnsValidHandle
- OpenStandardOutputHandle_ReturnsValidHandle
- OpenStandardErrorHandle_ReturnsValidHandle
- OpenStandardHandles_DoNotOwnHandle
The fix adds TestPlatforms.MacCatalyst to the exclusion list on all affected
tests, and adds it to the inclusion list on the corresponding "ThrowsOnUnsupportedPlatforms" tests.
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=1388505
Job: maccatalyst-arm64 Release AllSubsets_Mono
Work item: System.Console.Tests
Helix job: f4caa84e-1526-4c12-a872-6f24ac6f3ba1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

@kotlarmilos
kotlarmilos marked this pull request as ready for review April 22, 2026 11:32
@kotlarmiloskotlarmilos added this to the 11.0.0 milestone Apr 22, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes System.Console.Tests failures on MacCatalyst by aligning the PlatformSpecific test filters with other mobile platforms where Console.OpenStandard*Handle() is not supported.

Changes:

  • Exclude TestPlatforms.MacCatalyst from tests that expect standard handles to be available/usable.
  • Include TestPlatforms.MacCatalyst in tests that validate PlatformNotSupportedException is thrown on unsupported platforms.

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to update the code review skill to require the tests to be annotated when testing APIs that are not available on every platform

@kotlarmilos

Copy link
Copy Markdown
Member

/ba-g wasm job takes longer than the maximum time of 240 minutes

@kotlarmilos
kotlarmilos merged commit 24c5e6f into mainApr 27, 2026
92 of 100 checks passed
@kotlarmilos
kotlarmilos deleted the mobile-fix-console-maccatalyst-2f64009d55531485 branch April 27, 2026 08:54
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 27, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@adamsitnik
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

[mobile] Add MacCatalyst to Console OpenStandardHandle test exclusions - #127274

Merged
kotlarmilos merged 2 commits into
mainfrom
mobile-fix-console-maccatalyst-2f64009d55531485
Apr 27, 2026
Merged

[mobile] Add MacCatalyst to Console OpenStandardHandle test exclusions#127274
kotlarmilos merged 2 commits into
mainfrom
mobile-fix-console-maccatalyst-2f64009d55531485

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Fixes System.Console.Tests failures on MacCatalyst discovered in runtime-extra-platforms build #1388505.

Failure

Build: #1388505 (2026-04-21)
Job: maccatalyst-arm64 Release AllSubsets_Mono
Helix job: f4caa84e-1526-4c12-a872-6f24ac6f3ba1
Work item: System.Console.Tests
Platform: MacCatalyst arm64 (also affects maccatalyst-x64)

Failed tests

Four tests failed with PlatformNotSupportedException:

  1. OpenStandardInputHandle_ReturnsValidHandle
  2. OpenStandardOutputHandle_ReturnsValidHandle
  3. OpenStandardErrorHandle_ReturnsValidHandle
  4. OpenStandardHandles_DoNotOwnHandle
[FAIL] System.Tests.ConsoleTests.OpenStandardInputHandle_ReturnsValidHandle
System.PlatformNotSupportedException : Operation is not supported on this platform.
at System.ConsolePal.OpenStandardInputHandle()
at System.Console.OpenStandardInputHandle()

Root cause

The Console.OpenStandardXXXHandle() methods throw PlatformNotSupportedException on mobile platforms (iOS, tvOS, Android, MacCatalyst) because these platforms do not expose the underlying file handles for standard streams.

The existing tests already had [PlatformSpecific] attributes excluding iOS, tvOS, and Android, but MacCatalyst was missing from the exclusion list. This is an oversight because MacCatalyst has the same limitation as other Apple mobile platforms.

Fix

Add TestPlatforms.MacCatalyst to the exclusion list (using & ~TestPlatforms.MacCatalyst) on all five tests that attempt to use these APIs, and add it to the inclusion list on the three "ThrowsOnUnsupportedPlatforms" tests that validate the exception is thrown.

This makes the skip coverage consistent across all mobile platforms:

  • Skip on: iOS, tvOS, MacCatalyst, Android, Browser (where applicable)
  • Run on: Windows, Linux, macOS desktop

Testing

After this fix, the four failing tests will be skipped on MacCatalyst in the runtime-extra-platforms pipeline, matching the behavior on iOS, tvOS, and Android.


Note

This PR was created by GitHub Copilot after analyzing mobile platform CI failures in the runtime-extra-platforms pipeline (build 1388505).

Note

🔒 Integrity filter blocked 1 item

The following item were blocked because they don't meet the GitHub integrity level.

  • #126805search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
github:
min-integrity: approved # merged | approved | unapproved | none

Generated by Mobile Platform Failure Scanner · ● 2.2M ·

Fixes System.Console.Tests failures on MacCatalyst discovered in build #1388505.
The tests for Console.OpenStandardInputHandle(), OpenStandardOutputHandle(),
and OpenStandardErrorHandle() were already excluding iOS, tvOS, and Android
(where these APIs throw PlatformNotSupportedException), but were missing
MacCatalyst from the exclusion list.
This caused 4 test failures on maccatalyst-arm64:
- OpenStandardInputHandle_ReturnsValidHandle
- OpenStandardOutputHandle_ReturnsValidHandle
- OpenStandardErrorHandle_ReturnsValidHandle
- OpenStandardHandles_DoNotOwnHandle
The fix adds TestPlatforms.MacCatalyst to the exclusion list on all affected
tests, and adds it to the inclusion list on the corresponding "ThrowsOnUnsupportedPlatforms" tests.
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=1388505
Job: maccatalyst-arm64 Release AllSubsets_Mono
Work item: System.Console.Tests
Helix job: f4caa84e-1526-4c12-a872-6f24ac6f3ba1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

@kotlarmilos
kotlarmilos marked this pull request as ready for review April 22, 2026 11:32
@kotlarmiloskotlarmilos added this to the 11.0.0 milestone Apr 22, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes System.Console.Tests failures on MacCatalyst by aligning the PlatformSpecific test filters with other mobile platforms where Console.OpenStandard*Handle() is not supported.

Changes:

  • Exclude TestPlatforms.MacCatalyst from tests that expect standard handles to be available/usable.
  • Include TestPlatforms.MacCatalyst in tests that validate PlatformNotSupportedException is thrown on unsupported platforms.

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to update the code review skill to require the tests to be annotated when testing APIs that are not available on every platform

@kotlarmilos

Copy link
Copy Markdown
Member

/ba-g wasm job takes longer than the maximum time of 240 minutes

@kotlarmilos
kotlarmilos merged commit 24c5e6f into mainApr 27, 2026
92 of 100 checks passed
@kotlarmilos
kotlarmilos deleted the mobile-fix-console-maccatalyst-2f64009d55531485 branch April 27, 2026 08:54
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 27, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@adamsitnik
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[mobile] Add MacCatalyst to Console OpenStandardHandle test exclusions - #127274

Merged
kotlarmilos merged 2 commits into
mainfrom
mobile-fix-console-maccatalyst-2f64009d55531485
Apr 27, 2026
Merged

[mobile] Add MacCatalyst to Console OpenStandardHandle test exclusions#127274
kotlarmilos merged 2 commits into
mainfrom
mobile-fix-console-maccatalyst-2f64009d55531485

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Fixes System.Console.Tests failures on MacCatalyst discovered in runtime-extra-platforms build #1388505.

Failure

Build: #1388505 (2026-04-21)
Job: maccatalyst-arm64 Release AllSubsets_Mono
Helix job: f4caa84e-1526-4c12-a872-6f24ac6f3ba1
Work item: System.Console.Tests
Platform: MacCatalyst arm64 (also affects maccatalyst-x64)

Failed tests

Four tests failed with PlatformNotSupportedException:

  1. OpenStandardInputHandle_ReturnsValidHandle
  2. OpenStandardOutputHandle_ReturnsValidHandle
  3. OpenStandardErrorHandle_ReturnsValidHandle
  4. OpenStandardHandles_DoNotOwnHandle
[FAIL] System.Tests.ConsoleTests.OpenStandardInputHandle_ReturnsValidHandle
System.PlatformNotSupportedException : Operation is not supported on this platform.
at System.ConsolePal.OpenStandardInputHandle()
at System.Console.OpenStandardInputHandle()

Root cause

The Console.OpenStandardXXXHandle() methods throw PlatformNotSupportedException on mobile platforms (iOS, tvOS, Android, MacCatalyst) because these platforms do not expose the underlying file handles for standard streams.

The existing tests already had [PlatformSpecific] attributes excluding iOS, tvOS, and Android, but MacCatalyst was missing from the exclusion list. This is an oversight because MacCatalyst has the same limitation as other Apple mobile platforms.

Fix

Add TestPlatforms.MacCatalyst to the exclusion list (using & ~TestPlatforms.MacCatalyst) on all five tests that attempt to use these APIs, and add it to the inclusion list on the three "ThrowsOnUnsupportedPlatforms" tests that validate the exception is thrown.

This makes the skip coverage consistent across all mobile platforms:

  • Skip on: iOS, tvOS, MacCatalyst, Android, Browser (where applicable)
  • Run on: Windows, Linux, macOS desktop

Testing

After this fix, the four failing tests will be skipped on MacCatalyst in the runtime-extra-platforms pipeline, matching the behavior on iOS, tvOS, and Android.


Note

This PR was created by GitHub Copilot after analyzing mobile platform CI failures in the runtime-extra-platforms pipeline (build 1388505).

Note

🔒 Integrity filter blocked 1 item

The following item were blocked because they don't meet the GitHub integrity level.

  • #126805search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
github:
min-integrity: approved # merged | approved | unapproved | none

Generated by Mobile Platform Failure Scanner · ● 2.2M ·

Fixes System.Console.Tests failures on MacCatalyst discovered in build #1388505.
The tests for Console.OpenStandardInputHandle(), OpenStandardOutputHandle(),
and OpenStandardErrorHandle() were already excluding iOS, tvOS, and Android
(where these APIs throw PlatformNotSupportedException), but were missing
MacCatalyst from the exclusion list.
This caused 4 test failures on maccatalyst-arm64:
- OpenStandardInputHandle_ReturnsValidHandle
- OpenStandardOutputHandle_ReturnsValidHandle
- OpenStandardErrorHandle_ReturnsValidHandle
- OpenStandardHandles_DoNotOwnHandle
The fix adds TestPlatforms.MacCatalyst to the exclusion list on all affected
tests, and adds it to the inclusion list on the corresponding "ThrowsOnUnsupportedPlatforms" tests.
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=1388505
Job: maccatalyst-arm64 Release AllSubsets_Mono
Work item: System.Console.Tests
Helix job: f4caa84e-1526-4c12-a872-6f24ac6f3ba1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

@kotlarmilos
kotlarmilos marked this pull request as ready for review April 22, 2026 11:32
@kotlarmiloskotlarmilos added this to the 11.0.0 milestone Apr 22, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes System.Console.Tests failures on MacCatalyst by aligning the PlatformSpecific test filters with other mobile platforms where Console.OpenStandard*Handle() is not supported.

Changes:

  • Exclude TestPlatforms.MacCatalyst from tests that expect standard handles to be available/usable.
  • Include TestPlatforms.MacCatalyst in tests that validate PlatformNotSupportedException is thrown on unsupported platforms.

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to update the code review skill to require the tests to be annotated when testing APIs that are not available on every platform

@kotlarmilos

Copy link
Copy Markdown
Member

/ba-g wasm job takes longer than the maximum time of 240 minutes

@kotlarmilos
kotlarmilos merged commit 24c5e6f into mainApr 27, 2026
92 of 100 checks passed
@kotlarmilos
kotlarmilos deleted the mobile-fix-console-maccatalyst-2f64009d55531485 branch April 27, 2026 08:54
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 27, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@adamsitnik
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[mobile] Add MacCatalyst to Console OpenStandardHandle test exclusions - #127274

Merged
kotlarmilos merged 2 commits into
mainfrom
mobile-fix-console-maccatalyst-2f64009d55531485
Apr 27, 2026
Merged

[mobile] Add MacCatalyst to Console OpenStandardHandle test exclusions#127274
kotlarmilos merged 2 commits into
mainfrom
mobile-fix-console-maccatalyst-2f64009d55531485

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Fixes System.Console.Tests failures on MacCatalyst discovered in runtime-extra-platforms build #1388505.

Failure

Build: #1388505 (2026-04-21)
Job: maccatalyst-arm64 Release AllSubsets_Mono
Helix job: f4caa84e-1526-4c12-a872-6f24ac6f3ba1
Work item: System.Console.Tests
Platform: MacCatalyst arm64 (also affects maccatalyst-x64)

Failed tests

Four tests failed with PlatformNotSupportedException:

  1. OpenStandardInputHandle_ReturnsValidHandle
  2. OpenStandardOutputHandle_ReturnsValidHandle
  3. OpenStandardErrorHandle_ReturnsValidHandle
  4. OpenStandardHandles_DoNotOwnHandle
[FAIL] System.Tests.ConsoleTests.OpenStandardInputHandle_ReturnsValidHandle
System.PlatformNotSupportedException : Operation is not supported on this platform.
at System.ConsolePal.OpenStandardInputHandle()
at System.Console.OpenStandardInputHandle()

Root cause

The Console.OpenStandardXXXHandle() methods throw PlatformNotSupportedException on mobile platforms (iOS, tvOS, Android, MacCatalyst) because these platforms do not expose the underlying file handles for standard streams.

The existing tests already had [PlatformSpecific] attributes excluding iOS, tvOS, and Android, but MacCatalyst was missing from the exclusion list. This is an oversight because MacCatalyst has the same limitation as other Apple mobile platforms.

Fix

Add TestPlatforms.MacCatalyst to the exclusion list (using & ~TestPlatforms.MacCatalyst) on all five tests that attempt to use these APIs, and add it to the inclusion list on the three "ThrowsOnUnsupportedPlatforms" tests that validate the exception is thrown.

This makes the skip coverage consistent across all mobile platforms:

  • Skip on: iOS, tvOS, MacCatalyst, Android, Browser (where applicable)
  • Run on: Windows, Linux, macOS desktop

Testing

After this fix, the four failing tests will be skipped on MacCatalyst in the runtime-extra-platforms pipeline, matching the behavior on iOS, tvOS, and Android.


Note

This PR was created by GitHub Copilot after analyzing mobile platform CI failures in the runtime-extra-platforms pipeline (build 1388505).

Note

🔒 Integrity filter blocked 1 item

The following item were blocked because they don't meet the GitHub integrity level.

  • #126805search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
github:
min-integrity: approved # merged | approved | unapproved | none

Generated by Mobile Platform Failure Scanner · ● 2.2M ·

Fixes System.Console.Tests failures on MacCatalyst discovered in build #1388505.
The tests for Console.OpenStandardInputHandle(), OpenStandardOutputHandle(),
and OpenStandardErrorHandle() were already excluding iOS, tvOS, and Android
(where these APIs throw PlatformNotSupportedException), but were missing
MacCatalyst from the exclusion list.
This caused 4 test failures on maccatalyst-arm64:
- OpenStandardInputHandle_ReturnsValidHandle
- OpenStandardOutputHandle_ReturnsValidHandle
- OpenStandardErrorHandle_ReturnsValidHandle
- OpenStandardHandles_DoNotOwnHandle
The fix adds TestPlatforms.MacCatalyst to the exclusion list on all affected
tests, and adds it to the inclusion list on the corresponding "ThrowsOnUnsupportedPlatforms" tests.
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=1388505
Job: maccatalyst-arm64 Release AllSubsets_Mono
Work item: System.Console.Tests
Helix job: f4caa84e-1526-4c12-a872-6f24ac6f3ba1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

@kotlarmilos
kotlarmilos marked this pull request as ready for review April 22, 2026 11:32
@kotlarmiloskotlarmilos added this to the 11.0.0 milestone Apr 22, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes System.Console.Tests failures on MacCatalyst by aligning the PlatformSpecific test filters with other mobile platforms where Console.OpenStandard*Handle() is not supported.

Changes:

  • Exclude TestPlatforms.MacCatalyst from tests that expect standard handles to be available/usable.
  • Include TestPlatforms.MacCatalyst in tests that validate PlatformNotSupportedException is thrown on unsupported platforms.

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to update the code review skill to require the tests to be annotated when testing APIs that are not available on every platform

@kotlarmilos

Copy link
Copy Markdown
Member

/ba-g wasm job takes longer than the maximum time of 240 minutes

@kotlarmilos
kotlarmilos merged commit 24c5e6f into mainApr 27, 2026
92 of 100 checks passed
@kotlarmilos
kotlarmilos deleted the mobile-fix-console-maccatalyst-2f64009d55531485 branch April 27, 2026 08:54
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 27, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@adamsitnik
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

[mobile] Add MacCatalyst to Console OpenStandardHandle test exclusions - #127274

Merged
kotlarmilos merged 2 commits into
mainfrom
mobile-fix-console-maccatalyst-2f64009d55531485
Apr 27, 2026
Merged

[mobile] Add MacCatalyst to Console OpenStandardHandle test exclusions#127274
kotlarmilos merged 2 commits into
mainfrom
mobile-fix-console-maccatalyst-2f64009d55531485

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Fixes System.Console.Tests failures on MacCatalyst discovered in runtime-extra-platforms build #1388505.

Failure

Build: #1388505 (2026-04-21)
Job: maccatalyst-arm64 Release AllSubsets_Mono
Helix job: f4caa84e-1526-4c12-a872-6f24ac6f3ba1
Work item: System.Console.Tests
Platform: MacCatalyst arm64 (also affects maccatalyst-x64)

Failed tests

Four tests failed with PlatformNotSupportedException:

  1. OpenStandardInputHandle_ReturnsValidHandle
  2. OpenStandardOutputHandle_ReturnsValidHandle
  3. OpenStandardErrorHandle_ReturnsValidHandle
  4. OpenStandardHandles_DoNotOwnHandle
[FAIL] System.Tests.ConsoleTests.OpenStandardInputHandle_ReturnsValidHandle
System.PlatformNotSupportedException : Operation is not supported on this platform.
at System.ConsolePal.OpenStandardInputHandle()
at System.Console.OpenStandardInputHandle()

Root cause

The Console.OpenStandardXXXHandle() methods throw PlatformNotSupportedException on mobile platforms (iOS, tvOS, Android, MacCatalyst) because these platforms do not expose the underlying file handles for standard streams.

The existing tests already had [PlatformSpecific] attributes excluding iOS, tvOS, and Android, but MacCatalyst was missing from the exclusion list. This is an oversight because MacCatalyst has the same limitation as other Apple mobile platforms.

Fix

Add TestPlatforms.MacCatalyst to the exclusion list (using & ~TestPlatforms.MacCatalyst) on all five tests that attempt to use these APIs, and add it to the inclusion list on the three "ThrowsOnUnsupportedPlatforms" tests that validate the exception is thrown.

This makes the skip coverage consistent across all mobile platforms:

  • Skip on: iOS, tvOS, MacCatalyst, Android, Browser (where applicable)
  • Run on: Windows, Linux, macOS desktop

Testing

After this fix, the four failing tests will be skipped on MacCatalyst in the runtime-extra-platforms pipeline, matching the behavior on iOS, tvOS, and Android.


Note

This PR was created by GitHub Copilot after analyzing mobile platform CI failures in the runtime-extra-platforms pipeline (build 1388505).

Note

🔒 Integrity filter blocked 1 item

The following item were blocked because they don't meet the GitHub integrity level.

  • #126805search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
github:
min-integrity: approved # merged | approved | unapproved | none

Generated by Mobile Platform Failure Scanner · ● 2.2M ·

Fixes System.Console.Tests failures on MacCatalyst discovered in build #1388505.
The tests for Console.OpenStandardInputHandle(), OpenStandardOutputHandle(),
and OpenStandardErrorHandle() were already excluding iOS, tvOS, and Android
(where these APIs throw PlatformNotSupportedException), but were missing
MacCatalyst from the exclusion list.
This caused 4 test failures on maccatalyst-arm64:
- OpenStandardInputHandle_ReturnsValidHandle
- OpenStandardOutputHandle_ReturnsValidHandle
- OpenStandardErrorHandle_ReturnsValidHandle
- OpenStandardHandles_DoNotOwnHandle
The fix adds TestPlatforms.MacCatalyst to the exclusion list on all affected
tests, and adds it to the inclusion list on the corresponding "ThrowsOnUnsupportedPlatforms" tests.
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=1388505
Job: maccatalyst-arm64 Release AllSubsets_Mono
Work item: System.Console.Tests
Helix job: f4caa84e-1526-4c12-a872-6f24ac6f3ba1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

@kotlarmilos
kotlarmilos marked this pull request as ready for review April 22, 2026 11:32
@kotlarmiloskotlarmilos added this to the 11.0.0 milestone Apr 22, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes System.Console.Tests failures on MacCatalyst by aligning the PlatformSpecific test filters with other mobile platforms where Console.OpenStandard*Handle() is not supported.

Changes:

  • Exclude TestPlatforms.MacCatalyst from tests that expect standard handles to be available/usable.
  • Include TestPlatforms.MacCatalyst in tests that validate PlatformNotSupportedException is thrown on unsupported platforms.

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to update the code review skill to require the tests to be annotated when testing APIs that are not available on every platform

@kotlarmilos

Copy link
Copy Markdown
Member

/ba-g wasm job takes longer than the maximum time of 240 minutes

@kotlarmilos
kotlarmilos merged commit 24c5e6f into mainApr 27, 2026
92 of 100 checks passed
@kotlarmilos
kotlarmilos deleted the mobile-fix-console-maccatalyst-2f64009d55531485 branch April 27, 2026 08:54
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 27, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@adamsitnik