Uh oh!
There was an error while loading. Please reload this page.
[clr-ios] Clear stale Apple mobile CoreCLR test exclusions - #128408
Merged
kotlarmilos merged 7 commits intoJun 2, 2026
Conversation
Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg |
…ions
Removes 33 stale [ActiveIssue("...124344...")] decorations across 19
library test files (all sub-issues for interpreter codegen, dynamic-code
reporting, RefEmit/Moq, and virtual delegate dispatch are resolved
upstream). Drops the simulator-only ItemGroup in src/libraries/tests.proj
that excluded 10 test projects on iossimulator/tvossimulator/maccatalyst
CoreCLR under the now-closeddotnet#124044.
Fixesdotnet#127463 by running DCS_DeeplyLinkedData on a 16 MB-stack worker
thread (matching the precedent in System.Threading.Thread tests) so the
513-deep linked chain no longer exhausts the iOS default ~512 KB
main-thread stack; the underlying DataContractSerializer dynamic-method
recursion depth is unchanged.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>kotlarmilosforce-pushed
the
clr-ios/remove-activeissue-124344-bulk
branch
from
May 20, 2026 14:57
15d0d2f to
e2f017eCompareContributor
There was a problem hiding this comment.
Pull request overview
This PR removes Apple-mobile/CoreCLR-specific test suppressions and exclusions that appear to be stale, with the goal of increasing Apple mobile CoreCLR test coverage. It also adjusts a deep-recursion DataContractSerializer test to run on a dedicated thread with an explicitly larger stack to avoid stack overflows on platforms with smaller default stacks.
Changes:
- Remove stale
[ActiveIssue("...124344...")]skips across multiple library test files to re-enable coverage on Apple mobile CoreCLR. - Remove a simulator-only
ProjectExclusionsItemGroupfromsrc/libraries/tests.projthat was previously excluding several test projects for iossimulator/tvossimulator/maccatalyst CoreCLR. - Update
DataContractSerializerTests.DCS_DeeplyLinkedDatato execute on a worker thread with an explicit 16MB stack and rethrow captured exceptions on the calling thread.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/tests.proj | Drops simulator-only Apple-mobile CoreCLR project exclusions tied to a now-stale issue. |
| src/libraries/System.Runtime/tests/System.Text.Encoding.Tests/Encoding/TranscodingStreamTests.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skips from RefEmit/Moq-gated tests. |
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/SingleTests.GenericMath.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skip for native conversion coverage. |
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DoubleTests.GenericMath.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skip for native conversion coverage. |
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skips around dynamic code feature probing. |
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/InvokeWithRefLikeArgs.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skip from RefEmit/Moq-gated reflection test. |
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/ExceptionTests.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skips from stack-trace related tests. |
| src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializer.cs | Runs deep linked serialization test on a larger-stack thread to improve Apple-mobile portability. |
| src/libraries/System.Runtime.Loader/tests/RefEmitLoadContext/RefEmitLoadContextTest.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skip from RefEmit load context test. |
| src/libraries/System.Runtime.Loader/tests/DefaultContext/DefaultLoadContextTest.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skip from default ALC binding test. |
| src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/CustomAttributes/DllImportTests.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skip from pseudo-custom-attribute tests. |
| src/libraries/System.Reflection.Metadata/tests/Metadata/Decoding/CustomAttributeDecoderTests.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skip from reflection-based decoding test. |
| src/libraries/System.Private.Xml/tests/Xslt/XslCompiledTransformApi/XsltApiV2.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skip on a RefEmit-gated XSLT API test base. |
| src/libraries/System.Private.Xml/tests/Xslt/XslCompiledTransformApi/XslCompiledTransform.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skips from XSLT document()/resolver theory cases. |
| src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skip from collectible ALC XmlSerializer test. |
| src/libraries/System.Private.Xml/tests/Readers/CharCheckingReader/CharReaderTests.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skip from XmlTests-driven theory runner. |
| src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skip from a TensorPrimitives span-destination theory. |
| src/libraries/System.Diagnostics.StackTrace/tests/DiagnosticMethodInfoTests.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skip from delegate-based method info theory. |
| src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/FileVersionInfoTest.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skip from managed-assembly version info test. |
| src/libraries/Microsoft.Extensions.DependencyModel/tests/CompositeResolverTests.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skips from Moq/RefEmit-gated resolver tests. |
| src/libraries/Microsoft.Extensions.DependencyModel/tests/CompilationLibraryTests.cs | Removes stale Apple-mobile/CoreCLR [ActiveIssue] skip from Moq/RefEmit-gated resolver test. |
Copilot's findings
- Files reviewed: 21/21 changed files
- Comments generated: 1
Uh oh!
There was an error while loading. Please reload this page.
BrzVlad
reviewed
May 20, 2026
Uh oh!
There was an error while loading. Please reload this page.
… DCS_DeeplyLinkedData join CI on PR dotnet#128408 (build 1428339) failed on ios-arm64 and maccatalyst-arm64 because ExceptionTests.ThrowStatementDoesNotResetExceptionStackLineSameMethod still fails on Apple-mobile CoreCLR (the underlying dotnet#124344 stack-line tracking bug is unfixed). BrzVlad also flagged that ConvertToIntegerNativeTest on Double/Single is still broken on Apple-mobile x64 CoreCLR simulators. - Restore [ActiveIssue(dotnet#124344, IsAppleMobile, IsCoreCLR)] on ThrowStatementDoesNotResetExceptionStackLineSameMethod - Restore [ActiveIssue(dotnet#124344, IsAppleMobile, IsX64Process, IsCoreCLR)] on ThrowStatementDoesNotResetExceptionStackLineOtherMethod - Restore [ActiveIssue(dotnet#124344, IsAppleMobile, IsX64Process, IsCoreCLR)] on Double/Single GenericMath.ConvertToIntegerNativeTest - DCS_DeeplyLinkedData: mark worker thread as background and use a bounded Thread.Join(TimeSpan.FromMinutes(2)) so a runtime-side deadlock in the serializer cannot hang the entire Helix work item indefinitely (addresses Copilot review comment). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kotlarmilos
commented
May 21, 2026
MemberAuthor
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced May 21, 2026
Open
Open
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced May 29, 2026
BrzVlad
reviewed
Jun 2, 2026
Uh oh!
There was an error while loading. Please reload this page.
BrzVlad
approved these changes
Jun 2, 2026
kotlarmilos
enabled auto-merge (squash)
June 2, 2026 09:05
Uh oh!
There was an error while loading. Please reload this page.
tannergooding pushed a commit
that referenced
this pull request
Jun 22, 2026
…n ARM64 iOS simulator (refs #129045) (#129652) Workflow artifact: ci-fix Artifact kind: help Linked KBE: #129045 > [!NOTE] > This is an AI/Copilot-generated draft PR that attempts to fix the CI failure described in KBE #129045. It has NOT been build-validated (environment lacks .NET 11 SDK). Human review is needed. ## Root cause The vectorized `TensorPrimitives.Tan` on ARM64 produces values that diverge by ~47 ULPs from scalar `T.Tan` on iossimulator-arm64 CoreCLR. The test's `trigTolerance` is set to `null` (meaning default ~1 ULP) when `IsFmaSupported` is true (because `AdvSimd.Arm64.IsSupported` is true on Apple Silicon). However, the vectorized trig algorithm doesn't achieve bit-for-bit matching with the scalar math library on ARM64, even though FMA hardware is available. Failing log line: ``` Assert.All() Failure: 153 out of 201 items in the collection did not pass. Expected: 0.4103213 Actual: 0.4103199 ``` ## Fix Instead of using `null` tolerance when FMA is supported, apply an explicit small tolerance: - Float: `1e-5f` (allows ~333 ULPs — comfortably above the observed ~47 ULP divergence) - Double: `1e-14` (proportionally generous for double precision) This is consistent with how `CosPi` already applies `1e-5f` tolerance in the FMA case via its null-coalescing fallback pattern. Additionally, this removes the `[ActiveIssue("#124344")]` annotation on `SpanDestinationFunctions_ValueRange` that blanket-disabled the test on Apple Mobile CoreCLR, since the tolerance fix addresses the underlying precision issue rather than masking the failure. ## What is unverified / help needed - **Build not validated**: Environment has .NET 8/9 SDKs; the project targets .NET 11 preview. Could not run `dotnet build` or tests. - **Double tolerance**: The KBE doesn't show the actual value for the Double failure, so the `1e-14` tolerance is an estimate. Needs confirmation on-device. - **Other trig functions**: Asin, Cos, Sin also use `trigTolerance`. If they also diverge on ARM64, this fix covers them. If they DON'T currently diverge, this change is still safe (tolerance only relaxes the check). - **Removing ActiveIssue**: PR #129226 added it for Tan divergence. If there are OTHER undiscovered failures in `SpanDestinationFunctions_ValueRange` on Apple mobile unrelated to trig tolerance, removing the annotation could re-expose them. ## Suggested reviewers / area contacts - `@tannergooding` (area-System.Numerics.Tensors owner) - Possible related PR: #128408 (cleared stale Apple mobile test exclusions, causing this test to start running on iOS simulator) ## Validation - Command: `dotnet build src/libraries/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj` - Result: not run because environment lacks .NET 11 SDK ## Evidence - Failing build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1449088 - First build it occurred: 2026-06-04T09:47:08Z (computed within the scanned window; may not be the true origin) - Suspected regressing change: #128408 (removed test exclusions, enabling this test on iossimulator-arm64) --- Filed by [`ci-failure-fix`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-fix.md), which attempts validated fixes for `[ci-scan]` Known Build Errors and otherwise loops in owners. Comment here or on the workflow file to suggest changes; [`ci-failure-scan-feedback`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-scan-feedback.md) reads in-scope feedback daily and opens (or updates) a PR with prompt edits. > [!NOTE] > <details> > <summary>🔒 Integrity filter blocked 2 items</summary> > > The following items were blocked because they don't meet the GitHub integrity level. > > - #128450 `issue_read`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - #128451 `issue_read`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > > To allow these resources, lower `min-integrity` in your GitHub frontmatter: > > ```yaml > tools: > github: > min-integrity: approved # merged | approved | unapproved | none > ``` > > </details> > Generated by [CI Outer-Loop Failure Fixer](https://github.com/dotnet/runtime/actions/runs/27872474682/agentic_workflow) · ● 60.4M · [◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+ci-failure-fix%22&type=pullrequests) <!-- gh-aw-agentic-workflow: CI Outer-Loop Failure Fixer, engine: copilot, version: 1.0.40, model: claude-opus-4.6, id: 27872474682, workflow_id: ci-failure-fix, run: https://github.com/dotnet/runtime/actions/runs/27872474682 --> <!-- gh-aw-workflow-id: ci-failure-fix --> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduces the Apple-mobile CoreCLR test exclusions tracked under #124344, based on
runtime-extra-platforms(build 1429699):Projects that now run on iossim / tvossim / maccatalyst CoreCLR:
System.Reflection.InvokeEmit.TestsSystem.Reflection.InvokeInterpreted.TestsSystem.Memory.TestsPer-test
[ActiveIssue]decorations removed:DiagnosticMethodInfoTests,CharReaderTests,XmlSerializerTests,XslCompiledTransform,XsltApiV2,InvokeWithRefLikeArgsWorkaround landed:
DCS_DeeplyLinkedDatanow runs on a 16 MB-stack worker thread, so the 513-deep linked chain no longer exhausts the iOS default ~512 KB main-thread stack. The underlyingDataContractSerializerdynamic-method recursion depth is unchanged.Contributes to #124344
Fixes#127463