[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mobile test suites - #129226

Merged
kotlarmilos merged 5 commits into
dotnet:mainfrom
kotlarmilos:clr-ios-disable-failing-tests
Jun 15, 2026
Merged

[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mobile test suites#129226
kotlarmilos merged 5 commits into
dotnet:mainfrom
kotlarmilos:clr-ios-disable-failing-tests

Conversation

@kotlarmilos

@kotlarmiloskotlarmilos commented Jun 10, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Description

Disables three Apple CoreCLR mobile test failures against #124344 and fixes one via the trimmer descriptor:

  • InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE is disabled because Moq's RefEmit codegen breaks on iOS CoreCLR.
  • TensorPrimitives.SpanDestinationFunctions_ValueRange is disabled because Tan diverges by a few ULPs under FMA on arm64.
  • AssemblyTests.AssemblyGetForwardedTypesLoadFailure is disabled because GetForwardedTypes() does not resolve the forwarded System.Object/BadImageFormatException entries on trimmed Apple CoreCLR app bundles, even after rooting System.Runtime.
  • AssemblyTests.AssemblyLoadWithPublicKey is fixed by rooting the typeless System.Runtime facade in the trimmer descriptor so it is not dropped from the app bundle.

@kotlarmilos
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mob…
b5077aa
…ile test suites
Disable InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE and
TensorPrimitives SpanDestinationFunctions_ValueRange on Apple mobile CoreCLR
against dotnet#124344, and root the typeless System.Runtime facade in the trimmer
descriptor so AssemblyLoadWithPublicKey and AssemblyGetForwardedTypesLoadFailure
no longer fail to load it from the trimmed app bundle.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 10, 2026 10:06
CopilotAI reviewed Jun 10, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates several library test suites to improve reliability of Apple mobile CoreCLR test runs by conditionally disabling known failing tests and by ensuring trimming doesn’t remove a required facade assembly used by reflection tests.

Changes:

  • Add [ActiveIssue(...)] gating to skip a Moq/RefEmit-based reflection test on AppleMobile + CoreCLR.
  • Add [ActiveIssue(...)] gating to skip TensorPrimitives value-range coverage on AppleMobile + CoreCLR.
  • Update ILLink trimming descriptors to root the System.Runtime facade assembly so it isn’t trimmed away in the System.Reflection.Tests app.
Show a summary per file
FileDescription
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/InvokeWithRefLikeArgs.csAdds an AppleMobile+CoreCLR ActiveIssue skip for a Moq/RefEmit test.
src/libraries/System.Runtime/tests/System.Reflection.Tests/ILLink.Descriptors.xmlRoots System.Runtime in the linker descriptor to prevent it being trimmed from the test bundle.
src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.csAdds an AppleMobile+CoreCLR ActiveIssue skip for SpanDestinationFunctions_ValueRange.

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 1

Comment threadsrc/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs
@kotlarmiloskotlarmilos self-assigned this Jun 10, 2026
@kotlarmiloskotlarmilos added this to the 11.0.0 milestone Jun 10, 2026
kotlarmilosand others added 2 commits June 10, 2026 13:09
@kotlarmilos
Narrow Tan suppression to omit only the Tan case on Apple mobile CoreCLR
fdaf9e6
Address review feedback: instead of [ActiveIssue] on the whole
SpanDestinationFunctions_ValueRange theory, omit only the Tan case from the
shared data provider on Apple mobile CoreCLR, preserving ValueRange coverage
for the other operations.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kotlarmilos
Revert to method-level [ActiveIssue] for SpanDestinationFunctions_Val…
33b127f
…ueRange
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 10, 2026 11:11
CopilotAI reviewed Jun 10, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 1

Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/ILLink.Descriptors.xml
@kotlarmilos

kotlarmilos commented Jun 10, 2026

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jun 10, 2026

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 10, 2026
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Closed
Closed
Open
@kotlarmilos

kotlarmilos commented Jun 11, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jun 11, 2026

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@kotlarmilos

kotlarmilos commented Jun 11, 2026

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jun 11, 2026

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 11, 2026
Open
Open
@azure-pipelines

azure-pipelinesBot commented Jun 12, 2026

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

CopilotAI review requested due to automatic review settings June 12, 2026 07:18
CopilotAI reviewed Jun 12, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 4/4 changed files
  • Comments generated: 0 new

@build-analysisbuild-analysisBot mentioned this pull request Jun 12, 2026
Closed
@kotlarmilos
kotlarmilos merged commit 39ace2d into dotnet:mainJun 15, 2026
93 of 95 checks passed
@dotnet-maestrodotnet-maestroBot mentioned this pull request Jun 16, 2026
Merged
@github-actionsgithub-actionsBot mentioned this pull request Jun 17, 2026
Closed
This was referenced Jun 18, 2026
Closed
Merged
tannergooding pushed a commit that referenced this pull request Jun 22, 2026
@github-actions
[ci-fix] Needs review: Fix TensorPrimitives Tan precision tolerance o…
4a8dffc
…n ARM64 iOS simulator (refs #129045) (#129652)
Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #129045
> [!NOTE]
> This is an AI/Copilot-generated draft PR that attempts to fix the CI
failure described in KBE #129045. It has NOT been build-validated
(environment lacks .NET 11 SDK). Human review is needed.
## Root cause
The vectorized `TensorPrimitives.Tan` on ARM64 produces values that
diverge by ~47 ULPs from scalar `T.Tan` on iossimulator-arm64 CoreCLR.
The test's `trigTolerance` is set to `null` (meaning default ~1 ULP)
when `IsFmaSupported` is true (because `AdvSimd.Arm64.IsSupported` is
true on Apple Silicon). However, the vectorized trig algorithm doesn't
achieve bit-for-bit matching with the scalar math library on ARM64, even
though FMA hardware is available.
Failing log line:
```
Assert.All() Failure: 153 out of 201 items in the collection did not pass.
Expected: 0.4103213
Actual: 0.4103199
```
## Fix
Instead of using `null` tolerance when FMA is supported, apply an
explicit small tolerance:
- Float: `1e-5f` (allows ~333 ULPs — comfortably above the observed ~47
ULP divergence)
- Double: `1e-14` (proportionally generous for double precision)
This is consistent with how `CosPi` already applies `1e-5f` tolerance in
the FMA case via its null-coalescing fallback pattern.
Additionally, this removes the `[ActiveIssue("#124344")]` annotation on
`SpanDestinationFunctions_ValueRange` that blanket-disabled the test on
Apple Mobile CoreCLR, since the tolerance fix addresses the underlying
precision issue rather than masking the failure.
## What is unverified / help needed
- **Build not validated**: Environment has .NET 8/9 SDKs; the project
targets .NET 11 preview. Could not run `dotnet build` or tests.
- **Double tolerance**: The KBE doesn't show the actual value for the
Double failure, so the `1e-14` tolerance is an estimate. Needs
confirmation on-device.
- **Other trig functions**: Asin, Cos, Sin also use `trigTolerance`. If
they also diverge on ARM64, this fix covers them. If they DON'T
currently diverge, this change is still safe (tolerance only relaxes the
check).
- **Removing ActiveIssue**: PR #129226 added it for Tan divergence. If
there are OTHER undiscovered failures in
`SpanDestinationFunctions_ValueRange` on Apple mobile unrelated to trig
tolerance, removing the annotation could re-expose them.
## Suggested reviewers / area contacts
- `@tannergooding` (area-System.Numerics.Tensors owner)
- Possible related PR: #128408 (cleared stale Apple mobile
test exclusions, causing this test to start running on iOS simulator)
## Validation
- Command: `dotnet build
src/libraries/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj`
- Result: not run because environment lacks .NET 11 SDK
## Evidence
- Failing build:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1449088
- First build it occurred: 2026-06-04T09:47:08Z (computed within the
scanned window; may not be the true origin)
- Suspected regressing change: #128408 (removed test
exclusions, enabling this test on iossimulator-arm64)
---
Filed by
[`ci-failure-fix`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-fix.md),
which attempts validated fixes for `[ci-scan]` Known Build Errors and
otherwise loops in owners. Comment here or on the workflow file to
suggest changes;
[`ci-failure-scan-feedback`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-scan-feedback.md)
reads in-scope feedback daily and opens (or updates) a PR with prompt
edits.
> [!NOTE]
> <details>
> <summary>🔒 Integrity filter blocked 2 items</summary>
>
> The following items were blocked because they don't meet the GitHub
integrity level.
>
> - #128450 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
> - #128451 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
>
> To allow these resources, lower `min-integrity` in your GitHub
frontmatter:
>
> ```yaml
> tools:
> github:
> min-integrity: approved # merged | approved | unapproved | none
> ```
>
> </details>
> Generated by [CI Outer-Loop Failure
Fixer](https://github.com/dotnet/runtime/actions/runs/27872474682/agentic_workflow)
· ● 60.4M ·
[◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+ci-failure-fix%22&type=pullrequests)
<!-- gh-aw-agentic-workflow: CI Outer-Loop Failure Fixer, engine:
copilot, version: 1.0.40, model: claude-opus-4.6, id: 27872474682,
workflow_id: ci-failure-fix, run:
https://github.com/dotnet/runtime/actions/runs/27872474682 -->
<!-- gh-aw-workflow-id: ci-failure-fix -->
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
CopilotAI mentioned this pull request Jun 30, 2026
Merged
eiriktsarpalis pushed a commit that referenced this pull request Jul 15, 2026
@kotlarmilos@eiriktsarpalis
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mob…
1d6a259
…ile test suites (#129226)
## Description
Disables three Apple CoreCLR mobile test failures against #124344 and
fixes one via the trimmer descriptor:
- `InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE` is
disabled because Moq's RefEmit codegen breaks on iOS CoreCLR.
- `TensorPrimitives.SpanDestinationFunctions_ValueRange` is disabled
because `Tan` diverges by a few ULPs under FMA on arm64.
- `AssemblyTests.AssemblyGetForwardedTypesLoadFailure` is disabled
because `GetForwardedTypes()` does not resolve the forwarded
`System.Object`/`BadImageFormatException` entries on trimmed Apple
CoreCLR app bundles, even after rooting `System.Runtime`.
- `AssemblyTests.AssemblyLoadWithPublicKey` is fixed by rooting the
typeless `System.Runtime` facade in the trimmer descriptor so it is not
dropped from the app bundle.
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
eiriktsarpalis pushed a commit that referenced this pull request Jul 15, 2026
@github-actions@eiriktsarpalis
[ci-fix] Needs review: Fix TensorPrimitives Tan precision tolerance o…
095b0cb
…n ARM64 iOS simulator (refs #129045) (#129652)
Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #129045
> [!NOTE]
> This is an AI/Copilot-generated draft PR that attempts to fix the CI
failure described in KBE #129045. It has NOT been build-validated
(environment lacks .NET 11 SDK). Human review is needed.
## Root cause
The vectorized `TensorPrimitives.Tan` on ARM64 produces values that
diverge by ~47 ULPs from scalar `T.Tan` on iossimulator-arm64 CoreCLR.
The test's `trigTolerance` is set to `null` (meaning default ~1 ULP)
when `IsFmaSupported` is true (because `AdvSimd.Arm64.IsSupported` is
true on Apple Silicon). However, the vectorized trig algorithm doesn't
achieve bit-for-bit matching with the scalar math library on ARM64, even
though FMA hardware is available.
Failing log line:
```
Assert.All() Failure: 153 out of 201 items in the collection did not pass.
Expected: 0.4103213
Actual: 0.4103199
```
## Fix
Instead of using `null` tolerance when FMA is supported, apply an
explicit small tolerance:
- Float: `1e-5f` (allows ~333 ULPs — comfortably above the observed ~47
ULP divergence)
- Double: `1e-14` (proportionally generous for double precision)
This is consistent with how `CosPi` already applies `1e-5f` tolerance in
the FMA case via its null-coalescing fallback pattern.
Additionally, this removes the `[ActiveIssue("#124344")]` annotation on
`SpanDestinationFunctions_ValueRange` that blanket-disabled the test on
Apple Mobile CoreCLR, since the tolerance fix addresses the underlying
precision issue rather than masking the failure.
## What is unverified / help needed
- **Build not validated**: Environment has .NET 8/9 SDKs; the project
targets .NET 11 preview. Could not run `dotnet build` or tests.
- **Double tolerance**: The KBE doesn't show the actual value for the
Double failure, so the `1e-14` tolerance is an estimate. Needs
confirmation on-device.
- **Other trig functions**: Asin, Cos, Sin also use `trigTolerance`. If
they also diverge on ARM64, this fix covers them. If they DON'T
currently diverge, this change is still safe (tolerance only relaxes the
check).
- **Removing ActiveIssue**: PR #129226 added it for Tan divergence. If
there are OTHER undiscovered failures in
`SpanDestinationFunctions_ValueRange` on Apple mobile unrelated to trig
tolerance, removing the annotation could re-expose them.
## Suggested reviewers / area contacts
- `@tannergooding` (area-System.Numerics.Tensors owner)
- Possible related PR: #128408 (cleared stale Apple mobile
test exclusions, causing this test to start running on iOS simulator)
## Validation
- Command: `dotnet build
src/libraries/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj`
- Result: not run because environment lacks .NET 11 SDK
## Evidence
- Failing build:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1449088
- First build it occurred: 2026-06-04T09:47:08Z (computed within the
scanned window; may not be the true origin)
- Suspected regressing change: #128408 (removed test
exclusions, enabling this test on iossimulator-arm64)
---
Filed by
[`ci-failure-fix`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-fix.md),
which attempts validated fixes for `[ci-scan]` Known Build Errors and
otherwise loops in owners. Comment here or on the workflow file to
suggest changes;
[`ci-failure-scan-feedback`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-scan-feedback.md)
reads in-scope feedback daily and opens (or updates) a PR with prompt
edits.
> [!NOTE]
> <details>
> <summary>🔒 Integrity filter blocked 2 items</summary>
>
> The following items were blocked because they don't meet the GitHub
integrity level.
>
> - #128450 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
> - #128451 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
>
> To allow these resources, lower `min-integrity` in your GitHub
frontmatter:
>
> ```yaml
> tools:
> github:
> min-integrity: approved # merged | approved | unapproved | none
> ```
>
> </details>
> Generated by [CI Outer-Loop Failure
Fixer](https://github.com/dotnet/runtime/actions/runs/27872474682/agentic_workflow)
· ● 60.4M ·
[◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+ci-failure-fix%22&type=pullrequests)
<!-- gh-aw-agentic-workflow: CI Outer-Loop Failure Fixer, engine:
copilot, version: 1.0.40, model: claude-opus-4.6, id: 27872474682,
workflow_id: ci-failure-fix, run:
https://github.com/dotnet/runtime/actions/runs/27872474682 -->
<!-- gh-aw-workflow-id: ci-failure-fix -->
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 18, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@BrzVladBrzVladBrzVlad approved these changes
@vitek-karasvitek-karasAwaiting requested review from vitek-karas
@matouskozakmatouskozakAwaiting requested review from matouskozak

Assignees

@kotlarmiloskotlarmilos

Labels

area-Infrastructurelinkable-frameworkIssues associated with delivering a linker friendly frameworkos-iosApple iOS

Projects

Runtime Infra
Status: Done

Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@BrzVlad
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mobile test suites - #129226
Merged
kotlarmilos merged 5 commits into
dotnet:mainfrom 
kotlarmilos:clr-ios-disable-failing-tests
Jun 15, 2026
Merged
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mobile test suites#129226
kotlarmilos merged 5 commits into
dotnet:mainfrom 
kotlarmilos:clr-ios-disable-failing-tests
Conversation
@kotlarmilos
@kotlarmiloskotlarmilos
commented
Jun 10, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
Disables three Apple CoreCLR mobile test failures against #124344 and fixes one via the trimmer descriptor:
  • InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE is disabled because Moq's RefEmit codegen breaks on iOS CoreCLR.
  • TensorPrimitives.SpanDestinationFunctions_ValueRange is disabled because Tan diverges by a few ULPs under FMA on arm64.
  • AssemblyTests.AssemblyGetForwardedTypesLoadFailure is disabled because GetForwardedTypes() does not resolve the forwarded System.Object/BadImageFormatException entries on trimmed Apple CoreCLR app bundles, even after rooting System.Runtime.
  • AssemblyTests.AssemblyLoadWithPublicKey is fixed by rooting the typeless System.Runtime facade in the trimmer descriptor so it is not dropped from the app bundle.
@kotlarmilos
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mob…
b5077aa
…ile test suites
Disable InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE and
TensorPrimitives SpanDestinationFunctions_ValueRange on Apple mobile CoreCLR
against dotnet#124344, and root the typeless System.Runtime facade in the trimmer
descriptor so AssemblyLoadWithPublicKey and AssemblyGetForwardedTypesLoadFailure
no longer fail to load it from the trimmed app bundle.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 10, 2026 10:06
CopilotAI
reviewed
Jun 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates several library test suites to improve reliability of Apple mobile CoreCLR test runs by conditionally disabling known failing tests and by ensuring trimming doesn’t remove a required facade assembly used by reflection tests.
Changes:
  • Add [ActiveIssue(...)] gating to skip a Moq/RefEmit-based reflection test on AppleMobile + CoreCLR.
  • Add [ActiveIssue(...)] gating to skip TensorPrimitives value-range coverage on AppleMobile + CoreCLR.
  • Update ILLink trimming descriptors to root the System.Runtime facade assembly so it isn’t trimmed away in the System.Reflection.Tests app.
Show a summary per file
FileDescription
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/InvokeWithRefLikeArgs.csAdds an AppleMobile+CoreCLR ActiveIssue skip for a Moq/RefEmit test.
src/libraries/System.Runtime/tests/System.Reflection.Tests/ILLink.Descriptors.xmlRoots System.Runtime in the linker descriptor to prevent it being trimmed from the test bundle.
src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.csAdds an AppleMobile+CoreCLR ActiveIssue skip for SpanDestinationFunctions_ValueRange.
Copilot's findings
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
Comment threadsrc/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs
@kotlarmiloskotlarmilos
self-assigned this
Jun 10, 2026
@kotlarmiloskotlarmilos
added this to the 11.0.0 milestone
Jun 10, 2026
kotlarmilosand others
added 2 commits
June 10, 2026 13:09
@kotlarmilos
Narrow Tan suppression to omit only the Tan case on Apple mobile CoreCLR
fdaf9e6
Address review feedback: instead of [ActiveIssue] on the whole
SpanDestinationFunctions_ValueRange theory, omit only the Tan case from the
shared data provider on Apple mobile CoreCLR, preserving ValueRange coverage
for the other operations.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kotlarmilos
Revert to method-level [ActiveIssue] for SpanDestinationFunctions_Val…
33b127f
…ueRange
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 10, 2026 11:11
CopilotAI
reviewed
Jun 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/ILLink.Descriptors.xml
@kotlarmilos
kotlarmilos
commented
Jun 10, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 10, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 10, 2026

Open


Closed


Open


Open


Open


Open


Open


Open


Open


Closed


Closed


Open

@kotlarmilos
kotlarmilos
commented
Jun 11, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 11, 2026

Copy link


Copy Markdown


No pipelines are associated with this pull request.
@kotlarmilos
kotlarmilos
commented
Jun 11, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 11, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 11, 2026

Open


Open

@azure-pipelines
azure-pipelinesBot
commented
Jun 12, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
CopilotAI
review requested due to automatic review settings
June 12, 2026 07:18
CopilotAI
reviewed
Jun 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 4/4 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2026

Closed

@kotlarmilos
kotlarmilos
merged commit 39ace2d
into
dotnet:mainJun 15, 2026

93 of 95 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 16, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Jun 17, 2026

Closed


This was referenced Jun 18, 2026

Closed

 Merged

tannergooding pushed a commit
that referenced
this pull request
Jun 22, 2026
@github-actions
[ci-fix] Needs review: Fix TensorPrimitives Tan precision tolerance o…
4a8dffc
…n ARM64 iOS simulator (refs #129045) (#129652)
Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #129045
> [!NOTE]
> This is an AI/Copilot-generated draft PR that attempts to fix the CI
failure described in KBE #129045. It has NOT been build-validated
(environment lacks .NET 11 SDK). Human review is needed.
## Root cause
The vectorized `TensorPrimitives.Tan` on ARM64 produces values that
diverge by ~47 ULPs from scalar `T.Tan` on iossimulator-arm64 CoreCLR.
The test's `trigTolerance` is set to `null` (meaning default ~1 ULP)
when `IsFmaSupported` is true (because `AdvSimd.Arm64.IsSupported` is
true on Apple Silicon). However, the vectorized trig algorithm doesn't
achieve bit-for-bit matching with the scalar math library on ARM64, even
though FMA hardware is available.
Failing log line:
```
Assert.All() Failure: 153 out of 201 items in the collection did not pass.
Expected: 0.4103213
Actual: 0.4103199
```
## Fix
Instead of using `null` tolerance when FMA is supported, apply an
explicit small tolerance:
- Float: `1e-5f` (allows ~333 ULPs — comfortably above the observed ~47
ULP divergence)
- Double: `1e-14` (proportionally generous for double precision)
This is consistent with how `CosPi` already applies `1e-5f` tolerance in
the FMA case via its null-coalescing fallback pattern.
Additionally, this removes the `[ActiveIssue("#124344")]` annotation on
`SpanDestinationFunctions_ValueRange` that blanket-disabled the test on
Apple Mobile CoreCLR, since the tolerance fix addresses the underlying
precision issue rather than masking the failure.
## What is unverified / help needed
- **Build not validated**: Environment has .NET 8/9 SDKs; the project
targets .NET 11 preview. Could not run `dotnet build` or tests.
- **Double tolerance**: The KBE doesn't show the actual value for the
Double failure, so the `1e-14` tolerance is an estimate. Needs
confirmation on-device.
- **Other trig functions**: Asin, Cos, Sin also use `trigTolerance`. If
they also diverge on ARM64, this fix covers them. If they DON'T
currently diverge, this change is still safe (tolerance only relaxes the
check).
- **Removing ActiveIssue**: PR #129226 added it for Tan divergence. If
there are OTHER undiscovered failures in
`SpanDestinationFunctions_ValueRange` on Apple mobile unrelated to trig
tolerance, removing the annotation could re-expose them.
## Suggested reviewers / area contacts
- `@tannergooding` (area-System.Numerics.Tensors owner)
- Possible related PR: #128408 (cleared stale Apple mobile
test exclusions, causing this test to start running on iOS simulator)
## Validation
- Command: `dotnet build
src/libraries/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj`
- Result: not run because environment lacks .NET 11 SDK
## Evidence
- Failing build:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1449088
- First build it occurred: 2026-06-04T09:47:08Z (computed within the
scanned window; may not be the true origin)
- Suspected regressing change: #128408 (removed test
exclusions, enabling this test on iossimulator-arm64)
---
Filed by
[`ci-failure-fix`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-fix.md),
which attempts validated fixes for `[ci-scan]` Known Build Errors and
otherwise loops in owners. Comment here or on the workflow file to
suggest changes;
[`ci-failure-scan-feedback`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-scan-feedback.md)
reads in-scope feedback daily and opens (or updates) a PR with prompt
edits.
> [!NOTE]
> <details>
> <summary>🔒 Integrity filter blocked 2 items</summary>
>
> The following items were blocked because they don't meet the GitHub
integrity level.
>
> - #128450 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
> - #128451 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
>
> To allow these resources, lower `min-integrity` in your GitHub
frontmatter:
>
> ```yaml
> tools:
> github:
> min-integrity: approved # merged | approved | unapproved | none
> ```
>
> </details>
> Generated by [CI Outer-Loop Failure
Fixer](https://github.com/dotnet/runtime/actions/runs/27872474682/agentic_workflow)
· ● 60.4M ·
[◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+ci-failure-fix%22&type=pullrequests)
<!-- gh-aw-agentic-workflow: CI Outer-Loop Failure Fixer, engine:
copilot, version: 1.0.40, model: claude-opus-4.6, id: 27872474682,
workflow_id: ci-failure-fix, run:
https://github.com/dotnet/runtime/actions/runs/27872474682 -->
<!-- gh-aw-workflow-id: ci-failure-fix -->
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
CopilotAI
mentioned this pull request
Jun 30, 2026
 Merged

eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@kotlarmilos@eiriktsarpalis
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mob…
1d6a259
…ile test suites (#129226)
## Description
Disables three Apple CoreCLR mobile test failures against #124344 and
fixes one via the trimmer descriptor:
- `InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE` is
disabled because Moq's RefEmit codegen breaks on iOS CoreCLR.
- `TensorPrimitives.SpanDestinationFunctions_ValueRange` is disabled
because `Tan` diverges by a few ULPs under FMA on arm64.
- `AssemblyTests.AssemblyGetForwardedTypesLoadFailure` is disabled
because `GetForwardedTypes()` does not resolve the forwarded
`System.Object`/`BadImageFormatException` entries on trimmed Apple
CoreCLR app bundles, even after rooting `System.Runtime`.
- `AssemblyTests.AssemblyLoadWithPublicKey` is fixed by rooting the
typeless `System.Runtime` facade in the trimmer descriptor so it is not
dropped from the app bundle.
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@github-actions@eiriktsarpalis
[ci-fix] Needs review: Fix TensorPrimitives Tan precision tolerance o…
095b0cb
…n ARM64 iOS simulator (refs #129045) (#129652)
Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #129045
> [!NOTE]
> This is an AI/Copilot-generated draft PR that attempts to fix the CI
failure described in KBE #129045. It has NOT been build-validated
(environment lacks .NET 11 SDK). Human review is needed.
## Root cause
The vectorized `TensorPrimitives.Tan` on ARM64 produces values that
diverge by ~47 ULPs from scalar `T.Tan` on iossimulator-arm64 CoreCLR.
The test's `trigTolerance` is set to `null` (meaning default ~1 ULP)
when `IsFmaSupported` is true (because `AdvSimd.Arm64.IsSupported` is
true on Apple Silicon). However, the vectorized trig algorithm doesn't
achieve bit-for-bit matching with the scalar math library on ARM64, even
though FMA hardware is available.
Failing log line:
```
Assert.All() Failure: 153 out of 201 items in the collection did not pass.
Expected: 0.4103213
Actual: 0.4103199
```
## Fix
Instead of using `null` tolerance when FMA is supported, apply an
explicit small tolerance:
- Float: `1e-5f` (allows ~333 ULPs — comfortably above the observed ~47
ULP divergence)
- Double: `1e-14` (proportionally generous for double precision)
This is consistent with how `CosPi` already applies `1e-5f` tolerance in
the FMA case via its null-coalescing fallback pattern.
Additionally, this removes the `[ActiveIssue("#124344")]` annotation on
`SpanDestinationFunctions_ValueRange` that blanket-disabled the test on
Apple Mobile CoreCLR, since the tolerance fix addresses the underlying
precision issue rather than masking the failure.
## What is unverified / help needed
- **Build not validated**: Environment has .NET 8/9 SDKs; the project
targets .NET 11 preview. Could not run `dotnet build` or tests.
- **Double tolerance**: The KBE doesn't show the actual value for the
Double failure, so the `1e-14` tolerance is an estimate. Needs
confirmation on-device.
- **Other trig functions**: Asin, Cos, Sin also use `trigTolerance`. If
they also diverge on ARM64, this fix covers them. If they DON'T
currently diverge, this change is still safe (tolerance only relaxes the
check).
- **Removing ActiveIssue**: PR #129226 added it for Tan divergence. If
there are OTHER undiscovered failures in
`SpanDestinationFunctions_ValueRange` on Apple mobile unrelated to trig
tolerance, removing the annotation could re-expose them.
## Suggested reviewers / area contacts
- `@tannergooding` (area-System.Numerics.Tensors owner)
- Possible related PR: #128408 (cleared stale Apple mobile
test exclusions, causing this test to start running on iOS simulator)
## Validation
- Command: `dotnet build
src/libraries/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj`
- Result: not run because environment lacks .NET 11 SDK
## Evidence
- Failing build:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1449088
- First build it occurred: 2026-06-04T09:47:08Z (computed within the
scanned window; may not be the true origin)
- Suspected regressing change: #128408 (removed test
exclusions, enabling this test on iossimulator-arm64)
---
Filed by
[`ci-failure-fix`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-fix.md),
which attempts validated fixes for `[ci-scan]` Known Build Errors and
otherwise loops in owners. Comment here or on the workflow file to
suggest changes;
[`ci-failure-scan-feedback`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-scan-feedback.md)
reads in-scope feedback daily and opens (or updates) a PR with prompt
edits.
> [!NOTE]
> <details>
> <summary>🔒 Integrity filter blocked 2 items</summary>
>
> The following items were blocked because they don't meet the GitHub
integrity level.
>
> - #128450 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
> - #128451 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
>
> To allow these resources, lower `min-integrity` in your GitHub
frontmatter:
>
> ```yaml
> tools:
> github:
> min-integrity: approved # merged | approved | unapproved | none
> ```
>
> </details>
> Generated by [CI Outer-Loop Failure
Fixer](https://github.com/dotnet/runtime/actions/runs/27872474682/agentic_workflow)
· ● 60.4M ·
[◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+ci-failure-fix%22&type=pullrequests)
<!-- gh-aw-agentic-workflow: CI Outer-Loop Failure Fixer, engine:
copilot, version: 1.0.40, model: claude-opus-4.6, id: 27872474682,
workflow_id: ci-failure-fix, run:
https://github.com/dotnet/runtime/actions/runs/27872474682 -->
<!-- gh-aw-workflow-id: ci-failure-fix -->
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 18, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@BrzVladBrzVladBrzVlad approved these changes
@vitek-karasvitek-karasAwaiting requested review from vitek-karas
@matouskozakmatouskozakAwaiting requested review from matouskozak

Assignees

@kotlarmiloskotlarmilos

Labels

area-Infrastructurelinkable-frameworkIssues associated with delivering a linker friendly frameworkos-iosApple iOS

Projects

Runtime Infra

Status: Done


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@BrzVlad

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mobile test suites - #129226
Merged
kotlarmilos merged 5 commits into
dotnet:mainfrom 
kotlarmilos:clr-ios-disable-failing-tests
Jun 15, 2026
Merged
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mobile test suites#129226
kotlarmilos merged 5 commits into
dotnet:mainfrom 
kotlarmilos:clr-ios-disable-failing-tests
Conversation
@kotlarmilos
@kotlarmiloskotlarmilos
commented
Jun 10, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
Disables three Apple CoreCLR mobile test failures against #124344 and fixes one via the trimmer descriptor:
  • InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE is disabled because Moq's RefEmit codegen breaks on iOS CoreCLR.
  • TensorPrimitives.SpanDestinationFunctions_ValueRange is disabled because Tan diverges by a few ULPs under FMA on arm64.
  • AssemblyTests.AssemblyGetForwardedTypesLoadFailure is disabled because GetForwardedTypes() does not resolve the forwarded System.Object/BadImageFormatException entries on trimmed Apple CoreCLR app bundles, even after rooting System.Runtime.
  • AssemblyTests.AssemblyLoadWithPublicKey is fixed by rooting the typeless System.Runtime facade in the trimmer descriptor so it is not dropped from the app bundle.
@kotlarmilos
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mob…
b5077aa
…ile test suites
Disable InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE and
TensorPrimitives SpanDestinationFunctions_ValueRange on Apple mobile CoreCLR
against dotnet#124344, and root the typeless System.Runtime facade in the trimmer
descriptor so AssemblyLoadWithPublicKey and AssemblyGetForwardedTypesLoadFailure
no longer fail to load it from the trimmed app bundle.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 10, 2026 10:06
CopilotAI
reviewed
Jun 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates several library test suites to improve reliability of Apple mobile CoreCLR test runs by conditionally disabling known failing tests and by ensuring trimming doesn’t remove a required facade assembly used by reflection tests.
Changes:
  • Add [ActiveIssue(...)] gating to skip a Moq/RefEmit-based reflection test on AppleMobile + CoreCLR.
  • Add [ActiveIssue(...)] gating to skip TensorPrimitives value-range coverage on AppleMobile + CoreCLR.
  • Update ILLink trimming descriptors to root the System.Runtime facade assembly so it isn’t trimmed away in the System.Reflection.Tests app.
Show a summary per file
FileDescription
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/InvokeWithRefLikeArgs.csAdds an AppleMobile+CoreCLR ActiveIssue skip for a Moq/RefEmit test.
src/libraries/System.Runtime/tests/System.Reflection.Tests/ILLink.Descriptors.xmlRoots System.Runtime in the linker descriptor to prevent it being trimmed from the test bundle.
src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.csAdds an AppleMobile+CoreCLR ActiveIssue skip for SpanDestinationFunctions_ValueRange.
Copilot's findings
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
Comment threadsrc/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs
@kotlarmiloskotlarmilos
self-assigned this
Jun 10, 2026
@kotlarmiloskotlarmilos
added this to the 11.0.0 milestone
Jun 10, 2026
kotlarmilosand others
added 2 commits
June 10, 2026 13:09
@kotlarmilos
Narrow Tan suppression to omit only the Tan case on Apple mobile CoreCLR
fdaf9e6
Address review feedback: instead of [ActiveIssue] on the whole
SpanDestinationFunctions_ValueRange theory, omit only the Tan case from the
shared data provider on Apple mobile CoreCLR, preserving ValueRange coverage
for the other operations.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kotlarmilos
Revert to method-level [ActiveIssue] for SpanDestinationFunctions_Val…
33b127f
…ueRange
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 10, 2026 11:11
CopilotAI
reviewed
Jun 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/ILLink.Descriptors.xml
@kotlarmilos
kotlarmilos
commented
Jun 10, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 10, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 10, 2026

Open


Closed


Open


Open


Open


Open


Open


Open


Open


Closed


Closed


Open

@kotlarmilos
kotlarmilos
commented
Jun 11, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 11, 2026

Copy link


Copy Markdown


No pipelines are associated with this pull request.
@kotlarmilos
kotlarmilos
commented
Jun 11, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 11, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 11, 2026

Open


Open

@azure-pipelines
azure-pipelinesBot
commented
Jun 12, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
CopilotAI
review requested due to automatic review settings
June 12, 2026 07:18
CopilotAI
reviewed
Jun 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 4/4 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2026

Closed

@kotlarmilos
kotlarmilos
merged commit 39ace2d
into
dotnet:mainJun 15, 2026

93 of 95 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 16, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Jun 17, 2026

Closed


This was referenced Jun 18, 2026

Closed

 Merged

tannergooding pushed a commit
that referenced
this pull request
Jun 22, 2026
@github-actions
[ci-fix] Needs review: Fix TensorPrimitives Tan precision tolerance o…
4a8dffc
…n ARM64 iOS simulator (refs #129045) (#129652)
Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #129045
> [!NOTE]
> This is an AI/Copilot-generated draft PR that attempts to fix the CI
failure described in KBE #129045. It has NOT been build-validated
(environment lacks .NET 11 SDK). Human review is needed.
## Root cause
The vectorized `TensorPrimitives.Tan` on ARM64 produces values that
diverge by ~47 ULPs from scalar `T.Tan` on iossimulator-arm64 CoreCLR.
The test's `trigTolerance` is set to `null` (meaning default ~1 ULP)
when `IsFmaSupported` is true (because `AdvSimd.Arm64.IsSupported` is
true on Apple Silicon). However, the vectorized trig algorithm doesn't
achieve bit-for-bit matching with the scalar math library on ARM64, even
though FMA hardware is available.
Failing log line:
```
Assert.All() Failure: 153 out of 201 items in the collection did not pass.
Expected: 0.4103213
Actual: 0.4103199
```
## Fix
Instead of using `null` tolerance when FMA is supported, apply an
explicit small tolerance:
- Float: `1e-5f` (allows ~333 ULPs — comfortably above the observed ~47
ULP divergence)
- Double: `1e-14` (proportionally generous for double precision)
This is consistent with how `CosPi` already applies `1e-5f` tolerance in
the FMA case via its null-coalescing fallback pattern.
Additionally, this removes the `[ActiveIssue("#124344")]` annotation on
`SpanDestinationFunctions_ValueRange` that blanket-disabled the test on
Apple Mobile CoreCLR, since the tolerance fix addresses the underlying
precision issue rather than masking the failure.
## What is unverified / help needed
- **Build not validated**: Environment has .NET 8/9 SDKs; the project
targets .NET 11 preview. Could not run `dotnet build` or tests.
- **Double tolerance**: The KBE doesn't show the actual value for the
Double failure, so the `1e-14` tolerance is an estimate. Needs
confirmation on-device.
- **Other trig functions**: Asin, Cos, Sin also use `trigTolerance`. If
they also diverge on ARM64, this fix covers them. If they DON'T
currently diverge, this change is still safe (tolerance only relaxes the
check).
- **Removing ActiveIssue**: PR #129226 added it for Tan divergence. If
there are OTHER undiscovered failures in
`SpanDestinationFunctions_ValueRange` on Apple mobile unrelated to trig
tolerance, removing the annotation could re-expose them.
## Suggested reviewers / area contacts
- `@tannergooding` (area-System.Numerics.Tensors owner)
- Possible related PR: #128408 (cleared stale Apple mobile
test exclusions, causing this test to start running on iOS simulator)
## Validation
- Command: `dotnet build
src/libraries/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj`
- Result: not run because environment lacks .NET 11 SDK
## Evidence
- Failing build:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1449088
- First build it occurred: 2026-06-04T09:47:08Z (computed within the
scanned window; may not be the true origin)
- Suspected regressing change: #128408 (removed test
exclusions, enabling this test on iossimulator-arm64)
---
Filed by
[`ci-failure-fix`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-fix.md),
which attempts validated fixes for `[ci-scan]` Known Build Errors and
otherwise loops in owners. Comment here or on the workflow file to
suggest changes;
[`ci-failure-scan-feedback`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-scan-feedback.md)
reads in-scope feedback daily and opens (or updates) a PR with prompt
edits.
> [!NOTE]
> <details>
> <summary>🔒 Integrity filter blocked 2 items</summary>
>
> The following items were blocked because they don't meet the GitHub
integrity level.
>
> - #128450 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
> - #128451 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
>
> To allow these resources, lower `min-integrity` in your GitHub
frontmatter:
>
> ```yaml
> tools:
> github:
> min-integrity: approved # merged | approved | unapproved | none
> ```
>
> </details>
> Generated by [CI Outer-Loop Failure
Fixer](https://github.com/dotnet/runtime/actions/runs/27872474682/agentic_workflow)
· ● 60.4M ·
[◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+ci-failure-fix%22&type=pullrequests)
<!-- gh-aw-agentic-workflow: CI Outer-Loop Failure Fixer, engine:
copilot, version: 1.0.40, model: claude-opus-4.6, id: 27872474682,
workflow_id: ci-failure-fix, run:
https://github.com/dotnet/runtime/actions/runs/27872474682 -->
<!-- gh-aw-workflow-id: ci-failure-fix -->
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
CopilotAI
mentioned this pull request
Jun 30, 2026
 Merged

eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@kotlarmilos@eiriktsarpalis
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mob…
1d6a259
…ile test suites (#129226)
## Description
Disables three Apple CoreCLR mobile test failures against #124344 and
fixes one via the trimmer descriptor:
- `InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE` is
disabled because Moq's RefEmit codegen breaks on iOS CoreCLR.
- `TensorPrimitives.SpanDestinationFunctions_ValueRange` is disabled
because `Tan` diverges by a few ULPs under FMA on arm64.
- `AssemblyTests.AssemblyGetForwardedTypesLoadFailure` is disabled
because `GetForwardedTypes()` does not resolve the forwarded
`System.Object`/`BadImageFormatException` entries on trimmed Apple
CoreCLR app bundles, even after rooting `System.Runtime`.
- `AssemblyTests.AssemblyLoadWithPublicKey` is fixed by rooting the
typeless `System.Runtime` facade in the trimmer descriptor so it is not
dropped from the app bundle.
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@github-actions@eiriktsarpalis
[ci-fix] Needs review: Fix TensorPrimitives Tan precision tolerance o…
095b0cb
…n ARM64 iOS simulator (refs #129045) (#129652)
Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #129045
> [!NOTE]
> This is an AI/Copilot-generated draft PR that attempts to fix the CI
failure described in KBE #129045. It has NOT been build-validated
(environment lacks .NET 11 SDK). Human review is needed.
## Root cause
The vectorized `TensorPrimitives.Tan` on ARM64 produces values that
diverge by ~47 ULPs from scalar `T.Tan` on iossimulator-arm64 CoreCLR.
The test's `trigTolerance` is set to `null` (meaning default ~1 ULP)
when `IsFmaSupported` is true (because `AdvSimd.Arm64.IsSupported` is
true on Apple Silicon). However, the vectorized trig algorithm doesn't
achieve bit-for-bit matching with the scalar math library on ARM64, even
though FMA hardware is available.
Failing log line:
```
Assert.All() Failure: 153 out of 201 items in the collection did not pass.
Expected: 0.4103213
Actual: 0.4103199
```
## Fix
Instead of using `null` tolerance when FMA is supported, apply an
explicit small tolerance:
- Float: `1e-5f` (allows ~333 ULPs — comfortably above the observed ~47
ULP divergence)
- Double: `1e-14` (proportionally generous for double precision)
This is consistent with how `CosPi` already applies `1e-5f` tolerance in
the FMA case via its null-coalescing fallback pattern.
Additionally, this removes the `[ActiveIssue("#124344")]` annotation on
`SpanDestinationFunctions_ValueRange` that blanket-disabled the test on
Apple Mobile CoreCLR, since the tolerance fix addresses the underlying
precision issue rather than masking the failure.
## What is unverified / help needed
- **Build not validated**: Environment has .NET 8/9 SDKs; the project
targets .NET 11 preview. Could not run `dotnet build` or tests.
- **Double tolerance**: The KBE doesn't show the actual value for the
Double failure, so the `1e-14` tolerance is an estimate. Needs
confirmation on-device.
- **Other trig functions**: Asin, Cos, Sin also use `trigTolerance`. If
they also diverge on ARM64, this fix covers them. If they DON'T
currently diverge, this change is still safe (tolerance only relaxes the
check).
- **Removing ActiveIssue**: PR #129226 added it for Tan divergence. If
there are OTHER undiscovered failures in
`SpanDestinationFunctions_ValueRange` on Apple mobile unrelated to trig
tolerance, removing the annotation could re-expose them.
## Suggested reviewers / area contacts
- `@tannergooding` (area-System.Numerics.Tensors owner)
- Possible related PR: #128408 (cleared stale Apple mobile
test exclusions, causing this test to start running on iOS simulator)
## Validation
- Command: `dotnet build
src/libraries/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj`
- Result: not run because environment lacks .NET 11 SDK
## Evidence
- Failing build:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1449088
- First build it occurred: 2026-06-04T09:47:08Z (computed within the
scanned window; may not be the true origin)
- Suspected regressing change: #128408 (removed test
exclusions, enabling this test on iossimulator-arm64)
---
Filed by
[`ci-failure-fix`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-fix.md),
which attempts validated fixes for `[ci-scan]` Known Build Errors and
otherwise loops in owners. Comment here or on the workflow file to
suggest changes;
[`ci-failure-scan-feedback`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-scan-feedback.md)
reads in-scope feedback daily and opens (or updates) a PR with prompt
edits.
> [!NOTE]
> <details>
> <summary>🔒 Integrity filter blocked 2 items</summary>
>
> The following items were blocked because they don't meet the GitHub
integrity level.
>
> - #128450 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
> - #128451 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
>
> To allow these resources, lower `min-integrity` in your GitHub
frontmatter:
>
> ```yaml
> tools:
> github:
> min-integrity: approved # merged | approved | unapproved | none
> ```
>
> </details>
> Generated by [CI Outer-Loop Failure
Fixer](https://github.com/dotnet/runtime/actions/runs/27872474682/agentic_workflow)
· ● 60.4M ·
[◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+ci-failure-fix%22&type=pullrequests)
<!-- gh-aw-agentic-workflow: CI Outer-Loop Failure Fixer, engine:
copilot, version: 1.0.40, model: claude-opus-4.6, id: 27872474682,
workflow_id: ci-failure-fix, run:
https://github.com/dotnet/runtime/actions/runs/27872474682 -->
<!-- gh-aw-workflow-id: ci-failure-fix -->
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 18, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@BrzVladBrzVladBrzVlad approved these changes
@vitek-karasvitek-karasAwaiting requested review from vitek-karas
@matouskozakmatouskozakAwaiting requested review from matouskozak

Assignees

@kotlarmiloskotlarmilos

Labels

area-Infrastructurelinkable-frameworkIssues associated with delivering a linker friendly frameworkos-iosApple iOS

Projects

Runtime Infra

Status: Done


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@BrzVlad

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mobile test suites - #129226
Merged
kotlarmilos merged 5 commits into
dotnet:mainfrom 
kotlarmilos:clr-ios-disable-failing-tests
Jun 15, 2026
Merged
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mobile test suites#129226
kotlarmilos merged 5 commits into
dotnet:mainfrom 
kotlarmilos:clr-ios-disable-failing-tests
Conversation
@kotlarmilos
@kotlarmiloskotlarmilos
commented
Jun 10, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
Disables three Apple CoreCLR mobile test failures against #124344 and fixes one via the trimmer descriptor:
  • InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE is disabled because Moq's RefEmit codegen breaks on iOS CoreCLR.
  • TensorPrimitives.SpanDestinationFunctions_ValueRange is disabled because Tan diverges by a few ULPs under FMA on arm64.
  • AssemblyTests.AssemblyGetForwardedTypesLoadFailure is disabled because GetForwardedTypes() does not resolve the forwarded System.Object/BadImageFormatException entries on trimmed Apple CoreCLR app bundles, even after rooting System.Runtime.
  • AssemblyTests.AssemblyLoadWithPublicKey is fixed by rooting the typeless System.Runtime facade in the trimmer descriptor so it is not dropped from the app bundle.
@kotlarmilos
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mob…
b5077aa
…ile test suites
Disable InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE and
TensorPrimitives SpanDestinationFunctions_ValueRange on Apple mobile CoreCLR
against dotnet#124344, and root the typeless System.Runtime facade in the trimmer
descriptor so AssemblyLoadWithPublicKey and AssemblyGetForwardedTypesLoadFailure
no longer fail to load it from the trimmed app bundle.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 10, 2026 10:06
CopilotAI
reviewed
Jun 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates several library test suites to improve reliability of Apple mobile CoreCLR test runs by conditionally disabling known failing tests and by ensuring trimming doesn’t remove a required facade assembly used by reflection tests.
Changes:
  • Add [ActiveIssue(...)] gating to skip a Moq/RefEmit-based reflection test on AppleMobile + CoreCLR.
  • Add [ActiveIssue(...)] gating to skip TensorPrimitives value-range coverage on AppleMobile + CoreCLR.
  • Update ILLink trimming descriptors to root the System.Runtime facade assembly so it isn’t trimmed away in the System.Reflection.Tests app.
Show a summary per file
FileDescription
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/InvokeWithRefLikeArgs.csAdds an AppleMobile+CoreCLR ActiveIssue skip for a Moq/RefEmit test.
src/libraries/System.Runtime/tests/System.Reflection.Tests/ILLink.Descriptors.xmlRoots System.Runtime in the linker descriptor to prevent it being trimmed from the test bundle.
src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.csAdds an AppleMobile+CoreCLR ActiveIssue skip for SpanDestinationFunctions_ValueRange.
Copilot's findings
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
Comment threadsrc/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs
@kotlarmiloskotlarmilos
self-assigned this
Jun 10, 2026
@kotlarmiloskotlarmilos
added this to the 11.0.0 milestone
Jun 10, 2026
kotlarmilosand others
added 2 commits
June 10, 2026 13:09
@kotlarmilos
Narrow Tan suppression to omit only the Tan case on Apple mobile CoreCLR
fdaf9e6
Address review feedback: instead of [ActiveIssue] on the whole
SpanDestinationFunctions_ValueRange theory, omit only the Tan case from the
shared data provider on Apple mobile CoreCLR, preserving ValueRange coverage
for the other operations.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kotlarmilos
Revert to method-level [ActiveIssue] for SpanDestinationFunctions_Val…
33b127f
…ueRange
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 10, 2026 11:11
CopilotAI
reviewed
Jun 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/ILLink.Descriptors.xml
@kotlarmilos
kotlarmilos
commented
Jun 10, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 10, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 10, 2026

Open


Closed


Open


Open


Open


Open


Open


Open


Open


Closed


Closed


Open

@kotlarmilos
kotlarmilos
commented
Jun 11, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 11, 2026

Copy link


Copy Markdown


No pipelines are associated with this pull request.
@kotlarmilos
kotlarmilos
commented
Jun 11, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 11, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 11, 2026

Open


Open

@azure-pipelines
azure-pipelinesBot
commented
Jun 12, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
CopilotAI
review requested due to automatic review settings
June 12, 2026 07:18
CopilotAI
reviewed
Jun 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 4/4 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2026

Closed

@kotlarmilos
kotlarmilos
merged commit 39ace2d
into
dotnet:mainJun 15, 2026

93 of 95 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 16, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Jun 17, 2026

Closed


This was referenced Jun 18, 2026

Closed

 Merged

tannergooding pushed a commit
that referenced
this pull request
Jun 22, 2026
@github-actions
[ci-fix] Needs review: Fix TensorPrimitives Tan precision tolerance o…
4a8dffc
…n ARM64 iOS simulator (refs #129045) (#129652)
Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #129045
> [!NOTE]
> This is an AI/Copilot-generated draft PR that attempts to fix the CI
failure described in KBE #129045. It has NOT been build-validated
(environment lacks .NET 11 SDK). Human review is needed.
## Root cause
The vectorized `TensorPrimitives.Tan` on ARM64 produces values that
diverge by ~47 ULPs from scalar `T.Tan` on iossimulator-arm64 CoreCLR.
The test's `trigTolerance` is set to `null` (meaning default ~1 ULP)
when `IsFmaSupported` is true (because `AdvSimd.Arm64.IsSupported` is
true on Apple Silicon). However, the vectorized trig algorithm doesn't
achieve bit-for-bit matching with the scalar math library on ARM64, even
though FMA hardware is available.
Failing log line:
```
Assert.All() Failure: 153 out of 201 items in the collection did not pass.
Expected: 0.4103213
Actual: 0.4103199
```
## Fix
Instead of using `null` tolerance when FMA is supported, apply an
explicit small tolerance:
- Float: `1e-5f` (allows ~333 ULPs — comfortably above the observed ~47
ULP divergence)
- Double: `1e-14` (proportionally generous for double precision)
This is consistent with how `CosPi` already applies `1e-5f` tolerance in
the FMA case via its null-coalescing fallback pattern.
Additionally, this removes the `[ActiveIssue("#124344")]` annotation on
`SpanDestinationFunctions_ValueRange` that blanket-disabled the test on
Apple Mobile CoreCLR, since the tolerance fix addresses the underlying
precision issue rather than masking the failure.
## What is unverified / help needed
- **Build not validated**: Environment has .NET 8/9 SDKs; the project
targets .NET 11 preview. Could not run `dotnet build` or tests.
- **Double tolerance**: The KBE doesn't show the actual value for the
Double failure, so the `1e-14` tolerance is an estimate. Needs
confirmation on-device.
- **Other trig functions**: Asin, Cos, Sin also use `trigTolerance`. If
they also diverge on ARM64, this fix covers them. If they DON'T
currently diverge, this change is still safe (tolerance only relaxes the
check).
- **Removing ActiveIssue**: PR #129226 added it for Tan divergence. If
there are OTHER undiscovered failures in
`SpanDestinationFunctions_ValueRange` on Apple mobile unrelated to trig
tolerance, removing the annotation could re-expose them.
## Suggested reviewers / area contacts
- `@tannergooding` (area-System.Numerics.Tensors owner)
- Possible related PR: #128408 (cleared stale Apple mobile
test exclusions, causing this test to start running on iOS simulator)
## Validation
- Command: `dotnet build
src/libraries/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj`
- Result: not run because environment lacks .NET 11 SDK
## Evidence
- Failing build:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1449088
- First build it occurred: 2026-06-04T09:47:08Z (computed within the
scanned window; may not be the true origin)
- Suspected regressing change: #128408 (removed test
exclusions, enabling this test on iossimulator-arm64)
---
Filed by
[`ci-failure-fix`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-fix.md),
which attempts validated fixes for `[ci-scan]` Known Build Errors and
otherwise loops in owners. Comment here or on the workflow file to
suggest changes;
[`ci-failure-scan-feedback`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-scan-feedback.md)
reads in-scope feedback daily and opens (or updates) a PR with prompt
edits.
> [!NOTE]
> <details>
> <summary>🔒 Integrity filter blocked 2 items</summary>
>
> The following items were blocked because they don't meet the GitHub
integrity level.
>
> - #128450 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
> - #128451 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
>
> To allow these resources, lower `min-integrity` in your GitHub
frontmatter:
>
> ```yaml
> tools:
> github:
> min-integrity: approved # merged | approved | unapproved | none
> ```
>
> </details>
> Generated by [CI Outer-Loop Failure
Fixer](https://github.com/dotnet/runtime/actions/runs/27872474682/agentic_workflow)
· ● 60.4M ·
[◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+ci-failure-fix%22&type=pullrequests)
<!-- gh-aw-agentic-workflow: CI Outer-Loop Failure Fixer, engine:
copilot, version: 1.0.40, model: claude-opus-4.6, id: 27872474682,
workflow_id: ci-failure-fix, run:
https://github.com/dotnet/runtime/actions/runs/27872474682 -->
<!-- gh-aw-workflow-id: ci-failure-fix -->
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
CopilotAI
mentioned this pull request
Jun 30, 2026
 Merged

eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@kotlarmilos@eiriktsarpalis
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mob…
1d6a259
…ile test suites (#129226)
## Description
Disables three Apple CoreCLR mobile test failures against #124344 and
fixes one via the trimmer descriptor:
- `InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE` is
disabled because Moq's RefEmit codegen breaks on iOS CoreCLR.
- `TensorPrimitives.SpanDestinationFunctions_ValueRange` is disabled
because `Tan` diverges by a few ULPs under FMA on arm64.
- `AssemblyTests.AssemblyGetForwardedTypesLoadFailure` is disabled
because `GetForwardedTypes()` does not resolve the forwarded
`System.Object`/`BadImageFormatException` entries on trimmed Apple
CoreCLR app bundles, even after rooting `System.Runtime`.
- `AssemblyTests.AssemblyLoadWithPublicKey` is fixed by rooting the
typeless `System.Runtime` facade in the trimmer descriptor so it is not
dropped from the app bundle.
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@github-actions@eiriktsarpalis
[ci-fix] Needs review: Fix TensorPrimitives Tan precision tolerance o…
095b0cb
…n ARM64 iOS simulator (refs #129045) (#129652)
Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #129045
> [!NOTE]
> This is an AI/Copilot-generated draft PR that attempts to fix the CI
failure described in KBE #129045. It has NOT been build-validated
(environment lacks .NET 11 SDK). Human review is needed.
## Root cause
The vectorized `TensorPrimitives.Tan` on ARM64 produces values that
diverge by ~47 ULPs from scalar `T.Tan` on iossimulator-arm64 CoreCLR.
The test's `trigTolerance` is set to `null` (meaning default ~1 ULP)
when `IsFmaSupported` is true (because `AdvSimd.Arm64.IsSupported` is
true on Apple Silicon). However, the vectorized trig algorithm doesn't
achieve bit-for-bit matching with the scalar math library on ARM64, even
though FMA hardware is available.
Failing log line:
```
Assert.All() Failure: 153 out of 201 items in the collection did not pass.
Expected: 0.4103213
Actual: 0.4103199
```
## Fix
Instead of using `null` tolerance when FMA is supported, apply an
explicit small tolerance:
- Float: `1e-5f` (allows ~333 ULPs — comfortably above the observed ~47
ULP divergence)
- Double: `1e-14` (proportionally generous for double precision)
This is consistent with how `CosPi` already applies `1e-5f` tolerance in
the FMA case via its null-coalescing fallback pattern.
Additionally, this removes the `[ActiveIssue("#124344")]` annotation on
`SpanDestinationFunctions_ValueRange` that blanket-disabled the test on
Apple Mobile CoreCLR, since the tolerance fix addresses the underlying
precision issue rather than masking the failure.
## What is unverified / help needed
- **Build not validated**: Environment has .NET 8/9 SDKs; the project
targets .NET 11 preview. Could not run `dotnet build` or tests.
- **Double tolerance**: The KBE doesn't show the actual value for the
Double failure, so the `1e-14` tolerance is an estimate. Needs
confirmation on-device.
- **Other trig functions**: Asin, Cos, Sin also use `trigTolerance`. If
they also diverge on ARM64, this fix covers them. If they DON'T
currently diverge, this change is still safe (tolerance only relaxes the
check).
- **Removing ActiveIssue**: PR #129226 added it for Tan divergence. If
there are OTHER undiscovered failures in
`SpanDestinationFunctions_ValueRange` on Apple mobile unrelated to trig
tolerance, removing the annotation could re-expose them.
## Suggested reviewers / area contacts
- `@tannergooding` (area-System.Numerics.Tensors owner)
- Possible related PR: #128408 (cleared stale Apple mobile
test exclusions, causing this test to start running on iOS simulator)
## Validation
- Command: `dotnet build
src/libraries/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj`
- Result: not run because environment lacks .NET 11 SDK
## Evidence
- Failing build:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1449088
- First build it occurred: 2026-06-04T09:47:08Z (computed within the
scanned window; may not be the true origin)
- Suspected regressing change: #128408 (removed test
exclusions, enabling this test on iossimulator-arm64)
---
Filed by
[`ci-failure-fix`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-fix.md),
which attempts validated fixes for `[ci-scan]` Known Build Errors and
otherwise loops in owners. Comment here or on the workflow file to
suggest changes;
[`ci-failure-scan-feedback`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-scan-feedback.md)
reads in-scope feedback daily and opens (or updates) a PR with prompt
edits.
> [!NOTE]
> <details>
> <summary>🔒 Integrity filter blocked 2 items</summary>
>
> The following items were blocked because they don't meet the GitHub
integrity level.
>
> - #128450 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
> - #128451 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
>
> To allow these resources, lower `min-integrity` in your GitHub
frontmatter:
>
> ```yaml
> tools:
> github:
> min-integrity: approved # merged | approved | unapproved | none
> ```
>
> </details>
> Generated by [CI Outer-Loop Failure
Fixer](https://github.com/dotnet/runtime/actions/runs/27872474682/agentic_workflow)
· ● 60.4M ·
[◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+ci-failure-fix%22&type=pullrequests)
<!-- gh-aw-agentic-workflow: CI Outer-Loop Failure Fixer, engine:
copilot, version: 1.0.40, model: claude-opus-4.6, id: 27872474682,
workflow_id: ci-failure-fix, run:
https://github.com/dotnet/runtime/actions/runs/27872474682 -->
<!-- gh-aw-workflow-id: ci-failure-fix -->
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 18, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@BrzVladBrzVladBrzVlad approved these changes
@vitek-karasvitek-karasAwaiting requested review from vitek-karas
@matouskozakmatouskozakAwaiting requested review from matouskozak

Assignees

@kotlarmiloskotlarmilos

Labels

area-Infrastructurelinkable-frameworkIssues associated with delivering a linker friendly frameworkos-iosApple iOS

Projects

Runtime Infra

Status: Done


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@BrzVlad

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mobile test suites - #129226
Merged
kotlarmilos merged 5 commits into
dotnet:mainfrom 
kotlarmilos:clr-ios-disable-failing-tests
Jun 15, 2026
Merged
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mobile test suites#129226
kotlarmilos merged 5 commits into
dotnet:mainfrom 
kotlarmilos:clr-ios-disable-failing-tests
Conversation
@kotlarmilos
@kotlarmiloskotlarmilos
commented
Jun 10, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
Disables three Apple CoreCLR mobile test failures against #124344 and fixes one via the trimmer descriptor:
  • InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE is disabled because Moq's RefEmit codegen breaks on iOS CoreCLR.
  • TensorPrimitives.SpanDestinationFunctions_ValueRange is disabled because Tan diverges by a few ULPs under FMA on arm64.
  • AssemblyTests.AssemblyGetForwardedTypesLoadFailure is disabled because GetForwardedTypes() does not resolve the forwarded System.Object/BadImageFormatException entries on trimmed Apple CoreCLR app bundles, even after rooting System.Runtime.
  • AssemblyTests.AssemblyLoadWithPublicKey is fixed by rooting the typeless System.Runtime facade in the trimmer descriptor so it is not dropped from the app bundle.
@kotlarmilos
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mob…
b5077aa
…ile test suites
Disable InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE and
TensorPrimitives SpanDestinationFunctions_ValueRange on Apple mobile CoreCLR
against dotnet#124344, and root the typeless System.Runtime facade in the trimmer
descriptor so AssemblyLoadWithPublicKey and AssemblyGetForwardedTypesLoadFailure
no longer fail to load it from the trimmed app bundle.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 10, 2026 10:06
CopilotAI
reviewed
Jun 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates several library test suites to improve reliability of Apple mobile CoreCLR test runs by conditionally disabling known failing tests and by ensuring trimming doesn’t remove a required facade assembly used by reflection tests.
Changes:
  • Add [ActiveIssue(...)] gating to skip a Moq/RefEmit-based reflection test on AppleMobile + CoreCLR.
  • Add [ActiveIssue(...)] gating to skip TensorPrimitives value-range coverage on AppleMobile + CoreCLR.
  • Update ILLink trimming descriptors to root the System.Runtime facade assembly so it isn’t trimmed away in the System.Reflection.Tests app.
Show a summary per file
FileDescription
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/InvokeWithRefLikeArgs.csAdds an AppleMobile+CoreCLR ActiveIssue skip for a Moq/RefEmit test.
src/libraries/System.Runtime/tests/System.Reflection.Tests/ILLink.Descriptors.xmlRoots System.Runtime in the linker descriptor to prevent it being trimmed from the test bundle.
src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.csAdds an AppleMobile+CoreCLR ActiveIssue skip for SpanDestinationFunctions_ValueRange.
Copilot's findings
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
Comment threadsrc/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs
@kotlarmiloskotlarmilos
self-assigned this
Jun 10, 2026
@kotlarmiloskotlarmilos
added this to the 11.0.0 milestone
Jun 10, 2026
kotlarmilosand others
added 2 commits
June 10, 2026 13:09
@kotlarmilos
Narrow Tan suppression to omit only the Tan case on Apple mobile CoreCLR
fdaf9e6
Address review feedback: instead of [ActiveIssue] on the whole
SpanDestinationFunctions_ValueRange theory, omit only the Tan case from the
shared data provider on Apple mobile CoreCLR, preserving ValueRange coverage
for the other operations.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kotlarmilos
Revert to method-level [ActiveIssue] for SpanDestinationFunctions_Val…
33b127f
…ueRange
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 10, 2026 11:11
CopilotAI
reviewed
Jun 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/ILLink.Descriptors.xml
@kotlarmilos
kotlarmilos
commented
Jun 10, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 10, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 10, 2026

Open


Closed


Open


Open


Open


Open


Open


Open


Open


Closed


Closed


Open

@kotlarmilos
kotlarmilos
commented
Jun 11, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 11, 2026

Copy link


Copy Markdown


No pipelines are associated with this pull request.
@kotlarmilos
kotlarmilos
commented
Jun 11, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 11, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 11, 2026

Open


Open

@azure-pipelines
azure-pipelinesBot
commented
Jun 12, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
CopilotAI
review requested due to automatic review settings
June 12, 2026 07:18
CopilotAI
reviewed
Jun 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 4/4 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2026

Closed

@kotlarmilos
kotlarmilos
merged commit 39ace2d
into
dotnet:mainJun 15, 2026

93 of 95 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 16, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Jun 17, 2026

Closed


This was referenced Jun 18, 2026

Closed

 Merged

tannergooding pushed a commit
that referenced
this pull request
Jun 22, 2026
@github-actions
[ci-fix] Needs review: Fix TensorPrimitives Tan precision tolerance o…
4a8dffc
…n ARM64 iOS simulator (refs #129045) (#129652)
Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #129045
> [!NOTE]
> This is an AI/Copilot-generated draft PR that attempts to fix the CI
failure described in KBE #129045. It has NOT been build-validated
(environment lacks .NET 11 SDK). Human review is needed.
## Root cause
The vectorized `TensorPrimitives.Tan` on ARM64 produces values that
diverge by ~47 ULPs from scalar `T.Tan` on iossimulator-arm64 CoreCLR.
The test's `trigTolerance` is set to `null` (meaning default ~1 ULP)
when `IsFmaSupported` is true (because `AdvSimd.Arm64.IsSupported` is
true on Apple Silicon). However, the vectorized trig algorithm doesn't
achieve bit-for-bit matching with the scalar math library on ARM64, even
though FMA hardware is available.
Failing log line:
```
Assert.All() Failure: 153 out of 201 items in the collection did not pass.
Expected: 0.4103213
Actual: 0.4103199
```
## Fix
Instead of using `null` tolerance when FMA is supported, apply an
explicit small tolerance:
- Float: `1e-5f` (allows ~333 ULPs — comfortably above the observed ~47
ULP divergence)
- Double: `1e-14` (proportionally generous for double precision)
This is consistent with how `CosPi` already applies `1e-5f` tolerance in
the FMA case via its null-coalescing fallback pattern.
Additionally, this removes the `[ActiveIssue("#124344")]` annotation on
`SpanDestinationFunctions_ValueRange` that blanket-disabled the test on
Apple Mobile CoreCLR, since the tolerance fix addresses the underlying
precision issue rather than masking the failure.
## What is unverified / help needed
- **Build not validated**: Environment has .NET 8/9 SDKs; the project
targets .NET 11 preview. Could not run `dotnet build` or tests.
- **Double tolerance**: The KBE doesn't show the actual value for the
Double failure, so the `1e-14` tolerance is an estimate. Needs
confirmation on-device.
- **Other trig functions**: Asin, Cos, Sin also use `trigTolerance`. If
they also diverge on ARM64, this fix covers them. If they DON'T
currently diverge, this change is still safe (tolerance only relaxes the
check).
- **Removing ActiveIssue**: PR #129226 added it for Tan divergence. If
there are OTHER undiscovered failures in
`SpanDestinationFunctions_ValueRange` on Apple mobile unrelated to trig
tolerance, removing the annotation could re-expose them.
## Suggested reviewers / area contacts
- `@tannergooding` (area-System.Numerics.Tensors owner)
- Possible related PR: #128408 (cleared stale Apple mobile
test exclusions, causing this test to start running on iOS simulator)
## Validation
- Command: `dotnet build
src/libraries/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj`
- Result: not run because environment lacks .NET 11 SDK
## Evidence
- Failing build:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1449088
- First build it occurred: 2026-06-04T09:47:08Z (computed within the
scanned window; may not be the true origin)
- Suspected regressing change: #128408 (removed test
exclusions, enabling this test on iossimulator-arm64)
---
Filed by
[`ci-failure-fix`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-fix.md),
which attempts validated fixes for `[ci-scan]` Known Build Errors and
otherwise loops in owners. Comment here or on the workflow file to
suggest changes;
[`ci-failure-scan-feedback`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-scan-feedback.md)
reads in-scope feedback daily and opens (or updates) a PR with prompt
edits.
> [!NOTE]
> <details>
> <summary>🔒 Integrity filter blocked 2 items</summary>
>
> The following items were blocked because they don't meet the GitHub
integrity level.
>
> - #128450 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
> - #128451 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
>
> To allow these resources, lower `min-integrity` in your GitHub
frontmatter:
>
> ```yaml
> tools:
> github:
> min-integrity: approved # merged | approved | unapproved | none
> ```
>
> </details>
> Generated by [CI Outer-Loop Failure
Fixer](https://github.com/dotnet/runtime/actions/runs/27872474682/agentic_workflow)
· ● 60.4M ·
[◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+ci-failure-fix%22&type=pullrequests)
<!-- gh-aw-agentic-workflow: CI Outer-Loop Failure Fixer, engine:
copilot, version: 1.0.40, model: claude-opus-4.6, id: 27872474682,
workflow_id: ci-failure-fix, run:
https://github.com/dotnet/runtime/actions/runs/27872474682 -->
<!-- gh-aw-workflow-id: ci-failure-fix -->
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
CopilotAI
mentioned this pull request
Jun 30, 2026
 Merged

eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@kotlarmilos@eiriktsarpalis
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mob…
1d6a259
…ile test suites (#129226)
## Description
Disables three Apple CoreCLR mobile test failures against #124344 and
fixes one via the trimmer descriptor:
- `InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE` is
disabled because Moq's RefEmit codegen breaks on iOS CoreCLR.
- `TensorPrimitives.SpanDestinationFunctions_ValueRange` is disabled
because `Tan` diverges by a few ULPs under FMA on arm64.
- `AssemblyTests.AssemblyGetForwardedTypesLoadFailure` is disabled
because `GetForwardedTypes()` does not resolve the forwarded
`System.Object`/`BadImageFormatException` entries on trimmed Apple
CoreCLR app bundles, even after rooting `System.Runtime`.
- `AssemblyTests.AssemblyLoadWithPublicKey` is fixed by rooting the
typeless `System.Runtime` facade in the trimmer descriptor so it is not
dropped from the app bundle.
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@github-actions@eiriktsarpalis
[ci-fix] Needs review: Fix TensorPrimitives Tan precision tolerance o…
095b0cb
…n ARM64 iOS simulator (refs #129045) (#129652)
Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #129045
> [!NOTE]
> This is an AI/Copilot-generated draft PR that attempts to fix the CI
failure described in KBE #129045. It has NOT been build-validated
(environment lacks .NET 11 SDK). Human review is needed.
## Root cause
The vectorized `TensorPrimitives.Tan` on ARM64 produces values that
diverge by ~47 ULPs from scalar `T.Tan` on iossimulator-arm64 CoreCLR.
The test's `trigTolerance` is set to `null` (meaning default ~1 ULP)
when `IsFmaSupported` is true (because `AdvSimd.Arm64.IsSupported` is
true on Apple Silicon). However, the vectorized trig algorithm doesn't
achieve bit-for-bit matching with the scalar math library on ARM64, even
though FMA hardware is available.
Failing log line:
```
Assert.All() Failure: 153 out of 201 items in the collection did not pass.
Expected: 0.4103213
Actual: 0.4103199
```
## Fix
Instead of using `null` tolerance when FMA is supported, apply an
explicit small tolerance:
- Float: `1e-5f` (allows ~333 ULPs — comfortably above the observed ~47
ULP divergence)
- Double: `1e-14` (proportionally generous for double precision)
This is consistent with how `CosPi` already applies `1e-5f` tolerance in
the FMA case via its null-coalescing fallback pattern.
Additionally, this removes the `[ActiveIssue("#124344")]` annotation on
`SpanDestinationFunctions_ValueRange` that blanket-disabled the test on
Apple Mobile CoreCLR, since the tolerance fix addresses the underlying
precision issue rather than masking the failure.
## What is unverified / help needed
- **Build not validated**: Environment has .NET 8/9 SDKs; the project
targets .NET 11 preview. Could not run `dotnet build` or tests.
- **Double tolerance**: The KBE doesn't show the actual value for the
Double failure, so the `1e-14` tolerance is an estimate. Needs
confirmation on-device.
- **Other trig functions**: Asin, Cos, Sin also use `trigTolerance`. If
they also diverge on ARM64, this fix covers them. If they DON'T
currently diverge, this change is still safe (tolerance only relaxes the
check).
- **Removing ActiveIssue**: PR #129226 added it for Tan divergence. If
there are OTHER undiscovered failures in
`SpanDestinationFunctions_ValueRange` on Apple mobile unrelated to trig
tolerance, removing the annotation could re-expose them.
## Suggested reviewers / area contacts
- `@tannergooding` (area-System.Numerics.Tensors owner)
- Possible related PR: #128408 (cleared stale Apple mobile
test exclusions, causing this test to start running on iOS simulator)
## Validation
- Command: `dotnet build
src/libraries/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj`
- Result: not run because environment lacks .NET 11 SDK
## Evidence
- Failing build:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1449088
- First build it occurred: 2026-06-04T09:47:08Z (computed within the
scanned window; may not be the true origin)
- Suspected regressing change: #128408 (removed test
exclusions, enabling this test on iossimulator-arm64)
---
Filed by
[`ci-failure-fix`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-fix.md),
which attempts validated fixes for `[ci-scan]` Known Build Errors and
otherwise loops in owners. Comment here or on the workflow file to
suggest changes;
[`ci-failure-scan-feedback`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-scan-feedback.md)
reads in-scope feedback daily and opens (or updates) a PR with prompt
edits.
> [!NOTE]
> <details>
> <summary>🔒 Integrity filter blocked 2 items</summary>
>
> The following items were blocked because they don't meet the GitHub
integrity level.
>
> - #128450 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
> - #128451 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
>
> To allow these resources, lower `min-integrity` in your GitHub
frontmatter:
>
> ```yaml
> tools:
> github:
> min-integrity: approved # merged | approved | unapproved | none
> ```
>
> </details>
> Generated by [CI Outer-Loop Failure
Fixer](https://github.com/dotnet/runtime/actions/runs/27872474682/agentic_workflow)
· ● 60.4M ·
[◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+ci-failure-fix%22&type=pullrequests)
<!-- gh-aw-agentic-workflow: CI Outer-Loop Failure Fixer, engine:
copilot, version: 1.0.40, model: claude-opus-4.6, id: 27872474682,
workflow_id: ci-failure-fix, run:
https://github.com/dotnet/runtime/actions/runs/27872474682 -->
<!-- gh-aw-workflow-id: ci-failure-fix -->
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 18, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@BrzVladBrzVladBrzVlad approved these changes
@vitek-karasvitek-karasAwaiting requested review from vitek-karas
@matouskozakmatouskozakAwaiting requested review from matouskozak

Assignees

@kotlarmiloskotlarmilos

Labels

area-Infrastructurelinkable-frameworkIssues associated with delivering a linker friendly frameworkos-iosApple iOS

Projects

Runtime Infra

Status: Done


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@BrzVlad

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mobile test suites - #129226
Merged
kotlarmilos merged 5 commits into
dotnet:mainfrom 
kotlarmilos:clr-ios-disable-failing-tests
Jun 15, 2026
Merged
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mobile test suites#129226
kotlarmilos merged 5 commits into
dotnet:mainfrom 
kotlarmilos:clr-ios-disable-failing-tests
Conversation
@kotlarmilos
@kotlarmiloskotlarmilos
commented
Jun 10, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
Disables three Apple CoreCLR mobile test failures against #124344 and fixes one via the trimmer descriptor:
  • InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE is disabled because Moq's RefEmit codegen breaks on iOS CoreCLR.
  • TensorPrimitives.SpanDestinationFunctions_ValueRange is disabled because Tan diverges by a few ULPs under FMA on arm64.
  • AssemblyTests.AssemblyGetForwardedTypesLoadFailure is disabled because GetForwardedTypes() does not resolve the forwarded System.Object/BadImageFormatException entries on trimmed Apple CoreCLR app bundles, even after rooting System.Runtime.
  • AssemblyTests.AssemblyLoadWithPublicKey is fixed by rooting the typeless System.Runtime facade in the trimmer descriptor so it is not dropped from the app bundle.
@kotlarmilos
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mob…
b5077aa
…ile test suites
Disable InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE and
TensorPrimitives SpanDestinationFunctions_ValueRange on Apple mobile CoreCLR
against dotnet#124344, and root the typeless System.Runtime facade in the trimmer
descriptor so AssemblyLoadWithPublicKey and AssemblyGetForwardedTypesLoadFailure
no longer fail to load it from the trimmed app bundle.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 10, 2026 10:06
CopilotAI
reviewed
Jun 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates several library test suites to improve reliability of Apple mobile CoreCLR test runs by conditionally disabling known failing tests and by ensuring trimming doesn’t remove a required facade assembly used by reflection tests.
Changes:
  • Add [ActiveIssue(...)] gating to skip a Moq/RefEmit-based reflection test on AppleMobile + CoreCLR.
  • Add [ActiveIssue(...)] gating to skip TensorPrimitives value-range coverage on AppleMobile + CoreCLR.
  • Update ILLink trimming descriptors to root the System.Runtime facade assembly so it isn’t trimmed away in the System.Reflection.Tests app.
Show a summary per file
FileDescription
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/InvokeWithRefLikeArgs.csAdds an AppleMobile+CoreCLR ActiveIssue skip for a Moq/RefEmit test.
src/libraries/System.Runtime/tests/System.Reflection.Tests/ILLink.Descriptors.xmlRoots System.Runtime in the linker descriptor to prevent it being trimmed from the test bundle.
src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.csAdds an AppleMobile+CoreCLR ActiveIssue skip for SpanDestinationFunctions_ValueRange.
Copilot's findings
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
Comment threadsrc/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs
@kotlarmiloskotlarmilos
self-assigned this
Jun 10, 2026
@kotlarmiloskotlarmilos
added this to the 11.0.0 milestone
Jun 10, 2026
kotlarmilosand others
added 2 commits
June 10, 2026 13:09
@kotlarmilos
Narrow Tan suppression to omit only the Tan case on Apple mobile CoreCLR
fdaf9e6
Address review feedback: instead of [ActiveIssue] on the whole
SpanDestinationFunctions_ValueRange theory, omit only the Tan case from the
shared data provider on Apple mobile CoreCLR, preserving ValueRange coverage
for the other operations.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kotlarmilos
Revert to method-level [ActiveIssue] for SpanDestinationFunctions_Val…
33b127f
…ueRange
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 10, 2026 11:11
CopilotAI
reviewed
Jun 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/ILLink.Descriptors.xml
@kotlarmilos
kotlarmilos
commented
Jun 10, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 10, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 10, 2026

Open


Closed


Open


Open


Open


Open


Open


Open


Open


Closed


Closed


Open

@kotlarmilos
kotlarmilos
commented
Jun 11, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 11, 2026

Copy link


Copy Markdown


No pipelines are associated with this pull request.
@kotlarmilos
kotlarmilos
commented
Jun 11, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 11, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 11, 2026

Open


Open

@azure-pipelines
azure-pipelinesBot
commented
Jun 12, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
CopilotAI
review requested due to automatic review settings
June 12, 2026 07:18
CopilotAI
reviewed
Jun 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 4/4 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2026

Closed

@kotlarmilos
kotlarmilos
merged commit 39ace2d
into
dotnet:mainJun 15, 2026

93 of 95 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 16, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Jun 17, 2026

Closed


This was referenced Jun 18, 2026

Closed

 Merged

tannergooding pushed a commit
that referenced
this pull request
Jun 22, 2026
@github-actions
[ci-fix] Needs review: Fix TensorPrimitives Tan precision tolerance o…
4a8dffc
…n ARM64 iOS simulator (refs #129045) (#129652)
Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #129045
> [!NOTE]
> This is an AI/Copilot-generated draft PR that attempts to fix the CI
failure described in KBE #129045. It has NOT been build-validated
(environment lacks .NET 11 SDK). Human review is needed.
## Root cause
The vectorized `TensorPrimitives.Tan` on ARM64 produces values that
diverge by ~47 ULPs from scalar `T.Tan` on iossimulator-arm64 CoreCLR.
The test's `trigTolerance` is set to `null` (meaning default ~1 ULP)
when `IsFmaSupported` is true (because `AdvSimd.Arm64.IsSupported` is
true on Apple Silicon). However, the vectorized trig algorithm doesn't
achieve bit-for-bit matching with the scalar math library on ARM64, even
though FMA hardware is available.
Failing log line:
```
Assert.All() Failure: 153 out of 201 items in the collection did not pass.
Expected: 0.4103213
Actual: 0.4103199
```
## Fix
Instead of using `null` tolerance when FMA is supported, apply an
explicit small tolerance:
- Float: `1e-5f` (allows ~333 ULPs — comfortably above the observed ~47
ULP divergence)
- Double: `1e-14` (proportionally generous for double precision)
This is consistent with how `CosPi` already applies `1e-5f` tolerance in
the FMA case via its null-coalescing fallback pattern.
Additionally, this removes the `[ActiveIssue("#124344")]` annotation on
`SpanDestinationFunctions_ValueRange` that blanket-disabled the test on
Apple Mobile CoreCLR, since the tolerance fix addresses the underlying
precision issue rather than masking the failure.
## What is unverified / help needed
- **Build not validated**: Environment has .NET 8/9 SDKs; the project
targets .NET 11 preview. Could not run `dotnet build` or tests.
- **Double tolerance**: The KBE doesn't show the actual value for the
Double failure, so the `1e-14` tolerance is an estimate. Needs
confirmation on-device.
- **Other trig functions**: Asin, Cos, Sin also use `trigTolerance`. If
they also diverge on ARM64, this fix covers them. If they DON'T
currently diverge, this change is still safe (tolerance only relaxes the
check).
- **Removing ActiveIssue**: PR #129226 added it for Tan divergence. If
there are OTHER undiscovered failures in
`SpanDestinationFunctions_ValueRange` on Apple mobile unrelated to trig
tolerance, removing the annotation could re-expose them.
## Suggested reviewers / area contacts
- `@tannergooding` (area-System.Numerics.Tensors owner)
- Possible related PR: #128408 (cleared stale Apple mobile
test exclusions, causing this test to start running on iOS simulator)
## Validation
- Command: `dotnet build
src/libraries/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj`
- Result: not run because environment lacks .NET 11 SDK
## Evidence
- Failing build:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1449088
- First build it occurred: 2026-06-04T09:47:08Z (computed within the
scanned window; may not be the true origin)
- Suspected regressing change: #128408 (removed test
exclusions, enabling this test on iossimulator-arm64)
---
Filed by
[`ci-failure-fix`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-fix.md),
which attempts validated fixes for `[ci-scan]` Known Build Errors and
otherwise loops in owners. Comment here or on the workflow file to
suggest changes;
[`ci-failure-scan-feedback`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-scan-feedback.md)
reads in-scope feedback daily and opens (or updates) a PR with prompt
edits.
> [!NOTE]
> <details>
> <summary>🔒 Integrity filter blocked 2 items</summary>
>
> The following items were blocked because they don't meet the GitHub
integrity level.
>
> - #128450 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
> - #128451 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
>
> To allow these resources, lower `min-integrity` in your GitHub
frontmatter:
>
> ```yaml
> tools:
> github:
> min-integrity: approved # merged | approved | unapproved | none
> ```
>
> </details>
> Generated by [CI Outer-Loop Failure
Fixer](https://github.com/dotnet/runtime/actions/runs/27872474682/agentic_workflow)
· ● 60.4M ·
[◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+ci-failure-fix%22&type=pullrequests)
<!-- gh-aw-agentic-workflow: CI Outer-Loop Failure Fixer, engine:
copilot, version: 1.0.40, model: claude-opus-4.6, id: 27872474682,
workflow_id: ci-failure-fix, run:
https://github.com/dotnet/runtime/actions/runs/27872474682 -->
<!-- gh-aw-workflow-id: ci-failure-fix -->
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
CopilotAI
mentioned this pull request
Jun 30, 2026
 Merged

eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@kotlarmilos@eiriktsarpalis
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mob…
1d6a259
…ile test suites (#129226)
## Description
Disables three Apple CoreCLR mobile test failures against #124344 and
fixes one via the trimmer descriptor:
- `InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE` is
disabled because Moq's RefEmit codegen breaks on iOS CoreCLR.
- `TensorPrimitives.SpanDestinationFunctions_ValueRange` is disabled
because `Tan` diverges by a few ULPs under FMA on arm64.
- `AssemblyTests.AssemblyGetForwardedTypesLoadFailure` is disabled
because `GetForwardedTypes()` does not resolve the forwarded
`System.Object`/`BadImageFormatException` entries on trimmed Apple
CoreCLR app bundles, even after rooting `System.Runtime`.
- `AssemblyTests.AssemblyLoadWithPublicKey` is fixed by rooting the
typeless `System.Runtime` facade in the trimmer descriptor so it is not
dropped from the app bundle.
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@github-actions@eiriktsarpalis
[ci-fix] Needs review: Fix TensorPrimitives Tan precision tolerance o…
095b0cb
…n ARM64 iOS simulator (refs #129045) (#129652)
Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #129045
> [!NOTE]
> This is an AI/Copilot-generated draft PR that attempts to fix the CI
failure described in KBE #129045. It has NOT been build-validated
(environment lacks .NET 11 SDK). Human review is needed.
## Root cause
The vectorized `TensorPrimitives.Tan` on ARM64 produces values that
diverge by ~47 ULPs from scalar `T.Tan` on iossimulator-arm64 CoreCLR.
The test's `trigTolerance` is set to `null` (meaning default ~1 ULP)
when `IsFmaSupported` is true (because `AdvSimd.Arm64.IsSupported` is
true on Apple Silicon). However, the vectorized trig algorithm doesn't
achieve bit-for-bit matching with the scalar math library on ARM64, even
though FMA hardware is available.
Failing log line:
```
Assert.All() Failure: 153 out of 201 items in the collection did not pass.
Expected: 0.4103213
Actual: 0.4103199
```
## Fix
Instead of using `null` tolerance when FMA is supported, apply an
explicit small tolerance:
- Float: `1e-5f` (allows ~333 ULPs — comfortably above the observed ~47
ULP divergence)
- Double: `1e-14` (proportionally generous for double precision)
This is consistent with how `CosPi` already applies `1e-5f` tolerance in
the FMA case via its null-coalescing fallback pattern.
Additionally, this removes the `[ActiveIssue("#124344")]` annotation on
`SpanDestinationFunctions_ValueRange` that blanket-disabled the test on
Apple Mobile CoreCLR, since the tolerance fix addresses the underlying
precision issue rather than masking the failure.
## What is unverified / help needed
- **Build not validated**: Environment has .NET 8/9 SDKs; the project
targets .NET 11 preview. Could not run `dotnet build` or tests.
- **Double tolerance**: The KBE doesn't show the actual value for the
Double failure, so the `1e-14` tolerance is an estimate. Needs
confirmation on-device.
- **Other trig functions**: Asin, Cos, Sin also use `trigTolerance`. If
they also diverge on ARM64, this fix covers them. If they DON'T
currently diverge, this change is still safe (tolerance only relaxes the
check).
- **Removing ActiveIssue**: PR #129226 added it for Tan divergence. If
there are OTHER undiscovered failures in
`SpanDestinationFunctions_ValueRange` on Apple mobile unrelated to trig
tolerance, removing the annotation could re-expose them.
## Suggested reviewers / area contacts
- `@tannergooding` (area-System.Numerics.Tensors owner)
- Possible related PR: #128408 (cleared stale Apple mobile
test exclusions, causing this test to start running on iOS simulator)
## Validation
- Command: `dotnet build
src/libraries/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj`
- Result: not run because environment lacks .NET 11 SDK
## Evidence
- Failing build:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1449088
- First build it occurred: 2026-06-04T09:47:08Z (computed within the
scanned window; may not be the true origin)
- Suspected regressing change: #128408 (removed test
exclusions, enabling this test on iossimulator-arm64)
---
Filed by
[`ci-failure-fix`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-fix.md),
which attempts validated fixes for `[ci-scan]` Known Build Errors and
otherwise loops in owners. Comment here or on the workflow file to
suggest changes;
[`ci-failure-scan-feedback`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-scan-feedback.md)
reads in-scope feedback daily and opens (or updates) a PR with prompt
edits.
> [!NOTE]
> <details>
> <summary>🔒 Integrity filter blocked 2 items</summary>
>
> The following items were blocked because they don't meet the GitHub
integrity level.
>
> - #128450 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
> - #128451 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
>
> To allow these resources, lower `min-integrity` in your GitHub
frontmatter:
>
> ```yaml
> tools:
> github:
> min-integrity: approved # merged | approved | unapproved | none
> ```
>
> </details>
> Generated by [CI Outer-Loop Failure
Fixer](https://github.com/dotnet/runtime/actions/runs/27872474682/agentic_workflow)
· ● 60.4M ·
[◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+ci-failure-fix%22&type=pullrequests)
<!-- gh-aw-agentic-workflow: CI Outer-Loop Failure Fixer, engine:
copilot, version: 1.0.40, model: claude-opus-4.6, id: 27872474682,
workflow_id: ci-failure-fix, run:
https://github.com/dotnet/runtime/actions/runs/27872474682 -->
<!-- gh-aw-workflow-id: ci-failure-fix -->
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 18, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@BrzVladBrzVladBrzVlad approved these changes
@vitek-karasvitek-karasAwaiting requested review from vitek-karas
@matouskozakmatouskozakAwaiting requested review from matouskozak

Assignees

@kotlarmiloskotlarmilos

Labels

area-Infrastructurelinkable-frameworkIssues associated with delivering a linker friendly frameworkos-iosApple iOS

Projects

Runtime Infra

Status: Done


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@BrzVlad

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mobile test suites - #129226
Merged
kotlarmilos merged 5 commits into
dotnet:mainfrom 
kotlarmilos:clr-ios-disable-failing-tests
Jun 15, 2026
Merged
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mobile test suites#129226
kotlarmilos merged 5 commits into
dotnet:mainfrom 
kotlarmilos:clr-ios-disable-failing-tests
Conversation
@kotlarmilos
@kotlarmiloskotlarmilos
commented
Jun 10, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
Disables three Apple CoreCLR mobile test failures against #124344 and fixes one via the trimmer descriptor:
  • InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE is disabled because Moq's RefEmit codegen breaks on iOS CoreCLR.
  • TensorPrimitives.SpanDestinationFunctions_ValueRange is disabled because Tan diverges by a few ULPs under FMA on arm64.
  • AssemblyTests.AssemblyGetForwardedTypesLoadFailure is disabled because GetForwardedTypes() does not resolve the forwarded System.Object/BadImageFormatException entries on trimmed Apple CoreCLR app bundles, even after rooting System.Runtime.
  • AssemblyTests.AssemblyLoadWithPublicKey is fixed by rooting the typeless System.Runtime facade in the trimmer descriptor so it is not dropped from the app bundle.
@kotlarmilos
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mob…
b5077aa
…ile test suites
Disable InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE and
TensorPrimitives SpanDestinationFunctions_ValueRange on Apple mobile CoreCLR
against dotnet#124344, and root the typeless System.Runtime facade in the trimmer
descriptor so AssemblyLoadWithPublicKey and AssemblyGetForwardedTypesLoadFailure
no longer fail to load it from the trimmed app bundle.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 10, 2026 10:06
CopilotAI
reviewed
Jun 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates several library test suites to improve reliability of Apple mobile CoreCLR test runs by conditionally disabling known failing tests and by ensuring trimming doesn’t remove a required facade assembly used by reflection tests.
Changes:
  • Add [ActiveIssue(...)] gating to skip a Moq/RefEmit-based reflection test on AppleMobile + CoreCLR.
  • Add [ActiveIssue(...)] gating to skip TensorPrimitives value-range coverage on AppleMobile + CoreCLR.
  • Update ILLink trimming descriptors to root the System.Runtime facade assembly so it isn’t trimmed away in the System.Reflection.Tests app.
Show a summary per file
FileDescription
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/InvokeWithRefLikeArgs.csAdds an AppleMobile+CoreCLR ActiveIssue skip for a Moq/RefEmit test.
src/libraries/System.Runtime/tests/System.Reflection.Tests/ILLink.Descriptors.xmlRoots System.Runtime in the linker descriptor to prevent it being trimmed from the test bundle.
src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.csAdds an AppleMobile+CoreCLR ActiveIssue skip for SpanDestinationFunctions_ValueRange.
Copilot's findings
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
Comment threadsrc/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs
@kotlarmiloskotlarmilos
self-assigned this
Jun 10, 2026
@kotlarmiloskotlarmilos
added this to the 11.0.0 milestone
Jun 10, 2026
kotlarmilosand others
added 2 commits
June 10, 2026 13:09
@kotlarmilos
Narrow Tan suppression to omit only the Tan case on Apple mobile CoreCLR
fdaf9e6
Address review feedback: instead of [ActiveIssue] on the whole
SpanDestinationFunctions_ValueRange theory, omit only the Tan case from the
shared data provider on Apple mobile CoreCLR, preserving ValueRange coverage
for the other operations.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kotlarmilos
Revert to method-level [ActiveIssue] for SpanDestinationFunctions_Val…
33b127f
…ueRange
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 10, 2026 11:11
CopilotAI
reviewed
Jun 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/ILLink.Descriptors.xml
@kotlarmilos
kotlarmilos
commented
Jun 10, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 10, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 10, 2026

Open


Closed


Open


Open


Open


Open


Open


Open


Open


Closed


Closed


Open

@kotlarmilos
kotlarmilos
commented
Jun 11, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 11, 2026

Copy link


Copy Markdown


No pipelines are associated with this pull request.
@kotlarmilos
kotlarmilos
commented
Jun 11, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 11, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 11, 2026

Open


Open

@azure-pipelines
azure-pipelinesBot
commented
Jun 12, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
CopilotAI
review requested due to automatic review settings
June 12, 2026 07:18
CopilotAI
reviewed
Jun 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 4/4 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2026

Closed

@kotlarmilos
kotlarmilos
merged commit 39ace2d
into
dotnet:mainJun 15, 2026

93 of 95 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 16, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Jun 17, 2026

Closed


This was referenced Jun 18, 2026

Closed

 Merged

tannergooding pushed a commit
that referenced
this pull request
Jun 22, 2026
@github-actions
[ci-fix] Needs review: Fix TensorPrimitives Tan precision tolerance o…
4a8dffc
…n ARM64 iOS simulator (refs #129045) (#129652)
Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #129045
> [!NOTE]
> This is an AI/Copilot-generated draft PR that attempts to fix the CI
failure described in KBE #129045. It has NOT been build-validated
(environment lacks .NET 11 SDK). Human review is needed.
## Root cause
The vectorized `TensorPrimitives.Tan` on ARM64 produces values that
diverge by ~47 ULPs from scalar `T.Tan` on iossimulator-arm64 CoreCLR.
The test's `trigTolerance` is set to `null` (meaning default ~1 ULP)
when `IsFmaSupported` is true (because `AdvSimd.Arm64.IsSupported` is
true on Apple Silicon). However, the vectorized trig algorithm doesn't
achieve bit-for-bit matching with the scalar math library on ARM64, even
though FMA hardware is available.
Failing log line:
```
Assert.All() Failure: 153 out of 201 items in the collection did not pass.
Expected: 0.4103213
Actual: 0.4103199
```
## Fix
Instead of using `null` tolerance when FMA is supported, apply an
explicit small tolerance:
- Float: `1e-5f` (allows ~333 ULPs — comfortably above the observed ~47
ULP divergence)
- Double: `1e-14` (proportionally generous for double precision)
This is consistent with how `CosPi` already applies `1e-5f` tolerance in
the FMA case via its null-coalescing fallback pattern.
Additionally, this removes the `[ActiveIssue("#124344")]` annotation on
`SpanDestinationFunctions_ValueRange` that blanket-disabled the test on
Apple Mobile CoreCLR, since the tolerance fix addresses the underlying
precision issue rather than masking the failure.
## What is unverified / help needed
- **Build not validated**: Environment has .NET 8/9 SDKs; the project
targets .NET 11 preview. Could not run `dotnet build` or tests.
- **Double tolerance**: The KBE doesn't show the actual value for the
Double failure, so the `1e-14` tolerance is an estimate. Needs
confirmation on-device.
- **Other trig functions**: Asin, Cos, Sin also use `trigTolerance`. If
they also diverge on ARM64, this fix covers them. If they DON'T
currently diverge, this change is still safe (tolerance only relaxes the
check).
- **Removing ActiveIssue**: PR #129226 added it for Tan divergence. If
there are OTHER undiscovered failures in
`SpanDestinationFunctions_ValueRange` on Apple mobile unrelated to trig
tolerance, removing the annotation could re-expose them.
## Suggested reviewers / area contacts
- `@tannergooding` (area-System.Numerics.Tensors owner)
- Possible related PR: #128408 (cleared stale Apple mobile
test exclusions, causing this test to start running on iOS simulator)
## Validation
- Command: `dotnet build
src/libraries/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj`
- Result: not run because environment lacks .NET 11 SDK
## Evidence
- Failing build:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1449088
- First build it occurred: 2026-06-04T09:47:08Z (computed within the
scanned window; may not be the true origin)
- Suspected regressing change: #128408 (removed test
exclusions, enabling this test on iossimulator-arm64)
---
Filed by
[`ci-failure-fix`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-fix.md),
which attempts validated fixes for `[ci-scan]` Known Build Errors and
otherwise loops in owners. Comment here or on the workflow file to
suggest changes;
[`ci-failure-scan-feedback`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-scan-feedback.md)
reads in-scope feedback daily and opens (or updates) a PR with prompt
edits.
> [!NOTE]
> <details>
> <summary>🔒 Integrity filter blocked 2 items</summary>
>
> The following items were blocked because they don't meet the GitHub
integrity level.
>
> - #128450 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
> - #128451 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
>
> To allow these resources, lower `min-integrity` in your GitHub
frontmatter:
>
> ```yaml
> tools:
> github:
> min-integrity: approved # merged | approved | unapproved | none
> ```
>
> </details>
> Generated by [CI Outer-Loop Failure
Fixer](https://github.com/dotnet/runtime/actions/runs/27872474682/agentic_workflow)
· ● 60.4M ·
[◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+ci-failure-fix%22&type=pullrequests)
<!-- gh-aw-agentic-workflow: CI Outer-Loop Failure Fixer, engine:
copilot, version: 1.0.40, model: claude-opus-4.6, id: 27872474682,
workflow_id: ci-failure-fix, run:
https://github.com/dotnet/runtime/actions/runs/27872474682 -->
<!-- gh-aw-workflow-id: ci-failure-fix -->
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
CopilotAI
mentioned this pull request
Jun 30, 2026
 Merged

eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@kotlarmilos@eiriktsarpalis
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mob…
1d6a259
…ile test suites (#129226)
## Description
Disables three Apple CoreCLR mobile test failures against #124344 and
fixes one via the trimmer descriptor:
- `InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE` is
disabled because Moq's RefEmit codegen breaks on iOS CoreCLR.
- `TensorPrimitives.SpanDestinationFunctions_ValueRange` is disabled
because `Tan` diverges by a few ULPs under FMA on arm64.
- `AssemblyTests.AssemblyGetForwardedTypesLoadFailure` is disabled
because `GetForwardedTypes()` does not resolve the forwarded
`System.Object`/`BadImageFormatException` entries on trimmed Apple
CoreCLR app bundles, even after rooting `System.Runtime`.
- `AssemblyTests.AssemblyLoadWithPublicKey` is fixed by rooting the
typeless `System.Runtime` facade in the trimmer descriptor so it is not
dropped from the app bundle.
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@github-actions@eiriktsarpalis
[ci-fix] Needs review: Fix TensorPrimitives Tan precision tolerance o…
095b0cb
…n ARM64 iOS simulator (refs #129045) (#129652)
Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #129045
> [!NOTE]
> This is an AI/Copilot-generated draft PR that attempts to fix the CI
failure described in KBE #129045. It has NOT been build-validated
(environment lacks .NET 11 SDK). Human review is needed.
## Root cause
The vectorized `TensorPrimitives.Tan` on ARM64 produces values that
diverge by ~47 ULPs from scalar `T.Tan` on iossimulator-arm64 CoreCLR.
The test's `trigTolerance` is set to `null` (meaning default ~1 ULP)
when `IsFmaSupported` is true (because `AdvSimd.Arm64.IsSupported` is
true on Apple Silicon). However, the vectorized trig algorithm doesn't
achieve bit-for-bit matching with the scalar math library on ARM64, even
though FMA hardware is available.
Failing log line:
```
Assert.All() Failure: 153 out of 201 items in the collection did not pass.
Expected: 0.4103213
Actual: 0.4103199
```
## Fix
Instead of using `null` tolerance when FMA is supported, apply an
explicit small tolerance:
- Float: `1e-5f` (allows ~333 ULPs — comfortably above the observed ~47
ULP divergence)
- Double: `1e-14` (proportionally generous for double precision)
This is consistent with how `CosPi` already applies `1e-5f` tolerance in
the FMA case via its null-coalescing fallback pattern.
Additionally, this removes the `[ActiveIssue("#124344")]` annotation on
`SpanDestinationFunctions_ValueRange` that blanket-disabled the test on
Apple Mobile CoreCLR, since the tolerance fix addresses the underlying
precision issue rather than masking the failure.
## What is unverified / help needed
- **Build not validated**: Environment has .NET 8/9 SDKs; the project
targets .NET 11 preview. Could not run `dotnet build` or tests.
- **Double tolerance**: The KBE doesn't show the actual value for the
Double failure, so the `1e-14` tolerance is an estimate. Needs
confirmation on-device.
- **Other trig functions**: Asin, Cos, Sin also use `trigTolerance`. If
they also diverge on ARM64, this fix covers them. If they DON'T
currently diverge, this change is still safe (tolerance only relaxes the
check).
- **Removing ActiveIssue**: PR #129226 added it for Tan divergence. If
there are OTHER undiscovered failures in
`SpanDestinationFunctions_ValueRange` on Apple mobile unrelated to trig
tolerance, removing the annotation could re-expose them.
## Suggested reviewers / area contacts
- `@tannergooding` (area-System.Numerics.Tensors owner)
- Possible related PR: #128408 (cleared stale Apple mobile
test exclusions, causing this test to start running on iOS simulator)
## Validation
- Command: `dotnet build
src/libraries/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj`
- Result: not run because environment lacks .NET 11 SDK
## Evidence
- Failing build:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1449088
- First build it occurred: 2026-06-04T09:47:08Z (computed within the
scanned window; may not be the true origin)
- Suspected regressing change: #128408 (removed test
exclusions, enabling this test on iossimulator-arm64)
---
Filed by
[`ci-failure-fix`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-fix.md),
which attempts validated fixes for `[ci-scan]` Known Build Errors and
otherwise loops in owners. Comment here or on the workflow file to
suggest changes;
[`ci-failure-scan-feedback`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-scan-feedback.md)
reads in-scope feedback daily and opens (or updates) a PR with prompt
edits.
> [!NOTE]
> <details>
> <summary>🔒 Integrity filter blocked 2 items</summary>
>
> The following items were blocked because they don't meet the GitHub
integrity level.
>
> - #128450 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
> - #128451 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
>
> To allow these resources, lower `min-integrity` in your GitHub
frontmatter:
>
> ```yaml
> tools:
> github:
> min-integrity: approved # merged | approved | unapproved | none
> ```
>
> </details>
> Generated by [CI Outer-Loop Failure
Fixer](https://github.com/dotnet/runtime/actions/runs/27872474682/agentic_workflow)
· ● 60.4M ·
[◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+ci-failure-fix%22&type=pullrequests)
<!-- gh-aw-agentic-workflow: CI Outer-Loop Failure Fixer, engine:
copilot, version: 1.0.40, model: claude-opus-4.6, id: 27872474682,
workflow_id: ci-failure-fix, run:
https://github.com/dotnet/runtime/actions/runs/27872474682 -->
<!-- gh-aw-workflow-id: ci-failure-fix -->
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 18, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@BrzVladBrzVladBrzVlad approved these changes
@vitek-karasvitek-karasAwaiting requested review from vitek-karas
@matouskozakmatouskozakAwaiting requested review from matouskozak

Assignees

@kotlarmiloskotlarmilos

Labels

area-Infrastructurelinkable-frameworkIssues associated with delivering a linker friendly frameworkos-iosApple iOS

Projects

Runtime Infra

Status: Done


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@BrzVlad

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mobile test suites - #129226
Merged
kotlarmilos merged 5 commits into
dotnet:mainfrom 
kotlarmilos:clr-ios-disable-failing-tests
Jun 15, 2026
Merged
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mobile test suites#129226
kotlarmilos merged 5 commits into
dotnet:mainfrom 
kotlarmilos:clr-ios-disable-failing-tests
Conversation
@kotlarmilos
@kotlarmiloskotlarmilos
commented
Jun 10, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
Disables three Apple CoreCLR mobile test failures against #124344 and fixes one via the trimmer descriptor:
  • InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE is disabled because Moq's RefEmit codegen breaks on iOS CoreCLR.
  • TensorPrimitives.SpanDestinationFunctions_ValueRange is disabled because Tan diverges by a few ULPs under FMA on arm64.
  • AssemblyTests.AssemblyGetForwardedTypesLoadFailure is disabled because GetForwardedTypes() does not resolve the forwarded System.Object/BadImageFormatException entries on trimmed Apple CoreCLR app bundles, even after rooting System.Runtime.
  • AssemblyTests.AssemblyLoadWithPublicKey is fixed by rooting the typeless System.Runtime facade in the trimmer descriptor so it is not dropped from the app bundle.
@kotlarmilos
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mob…
b5077aa
…ile test suites
Disable InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE and
TensorPrimitives SpanDestinationFunctions_ValueRange on Apple mobile CoreCLR
against dotnet#124344, and root the typeless System.Runtime facade in the trimmer
descriptor so AssemblyLoadWithPublicKey and AssemblyGetForwardedTypesLoadFailure
no longer fail to load it from the trimmed app bundle.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 10, 2026 10:06
CopilotAI
reviewed
Jun 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates several library test suites to improve reliability of Apple mobile CoreCLR test runs by conditionally disabling known failing tests and by ensuring trimming doesn’t remove a required facade assembly used by reflection tests.
Changes:
  • Add [ActiveIssue(...)] gating to skip a Moq/RefEmit-based reflection test on AppleMobile + CoreCLR.
  • Add [ActiveIssue(...)] gating to skip TensorPrimitives value-range coverage on AppleMobile + CoreCLR.
  • Update ILLink trimming descriptors to root the System.Runtime facade assembly so it isn’t trimmed away in the System.Reflection.Tests app.
Show a summary per file
FileDescription
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/InvokeWithRefLikeArgs.csAdds an AppleMobile+CoreCLR ActiveIssue skip for a Moq/RefEmit test.
src/libraries/System.Runtime/tests/System.Reflection.Tests/ILLink.Descriptors.xmlRoots System.Runtime in the linker descriptor to prevent it being trimmed from the test bundle.
src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.csAdds an AppleMobile+CoreCLR ActiveIssue skip for SpanDestinationFunctions_ValueRange.
Copilot's findings
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
Comment threadsrc/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs
@kotlarmiloskotlarmilos
self-assigned this
Jun 10, 2026
@kotlarmiloskotlarmilos
added this to the 11.0.0 milestone
Jun 10, 2026
kotlarmilosand others
added 2 commits
June 10, 2026 13:09
@kotlarmilos
Narrow Tan suppression to omit only the Tan case on Apple mobile CoreCLR
fdaf9e6
Address review feedback: instead of [ActiveIssue] on the whole
SpanDestinationFunctions_ValueRange theory, omit only the Tan case from the
shared data provider on Apple mobile CoreCLR, preserving ValueRange coverage
for the other operations.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kotlarmilos
Revert to method-level [ActiveIssue] for SpanDestinationFunctions_Val…
33b127f
…ueRange
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 10, 2026 11:11
CopilotAI
reviewed
Jun 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/ILLink.Descriptors.xml
@kotlarmilos
kotlarmilos
commented
Jun 10, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 10, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 10, 2026

Open


Closed


Open


Open


Open


Open


Open


Open


Open


Closed


Closed


Open

@kotlarmilos
kotlarmilos
commented
Jun 11, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 11, 2026

Copy link


Copy Markdown


No pipelines are associated with this pull request.
@kotlarmilos
kotlarmilos
commented
Jun 11, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jun 11, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 11, 2026

Open


Open

@azure-pipelines
azure-pipelinesBot
commented
Jun 12, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
CopilotAI
review requested due to automatic review settings
June 12, 2026 07:18
CopilotAI
reviewed
Jun 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 4/4 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2026

Closed

@kotlarmilos
kotlarmilos
merged commit 39ace2d
into
dotnet:mainJun 15, 2026

93 of 95 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 16, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Jun 17, 2026

Closed


This was referenced Jun 18, 2026

Closed

 Merged

tannergooding pushed a commit
that referenced
this pull request
Jun 22, 2026
@github-actions
[ci-fix] Needs review: Fix TensorPrimitives Tan precision tolerance o…
4a8dffc
…n ARM64 iOS simulator (refs #129045) (#129652)
Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #129045
> [!NOTE]
> This is an AI/Copilot-generated draft PR that attempts to fix the CI
failure described in KBE #129045. It has NOT been build-validated
(environment lacks .NET 11 SDK). Human review is needed.
## Root cause
The vectorized `TensorPrimitives.Tan` on ARM64 produces values that
diverge by ~47 ULPs from scalar `T.Tan` on iossimulator-arm64 CoreCLR.
The test's `trigTolerance` is set to `null` (meaning default ~1 ULP)
when `IsFmaSupported` is true (because `AdvSimd.Arm64.IsSupported` is
true on Apple Silicon). However, the vectorized trig algorithm doesn't
achieve bit-for-bit matching with the scalar math library on ARM64, even
though FMA hardware is available.
Failing log line:
```
Assert.All() Failure: 153 out of 201 items in the collection did not pass.
Expected: 0.4103213
Actual: 0.4103199
```
## Fix
Instead of using `null` tolerance when FMA is supported, apply an
explicit small tolerance:
- Float: `1e-5f` (allows ~333 ULPs — comfortably above the observed ~47
ULP divergence)
- Double: `1e-14` (proportionally generous for double precision)
This is consistent with how `CosPi` already applies `1e-5f` tolerance in
the FMA case via its null-coalescing fallback pattern.
Additionally, this removes the `[ActiveIssue("#124344")]` annotation on
`SpanDestinationFunctions_ValueRange` that blanket-disabled the test on
Apple Mobile CoreCLR, since the tolerance fix addresses the underlying
precision issue rather than masking the failure.
## What is unverified / help needed
- **Build not validated**: Environment has .NET 8/9 SDKs; the project
targets .NET 11 preview. Could not run `dotnet build` or tests.
- **Double tolerance**: The KBE doesn't show the actual value for the
Double failure, so the `1e-14` tolerance is an estimate. Needs
confirmation on-device.
- **Other trig functions**: Asin, Cos, Sin also use `trigTolerance`. If
they also diverge on ARM64, this fix covers them. If they DON'T
currently diverge, this change is still safe (tolerance only relaxes the
check).
- **Removing ActiveIssue**: PR #129226 added it for Tan divergence. If
there are OTHER undiscovered failures in
`SpanDestinationFunctions_ValueRange` on Apple mobile unrelated to trig
tolerance, removing the annotation could re-expose them.
## Suggested reviewers / area contacts
- `@tannergooding` (area-System.Numerics.Tensors owner)
- Possible related PR: #128408 (cleared stale Apple mobile
test exclusions, causing this test to start running on iOS simulator)
## Validation
- Command: `dotnet build
src/libraries/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj`
- Result: not run because environment lacks .NET 11 SDK
## Evidence
- Failing build:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1449088
- First build it occurred: 2026-06-04T09:47:08Z (computed within the
scanned window; may not be the true origin)
- Suspected regressing change: #128408 (removed test
exclusions, enabling this test on iossimulator-arm64)
---
Filed by
[`ci-failure-fix`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-fix.md),
which attempts validated fixes for `[ci-scan]` Known Build Errors and
otherwise loops in owners. Comment here or on the workflow file to
suggest changes;
[`ci-failure-scan-feedback`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-scan-feedback.md)
reads in-scope feedback daily and opens (or updates) a PR with prompt
edits.
> [!NOTE]
> <details>
> <summary>🔒 Integrity filter blocked 2 items</summary>
>
> The following items were blocked because they don't meet the GitHub
integrity level.
>
> - #128450 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
> - #128451 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
>
> To allow these resources, lower `min-integrity` in your GitHub
frontmatter:
>
> ```yaml
> tools:
> github:
> min-integrity: approved # merged | approved | unapproved | none
> ```
>
> </details>
> Generated by [CI Outer-Loop Failure
Fixer](https://github.com/dotnet/runtime/actions/runs/27872474682/agentic_workflow)
· ● 60.4M ·
[◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+ci-failure-fix%22&type=pullrequests)
<!-- gh-aw-agentic-workflow: CI Outer-Loop Failure Fixer, engine:
copilot, version: 1.0.40, model: claude-opus-4.6, id: 27872474682,
workflow_id: ci-failure-fix, run:
https://github.com/dotnet/runtime/actions/runs/27872474682 -->
<!-- gh-aw-workflow-id: ci-failure-fix -->
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
CopilotAI
mentioned this pull request
Jun 30, 2026
 Merged

eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@kotlarmilos@eiriktsarpalis
[clr-ios] Disable failing tests and fix trimming in Apple CoreCLR mob…
1d6a259
…ile test suites (#129226)
## Description
Disables three Apple CoreCLR mobile test failures against #124344 and
fixes one via the trimmer descriptor:
- `InvokeWithRefLikeArgs.MethodTakesRefToRefStructAsArg_ThrowsNSE` is
disabled because Moq's RefEmit codegen breaks on iOS CoreCLR.
- `TensorPrimitives.SpanDestinationFunctions_ValueRange` is disabled
because `Tan` diverges by a few ULPs under FMA on arm64.
- `AssemblyTests.AssemblyGetForwardedTypesLoadFailure` is disabled
because `GetForwardedTypes()` does not resolve the forwarded
`System.Object`/`BadImageFormatException` entries on trimmed Apple
CoreCLR app bundles, even after rooting `System.Runtime`.
- `AssemblyTests.AssemblyLoadWithPublicKey` is fixed by rooting the
typeless `System.Runtime` facade in the trimmer descriptor so it is not
dropped from the app bundle.
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@github-actions@eiriktsarpalis
[ci-fix] Needs review: Fix TensorPrimitives Tan precision tolerance o…
095b0cb
…n ARM64 iOS simulator (refs #129045) (#129652)
Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #129045
> [!NOTE]
> This is an AI/Copilot-generated draft PR that attempts to fix the CI
failure described in KBE #129045. It has NOT been build-validated
(environment lacks .NET 11 SDK). Human review is needed.
## Root cause
The vectorized `TensorPrimitives.Tan` on ARM64 produces values that
diverge by ~47 ULPs from scalar `T.Tan` on iossimulator-arm64 CoreCLR.
The test's `trigTolerance` is set to `null` (meaning default ~1 ULP)
when `IsFmaSupported` is true (because `AdvSimd.Arm64.IsSupported` is
true on Apple Silicon). However, the vectorized trig algorithm doesn't
achieve bit-for-bit matching with the scalar math library on ARM64, even
though FMA hardware is available.
Failing log line:
```
Assert.All() Failure: 153 out of 201 items in the collection did not pass.
Expected: 0.4103213
Actual: 0.4103199
```
## Fix
Instead of using `null` tolerance when FMA is supported, apply an
explicit small tolerance:
- Float: `1e-5f` (allows ~333 ULPs — comfortably above the observed ~47
ULP divergence)
- Double: `1e-14` (proportionally generous for double precision)
This is consistent with how `CosPi` already applies `1e-5f` tolerance in
the FMA case via its null-coalescing fallback pattern.
Additionally, this removes the `[ActiveIssue("#124344")]` annotation on
`SpanDestinationFunctions_ValueRange` that blanket-disabled the test on
Apple Mobile CoreCLR, since the tolerance fix addresses the underlying
precision issue rather than masking the failure.
## What is unverified / help needed
- **Build not validated**: Environment has .NET 8/9 SDKs; the project
targets .NET 11 preview. Could not run `dotnet build` or tests.
- **Double tolerance**: The KBE doesn't show the actual value for the
Double failure, so the `1e-14` tolerance is an estimate. Needs
confirmation on-device.
- **Other trig functions**: Asin, Cos, Sin also use `trigTolerance`. If
they also diverge on ARM64, this fix covers them. If they DON'T
currently diverge, this change is still safe (tolerance only relaxes the
check).
- **Removing ActiveIssue**: PR #129226 added it for Tan divergence. If
there are OTHER undiscovered failures in
`SpanDestinationFunctions_ValueRange` on Apple mobile unrelated to trig
tolerance, removing the annotation could re-expose them.
## Suggested reviewers / area contacts
- `@tannergooding` (area-System.Numerics.Tensors owner)
- Possible related PR: #128408 (cleared stale Apple mobile
test exclusions, causing this test to start running on iOS simulator)
## Validation
- Command: `dotnet build
src/libraries/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj`
- Result: not run because environment lacks .NET 11 SDK
## Evidence
- Failing build:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1449088
- First build it occurred: 2026-06-04T09:47:08Z (computed within the
scanned window; may not be the true origin)
- Suspected regressing change: #128408 (removed test
exclusions, enabling this test on iossimulator-arm64)
---
Filed by
[`ci-failure-fix`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-fix.md),
which attempts validated fixes for `[ci-scan]` Known Build Errors and
otherwise loops in owners. Comment here or on the workflow file to
suggest changes;
[`ci-failure-scan-feedback`](https://github.com/dotnet/runtime/blob/main/.github/workflows/ci-failure-scan-feedback.md)
reads in-scope feedback daily and opens (or updates) a PR with prompt
edits.
> [!NOTE]
> <details>
> <summary>🔒 Integrity filter blocked 2 items</summary>
>
> The following items were blocked because they don't meet the GitHub
integrity level.
>
> - #128450 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
> - #128451 `issue_read`: has lower integrity than agent
requires. The agent cannot read data with integrity below "approved".
>
> To allow these resources, lower `min-integrity` in your GitHub
frontmatter:
>
> ```yaml
> tools:
> github:
> min-integrity: approved # merged | approved | unapproved | none
> ```
>
> </details>
> Generated by [CI Outer-Loop Failure
Fixer](https://github.com/dotnet/runtime/actions/runs/27872474682/agentic_workflow)
· ● 60.4M ·
[◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+ci-failure-fix%22&type=pullrequests)
<!-- gh-aw-agentic-workflow: CI Outer-Loop Failure Fixer, engine:
copilot, version: 1.0.40, model: claude-opus-4.6, id: 27872474682,
workflow_id: ci-failure-fix, run:
https://github.com/dotnet/runtime/actions/runs/27872474682 -->
<!-- gh-aw-workflow-id: ci-failure-fix -->
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 18, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@BrzVladBrzVladBrzVlad approved these changes
@vitek-karasvitek-karasAwaiting requested review from vitek-karas
@matouskozakmatouskozakAwaiting requested review from matouskozak

Assignees

@kotlarmiloskotlarmilos

Labels

area-Infrastructurelinkable-frameworkIssues associated with delivering a linker friendly frameworkos-iosApple iOS

Projects

Runtime Infra

Status: Done


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@BrzVlad