Skip to content

Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk - #128722

Merged
tannergooding merged 6 commits into
dotnet:mainfrom
tannergooding:intrinsic-intrng-fornode
Jun 1, 2026
Merged

Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk#128722
tannergooding merged 6 commits into
dotnet:mainfrom
tannergooding:intrinsic-intrng-fornode

Conversation

@tannergooding

@tannergoodingtannergooding commented May 28, 2026

Copy link
Copy Markdown
Member

Found some cases that were getting pessimized in #128677 because we didn't consistently handle different intrinsics across the various places that can produce range information.

CopilotAI review requested due to automatic review settings May 28, 2026 19:45
@github-actionsgithub-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 28, 2026
@dotnet-policy-service

dotnet-policy-serviceBot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

CopilotAI reviewed May 28, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates CoreCLR JIT range reasoning so that more intrinsic operations contribute consistent non-negative/range information across value numbering, assertion propagation, and range check elimination.

Changes:

  • Adds a ValueNumStore helper to extract SIMD size/base type from HW-intrinsic VN function apps.
  • Extends IsVNNeverNegative and RangeCheck’s VN-based range extraction to recognize additional HW-intrinsic VNFuncs and bit-counting VNFuncs.
  • Extends RangeCheck and AssertionProp tree-based range modeling for GT_INTRINSIC and GT_HWINTRINSIC bit-counting / extract-msb / element extraction patterns.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

FileDescription
src/coreclr/jit/valuenum.hDeclares new HW-intrinsic VN helper for SIMD size/base type extraction.
src/coreclr/jit/valuenum.cppUses new helper in IsVNNeverNegative and refactors HW-intrinsic VN decoding.
src/coreclr/jit/rangecheck.cppAdds new intrinsic/HW-intrinsic range modeling in VN-based and tree-based range computation.
src/coreclr/jit/assertionprop.cppExtends IntegralRange modeling for long constants, primitive intrinsics, and HW intrinsics.

Comment threadsrc/coreclr/jit/valuenum.cpp Outdated
Comment threadsrc/coreclr/jit/valuenum.cpp Outdated
Comment threadsrc/coreclr/jit/rangecheck.cpp Outdated
CopilotAI review requested due to automatic review settings May 29, 2026 01:16
CopilotAI reviewed May 29, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

Comment threadsrc/coreclr/jit/valuenum.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp Outdated
Comment threadsrc/coreclr/jit/rangecheck.cpp Outdated
@build-analysisbuild-analysisBot mentioned this pull request May 29, 2026
Open
@tannergooding
tannergooding marked this pull request as ready for review May 29, 2026 13:13
CopilotAI review requested due to automatic review settings May 29, 2026 13:13
@tannergooding

tannergooding commented May 29, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

CC. @dotnet/jit-contrib, @EgorBo for review. Another PR around the various range/limit support we have.

Diffs are generally positive, with about half of the -2k bytes of improvements being in tests and the other half being in other collections.

The general improvements come from us being able to drop otherwise unnecessary casts and a few from redundant comparisons, some of which were found in #128677 and inspired this PR.

The ExtractMostSignificantBits helper is the new thing and is particularly prominent since we can know its never negative for any V64/V128 and almost any V256 (barring V256<byte> which has 32 elements).

For the rest, we had some handling already, and so this merges the Arm64/x64 code paths together to reduce duplication in those spots and is otherwise ensuring consistent handling across the locations that produce range/limit information, as we had a split of the handling before which could cause things to be missed.

There is no way for the JIT to determine this range information without us being explicit about it

CopilotAI reviewed May 29, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comment threadsrc/coreclr/jit/valuenum.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
CopilotAI review requested due to automatic review settings May 29, 2026 18:09
CopilotAI reviewed May 29, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comment threadsrc/coreclr/jit/valuenum.cpp
This was referenced May 30, 2026
Open
Open
Open
@tannergooding
tannergooding requested a review from EgorBoJune 1, 2026 13:17
EgorBo
EgorBo reviewed Jun 1, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/valuenum.cpp
EgorBo
EgorBo approved these changes Jun 1, 2026
View reviewed changes

@EgorBoEgorBo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't continue overcomplicating IntegralRange - all niche scenarios like SIMD can be handled only in the VN function which is more powerful, ideally we leave only things that are proved to be useful in the IntegralRange and slowly move away from it.

@tannergooding
tannergooding merged commit 2487b5e into dotnet:mainJun 1, 2026
134 of 139 checks passed
@tannergooding
tannergooding deleted the intrinsic-intrng-fornode branch June 1, 2026 13:58
@tannergoodingtannergooding mentioned this pull request Jun 1, 2026
Closed
CopilotAI mentioned this pull request Jun 1, 2026
Merged
@dotnet-maestrodotnet-maestroBot mentioned this pull request Jun 2, 2026
Merged
@dotnet-milestone-botdotnet-milestone-botBot added this to the 11.0-preview6 milestone Jun 2, 2026
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 2, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@EgorBoEgorBoEgorBo approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding@EgorBo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk by tannergooding · Pull Request #128722 · dotnet/runtime · GitHub
Skip to content
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk - #128722
Merged
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:intrinsic-intrng-fornode
Jun 1, 2026
Merged
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk#128722
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:intrinsic-intrng-fornode
Conversation
@tannergooding
@tannergoodingtannergooding
commented
May 28, 2026

Copy link


Copy Markdown

Member
Found some cases that were getting pessimized in #128677 because we didn't consistently handle different intrinsics across the various places that can produce range information.
CopilotAI
review requested due to automatic review settings
May 28, 2026 19:45
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
May 28, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 28, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
May 28, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates CoreCLR JIT range reasoning so that more intrinsic operations contribute consistent non-negative/range information across value numbering, assertion propagation, and range check elimination.
Changes:
  • Adds a ValueNumStore helper to extract SIMD size/base type from HW-intrinsic VN function apps.
  • Extends IsVNNeverNegative and RangeCheck’s VN-based range extraction to recognize additional HW-intrinsic VNFuncs and bit-counting VNFuncs.
  • Extends RangeCheck and AssertionProp tree-based range modeling for GT_INTRINSIC and GT_HWINTRINSIC bit-counting / extract-msb / element extraction patterns.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
FileDescription
src/coreclr/jit/valuenum.hDeclares new HW-intrinsic VN helper for SIMD size/base type extraction.
src/coreclr/jit/valuenum.cppUses new helper in IsVNNeverNegative and refactors HW-intrinsic VN decoding.
src/coreclr/jit/rangecheck.cppAdds new intrinsic/HW-intrinsic range modeling in VN-based and tree-based range computation.
src/coreclr/jit/assertionprop.cppExtends IntegralRange modeling for long constants, primitive intrinsics, and HW intrinsics.
Comment threadsrc/coreclr/jit/valuenum.cpp
Outdated

Comment threadsrc/coreclr/jit/valuenum.cpp
Outdated

Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

CopilotAI
review requested due to automatic review settings
May 29, 2026 01:16
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
Comment threadsrc/coreclr/jit/valuenum.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 29, 2026

Open

@tannergooding
tannergooding
marked this pull request as ready for review
May 29, 2026 13:13
CopilotAI
review requested due to automatic review settings
May 29, 2026 13:13
@tannergooding
tannergooding
commented
May 29, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
CC. @dotnet/jit-contrib, @EgorBo for review. Another PR around the various range/limit support we have.
Diffs are generally positive, with about half of the -2k bytes of improvements being in tests and the other half being in other collections.
The general improvements come from us being able to drop otherwise unnecessary casts and a few from redundant comparisons, some of which were found in #128677 and inspired this PR.
The ExtractMostSignificantBits helper is the new thing and is particularly prominent since we can know its never negative for any V64/V128 and almost any V256 (barring V256<byte> which has 32 elements).
For the rest, we had some handling already, and so this merges the Arm64/x64 code paths together to reduce duplication in those spots and is otherwise ensuring consistent handling across the locations that produce range/limit information, as we had a split of the handling before which could cause things to be missed.
There is no way for the JIT to determine this range information without us being explicit about it
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comment threadsrc/coreclr/jit/valuenum.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
CopilotAI
review requested due to automatic review settings
May 29, 2026 18:09
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comment threadsrc/coreclr/jit/valuenum.cpp

This was referenced May 30, 2026

Open


Open


Open

@tannergooding
tannergooding
requested a review
from EgorBoJune 1, 2026 13:17
EgorBo
EgorBo
reviewed
Jun 1, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/valuenum.cpp
EgorBo
EgorBo
approved these changes
Jun 1, 2026
View reviewed changes
@EgorBoEgorBo
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't continue overcomplicating IntegralRange - all niche scenarios like SIMD can be handled only in the VN function which is more powerful, ideally we leave only things that are proved to be useful in the IntegralRange and slowly move away from it.
@tannergooding
tannergooding
merged commit 2487b5e
into
dotnet:mainJun 1, 2026

134 of 139 checks passed

@tannergooding
tannergooding
deleted the

intrinsic-intrng-fornode

branch
June 1, 2026 13:58
@tannergoodingtannergooding
mentioned this pull request
Jun 1, 2026

Closed

CopilotAI
mentioned this pull request
Jun 1, 2026
 Merged

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 2, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
Jun 2, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 2, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@EgorBoEgorBoEgorBo approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk by tannergooding · Pull Request #128722 · dotnet/runtime · GitHub
Skip to content
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk - #128722
Merged
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:intrinsic-intrng-fornode
Jun 1, 2026
Merged
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk#128722
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:intrinsic-intrng-fornode
Conversation
@tannergooding
@tannergoodingtannergooding
commented
May 28, 2026

Copy link


Copy Markdown

Member
Found some cases that were getting pessimized in #128677 because we didn't consistently handle different intrinsics across the various places that can produce range information.
CopilotAI
review requested due to automatic review settings
May 28, 2026 19:45
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
May 28, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 28, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
May 28, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates CoreCLR JIT range reasoning so that more intrinsic operations contribute consistent non-negative/range information across value numbering, assertion propagation, and range check elimination.
Changes:
  • Adds a ValueNumStore helper to extract SIMD size/base type from HW-intrinsic VN function apps.
  • Extends IsVNNeverNegative and RangeCheck’s VN-based range extraction to recognize additional HW-intrinsic VNFuncs and bit-counting VNFuncs.
  • Extends RangeCheck and AssertionProp tree-based range modeling for GT_INTRINSIC and GT_HWINTRINSIC bit-counting / extract-msb / element extraction patterns.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
FileDescription
src/coreclr/jit/valuenum.hDeclares new HW-intrinsic VN helper for SIMD size/base type extraction.
src/coreclr/jit/valuenum.cppUses new helper in IsVNNeverNegative and refactors HW-intrinsic VN decoding.
src/coreclr/jit/rangecheck.cppAdds new intrinsic/HW-intrinsic range modeling in VN-based and tree-based range computation.
src/coreclr/jit/assertionprop.cppExtends IntegralRange modeling for long constants, primitive intrinsics, and HW intrinsics.
Comment threadsrc/coreclr/jit/valuenum.cpp
Outdated

Comment threadsrc/coreclr/jit/valuenum.cpp
Outdated

Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

CopilotAI
review requested due to automatic review settings
May 29, 2026 01:16
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
Comment threadsrc/coreclr/jit/valuenum.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 29, 2026

Open

@tannergooding
tannergooding
marked this pull request as ready for review
May 29, 2026 13:13
CopilotAI
review requested due to automatic review settings
May 29, 2026 13:13
@tannergooding
tannergooding
commented
May 29, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
CC. @dotnet/jit-contrib, @EgorBo for review. Another PR around the various range/limit support we have.
Diffs are generally positive, with about half of the -2k bytes of improvements being in tests and the other half being in other collections.
The general improvements come from us being able to drop otherwise unnecessary casts and a few from redundant comparisons, some of which were found in #128677 and inspired this PR.
The ExtractMostSignificantBits helper is the new thing and is particularly prominent since we can know its never negative for any V64/V128 and almost any V256 (barring V256<byte> which has 32 elements).
For the rest, we had some handling already, and so this merges the Arm64/x64 code paths together to reduce duplication in those spots and is otherwise ensuring consistent handling across the locations that produce range/limit information, as we had a split of the handling before which could cause things to be missed.
There is no way for the JIT to determine this range information without us being explicit about it
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comment threadsrc/coreclr/jit/valuenum.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
CopilotAI
review requested due to automatic review settings
May 29, 2026 18:09
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comment threadsrc/coreclr/jit/valuenum.cpp

This was referenced May 30, 2026

Open


Open


Open

@tannergooding
tannergooding
requested a review
from EgorBoJune 1, 2026 13:17
EgorBo
EgorBo
reviewed
Jun 1, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/valuenum.cpp
EgorBo
EgorBo
approved these changes
Jun 1, 2026
View reviewed changes
@EgorBoEgorBo
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't continue overcomplicating IntegralRange - all niche scenarios like SIMD can be handled only in the VN function which is more powerful, ideally we leave only things that are proved to be useful in the IntegralRange and slowly move away from it.
@tannergooding
tannergooding
merged commit 2487b5e
into
dotnet:mainJun 1, 2026

134 of 139 checks passed

@tannergooding
tannergooding
deleted the

intrinsic-intrng-fornode

branch
June 1, 2026 13:58
@tannergoodingtannergooding
mentioned this pull request
Jun 1, 2026

Closed

CopilotAI
mentioned this pull request
Jun 1, 2026
 Merged

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 2, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
Jun 2, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 2, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@EgorBoEgorBoEgorBo approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk by tannergooding · Pull Request #128722 · dotnet/runtime · GitHub
Skip to content
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk - #128722
Merged
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:intrinsic-intrng-fornode
Jun 1, 2026
Merged
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk#128722
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:intrinsic-intrng-fornode
Conversation
@tannergooding
@tannergoodingtannergooding
commented
May 28, 2026

Copy link


Copy Markdown

Member
Found some cases that were getting pessimized in #128677 because we didn't consistently handle different intrinsics across the various places that can produce range information.
CopilotAI
review requested due to automatic review settings
May 28, 2026 19:45
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
May 28, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 28, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
May 28, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates CoreCLR JIT range reasoning so that more intrinsic operations contribute consistent non-negative/range information across value numbering, assertion propagation, and range check elimination.
Changes:
  • Adds a ValueNumStore helper to extract SIMD size/base type from HW-intrinsic VN function apps.
  • Extends IsVNNeverNegative and RangeCheck’s VN-based range extraction to recognize additional HW-intrinsic VNFuncs and bit-counting VNFuncs.
  • Extends RangeCheck and AssertionProp tree-based range modeling for GT_INTRINSIC and GT_HWINTRINSIC bit-counting / extract-msb / element extraction patterns.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
FileDescription
src/coreclr/jit/valuenum.hDeclares new HW-intrinsic VN helper for SIMD size/base type extraction.
src/coreclr/jit/valuenum.cppUses new helper in IsVNNeverNegative and refactors HW-intrinsic VN decoding.
src/coreclr/jit/rangecheck.cppAdds new intrinsic/HW-intrinsic range modeling in VN-based and tree-based range computation.
src/coreclr/jit/assertionprop.cppExtends IntegralRange modeling for long constants, primitive intrinsics, and HW intrinsics.
Comment threadsrc/coreclr/jit/valuenum.cpp
Outdated

Comment threadsrc/coreclr/jit/valuenum.cpp
Outdated

Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

CopilotAI
review requested due to automatic review settings
May 29, 2026 01:16
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
Comment threadsrc/coreclr/jit/valuenum.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 29, 2026

Open

@tannergooding
tannergooding
marked this pull request as ready for review
May 29, 2026 13:13
CopilotAI
review requested due to automatic review settings
May 29, 2026 13:13
@tannergooding
tannergooding
commented
May 29, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
CC. @dotnet/jit-contrib, @EgorBo for review. Another PR around the various range/limit support we have.
Diffs are generally positive, with about half of the -2k bytes of improvements being in tests and the other half being in other collections.
The general improvements come from us being able to drop otherwise unnecessary casts and a few from redundant comparisons, some of which were found in #128677 and inspired this PR.
The ExtractMostSignificantBits helper is the new thing and is particularly prominent since we can know its never negative for any V64/V128 and almost any V256 (barring V256<byte> which has 32 elements).
For the rest, we had some handling already, and so this merges the Arm64/x64 code paths together to reduce duplication in those spots and is otherwise ensuring consistent handling across the locations that produce range/limit information, as we had a split of the handling before which could cause things to be missed.
There is no way for the JIT to determine this range information without us being explicit about it
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comment threadsrc/coreclr/jit/valuenum.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
CopilotAI
review requested due to automatic review settings
May 29, 2026 18:09
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comment threadsrc/coreclr/jit/valuenum.cpp

This was referenced May 30, 2026

Open


Open


Open

@tannergooding
tannergooding
requested a review
from EgorBoJune 1, 2026 13:17
EgorBo
EgorBo
reviewed
Jun 1, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/valuenum.cpp
EgorBo
EgorBo
approved these changes
Jun 1, 2026
View reviewed changes
@EgorBoEgorBo
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't continue overcomplicating IntegralRange - all niche scenarios like SIMD can be handled only in the VN function which is more powerful, ideally we leave only things that are proved to be useful in the IntegralRange and slowly move away from it.
@tannergooding
tannergooding
merged commit 2487b5e
into
dotnet:mainJun 1, 2026

134 of 139 checks passed

@tannergooding
tannergooding
deleted the

intrinsic-intrng-fornode

branch
June 1, 2026 13:58
@tannergoodingtannergooding
mentioned this pull request
Jun 1, 2026

Closed

CopilotAI
mentioned this pull request
Jun 1, 2026
 Merged

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 2, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
Jun 2, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 2, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@EgorBoEgorBoEgorBo approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk by tannergooding · Pull Request #128722 · dotnet/runtime · GitHub
Skip to content
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk - #128722
Merged
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:intrinsic-intrng-fornode
Jun 1, 2026
Merged
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk#128722
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:intrinsic-intrng-fornode
Conversation
@tannergooding
@tannergoodingtannergooding
commented
May 28, 2026

Copy link


Copy Markdown

Member
Found some cases that were getting pessimized in #128677 because we didn't consistently handle different intrinsics across the various places that can produce range information.
CopilotAI
review requested due to automatic review settings
May 28, 2026 19:45
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
May 28, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 28, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
May 28, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates CoreCLR JIT range reasoning so that more intrinsic operations contribute consistent non-negative/range information across value numbering, assertion propagation, and range check elimination.
Changes:
  • Adds a ValueNumStore helper to extract SIMD size/base type from HW-intrinsic VN function apps.
  • Extends IsVNNeverNegative and RangeCheck’s VN-based range extraction to recognize additional HW-intrinsic VNFuncs and bit-counting VNFuncs.
  • Extends RangeCheck and AssertionProp tree-based range modeling for GT_INTRINSIC and GT_HWINTRINSIC bit-counting / extract-msb / element extraction patterns.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
FileDescription
src/coreclr/jit/valuenum.hDeclares new HW-intrinsic VN helper for SIMD size/base type extraction.
src/coreclr/jit/valuenum.cppUses new helper in IsVNNeverNegative and refactors HW-intrinsic VN decoding.
src/coreclr/jit/rangecheck.cppAdds new intrinsic/HW-intrinsic range modeling in VN-based and tree-based range computation.
src/coreclr/jit/assertionprop.cppExtends IntegralRange modeling for long constants, primitive intrinsics, and HW intrinsics.
Comment threadsrc/coreclr/jit/valuenum.cpp
Outdated

Comment threadsrc/coreclr/jit/valuenum.cpp
Outdated

Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

CopilotAI
review requested due to automatic review settings
May 29, 2026 01:16
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
Comment threadsrc/coreclr/jit/valuenum.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 29, 2026

Open

@tannergooding
tannergooding
marked this pull request as ready for review
May 29, 2026 13:13
CopilotAI
review requested due to automatic review settings
May 29, 2026 13:13
@tannergooding
tannergooding
commented
May 29, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
CC. @dotnet/jit-contrib, @EgorBo for review. Another PR around the various range/limit support we have.
Diffs are generally positive, with about half of the -2k bytes of improvements being in tests and the other half being in other collections.
The general improvements come from us being able to drop otherwise unnecessary casts and a few from redundant comparisons, some of which were found in #128677 and inspired this PR.
The ExtractMostSignificantBits helper is the new thing and is particularly prominent since we can know its never negative for any V64/V128 and almost any V256 (barring V256<byte> which has 32 elements).
For the rest, we had some handling already, and so this merges the Arm64/x64 code paths together to reduce duplication in those spots and is otherwise ensuring consistent handling across the locations that produce range/limit information, as we had a split of the handling before which could cause things to be missed.
There is no way for the JIT to determine this range information without us being explicit about it
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comment threadsrc/coreclr/jit/valuenum.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
CopilotAI
review requested due to automatic review settings
May 29, 2026 18:09
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comment threadsrc/coreclr/jit/valuenum.cpp

This was referenced May 30, 2026

Open


Open


Open

@tannergooding
tannergooding
requested a review
from EgorBoJune 1, 2026 13:17
EgorBo
EgorBo
reviewed
Jun 1, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/valuenum.cpp
EgorBo
EgorBo
approved these changes
Jun 1, 2026
View reviewed changes
@EgorBoEgorBo
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't continue overcomplicating IntegralRange - all niche scenarios like SIMD can be handled only in the VN function which is more powerful, ideally we leave only things that are proved to be useful in the IntegralRange and slowly move away from it.
@tannergooding
tannergooding
merged commit 2487b5e
into
dotnet:mainJun 1, 2026

134 of 139 checks passed

@tannergooding
tannergooding
deleted the

intrinsic-intrng-fornode

branch
June 1, 2026 13:58
@tannergoodingtannergooding
mentioned this pull request
Jun 1, 2026

Closed

CopilotAI
mentioned this pull request
Jun 1, 2026
 Merged

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 2, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
Jun 2, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 2, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@EgorBoEgorBoEgorBo approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk by tannergooding · Pull Request #128722 · dotnet/runtime · GitHub
Skip to content
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk - #128722
Merged
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:intrinsic-intrng-fornode
Jun 1, 2026
Merged
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk#128722
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:intrinsic-intrng-fornode
Conversation
@tannergooding
@tannergoodingtannergooding
commented
May 28, 2026

Copy link


Copy Markdown

Member
Found some cases that were getting pessimized in #128677 because we didn't consistently handle different intrinsics across the various places that can produce range information.
CopilotAI
review requested due to automatic review settings
May 28, 2026 19:45
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
May 28, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 28, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
May 28, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates CoreCLR JIT range reasoning so that more intrinsic operations contribute consistent non-negative/range information across value numbering, assertion propagation, and range check elimination.
Changes:
  • Adds a ValueNumStore helper to extract SIMD size/base type from HW-intrinsic VN function apps.
  • Extends IsVNNeverNegative and RangeCheck’s VN-based range extraction to recognize additional HW-intrinsic VNFuncs and bit-counting VNFuncs.
  • Extends RangeCheck and AssertionProp tree-based range modeling for GT_INTRINSIC and GT_HWINTRINSIC bit-counting / extract-msb / element extraction patterns.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
FileDescription
src/coreclr/jit/valuenum.hDeclares new HW-intrinsic VN helper for SIMD size/base type extraction.
src/coreclr/jit/valuenum.cppUses new helper in IsVNNeverNegative and refactors HW-intrinsic VN decoding.
src/coreclr/jit/rangecheck.cppAdds new intrinsic/HW-intrinsic range modeling in VN-based and tree-based range computation.
src/coreclr/jit/assertionprop.cppExtends IntegralRange modeling for long constants, primitive intrinsics, and HW intrinsics.
Comment threadsrc/coreclr/jit/valuenum.cpp
Outdated

Comment threadsrc/coreclr/jit/valuenum.cpp
Outdated

Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

CopilotAI
review requested due to automatic review settings
May 29, 2026 01:16
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
Comment threadsrc/coreclr/jit/valuenum.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 29, 2026

Open

@tannergooding
tannergooding
marked this pull request as ready for review
May 29, 2026 13:13
CopilotAI
review requested due to automatic review settings
May 29, 2026 13:13
@tannergooding
tannergooding
commented
May 29, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
CC. @dotnet/jit-contrib, @EgorBo for review. Another PR around the various range/limit support we have.
Diffs are generally positive, with about half of the -2k bytes of improvements being in tests and the other half being in other collections.
The general improvements come from us being able to drop otherwise unnecessary casts and a few from redundant comparisons, some of which were found in #128677 and inspired this PR.
The ExtractMostSignificantBits helper is the new thing and is particularly prominent since we can know its never negative for any V64/V128 and almost any V256 (barring V256<byte> which has 32 elements).
For the rest, we had some handling already, and so this merges the Arm64/x64 code paths together to reduce duplication in those spots and is otherwise ensuring consistent handling across the locations that produce range/limit information, as we had a split of the handling before which could cause things to be missed.
There is no way for the JIT to determine this range information without us being explicit about it
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comment threadsrc/coreclr/jit/valuenum.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
CopilotAI
review requested due to automatic review settings
May 29, 2026 18:09
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comment threadsrc/coreclr/jit/valuenum.cpp

This was referenced May 30, 2026

Open


Open


Open

@tannergooding
tannergooding
requested a review
from EgorBoJune 1, 2026 13:17
EgorBo
EgorBo
reviewed
Jun 1, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/valuenum.cpp
EgorBo
EgorBo
approved these changes
Jun 1, 2026
View reviewed changes
@EgorBoEgorBo
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't continue overcomplicating IntegralRange - all niche scenarios like SIMD can be handled only in the VN function which is more powerful, ideally we leave only things that are proved to be useful in the IntegralRange and slowly move away from it.
@tannergooding
tannergooding
merged commit 2487b5e
into
dotnet:mainJun 1, 2026

134 of 139 checks passed

@tannergooding
tannergooding
deleted the

intrinsic-intrng-fornode

branch
June 1, 2026 13:58
@tannergoodingtannergooding
mentioned this pull request
Jun 1, 2026

Closed

CopilotAI
mentioned this pull request
Jun 1, 2026
 Merged

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 2, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
Jun 2, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 2, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@EgorBoEgorBoEgorBo approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk by tannergooding · Pull Request #128722 · dotnet/runtime · GitHub
Skip to content
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk - #128722
Merged
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:intrinsic-intrng-fornode
Jun 1, 2026
Merged
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk#128722
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:intrinsic-intrng-fornode
Conversation
@tannergooding
@tannergoodingtannergooding
commented
May 28, 2026

Copy link


Copy Markdown

Member
Found some cases that were getting pessimized in #128677 because we didn't consistently handle different intrinsics across the various places that can produce range information.
CopilotAI
review requested due to automatic review settings
May 28, 2026 19:45
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
May 28, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 28, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
May 28, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates CoreCLR JIT range reasoning so that more intrinsic operations contribute consistent non-negative/range information across value numbering, assertion propagation, and range check elimination.
Changes:
  • Adds a ValueNumStore helper to extract SIMD size/base type from HW-intrinsic VN function apps.
  • Extends IsVNNeverNegative and RangeCheck’s VN-based range extraction to recognize additional HW-intrinsic VNFuncs and bit-counting VNFuncs.
  • Extends RangeCheck and AssertionProp tree-based range modeling for GT_INTRINSIC and GT_HWINTRINSIC bit-counting / extract-msb / element extraction patterns.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
FileDescription
src/coreclr/jit/valuenum.hDeclares new HW-intrinsic VN helper for SIMD size/base type extraction.
src/coreclr/jit/valuenum.cppUses new helper in IsVNNeverNegative and refactors HW-intrinsic VN decoding.
src/coreclr/jit/rangecheck.cppAdds new intrinsic/HW-intrinsic range modeling in VN-based and tree-based range computation.
src/coreclr/jit/assertionprop.cppExtends IntegralRange modeling for long constants, primitive intrinsics, and HW intrinsics.
Comment threadsrc/coreclr/jit/valuenum.cpp
Outdated

Comment threadsrc/coreclr/jit/valuenum.cpp
Outdated

Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

CopilotAI
review requested due to automatic review settings
May 29, 2026 01:16
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
Comment threadsrc/coreclr/jit/valuenum.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 29, 2026

Open

@tannergooding
tannergooding
marked this pull request as ready for review
May 29, 2026 13:13
CopilotAI
review requested due to automatic review settings
May 29, 2026 13:13
@tannergooding
tannergooding
commented
May 29, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
CC. @dotnet/jit-contrib, @EgorBo for review. Another PR around the various range/limit support we have.
Diffs are generally positive, with about half of the -2k bytes of improvements being in tests and the other half being in other collections.
The general improvements come from us being able to drop otherwise unnecessary casts and a few from redundant comparisons, some of which were found in #128677 and inspired this PR.
The ExtractMostSignificantBits helper is the new thing and is particularly prominent since we can know its never negative for any V64/V128 and almost any V256 (barring V256<byte> which has 32 elements).
For the rest, we had some handling already, and so this merges the Arm64/x64 code paths together to reduce duplication in those spots and is otherwise ensuring consistent handling across the locations that produce range/limit information, as we had a split of the handling before which could cause things to be missed.
There is no way for the JIT to determine this range information without us being explicit about it
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comment threadsrc/coreclr/jit/valuenum.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
CopilotAI
review requested due to automatic review settings
May 29, 2026 18:09
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comment threadsrc/coreclr/jit/valuenum.cpp

This was referenced May 30, 2026

Open


Open


Open

@tannergooding
tannergooding
requested a review
from EgorBoJune 1, 2026 13:17
EgorBo
EgorBo
reviewed
Jun 1, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/valuenum.cpp
EgorBo
EgorBo
approved these changes
Jun 1, 2026
View reviewed changes
@EgorBoEgorBo
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't continue overcomplicating IntegralRange - all niche scenarios like SIMD can be handled only in the VN function which is more powerful, ideally we leave only things that are proved to be useful in the IntegralRange and slowly move away from it.
@tannergooding
tannergooding
merged commit 2487b5e
into
dotnet:mainJun 1, 2026

134 of 139 checks passed

@tannergooding
tannergooding
deleted the

intrinsic-intrng-fornode

branch
June 1, 2026 13:58
@tannergoodingtannergooding
mentioned this pull request
Jun 1, 2026

Closed

CopilotAI
mentioned this pull request
Jun 1, 2026
 Merged

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 2, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
Jun 2, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 2, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@EgorBoEgorBoEgorBo approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk by tannergooding · Pull Request #128722 · dotnet/runtime · GitHub
Skip to content
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk - #128722
Merged
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:intrinsic-intrng-fornode
Jun 1, 2026
Merged
Ensure that applicable intrinsics have their ranges tracked by vn/assertionprop/rngchk#128722
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:intrinsic-intrng-fornode
Conversation
@tannergooding
@tannergoodingtannergooding
commented
May 28, 2026

Copy link


Copy Markdown

Member
Found some cases that were getting pessimized in #128677 because we didn't consistently handle different intrinsics across the various places that can produce range information.
CopilotAI
review requested due to automatic review settings
May 28, 2026 19:45
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
May 28, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 28, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
May 28, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates CoreCLR JIT range reasoning so that more intrinsic operations contribute consistent non-negative/range information across value numbering, assertion propagation, and range check elimination.
Changes:
  • Adds a ValueNumStore helper to extract SIMD size/base type from HW-intrinsic VN function apps.
  • Extends IsVNNeverNegative and RangeCheck’s VN-based range extraction to recognize additional HW-intrinsic VNFuncs and bit-counting VNFuncs.
  • Extends RangeCheck and AssertionProp tree-based range modeling for GT_INTRINSIC and GT_HWINTRINSIC bit-counting / extract-msb / element extraction patterns.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
FileDescription
src/coreclr/jit/valuenum.hDeclares new HW-intrinsic VN helper for SIMD size/base type extraction.
src/coreclr/jit/valuenum.cppUses new helper in IsVNNeverNegative and refactors HW-intrinsic VN decoding.
src/coreclr/jit/rangecheck.cppAdds new intrinsic/HW-intrinsic range modeling in VN-based and tree-based range computation.
src/coreclr/jit/assertionprop.cppExtends IntegralRange modeling for long constants, primitive intrinsics, and HW intrinsics.
Comment threadsrc/coreclr/jit/valuenum.cpp
Outdated

Comment threadsrc/coreclr/jit/valuenum.cpp
Outdated

Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

CopilotAI
review requested due to automatic review settings
May 29, 2026 01:16
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
Comment threadsrc/coreclr/jit/valuenum.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

Comment threadsrc/coreclr/jit/rangecheck.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 29, 2026

Open

@tannergooding
tannergooding
marked this pull request as ready for review
May 29, 2026 13:13
CopilotAI
review requested due to automatic review settings
May 29, 2026 13:13
@tannergooding
tannergooding
commented
May 29, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
CC. @dotnet/jit-contrib, @EgorBo for review. Another PR around the various range/limit support we have.
Diffs are generally positive, with about half of the -2k bytes of improvements being in tests and the other half being in other collections.
The general improvements come from us being able to drop otherwise unnecessary casts and a few from redundant comparisons, some of which were found in #128677 and inspired this PR.
The ExtractMostSignificantBits helper is the new thing and is particularly prominent since we can know its never negative for any V64/V128 and almost any V256 (barring V256<byte> which has 32 elements).
For the rest, we had some handling already, and so this merges the Arm64/x64 code paths together to reduce duplication in those spots and is otherwise ensuring consistent handling across the locations that produce range/limit information, as we had a split of the handling before which could cause things to be missed.
There is no way for the JIT to determine this range information without us being explicit about it
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comment threadsrc/coreclr/jit/valuenum.cpp
Comment threadsrc/coreclr/jit/rangecheck.cpp
CopilotAI
review requested due to automatic review settings
May 29, 2026 18:09
CopilotAI
reviewed
May 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comment threadsrc/coreclr/jit/valuenum.cpp

This was referenced May 30, 2026

Open


Open


Open

@tannergooding
tannergooding
requested a review
from EgorBoJune 1, 2026 13:17
EgorBo
EgorBo
reviewed
Jun 1, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/valuenum.cpp
EgorBo
EgorBo
approved these changes
Jun 1, 2026
View reviewed changes
@EgorBoEgorBo
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't continue overcomplicating IntegralRange - all niche scenarios like SIMD can be handled only in the VN function which is more powerful, ideally we leave only things that are proved to be useful in the IntegralRange and slowly move away from it.
@tannergooding
tannergooding
merged commit 2487b5e
into
dotnet:mainJun 1, 2026

134 of 139 checks passed

@tannergooding
tannergooding
deleted the

intrinsic-intrng-fornode

branch
June 1, 2026 13:58
@tannergoodingtannergooding
mentioned this pull request
Jun 1, 2026

Closed

CopilotAI
mentioned this pull request
Jun 1, 2026
 Merged

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 2, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
Jun 2, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 2, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@EgorBoEgorBoEgorBo approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding@EgorBo