Skip to content

[browser][CoreCLR] Gate remaining priority-1 outerloop failures - #131957

Merged
radekdoulik merged 2 commits into
dotnet:mainfrom
radekdoulik:radekdoulik-fix-browser-outerloop
Aug 19, 2026
Merged

[browser][CoreCLR] Gate remaining priority-1 outerloop failures#131957
radekdoulik merged 2 commits into
dotnet:mainfrom
radekdoulik:radekdoulik-fix-browser-outerloop

Conversation

@radekdoulik

@radekdoulikradekdoulik commented Aug 6, 2026

Copy link
Copy Markdown
Member

Summary

Related issues: #131321, #131898, #131925.

Validation

  • Merged and validated current origin/main at 663c457b86ccd35743374676a69de5ed97bc3b14; the Checked browser clr+libs baseline passed with 0 warnings and 0 errors.
  • b65423 passed 3/3: browser default, browser DOTNET_TieredCompilation=0, and native macOS arm64 process-isolated execution, each with expected/actual exit code 100.
  • fieldlayout passed 2/2 in browser default and no-tiered modes after producing and loading its composite Crossgen2/R2R WASM image.
  • Removing the ContextualReflection ActiveIssue reproduced Assert failure: !"OBJECTREF being accessed while thread is in preemptive GC mode." #131925 in 2/2 browser modes; the final gated browser runs passed 2/2, and native ContextualReflection executed successfully.
  • An ungated no-tiered GCEvents run reproduced the expected Process.GetCurrentProcess PlatformNotSupportedException; all four final EventPipe projects were gated from CoreCLR-browser builds.
  • 14/14 representative property evaluations matched the intended scope across CoreCLR browser, CoreCLR macOS, and browser Mono.
  • Final delta: exactly 6 files, 23 insertions, 3 deletions. git diff --check origin/main..HEAD passed.

Note

This pull request description was generated by GitHub Copilot.

Keep b65423's Environment.Exit coverage intact and skip it on CoreCLR
browser while the corerun exit path is tracked separately.
Restore the fieldlayout Crossgen2 bypass because its R2R assertion
occurs before the managed ActiveIssue can run. Gate the unsupported
self-process EventPipe tests and temporarily suppress the
ContextualReflection interpreter failure.
Clarify that Server GC is disabled on CoreCLR browser by design.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 808c6867-a1ea-4256-a003-46c17785ad04
CopilotAI lite review requested due to automatic review settings August 6, 2026 17:04
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@radekdoulikradekdoulik added arch-wasm WebAssembly architecture area-Infrastructure-coreclr Only use for closed issues labels Aug 6, 2026
@radekdoulik

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

CopilotAI reviewed Aug 6, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Note

This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.

Remove the b65423 and fieldlayout suppressions now that dotnet#132078 and
dotnet#132172 fix their underlying CoreCLR browser failures.
Retain the EventPipe, ContextualReflection, and Server GC exclusions
that remain necessary on current main.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 808c6867-a1ea-4256-a003-46c17785ad04
CopilotAI review requested due to automatic review settings August 18, 2026 12:07

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

@radekdoulik

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@radekdoulik

Copy link
Copy Markdown
MemberAuthor

/ba-g the PAL tests failures are unrelated

@radekdoulik
radekdoulik merged commit a7a9b87 into dotnet:mainAug 19, 2026
131 of 139 checks passed
@dotnet-milestone-botdotnet-milestone-botBot added this to the 12.0-preview1 milestone Aug 21, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-wasmWebAssembly architecturearea-Infrastructure-coreclrOnly use for closed issues

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants

@radekdoulik@pavelsavara@akoeplinger