Uh oh!
There was an error while loading. Please reload this page.
Re-enable ContextualReflection test for CoreCLR browser WASM - #133262
Open
davidwrighton with Copilot wants to merge 3 commits into
Open
Re-enable ContextualReflection test for CoreCLR browser WASM#133262davidwrighton with Copilot wants to merge 3 commits into
davidwrighton with Copilot wants to merge 3 commits into
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: davidwrighton <10779849+davidwrighton@users.noreply.github.com>
Co-authored-by: davidwrighton <10779849+davidwrighton@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Re-enable ContextualReflection test for browser WASM targetRe-enable ContextualReflection test for CoreCLR browser WASMSep 4, 2026
davidwrighton
marked this pull request as ready for review
September 4, 2026 21:17
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Tagging subscribers to this area: @steveisok, @dotnet/area-system-reflection |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change only removes redundant gating to re-enable an existing test, without altering test logic or product code paths.
Pull request overview
This PR re-enables the Loader/ContextualReflection test on CoreCLR browser WASM by removing the build-time exclusion and the runtime [ActiveIssue] skip that previously prevented the test from running in that configuration.
Changes:
- Removes the
CLRTestTargetUnsupportedgate forRuntimeFlavor=coreclr+TargetOS=browserso the project is included again for CoreCLR browser runs. - Removes the browser+CoreCLR-specific
[ActiveIssue]onTestEntryPoint, ensuring the test actually executes when the project is re-enabled.
File summaries
| File | Description |
|---|---|
| src/tests/Loader/ContextualReflection/ContextualReflection.csproj | Removes the CoreCLR+browser MSBuild property that marked the test as unsupported. |
| src/tests/Loader/ContextualReflection/ContextualReflection.cs | Removes the browser+CoreCLR ActiveIssue skip so the test runs at runtime again. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loader/ContextualReflectionwas disabled on CoreCLR browser WASM by #132491 due to #131925 (OBJECTREF being accessed while thread is in preemptive GC modeassert). That failure is believed fixed, so the exclusion is removed.Changes
ContextualReflection.csproj— removed theCLRTestTargetUnsupportedcondition forRuntimeFlavor=coreclr+TargetOS=browseradded in Disable ContextualReflection test on browser wasm #132491.ContextualReflection.cs— removed the[ActiveIssue]skip onTestEntryPointfor the same issue, added earlier in [browser][CoreCLR] Gate remaining priority-1 outerloop failures #131957:The issue was gated twice. Dropping only the csproj property would leave the test skipped at runtime on browser WASM, making the change a no-op. No other platform or runtime flavor is affected — the remaining NativeAOT and Mono
ActiveIssueattributes are untouched.Notes for reviewers
-p:TargetOS=browser -p:TargetArchitecture=wasm -p:RuntimeFlavor=coreclr -getProperty:CLRTestTargetUnsupportednow returns empty for this project, while a control project that retains its exclusion still returnstrue. The real signal is the browser WASM CI leg on this PR.Note
This PR description was generated by GitHub Copilot.