Uh oh!
There was an error while loading. Please reload this page.
Strip KBE dedup search suffix noise - #132540
Merged
vitek-karas merged 2 commits intoAug 20, 2026
Merged
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>
Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
CopilotAI
changed the title
[WIP] Strip script-runner/exit-code suffixes in KBE dedup searchStrip KBE dedup search suffix noiseAug 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (2)
.github/workflows/shared/create-kbe.instructions.md:76
- The guardrail says “Only strip the specific … exit-code/signal suffixes described in variation 6”, but variation 6 currently shows specific examples. This can unintentionally constrain stripping to just those example values (e.g., only
exit 101/exit 134). Consider clarifying that this is a suffix pattern (e.g.,exit <code>/SIG<signal>) rather than a fixed enumerated list.
underscore-delimited identifiers; GitHub search does not reliably prefix-match
them. Only strip the specific platform, architecture, type-width,
script-runner, and exit-code/signal suffixes described in variation 6.
.github/workflows/shared/create-kbe.instructions.md:60
- The guidance lists only a few concrete exit codes/signals (e.g.,
exit 101,exit 134,SIGABRT). Since the intent is to dedup the same test across any exit code/signal suffix noise, this can be misread as only stripping those specific values, which would keep producing duplicates for other exit codes/signals.
This issue also appears on line 74 of the same file.
paths, also strip trailing script-runner suffixes (`.cmd`, `.dll`, `.sh`,
`.exe`) and exit-code/signal descriptors (`exit 134`, `exit 101`,
`SIGABRT`); search the bare stem in `in:title` and `in:body`. For example,
search `GC/API/Refresh/Refresh/Refresh` for both
`GC/API/Refresh/Refresh/Refresh` and `GC/API/Refresh/Refresh/Refresh.cmd`
jkoritzinsky
approved these changes
Aug 19, 2026
jkoritzinsky
marked this pull request as ready for review
August 19, 2026 22:27
|
Azure Pipelines: Successfully started running 1 pipeline(s). 15 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
jkoritzinsky
approved these changes
Aug 20, 2026
akoeplinger
approved these changes
Aug 20, 2026
kotlarmilos
approved these changes
Aug 20, 2026
vitek-karas
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The KBE scanner can re-file the same CoreCLR runtime test when failures differ only by script-runner suffix or exit/signal text. This updates the shared existing-KBE search guidance so those variants resolve to the same bare test stem.
Existing-KBE search
.cmd,.dll,.sh, and.exefrom slash-delimited CoreCLR test paths.exit 134,exit 101, andSIGABRT.Examples and guardrails
Refreshandarrres_il_rduplicate patterns.