Skip to content

Strip KBE dedup search suffix noise - #132540

Merged
vitek-karas merged 2 commits into
mainfrom
copilot/strip-script-runner-exit-code-suffixes
Aug 20, 2026
Merged

Strip KBE dedup search suffix noise#132540
vitek-karas merged 2 commits into
mainfrom
copilot/strip-script-runner-exit-code-suffixes

Conversation

CopilotAI commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

The KBE scanner can re-file the same CoreCLR runtime test when failures differ only by script-runner suffix or exit/signal text. This updates the shared existing-KBE search guidance so those variants resolve to the same bare test stem.

  • Existing-KBE search

    • Extends stripped stem variation to remove .cmd, .dll, .sh, and .exe from slash-delimited CoreCLR test paths.
    • Adds exit-code/signal descriptor stripping for cases like exit 134, exit 101, and SIGABRT.
  • Examples and guardrails

    • Documents the Refresh and arrres_il_r duplicate patterns.
    • Updates the suffix-stripping caveat and variation summary to match the new guidance.

CopilotAI lite review requested due to automatic review settings August 19, 2026 22:13

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
16 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>
CopilotAI review requested due to automatic review settings August 19, 2026 22:18
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

CopilotAI changed the title [WIP] Strip script-runner/exit-code suffixes in KBE dedup searchStrip KBE dedup search suffix noiseAug 19, 2026
CopilotAI requested a review from jkoritzinskyAugust 19, 2026 22:19

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (2)

.github/workflows/shared/create-kbe.instructions.md:76

  • The guardrail says “Only strip the specific … exit-code/signal suffixes described in variation 6”, but variation 6 currently shows specific examples. This can unintentionally constrain stripping to just those example values (e.g., only exit 101/exit 134). Consider clarifying that this is a suffix pattern (e.g., exit <code> / SIG<signal>) rather than a fixed enumerated list.
underscore-delimited identifiers; GitHub search does not reliably prefix-match
them. Only strip the specific platform, architecture, type-width,
script-runner, and exit-code/signal suffixes described in variation 6.

.github/workflows/shared/create-kbe.instructions.md:60

  • The guidance lists only a few concrete exit codes/signals (e.g., exit 101, exit 134, SIGABRT). Since the intent is to dedup the same test across any exit code/signal suffix noise, this can be misread as only stripping those specific values, which would keep producing duplicates for other exit codes/signals.

This issue also appears on line 74 of the same file.

 paths, also strip trailing script-runner suffixes (`.cmd`, `.dll`, `.sh`,
`.exe`) and exit-code/signal descriptors (`exit 134`, `exit 101`,
`SIGABRT`); search the bare stem in `in:title` and `in:body`. For example,
search `GC/API/Refresh/Refresh/Refresh` for both
`GC/API/Refresh/Refresh/Refresh` and `GC/API/Refresh/Refresh/Refresh.cmd`

@jkoritzinsky
jkoritzinsky marked this pull request as ready for review August 19, 2026 22:27
@jkoritzinsky
jkoritzinsky requested review from a team and jeffhandley as code ownersAugust 19, 2026 22:27
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
15 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@vitek-karas
vitek-karas merged commit 8adcd25 into mainAug 20, 2026
26 checks passed
@vitek-karas
vitek-karas deleted the copilot/strip-script-runner-exit-code-suffixes branch August 20, 2026 15:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

[ci-scan-feedback] Strip script-runner/exit-code suffixes in KBE dedup search to cut same-test duplicates

6 participants

@akoeplinger@jkoritzinsky@vitek-karas@kotlarmilos