Skip to content

[main] Source code updates from dotnet/runtime - #8563

Open
dotnet-maestro[bot] wants to merge 3 commits into
mainfrom
darc-main-8c23c679-517c-4764-9c8b-f9c0b98500ad
Open

[main] Source code updates from dotnet/runtime#8563
dotnet-maestro[bot] wants to merge 3 commits into
mainfrom
darc-main-8c23c679-517c-4764-9c8b-f9c0b98500ad

Conversation

@dotnet-maestro

Copy link
Copy Markdown
Contributor

Note

This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/runtime

Diff the source with this PR branch
darc vmr diff --name-only https://github.com/dotnet/runtime:a75007fc6175cfb188e338a5553d6f49df906b60..https://github.com/dotnet/dotnet:darc-main-8c23c679-517c-4764-9c8b-f9c0b98500ad

@dotnet-maestro

Copy link
Copy Markdown
ContributorAuthor

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
1 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service
dotnet-policy-serviceBot requested a review from a teamAugust 22, 2026 02:11

@maestro-approvermaestro-approverBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains only source updates from https://github.com/dotnet/runtime.

@akoeplinger

Copy link
Copy Markdown
Member

@copilot fix the build failure on iOSSimulator_Shortstack_arm64

Co-authored-by: akoeplinger <1376924+akoeplinger@users.noreply.github.com>

CopilotAI commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

@copilot fix the build failure on iOSSimulator_Shortstack_arm64

Fixed in ec8f9b6.

Root cause: mono's CMake build adds -D_XOPEN_SOURCE (src/mono/CMakeLists.txt:210), which on Apple hides the non-POSIX pthread_cond_timedwait_relative_np declaration in <pthread.h>, so the new src/native/minipal/conditionvariable.c failed with -Werror=implicit-function-declaration (only in the mono minipal build; coreclr defines _DARWIN_C_SOURCE globally). Defined _DARWIN_C_SOURCE at the top of the file before any system header, matching the existing pattern in src/native/minipal/thread.c. This will need to flow back to dotnet/runtime.

@akoeplinger

Copy link
Copy Markdown
Member

FYI @jkoritzinsky

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@akoeplinger