Skip to content

Add spec: deserializing objects with parameterized ctors - #33095

Merged
layomia merged 5 commits into
dotnet:masterfrom
layomia:parameterized_ctors_spec
Mar 20, 2020
Merged

Add spec: deserializing objects with parameterized ctors#33095
layomia merged 5 commits into
dotnet:masterfrom
layomia:parameterized_ctors_spec

Conversation

@layomia

@layomialayomia commented Mar 3, 2020

Copy link
Copy Markdown
Contributor

Contributes to #29895.

@layomialayomia added this to the 5.0 milestone Mar 3, 2020
@layomialayomia self-assigned this Mar 3, 2020
@layomia
layomiaforce-pushed the parameterized_ctors_spec branch from 3006d2b to 68f22e2CompareMarch 3, 2020 07:04
@layomia
layomiaforce-pushed the parameterized_ctors_spec branch from 68f22e2 to fa1ed91CompareMarch 3, 2020 07:10
steveharter
steveharter reviewed Mar 4, 2020
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/docs/ParameterizedCtorSpec.md Outdated
Comment threadsrc/libraries/System.Text.Json/docs/ParameterizedCtorSpec.md
Comment threadsrc/libraries/System.Text.Json/docs/ParameterizedCtorSpec.md Outdated
Comment threadsrc/libraries/System.Text.Json/docs/ParameterizedCtorSpec.md Outdated
Comment threadsrc/libraries/System.Text.Json/docs/ParameterizedCtorSpec.md Outdated
@layomia
layomiaforce-pushed the parameterized_ctors_spec branch from a913b80 to 9063bf8CompareMarch 6, 2020 04:28
jozkee
jozkee approved these changes Mar 6, 2020
View reviewed changes

@jozkeejozkee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise; looks great.

Comment threadsrc/libraries/System.Text.Json/docs/ParameterizedCtorSpec.md Outdated
Comment threadsrc/libraries/System.Text.Json/docs/ParameterizedCtorSpec.md Outdated
Comment threadsrc/libraries/System.Text.Json/docs/ParameterizedCtorSpec.md Outdated
Comment threadsrc/libraries/System.Text.Json/docs/ParameterizedCtorSpec.md Outdated
Comment threadsrc/libraries/System.Text.Json/docs/ParameterizedCtorSpec.md Outdated
Comment threadsrc/libraries/System.Text.Json/docs/ParameterizedCtorSpec.md Outdated
Comment threadsrc/libraries/System.Text.Json/docs/ParameterizedCtorSpec.md Outdated
@jozkeejozkee added the documentation Documentation bug or enhancement, does not impact product or test code label Mar 6, 2020
terrajobst
terrajobst reviewed Mar 6, 2020
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/docs/ParameterizedCtorSpec.md
with a message stating that objects without public parameterless constructors, including `interface`s and `abstract`
types, are not supported for deserialization. There is no way to deserialize an instance of an object using a parameterized constructor.

A common pattern is to make data objects immutable for various reasons. For example, given `Point`:

@terrajobstterrajobstMar 6, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that this change alone won't support all immutable types. For example, our own immutable collections don't use constructors but factory methods.

terrajobst
terrajobst reviewed Mar 6, 2020
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/docs/ParameterizedCtorSpec.md Outdated
@layomialayomia mentioned this pull request Mar 10, 2020
Merged
campersau
campersau reviewed Mar 12, 2020
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/docs/ParameterizedCtorSpec.md Outdated
@layomia
layomia merged commit a43d6c4 into dotnet:masterMar 20, 2020
@ghostghost locked as resolved and limited conversation to collaborators Dec 10, 2020
@layomia
layomia deleted the parameterized_ctors_spec branch May 18, 2021 07:03
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ericstjericstjericstj left review comments
@jozkeejozkeejozkee approved these changes
@ahsonkhanahsonkhanAwaiting requested review from ahsonkhan
+3 more reviewers
@campersaucampersaucampersau left review comments
@terrajobstterrajobstterrajobst left review comments
@steveharterstevehartersteveharter left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@layomialayomia

Labels

area-System.Text.JsondocumentationDocumentation bug or enhancement, does not impact product or test code

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@layomia@campersau@terrajobst@ahsonkhan@steveharter@ericstj@jozkee