Uh oh!
There was an error while loading. Please reload this page.
Add [JsonConstructor] and support for deserializing with parameterized ctors - #33444
Conversation
Dotnet-GitSync-Bot
commented
Mar 10, 2020
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
steveharter
commented
Mar 12, 2020
Does this degrade perf on the existing benchmarks? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Perf results for existing benchmarks:
|
layomia
commented
Mar 13, 2020
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
layomia
commented
Mar 20, 2020
Test failure unrelated - System.Xml.RW.XmlConvert.Tests. |
Fixes#29895.
Implements specification in #33095.
Performance notes
Benchmarks: dotnet/performance#1233.
TLDR
IndexViewModelandMyEventListerViewModelbenchmarks). There's also a ~300B increase in allocs for these cases. This is due to new state added to theReadStackto support this feature, and a minimal check when pushing/popping stack frames to support fetching ctor arg state on continuation and/or scenarios involving nested objects with parameterized ctors.