Uh oh!
There was an error while loading. Please reload this page.
Enable restore for ref and src projects in libs - #33553
Merged
Merged
Conversation
ViktorHoferforce-pushed
the
RestorePhase2-respin
branch
4 times, most recently
from
March 23, 2020 13:09
5d2c5c0 to
786b7d0CompareViktorHoferforce-pushed
the
RestorePhase2-respin
branch
from
March 23, 2020 16:13
b0c5639 to
b92c5eeCompareViktorHofer
commented
Mar 23, 2020
Uh oh!
There was an error while loading. Please reload this page.
ViktorHofer
marked this pull request as ready for review
March 23, 2020 20:20
ViktorHofer
requested review from
EgorBo, akoeplinger, marek-safar, steveisok and vargaz
as code ownersMarch 23, 2020 20:20
ViktorHofer
requested review from
Anipik and ericstj
and removed request for
EgorBo, akoeplinger, marek-safar, steveisok and vargazMarch 23, 2020 20:21
Anipik
reviewed
Mar 24, 2020
Uh oh!
There was an error while loading. Please reload this page.
Anipik
reviewed
Mar 24, 2020
Uh oh!
There was an error while loading. Please reload this page.
ViktorHoferforce-pushed
the
RestorePhase2-respin
branch
from
March 25, 2020 13:13
307bf7b to
2a00c2cCompareUh oh!
There was an error while loading. Please reload this page.
ViktorHoferforce-pushed
the
RestorePhase2-respin
branch
from
March 26, 2020 20:10
0004237 to
3f7dab3Compareeerhardt
reviewed
Apr 4, 2020
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
Queued an official build: https://dnceng.visualstudio.com/internal/_build/results?buildId=589912 |
ViktorHofer
commented
Apr 6, 2020
MemberAuthor
Failure is #30056 |
ViktorHofer
commented
Apr 6, 2020
MemberAuthor
Internal build succeeded and all previous public runs were green. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second attempt of #33242
Fixes#29953
Contributes towards #31844
Changes
-buildtestsswitch which was only working for libraries in favor of the subset switch-subset testswhich works consistently.Perf
In most cases I see improvements in the overall restore but based on it hitting the network the numbers vary slightly accross builds. That said, this should provide confidence that the regression introduced in the previous attempt is now addressed.
Thoughts on the numbers:
Compared https://dev.azure.com/dnceng/public/_build/results?buildId=582003 with https://dev.azure.com/dnceng/public/_build/results?buildId=583335 and looked into other builds as well to make sure that the before numbers aren't a best or worst case.
cc @jeffkl@ericstj