') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Import Microsoft.Managed targets in Sdk.IL by ViktorHofer · Pull Request #34124 · dotnet/runtime · GitHub
Skip to content

Import Microsoft.Managed targets in Sdk.IL - #34124

Merged
ViktorHofer merged 1 commit into
masterfrom
ViktorHofer-ilsdk
Mar 26, 2020
Merged

Import Microsoft.Managed targets in Sdk.IL#34124
ViktorHofer merged 1 commit into
masterfrom
ViktorHofer-ilsdk

Conversation

@ViktorHofer

@ViktorHoferViktorHofer commented Mar 26, 2020•
edited
Loading

Copy link
Copy Markdown
Member

If Microsoft.Managed targets aren't imported, multitargeting is broken as the required InnerBuildProperty and InnerBuildPropertyValues properties aren't defined. Those properties are read by the Graph APIs to identify if a build is an outer or inner build and multiplexes on them.

This mimics what the CSharp target does: https://github.com/microsoft/msbuild/blob/2d82e1a861d890fce68c8e2d42b569e5bbaf5687/src/Tasks/Microsoft.CSharp.targets#L159-L163

Fixes#34123
Unblocks #33553

🗡 This took me 4h to root cause 🗡

@ViktorHofer
Import Microsoft.Managed targets in Sdk.IL
d985b85
If Microsoft.Managed targets aren't imported, multitargeting is broken as the required `InnerBuildProperty` and `InnerBuildPropertyValues` properties aren't defined. Those properties are read by the Graph APIs to identify if a build is an outer or inner build and multiplexes on them.
Fixes#34123
@ViktorHoferViktorHofer mentioned this pull request Mar 26, 2020
Merged
@ViktorHofer

ViktorHofer commented Mar 26, 2020

Copy link
Copy Markdown
MemberAuthor

Merging as this change isn't exercised in CI and to be able to consume the package in the blocked PR.

@ViktorHofer
ViktorHofer merged commit 3b719ca into masterMar 26, 2020
@ViktorHofer
ViktorHofer deleted the ViktorHofer-ilsdk branch March 26, 2020 13:55
@am11am11 mentioned this pull request Sep 8, 2020
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@ericstjericstjAwaiting requested review from ericstj
@AnipikAnipikAwaiting requested review from Anipik
@jeffkljeffklAwaiting requested review from jeffkl

Assignees

No one assigned

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sdk.IL doesn't import Microsoft.Managed.props/targets which breaks multitargeting

3 participants

@ViktorHofer@akoeplinger@Dotnet-GitSync-Bot