[mono] Make some API functions public and private by lambdageek · Pull Request #33736 · dotnet/runtime

lambdageek · 2020-03-18T20:58:05Z

See #33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4

mono_install_load_aot_data_hook was already a MONO_API, but it was not in a public header.
It is added to mono/jit/mono-private-unstable.h
mono_gc_init_finalizer_thread was used by Xamarin.iOS for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with --disable-visibility-hidden. Make the function a proper MONO_API unconditionally - but make it do nothing if the runtime is compiled without --with-lazy-thread-creation (the default). It is now a public Mono API function.
mono_trace_init was a MONO_API function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as mono_trace_set_log_handler

EgorBo · 2020-03-18T20:59:28Z

heh, I was about to file an issue 🙂

EgorBo · 2020-03-18T21:01:10Z

since #33633 is already merged could you please update runtime.m ? https://github.com/dotnet/runtime/blob/master/src/mono/netcore/sample/iOS/runtime.m#L15-L20

lambdageek · 2020-03-18T21:46:07Z

Verified that the ios sample builds in Xcode.

vargaz · 2020-03-19T01:09:25Z

So we didn't put them in public headers to avoid having to avoid users depending on them and thus having to support them forever.

akoeplinger · 2020-03-19T11:06:41Z

@vargaz you could argue that with XI relying on them we're already on that path. Do you see any of these APIs as particularly problematic?

lambdageek · 2020-03-20T18:36:51Z

new plan:

mono_trace_init is going to stay private. instead i'm going to update mono_trace_set_log_handler and other logging APIs to implicitly initialize the logger so that the iOS sample (and XI) don't need to call it anymore.
mono_gc_init_finalizer_thread will become a public API (there's no other way to work with a --with-lazy-thread-creation runtime)
Move mono_install_load_aot_data_hook to the new mono/jit/mono-private-unstable.h header from [mono] Add headers for unstable APIs #33869

It's already a MONO_API and it is used, for example, by Xamarin.iOS, but it wasn't in a public header. Mark it external only. There are no uses of it inside the runtiem

It was already used by Xamarin.iOS but wasn't in a public header and required compiling with --disable-visibility-hidden in order to dlsym the symbol. If --with-lazy-gc-thread-creation is used, embedders must call this function to create the finalizer therad. Otherwise the function does nothing and the runtime will create the finalizer thread automatically.

It was already marked as MONO_API, but it was not in a public header. It is used by embedders such as Xamarin.iOS

This reverts commit a0cc087.

lambdageek · 2020-03-24T01:33:15Z

Changed this PR to make mono_install_load_aot_data_hook an unstable API, and to make mono_trace_init unnecessary.

@EgorBo could you check that the sample still compiles.

Embedders don't need to call mono_trace_init before calling mono_trace_set_log_handler, mono_trace_set_print_handler or mono_trace_set_printerr_handler

We do not guarantee that this API will be stable

EgorBo · 2020-03-24T10:13:03Z

@lambdageek just checked, compiles and works 👍

lambdageek · 2020-03-18T20:58:05Z

See #33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4

mono_install_load_aot_data_hook was already a MONO_API, but it was not in a public header.
It is added to mono/jit/mono-private-unstable.h
mono_gc_init_finalizer_thread was used by Xamarin.iOS for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with --disable-visibility-hidden. Make the function a proper MONO_API unconditionally - but make it do nothing if the runtime is compiled without --with-lazy-thread-creation (the default). It is now a public Mono API function.
mono_trace_init was a MONO_API function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as mono_trace_set_log_handler

EgorBo · 2020-03-18T20:59:28Z

heh, I was about to file an issue 🙂

EgorBo · 2020-03-18T21:01:10Z

since #33633 is already merged could you please update runtime.m ? https://github.com/dotnet/runtime/blob/master/src/mono/netcore/sample/iOS/runtime.m#L15-L20

lambdageek · 2020-03-18T21:46:07Z

Verified that the ios sample builds in Xcode.

vargaz · 2020-03-19T01:09:25Z

So we didn't put them in public headers to avoid having to avoid users depending on them and thus having to support them forever.

akoeplinger · 2020-03-19T11:06:41Z

@vargaz you could argue that with XI relying on them we're already on that path. Do you see any of these APIs as particularly problematic?

lambdageek · 2020-03-20T18:36:51Z

new plan:

mono_trace_init is going to stay private. instead i'm going to update mono_trace_set_log_handler and other logging APIs to implicitly initialize the logger so that the iOS sample (and XI) don't need to call it anymore.
mono_gc_init_finalizer_thread will become a public API (there's no other way to work with a --with-lazy-thread-creation runtime)
Move mono_install_load_aot_data_hook to the new mono/jit/mono-private-unstable.h header from [mono] Add headers for unstable APIs #33869

It's already a MONO_API and it is used, for example, by Xamarin.iOS, but it wasn't in a public header. Mark it external only. There are no uses of it inside the runtiem

It was already used by Xamarin.iOS but wasn't in a public header and required compiling with --disable-visibility-hidden in order to dlsym the symbol. If --with-lazy-gc-thread-creation is used, embedders must call this function to create the finalizer therad. Otherwise the function does nothing and the runtime will create the finalizer thread automatically.

It was already marked as MONO_API, but it was not in a public header. It is used by embedders such as Xamarin.iOS

This reverts commit a0cc087.

lambdageek · 2020-03-24T01:33:15Z

Changed this PR to make mono_install_load_aot_data_hook an unstable API, and to make mono_trace_init unnecessary.

@EgorBo could you check that the sample still compiles.

Embedders don't need to call mono_trace_init before calling mono_trace_set_log_handler, mono_trace_set_print_handler or mono_trace_set_printerr_handler

We do not guarantee that this API will be stable

EgorBo · 2020-03-24T10:13:03Z

@lambdageek just checked, compiles and works 👍

lambdageek · 2020-03-18T20:58:05Z

See #33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4

mono_install_load_aot_data_hook was already a MONO_API, but it was not in a public header.
It is added to mono/jit/mono-private-unstable.h
mono_gc_init_finalizer_thread was used by Xamarin.iOS for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with --disable-visibility-hidden. Make the function a proper MONO_API unconditionally - but make it do nothing if the runtime is compiled without --with-lazy-thread-creation (the default). It is now a public Mono API function.
mono_trace_init was a MONO_API function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as mono_trace_set_log_handler

EgorBo · 2020-03-18T20:59:28Z

heh, I was about to file an issue 🙂

EgorBo · 2020-03-18T21:01:10Z

since #33633 is already merged could you please update runtime.m ? https://github.com/dotnet/runtime/blob/master/src/mono/netcore/sample/iOS/runtime.m#L15-L20

lambdageek · 2020-03-18T21:46:07Z

Verified that the ios sample builds in Xcode.

vargaz · 2020-03-19T01:09:25Z

So we didn't put them in public headers to avoid having to avoid users depending on them and thus having to support them forever.

akoeplinger · 2020-03-19T11:06:41Z

@vargaz you could argue that with XI relying on them we're already on that path. Do you see any of these APIs as particularly problematic?

lambdageek · 2020-03-20T18:36:51Z

new plan:

mono_trace_init is going to stay private. instead i'm going to update mono_trace_set_log_handler and other logging APIs to implicitly initialize the logger so that the iOS sample (and XI) don't need to call it anymore.
mono_gc_init_finalizer_thread will become a public API (there's no other way to work with a --with-lazy-thread-creation runtime)
Move mono_install_load_aot_data_hook to the new mono/jit/mono-private-unstable.h header from [mono] Add headers for unstable APIs #33869

It's already a MONO_API and it is used, for example, by Xamarin.iOS, but it wasn't in a public header. Mark it external only. There are no uses of it inside the runtiem

It was already used by Xamarin.iOS but wasn't in a public header and required compiling with --disable-visibility-hidden in order to dlsym the symbol. If --with-lazy-gc-thread-creation is used, embedders must call this function to create the finalizer therad. Otherwise the function does nothing and the runtime will create the finalizer thread automatically.

It was already marked as MONO_API, but it was not in a public header. It is used by embedders such as Xamarin.iOS

This reverts commit a0cc087.

lambdageek · 2020-03-24T01:33:15Z

Changed this PR to make mono_install_load_aot_data_hook an unstable API, and to make mono_trace_init unnecessary.

@EgorBo could you check that the sample still compiles.

Embedders don't need to call mono_trace_init before calling mono_trace_set_log_handler, mono_trace_set_print_handler or mono_trace_set_printerr_handler

We do not guarantee that this API will be stable

EgorBo · 2020-03-24T10:13:03Z

@lambdageek just checked, compiles and works 👍

lambdageek · 2020-03-18T20:58:05Z

See #33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4

mono_install_load_aot_data_hook was already a MONO_API, but it was not in a public header.
It is added to mono/jit/mono-private-unstable.h
mono_gc_init_finalizer_thread was used by Xamarin.iOS for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with --disable-visibility-hidden. Make the function a proper MONO_API unconditionally - but make it do nothing if the runtime is compiled without --with-lazy-thread-creation (the default). It is now a public Mono API function.
mono_trace_init was a MONO_API function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as mono_trace_set_log_handler

EgorBo · 2020-03-18T20:59:28Z

heh, I was about to file an issue 🙂

EgorBo · 2020-03-18T21:01:10Z

since #33633 is already merged could you please update runtime.m ? https://github.com/dotnet/runtime/blob/master/src/mono/netcore/sample/iOS/runtime.m#L15-L20

lambdageek · 2020-03-18T21:46:07Z

Verified that the ios sample builds in Xcode.

vargaz · 2020-03-19T01:09:25Z

So we didn't put them in public headers to avoid having to avoid users depending on them and thus having to support them forever.

akoeplinger · 2020-03-19T11:06:41Z

@vargaz you could argue that with XI relying on them we're already on that path. Do you see any of these APIs as particularly problematic?

lambdageek · 2020-03-20T18:36:51Z

new plan:

mono_trace_init is going to stay private. instead i'm going to update mono_trace_set_log_handler and other logging APIs to implicitly initialize the logger so that the iOS sample (and XI) don't need to call it anymore.
mono_gc_init_finalizer_thread will become a public API (there's no other way to work with a --with-lazy-thread-creation runtime)
Move mono_install_load_aot_data_hook to the new mono/jit/mono-private-unstable.h header from [mono] Add headers for unstable APIs #33869

It's already a MONO_API and it is used, for example, by Xamarin.iOS, but it wasn't in a public header. Mark it external only. There are no uses of it inside the runtiem

It was already used by Xamarin.iOS but wasn't in a public header and required compiling with --disable-visibility-hidden in order to dlsym the symbol. If --with-lazy-gc-thread-creation is used, embedders must call this function to create the finalizer therad. Otherwise the function does nothing and the runtime will create the finalizer thread automatically.

It was already marked as MONO_API, but it was not in a public header. It is used by embedders such as Xamarin.iOS

This reverts commit a0cc087.

lambdageek · 2020-03-24T01:33:15Z

Changed this PR to make mono_install_load_aot_data_hook an unstable API, and to make mono_trace_init unnecessary.

@EgorBo could you check that the sample still compiles.

Embedders don't need to call mono_trace_init before calling mono_trace_set_log_handler, mono_trace_set_print_handler or mono_trace_set_printerr_handler

We do not guarantee that this API will be stable

EgorBo · 2020-03-24T10:13:03Z

@lambdageek just checked, compiles and works 👍

lambdageek · 2020-03-18T20:58:05Z

See #33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4

mono_install_load_aot_data_hook was already a MONO_API, but it was not in a public header.
It is added to mono/jit/mono-private-unstable.h
mono_gc_init_finalizer_thread was used by Xamarin.iOS for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with --disable-visibility-hidden. Make the function a proper MONO_API unconditionally - but make it do nothing if the runtime is compiled without --with-lazy-thread-creation (the default). It is now a public Mono API function.
mono_trace_init was a MONO_API function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as mono_trace_set_log_handler

EgorBo · 2020-03-18T20:59:28Z

heh, I was about to file an issue 🙂

EgorBo · 2020-03-18T21:01:10Z

since #33633 is already merged could you please update runtime.m ? https://github.com/dotnet/runtime/blob/master/src/mono/netcore/sample/iOS/runtime.m#L15-L20

lambdageek · 2020-03-18T21:46:07Z

Verified that the ios sample builds in Xcode.

vargaz · 2020-03-19T01:09:25Z

So we didn't put them in public headers to avoid having to avoid users depending on them and thus having to support them forever.

akoeplinger · 2020-03-19T11:06:41Z

@vargaz you could argue that with XI relying on them we're already on that path. Do you see any of these APIs as particularly problematic?

lambdageek · 2020-03-20T18:36:51Z

new plan:

mono_trace_init is going to stay private. instead i'm going to update mono_trace_set_log_handler and other logging APIs to implicitly initialize the logger so that the iOS sample (and XI) don't need to call it anymore.
mono_gc_init_finalizer_thread will become a public API (there's no other way to work with a --with-lazy-thread-creation runtime)
Move mono_install_load_aot_data_hook to the new mono/jit/mono-private-unstable.h header from [mono] Add headers for unstable APIs #33869

It's already a MONO_API and it is used, for example, by Xamarin.iOS, but it wasn't in a public header. Mark it external only. There are no uses of it inside the runtiem

It was already used by Xamarin.iOS but wasn't in a public header and required compiling with --disable-visibility-hidden in order to dlsym the symbol. If --with-lazy-gc-thread-creation is used, embedders must call this function to create the finalizer therad. Otherwise the function does nothing and the runtime will create the finalizer thread automatically.

It was already marked as MONO_API, but it was not in a public header. It is used by embedders such as Xamarin.iOS

This reverts commit a0cc087.

lambdageek · 2020-03-24T01:33:15Z

Changed this PR to make mono_install_load_aot_data_hook an unstable API, and to make mono_trace_init unnecessary.

@EgorBo could you check that the sample still compiles.

Embedders don't need to call mono_trace_init before calling mono_trace_set_log_handler, mono_trace_set_print_handler or mono_trace_set_printerr_handler

We do not guarantee that this API will be stable

EgorBo · 2020-03-24T10:13:03Z

@lambdageek just checked, compiles and works 👍

lambdageek · 2020-03-18T20:58:05Z

See #33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4

mono_install_load_aot_data_hook was already a MONO_API, but it was not in a public header.
It is added to mono/jit/mono-private-unstable.h
mono_gc_init_finalizer_thread was used by Xamarin.iOS for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with --disable-visibility-hidden. Make the function a proper MONO_API unconditionally - but make it do nothing if the runtime is compiled without --with-lazy-thread-creation (the default). It is now a public Mono API function.
mono_trace_init was a MONO_API function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as mono_trace_set_log_handler

EgorBo · 2020-03-18T20:59:28Z

heh, I was about to file an issue 🙂

EgorBo · 2020-03-18T21:01:10Z

since #33633 is already merged could you please update runtime.m ? https://github.com/dotnet/runtime/blob/master/src/mono/netcore/sample/iOS/runtime.m#L15-L20

lambdageek · 2020-03-18T21:46:07Z

Verified that the ios sample builds in Xcode.

vargaz · 2020-03-19T01:09:25Z

So we didn't put them in public headers to avoid having to avoid users depending on them and thus having to support them forever.

akoeplinger · 2020-03-19T11:06:41Z

@vargaz you could argue that with XI relying on them we're already on that path. Do you see any of these APIs as particularly problematic?

lambdageek · 2020-03-20T18:36:51Z

new plan:

mono_trace_init is going to stay private. instead i'm going to update mono_trace_set_log_handler and other logging APIs to implicitly initialize the logger so that the iOS sample (and XI) don't need to call it anymore.
mono_gc_init_finalizer_thread will become a public API (there's no other way to work with a --with-lazy-thread-creation runtime)
Move mono_install_load_aot_data_hook to the new mono/jit/mono-private-unstable.h header from [mono] Add headers for unstable APIs #33869

It's already a MONO_API and it is used, for example, by Xamarin.iOS, but it wasn't in a public header. Mark it external only. There are no uses of it inside the runtiem

It was already used by Xamarin.iOS but wasn't in a public header and required compiling with --disable-visibility-hidden in order to dlsym the symbol. If --with-lazy-gc-thread-creation is used, embedders must call this function to create the finalizer therad. Otherwise the function does nothing and the runtime will create the finalizer thread automatically.

It was already marked as MONO_API, but it was not in a public header. It is used by embedders such as Xamarin.iOS

This reverts commit a0cc087.

lambdageek · 2020-03-24T01:33:15Z

Changed this PR to make mono_install_load_aot_data_hook an unstable API, and to make mono_trace_init unnecessary.

@EgorBo could you check that the sample still compiles.

Embedders don't need to call mono_trace_init before calling mono_trace_set_log_handler, mono_trace_set_print_handler or mono_trace_set_printerr_handler

We do not guarantee that this API will be stable

EgorBo · 2020-03-24T10:13:03Z

@lambdageek just checked, compiles and works 👍

lambdageek · 2020-03-18T20:58:05Z

See #33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4

mono_install_load_aot_data_hook was already a MONO_API, but it was not in a public header.
It is added to mono/jit/mono-private-unstable.h
mono_gc_init_finalizer_thread was used by Xamarin.iOS for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with --disable-visibility-hidden. Make the function a proper MONO_API unconditionally - but make it do nothing if the runtime is compiled without --with-lazy-thread-creation (the default). It is now a public Mono API function.
mono_trace_init was a MONO_API function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as mono_trace_set_log_handler

EgorBo · 2020-03-18T20:59:28Z

heh, I was about to file an issue 🙂

EgorBo · 2020-03-18T21:01:10Z

since #33633 is already merged could you please update runtime.m ? https://github.com/dotnet/runtime/blob/master/src/mono/netcore/sample/iOS/runtime.m#L15-L20

lambdageek · 2020-03-18T21:46:07Z

Verified that the ios sample builds in Xcode.

vargaz · 2020-03-19T01:09:25Z

So we didn't put them in public headers to avoid having to avoid users depending on them and thus having to support them forever.

akoeplinger · 2020-03-19T11:06:41Z

@vargaz you could argue that with XI relying on them we're already on that path. Do you see any of these APIs as particularly problematic?

lambdageek · 2020-03-20T18:36:51Z

new plan:

mono_trace_init is going to stay private. instead i'm going to update mono_trace_set_log_handler and other logging APIs to implicitly initialize the logger so that the iOS sample (and XI) don't need to call it anymore.
mono_gc_init_finalizer_thread will become a public API (there's no other way to work with a --with-lazy-thread-creation runtime)
Move mono_install_load_aot_data_hook to the new mono/jit/mono-private-unstable.h header from [mono] Add headers for unstable APIs #33869

It's already a MONO_API and it is used, for example, by Xamarin.iOS, but it wasn't in a public header. Mark it external only. There are no uses of it inside the runtiem

It was already used by Xamarin.iOS but wasn't in a public header and required compiling with --disable-visibility-hidden in order to dlsym the symbol. If --with-lazy-gc-thread-creation is used, embedders must call this function to create the finalizer therad. Otherwise the function does nothing and the runtime will create the finalizer thread automatically.

It was already marked as MONO_API, but it was not in a public header. It is used by embedders such as Xamarin.iOS

This reverts commit a0cc087.

lambdageek · 2020-03-24T01:33:15Z

Changed this PR to make mono_install_load_aot_data_hook an unstable API, and to make mono_trace_init unnecessary.

@EgorBo could you check that the sample still compiles.

Embedders don't need to call mono_trace_init before calling mono_trace_set_log_handler, mono_trace_set_print_handler or mono_trace_set_printerr_handler

We do not guarantee that this API will be stable

EgorBo · 2020-03-24T10:13:03Z

@lambdageek just checked, compiles and works 👍

lambdageek · 2020-03-18T20:58:05Z

See #33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4

mono_install_load_aot_data_hook was already a MONO_API, but it was not in a public header.
It is added to mono/jit/mono-private-unstable.h
mono_gc_init_finalizer_thread was used by Xamarin.iOS for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with --disable-visibility-hidden. Make the function a proper MONO_API unconditionally - but make it do nothing if the runtime is compiled without --with-lazy-thread-creation (the default). It is now a public Mono API function.
mono_trace_init was a MONO_API function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as mono_trace_set_log_handler

EgorBo · 2020-03-18T20:59:28Z

heh, I was about to file an issue 🙂

EgorBo · 2020-03-18T21:01:10Z

since #33633 is already merged could you please update runtime.m ? https://github.com/dotnet/runtime/blob/master/src/mono/netcore/sample/iOS/runtime.m#L15-L20

lambdageek · 2020-03-18T21:46:07Z

Verified that the ios sample builds in Xcode.

vargaz · 2020-03-19T01:09:25Z

So we didn't put them in public headers to avoid having to avoid users depending on them and thus having to support them forever.

akoeplinger · 2020-03-19T11:06:41Z

@vargaz you could argue that with XI relying on them we're already on that path. Do you see any of these APIs as particularly problematic?

lambdageek · 2020-03-20T18:36:51Z

new plan:

mono_trace_init is going to stay private. instead i'm going to update mono_trace_set_log_handler and other logging APIs to implicitly initialize the logger so that the iOS sample (and XI) don't need to call it anymore.
mono_gc_init_finalizer_thread will become a public API (there's no other way to work with a --with-lazy-thread-creation runtime)
Move mono_install_load_aot_data_hook to the new mono/jit/mono-private-unstable.h header from [mono] Add headers for unstable APIs #33869

It's already a MONO_API and it is used, for example, by Xamarin.iOS, but it wasn't in a public header. Mark it external only. There are no uses of it inside the runtiem

It was already used by Xamarin.iOS but wasn't in a public header and required compiling with --disable-visibility-hidden in order to dlsym the symbol. If --with-lazy-gc-thread-creation is used, embedders must call this function to create the finalizer therad. Otherwise the function does nothing and the runtime will create the finalizer thread automatically.

It was already marked as MONO_API, but it was not in a public header. It is used by embedders such as Xamarin.iOS

This reverts commit a0cc087.

lambdageek · 2020-03-24T01:33:15Z

Changed this PR to make mono_install_load_aot_data_hook an unstable API, and to make mono_trace_init unnecessary.

@EgorBo could you check that the sample still compiles.

Embedders don't need to call mono_trace_init before calling mono_trace_set_log_handler, mono_trace_set_print_handler or mono_trace_set_printerr_handler

We do not guarantee that this API will be stable

EgorBo · 2020-03-24T10:13:03Z

@lambdageek just checked, compiles and works 👍

lambdageek requested review from CoffeeFlux, SamMonoRT, alexischr, lewurm, thaystg and vargaz as code owners March 18, 2020 20:58

Dotnet-GitSync-Bot added the area-VM-meta-mono label Mar 18, 2020

lambdageek mentioned this pull request Mar 18, 2020
[mono] Add iOS sample (AOT, arm64) #33633
Merged

monojenkins mentioned this pull request Mar 18, 2020
[mono] Make some API functions public and private mono/mono#19259
Merged

lambdageek force-pushed the add-xi-nonpublic-apis branch from 241e949 to 3df6e71Compare March 18, 2020 21:08

lambdageek requested review from EgorBo, akoeplinger, marek-safar and steveisok as code owners March 18, 2020 21:08

lambdageek force-pushed the add-xi-nonpublic-apis branch 2 times, most recently from 3e42c06 to 93a416aCompare March 18, 2020 21:32

EgorBo approved these changes Mar 18, 2020
View reviewed changes

lambdageek mentioned this pull request Mar 20, 2020
[mono] Add headers for unstable APIs #33869
Merged

lambdageek changed the title ~~[mono] Make some API functions public~~wip: [mono] Make some API functions publicMar 20, 2020

lambdageekand others added 5 commits March 23, 2020 21:10

[mini] Move mono_install_load_aot_data_hook to a public header
92290b1
It's already a MONO_API and it is used, for example, by Xamarin.iOS, but it wasn't in a public header. Mark it external only. There are no uses of it inside the runtiem

[utils] Move mono_trace_init to a public header
a0cc087
It was already marked as MONO_API, but it was not in a public header. It is used by embedders such as Xamarin.iOS

Update ios sample
9b80efe

Revert "[utils] Move mono_trace_init to a public header"
c7cf3af
This reverts commit a0cc087.

lambdageek force-pushed the add-xi-nonpublic-apis branch from 93a416a to c037a3eCompare March 24, 2020 01:29

lambdageek changed the title ~~wip: [mono] Make some API functions public~~[mono] Make some API functions public and privateMar 24, 2020

lambdageek requested a review from EgorBo March 24, 2020 01:32

lambdageek added 2 commits March 23, 2020 21:35

[utils] init mono_logger in all public API functions
6e3f02f
Embedders don't need to call mono_trace_init before calling mono_trace_set_log_handler, mono_trace_set_print_handler or mono_trace_set_printerr_handler

[jit] Move mono_install_load_aot_data_hook to mono-private-unstable.h
7dfc6ef
We do not guarantee that this API will be stable

lambdageek force-pushed the add-xi-nonpublic-apis branch from c037a3e to 7dfc6efCompare March 24, 2020 01:35

EgorBo approved these changes Mar 24, 2020
View reviewed changes

lambdageek merged commit c1686da into dotnet:masterMar 24, 2020

ghost locked as resolved and limited conversation to collaborators Dec 10, 2020

lambdageek deleted the add-xi-nonpublic-apis branch March 7, 2021 21:54