Skip to content

[mono] Add iOS sample (AOT, arm64) - #33633

Merged
EgorBo merged 15 commits into
dotnet:masterfrom
EgorBo:ios-sample
Mar 18, 2020
Merged

[mono] Add iOS sample (AOT, arm64)#33633
EgorBo merged 15 commits into
dotnet:masterfrom
EgorBo:ios-sample

Conversation

@EgorBo

@EgorBoEgorBo commented Mar 16, 2020•
edited
Loading

Copy link
Copy Markdown
Member

I'd like to add a minimal Full AOT sample for iOS (to our mono/netcore/sample directory).
I decided to add it as an xcode project to be able to easily open & debug/deploy on a device.
Such samples are useful for experiments and debug purposes (I use it in order to debug issues in corefx tests).

Steps to run the sample:

./build.sh -os iOS -arch arm64
cd src/mono/netcore/sample/iOS
make xcode
# now you can open the xcode project and deploy/debug the sample

Безымянный проект

However, xcode files are quite verbose so probably makes sense to generate the project via cmake.
What do you think @akoeplinger@steveisok@marek-safar do we need the sample in the repo?
UPD replaced with CMake.

EgorBo
EgorBo commented Mar 16, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
// a kind of an animation
ios_set_text (msg.Substring (0, i + 1));
await Task.Delay (100);
}

@EgorBoEgorBoMar 16, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how text is animated (see gif)

@EgorBoEgorBo added os-ios Apple iOS and removed os-ios Apple iOS labels Mar 16, 2020
marek-safar
marek-safar reviewed Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/HelloiOS/runtime.m
static os_log_t stdout_log;

/* These are not in public headers */
typedef unsigned char* (*MonoLoadAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void **out_handle);

@marek-safarmarek-safarMar 17, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lambdageek could this be fixed?

@akoeplingerakoeplingerMar 18, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes let's file an issue about this, we shouldn't need to rely on private functions.

marek-safar
marek-safar reviewed Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/HelloiOS/runtime.m Outdated
marek-safar
marek-safar reviewed Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
using System.Threading.Tasks;
using System.Runtime.InteropServices;

public class MonoPInvokeCallbackAttribute : Attribute

@marek-safarmarek-safarMar 17, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to avoid this and use NativeCallableAttribute

@vargaz could you please check where we are with the support of mono/mono#17479

@EgorBoEgorBoMar 17, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it basically same thing? but yeah NativeCallableAttribute sounds better.

@stephentoub

stephentoub commented Mar 17, 2020

Copy link
Copy Markdown
Member

Neat

stephentoub
stephentoub reviewed Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs Outdated
akoeplinger
akoeplinger approved these changes Mar 18, 2020
View reviewed changes

@akoeplingerakoeplinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a few nits.

Comment threadsrc/mono/netcore/sample/iOS/Makefile Outdated
Comment threadsrc/mono/netcore/sample/iOS/Plist.in Outdated
Comment threadsrc/mono/netcore/sample/iOS/Program.cs Outdated
Comment threadsrc/mono/netcore/sample/iOS/Program.csproj Outdated
Comment threadsrc/mono/netcore/sample/iOS/Program.csproj Outdated
Comment threadsrc/mono/netcore/sample/iOS/runtime.m Outdated
@EgorBo
EgorBo merged commit 67d1cb6 into dotnet:masterMar 18, 2020
@lambdageeklambdageek mentioned this pull request Mar 18, 2020
Merged
lambdageek
lambdageek reviewed Mar 18, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/runtime.m
Comment on lines +15 to +20
/* These are not in public headers */
typedef unsigned char* (*MonoLoadAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void **out_handle);
typedef void (*MonoFreeAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void *handle);
void mono_install_load_aot_data_hook (MonoLoadAotDataFunc load_func, MonoFreeAotDataFunc free_func, void *user_data);
void mono_trace_init (void);
void mono_gc_init_finalizer_thread (void);

@lambdageeklambdageekMar 18, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #33736

@monojenkinsmonojenkins mentioned this pull request Mar 18, 2020
Merged
@EgorBoEgorBo mentioned this pull request Mar 18, 2020
Merged
@steveisoksteveisok mentioned this pull request Mar 21, 2020
Closed
4 tasks
monojenkins pushed a commit to monojenkins/mono that referenced this pull request Mar 24, 2020
@lambdageek
[mono] Make some API functions public and private
dff5ab9
See dotnet/runtime#33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4
* `mono_install_load_aot_data_hook` was already a `MONO_API`, but it was not in a public header.
It is added to `mono/jit/mono-private-unstable.h`
* `mono_gc_init_finalizer_thread` was [used by Xamarin.iOS](https://github.com/xamarin/xamarin-macios/blob/63ab48e679716264b33af00f86c24426da1d9f97/runtime/mono-runtime.h.t4#L278) for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with `--disable-visibility-hidden`. Make the function a proper `MONO_API` unconditionally - but make it do nothing if the runtime is compiled without `--with-lazy-thread-creation` (the default). It is now a public Mono API function.
* `mono_trace_init` was a `MONO_API` function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as `mono_trace_set_log_handler`
lambdageek added a commit to mono/mono that referenced this pull request Mar 24, 2020
@monojenkins@lambdageek
[mono] Make some API functions public and private (#19259)
1425b4d
See dotnet/runtime#33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4
* `mono_install_load_aot_data_hook` was already a `MONO_API`, but it was not in a public header.
It is added to `mono/jit/mono-private-unstable.h`
* `mono_gc_init_finalizer_thread` was [used by Xamarin.iOS](https://github.com/xamarin/xamarin-macios/blob/63ab48e679716264b33af00f86c24426da1d9f97/runtime/mono-runtime.h.t4#L278) for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with `--disable-visibility-hidden`. Make the function a proper `MONO_API` unconditionally - but make it do nothing if the runtime is compiled without `--with-lazy-thread-creation` (the default). It is now a public Mono API function.
* `mono_trace_init` was a `MONO_API` function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as `mono_trace_set_log_handler`
Co-authored-by: lambdageek <lambdageek@users.noreply.github.com>
@ghostghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@lambdageeklambdageeklambdageek left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@stephentoubstephentoubstephentoub left review comments
@steveisoksteveisokAwaiting requested review from steveisok
@vargazvargazAwaiting requested review from vargaz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@EgorBo@stephentoub@marek-safar@lambdageek@akoeplinger@Dotnet-GitSync-Bot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[mono] Add iOS sample (AOT, arm64) by EgorBo · Pull Request #33633 · dotnet/runtime · GitHub
Skip to content
[mono] Add iOS sample (AOT, arm64) - #33633
Merged
EgorBo merged 15 commits into
dotnet:masterfrom 
EgorBo:ios-sample
Mar 18, 2020
Merged
[mono] Add iOS sample (AOT, arm64)#33633
EgorBo merged 15 commits into
dotnet:masterfrom 
EgorBo:ios-sample
Conversation
@EgorBo
@EgorBoEgorBo
commented
Mar 16, 2020•

edited

Loading

Copy link


Copy Markdown

Member
I'd like to add a minimal Full AOT sample for iOS (to our mono/netcore/sample directory).

I decided to add it as an xcode project to be able to easily open & debug/deploy on a device.

Such samples are useful for experiments and debug purposes (I use it in order to debug issues in corefx tests).
Steps to run the sample:
./build.sh -os iOS -arch arm64
cd src/mono/netcore/sample/iOS
make xcode
# now you can open the xcode project and deploy/debug the sample
Безымянный проект
However, xcode files are quite verbose so probably makes sense to generate the project via cmake.

What do you think @akoeplinger@steveisok@marek-safar do we need the sample in the repo?
UPD replaced with CMake.
EgorBo
EgorBo
commented
Mar 16, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
 // a kind of an animation
 ios_set_text (msg.Substring (0, i + 1));
 await Task.Delay (100);
 }
@EgorBoEgorBoMar 16, 2020

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how text is animated (see gif)
@EgorBoEgorBo
added

os-ios
Apple iOS
and removed

os-ios
Apple iOS
labels
Mar 16, 2020
marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/HelloiOS/runtime.m
static os_log_t stdout_log;

/* These are not in public headers */
typedef unsigned char* (*MonoLoadAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void **out_handle);
@marek-safarmarek-safarMar 17, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lambdageek could this be fixed?
@akoeplingerakoeplingerMar 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes let's file an issue about this, we shouldn't need to rely on private functions.
marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/HelloiOS/runtime.m
Outdated

marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
using System.Threading.Tasks;
using System.Runtime.InteropServices;

public class MonoPInvokeCallbackAttribute : Attribute
@marek-safarmarek-safarMar 17, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to avoid this and use NativeCallableAttribute
@vargaz could you please check where we are with the support of mono/mono#17479
@EgorBoEgorBoMar 17, 2020

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it basically same thing? but yeah NativeCallableAttribute sounds better.
@stephentoub
stephentoub
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
Neat
stephentoub
stephentoub
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
Outdated

akoeplinger
akoeplinger
approved these changes
Mar 18, 2020
View reviewed changes
@akoeplingerakoeplinger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a few nits.
Comment threadsrc/mono/netcore/sample/iOS/Makefile
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Plist.in
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.cs
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.csproj
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.csproj
Outdated

Comment threadsrc/mono/netcore/sample/iOS/runtime.m
Outdated

@EgorBo
EgorBo
merged commit 67d1cb6
into
dotnet:masterMar 18, 2020
@lambdageeklambdageek
mentioned this pull request
Mar 18, 2020
 Merged

lambdageek
lambdageek
reviewed
Mar 18, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/runtime.m

Comment on lines

+15
 to 
+20

/* These are not in public headers */
typedef unsigned char* (*MonoLoadAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void **out_handle);
typedef void (*MonoFreeAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void *handle);
void mono_install_load_aot_data_hook (MonoLoadAotDataFunc load_func, MonoFreeAotDataFunc free_func, void *user_data);
void mono_trace_init (void);
void mono_gc_init_finalizer_thread (void);
@lambdageeklambdageekMar 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #33736
@monojenkinsmonojenkins
mentioned this pull request
Mar 18, 2020
 Merged

@EgorBoEgorBo
mentioned this pull request
Mar 18, 2020
 Merged

@steveisoksteveisok
mentioned this pull request
Mar 21, 2020

Closed

4 tasks
monojenkins pushed a commit
to monojenkins/mono
that referenced
this pull request
Mar 24, 2020
@lambdageek
[mono] Make some API functions public and private
dff5ab9
See dotnet/runtime#33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4
* `mono_install_load_aot_data_hook` was already a `MONO_API`, but it was not in a public header.
It is added to `mono/jit/mono-private-unstable.h`
* `mono_gc_init_finalizer_thread` was [used by Xamarin.iOS](https://github.com/xamarin/xamarin-macios/blob/63ab48e679716264b33af00f86c24426da1d9f97/runtime/mono-runtime.h.t4#L278) for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with `--disable-visibility-hidden`. Make the function a proper `MONO_API` unconditionally - but make it do nothing if the runtime is compiled without `--with-lazy-thread-creation` (the default). It is now a public Mono API function.
* `mono_trace_init` was a `MONO_API` function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as `mono_trace_set_log_handler`
lambdageek added a commit
to mono/mono
that referenced
this pull request
Mar 24, 2020
@monojenkins@lambdageek
[mono] Make some API functions public and private (#19259)
1425b4d
See dotnet/runtime#33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4
* `mono_install_load_aot_data_hook` was already a `MONO_API`, but it was not in a public header.
It is added to `mono/jit/mono-private-unstable.h`
* `mono_gc_init_finalizer_thread` was [used by Xamarin.iOS](https://github.com/xamarin/xamarin-macios/blob/63ab48e679716264b33af00f86c24426da1d9f97/runtime/mono-runtime.h.t4#L278) for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with `--disable-visibility-hidden`. Make the function a proper `MONO_API` unconditionally - but make it do nothing if the runtime is compiled without `--with-lazy-thread-creation` (the default). It is now a public Mono API function.
* `mono_trace_init` was a `MONO_API` function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as `mono_trace_set_log_handler`
Co-authored-by: lambdageek <lambdageek@users.noreply.github.com>
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@lambdageeklambdageeklambdageek left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@stephentoubstephentoubstephentoub left review comments
@steveisoksteveisokAwaiting requested review from steveisok
@vargazvargazAwaiting requested review from vargaz

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@EgorBo@stephentoub@marek-safar@lambdageek@akoeplinger@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[mono] Add iOS sample (AOT, arm64) by EgorBo · Pull Request #33633 · dotnet/runtime · GitHub
Skip to content
[mono] Add iOS sample (AOT, arm64) - #33633
Merged
EgorBo merged 15 commits into
dotnet:masterfrom 
EgorBo:ios-sample
Mar 18, 2020
Merged
[mono] Add iOS sample (AOT, arm64)#33633
EgorBo merged 15 commits into
dotnet:masterfrom 
EgorBo:ios-sample
Conversation
@EgorBo
@EgorBoEgorBo
commented
Mar 16, 2020•

edited

Loading

Copy link


Copy Markdown

Member
I'd like to add a minimal Full AOT sample for iOS (to our mono/netcore/sample directory).

I decided to add it as an xcode project to be able to easily open & debug/deploy on a device.

Such samples are useful for experiments and debug purposes (I use it in order to debug issues in corefx tests).
Steps to run the sample:
./build.sh -os iOS -arch arm64
cd src/mono/netcore/sample/iOS
make xcode
# now you can open the xcode project and deploy/debug the sample
Безымянный проект
However, xcode files are quite verbose so probably makes sense to generate the project via cmake.

What do you think @akoeplinger@steveisok@marek-safar do we need the sample in the repo?
UPD replaced with CMake.
EgorBo
EgorBo
commented
Mar 16, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
 // a kind of an animation
 ios_set_text (msg.Substring (0, i + 1));
 await Task.Delay (100);
 }
@EgorBoEgorBoMar 16, 2020

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how text is animated (see gif)
@EgorBoEgorBo
added

os-ios
Apple iOS
and removed

os-ios
Apple iOS
labels
Mar 16, 2020
marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/HelloiOS/runtime.m
static os_log_t stdout_log;

/* These are not in public headers */
typedef unsigned char* (*MonoLoadAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void **out_handle);
@marek-safarmarek-safarMar 17, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lambdageek could this be fixed?
@akoeplingerakoeplingerMar 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes let's file an issue about this, we shouldn't need to rely on private functions.
marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/HelloiOS/runtime.m
Outdated

marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
using System.Threading.Tasks;
using System.Runtime.InteropServices;

public class MonoPInvokeCallbackAttribute : Attribute
@marek-safarmarek-safarMar 17, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to avoid this and use NativeCallableAttribute
@vargaz could you please check where we are with the support of mono/mono#17479
@EgorBoEgorBoMar 17, 2020

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it basically same thing? but yeah NativeCallableAttribute sounds better.
@stephentoub
stephentoub
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
Neat
stephentoub
stephentoub
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
Outdated

akoeplinger
akoeplinger
approved these changes
Mar 18, 2020
View reviewed changes
@akoeplingerakoeplinger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a few nits.
Comment threadsrc/mono/netcore/sample/iOS/Makefile
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Plist.in
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.cs
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.csproj
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.csproj
Outdated

Comment threadsrc/mono/netcore/sample/iOS/runtime.m
Outdated

@EgorBo
EgorBo
merged commit 67d1cb6
into
dotnet:masterMar 18, 2020
@lambdageeklambdageek
mentioned this pull request
Mar 18, 2020
 Merged

lambdageek
lambdageek
reviewed
Mar 18, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/runtime.m

Comment on lines

+15
 to 
+20

/* These are not in public headers */
typedef unsigned char* (*MonoLoadAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void **out_handle);
typedef void (*MonoFreeAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void *handle);
void mono_install_load_aot_data_hook (MonoLoadAotDataFunc load_func, MonoFreeAotDataFunc free_func, void *user_data);
void mono_trace_init (void);
void mono_gc_init_finalizer_thread (void);
@lambdageeklambdageekMar 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #33736
@monojenkinsmonojenkins
mentioned this pull request
Mar 18, 2020
 Merged

@EgorBoEgorBo
mentioned this pull request
Mar 18, 2020
 Merged

@steveisoksteveisok
mentioned this pull request
Mar 21, 2020

Closed

4 tasks
monojenkins pushed a commit
to monojenkins/mono
that referenced
this pull request
Mar 24, 2020
@lambdageek
[mono] Make some API functions public and private
dff5ab9
See dotnet/runtime#33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4
* `mono_install_load_aot_data_hook` was already a `MONO_API`, but it was not in a public header.
It is added to `mono/jit/mono-private-unstable.h`
* `mono_gc_init_finalizer_thread` was [used by Xamarin.iOS](https://github.com/xamarin/xamarin-macios/blob/63ab48e679716264b33af00f86c24426da1d9f97/runtime/mono-runtime.h.t4#L278) for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with `--disable-visibility-hidden`. Make the function a proper `MONO_API` unconditionally - but make it do nothing if the runtime is compiled without `--with-lazy-thread-creation` (the default). It is now a public Mono API function.
* `mono_trace_init` was a `MONO_API` function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as `mono_trace_set_log_handler`
lambdageek added a commit
to mono/mono
that referenced
this pull request
Mar 24, 2020
@monojenkins@lambdageek
[mono] Make some API functions public and private (#19259)
1425b4d
See dotnet/runtime#33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4
* `mono_install_load_aot_data_hook` was already a `MONO_API`, but it was not in a public header.
It is added to `mono/jit/mono-private-unstable.h`
* `mono_gc_init_finalizer_thread` was [used by Xamarin.iOS](https://github.com/xamarin/xamarin-macios/blob/63ab48e679716264b33af00f86c24426da1d9f97/runtime/mono-runtime.h.t4#L278) for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with `--disable-visibility-hidden`. Make the function a proper `MONO_API` unconditionally - but make it do nothing if the runtime is compiled without `--with-lazy-thread-creation` (the default). It is now a public Mono API function.
* `mono_trace_init` was a `MONO_API` function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as `mono_trace_set_log_handler`
Co-authored-by: lambdageek <lambdageek@users.noreply.github.com>
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@lambdageeklambdageeklambdageek left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@stephentoubstephentoubstephentoub left review comments
@steveisoksteveisokAwaiting requested review from steveisok
@vargazvargazAwaiting requested review from vargaz

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@EgorBo@stephentoub@marek-safar@lambdageek@akoeplinger@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[mono] Add iOS sample (AOT, arm64) by EgorBo · Pull Request #33633 · dotnet/runtime · GitHub
Skip to content
[mono] Add iOS sample (AOT, arm64) - #33633
Merged
EgorBo merged 15 commits into
dotnet:masterfrom 
EgorBo:ios-sample
Mar 18, 2020
Merged
[mono] Add iOS sample (AOT, arm64)#33633
EgorBo merged 15 commits into
dotnet:masterfrom 
EgorBo:ios-sample
Conversation
@EgorBo
@EgorBoEgorBo
commented
Mar 16, 2020•

edited

Loading

Copy link


Copy Markdown

Member
I'd like to add a minimal Full AOT sample for iOS (to our mono/netcore/sample directory).

I decided to add it as an xcode project to be able to easily open & debug/deploy on a device.

Such samples are useful for experiments and debug purposes (I use it in order to debug issues in corefx tests).
Steps to run the sample:
./build.sh -os iOS -arch arm64
cd src/mono/netcore/sample/iOS
make xcode
# now you can open the xcode project and deploy/debug the sample
Безымянный проект
However, xcode files are quite verbose so probably makes sense to generate the project via cmake.

What do you think @akoeplinger@steveisok@marek-safar do we need the sample in the repo?
UPD replaced with CMake.
EgorBo
EgorBo
commented
Mar 16, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
 // a kind of an animation
 ios_set_text (msg.Substring (0, i + 1));
 await Task.Delay (100);
 }
@EgorBoEgorBoMar 16, 2020

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how text is animated (see gif)
@EgorBoEgorBo
added

os-ios
Apple iOS
and removed

os-ios
Apple iOS
labels
Mar 16, 2020
marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/HelloiOS/runtime.m
static os_log_t stdout_log;

/* These are not in public headers */
typedef unsigned char* (*MonoLoadAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void **out_handle);
@marek-safarmarek-safarMar 17, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lambdageek could this be fixed?
@akoeplingerakoeplingerMar 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes let's file an issue about this, we shouldn't need to rely on private functions.
marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/HelloiOS/runtime.m
Outdated

marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
using System.Threading.Tasks;
using System.Runtime.InteropServices;

public class MonoPInvokeCallbackAttribute : Attribute
@marek-safarmarek-safarMar 17, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to avoid this and use NativeCallableAttribute
@vargaz could you please check where we are with the support of mono/mono#17479
@EgorBoEgorBoMar 17, 2020

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it basically same thing? but yeah NativeCallableAttribute sounds better.
@stephentoub
stephentoub
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
Neat
stephentoub
stephentoub
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
Outdated

akoeplinger
akoeplinger
approved these changes
Mar 18, 2020
View reviewed changes
@akoeplingerakoeplinger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a few nits.
Comment threadsrc/mono/netcore/sample/iOS/Makefile
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Plist.in
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.cs
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.csproj
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.csproj
Outdated

Comment threadsrc/mono/netcore/sample/iOS/runtime.m
Outdated

@EgorBo
EgorBo
merged commit 67d1cb6
into
dotnet:masterMar 18, 2020
@lambdageeklambdageek
mentioned this pull request
Mar 18, 2020
 Merged

lambdageek
lambdageek
reviewed
Mar 18, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/runtime.m

Comment on lines

+15
 to 
+20

/* These are not in public headers */
typedef unsigned char* (*MonoLoadAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void **out_handle);
typedef void (*MonoFreeAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void *handle);
void mono_install_load_aot_data_hook (MonoLoadAotDataFunc load_func, MonoFreeAotDataFunc free_func, void *user_data);
void mono_trace_init (void);
void mono_gc_init_finalizer_thread (void);
@lambdageeklambdageekMar 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #33736
@monojenkinsmonojenkins
mentioned this pull request
Mar 18, 2020
 Merged

@EgorBoEgorBo
mentioned this pull request
Mar 18, 2020
 Merged

@steveisoksteveisok
mentioned this pull request
Mar 21, 2020

Closed

4 tasks
monojenkins pushed a commit
to monojenkins/mono
that referenced
this pull request
Mar 24, 2020
@lambdageek
[mono] Make some API functions public and private
dff5ab9
See dotnet/runtime#33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4
* `mono_install_load_aot_data_hook` was already a `MONO_API`, but it was not in a public header.
It is added to `mono/jit/mono-private-unstable.h`
* `mono_gc_init_finalizer_thread` was [used by Xamarin.iOS](https://github.com/xamarin/xamarin-macios/blob/63ab48e679716264b33af00f86c24426da1d9f97/runtime/mono-runtime.h.t4#L278) for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with `--disable-visibility-hidden`. Make the function a proper `MONO_API` unconditionally - but make it do nothing if the runtime is compiled without `--with-lazy-thread-creation` (the default). It is now a public Mono API function.
* `mono_trace_init` was a `MONO_API` function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as `mono_trace_set_log_handler`
lambdageek added a commit
to mono/mono
that referenced
this pull request
Mar 24, 2020
@monojenkins@lambdageek
[mono] Make some API functions public and private (#19259)
1425b4d
See dotnet/runtime#33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4
* `mono_install_load_aot_data_hook` was already a `MONO_API`, but it was not in a public header.
It is added to `mono/jit/mono-private-unstable.h`
* `mono_gc_init_finalizer_thread` was [used by Xamarin.iOS](https://github.com/xamarin/xamarin-macios/blob/63ab48e679716264b33af00f86c24426da1d9f97/runtime/mono-runtime.h.t4#L278) for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with `--disable-visibility-hidden`. Make the function a proper `MONO_API` unconditionally - but make it do nothing if the runtime is compiled without `--with-lazy-thread-creation` (the default). It is now a public Mono API function.
* `mono_trace_init` was a `MONO_API` function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as `mono_trace_set_log_handler`
Co-authored-by: lambdageek <lambdageek@users.noreply.github.com>
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@lambdageeklambdageeklambdageek left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@stephentoubstephentoubstephentoub left review comments
@steveisoksteveisokAwaiting requested review from steveisok
@vargazvargazAwaiting requested review from vargaz

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@EgorBo@stephentoub@marek-safar@lambdageek@akoeplinger@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[mono] Add iOS sample (AOT, arm64) by EgorBo · Pull Request #33633 · dotnet/runtime · GitHub
Skip to content
[mono] Add iOS sample (AOT, arm64) - #33633
Merged
EgorBo merged 15 commits into
dotnet:masterfrom 
EgorBo:ios-sample
Mar 18, 2020
Merged
[mono] Add iOS sample (AOT, arm64)#33633
EgorBo merged 15 commits into
dotnet:masterfrom 
EgorBo:ios-sample
Conversation
@EgorBo
@EgorBoEgorBo
commented
Mar 16, 2020•

edited

Loading

Copy link


Copy Markdown

Member
I'd like to add a minimal Full AOT sample for iOS (to our mono/netcore/sample directory).

I decided to add it as an xcode project to be able to easily open & debug/deploy on a device.

Such samples are useful for experiments and debug purposes (I use it in order to debug issues in corefx tests).
Steps to run the sample:
./build.sh -os iOS -arch arm64
cd src/mono/netcore/sample/iOS
make xcode
# now you can open the xcode project and deploy/debug the sample
Безымянный проект
However, xcode files are quite verbose so probably makes sense to generate the project via cmake.

What do you think @akoeplinger@steveisok@marek-safar do we need the sample in the repo?
UPD replaced with CMake.
EgorBo
EgorBo
commented
Mar 16, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
 // a kind of an animation
 ios_set_text (msg.Substring (0, i + 1));
 await Task.Delay (100);
 }
@EgorBoEgorBoMar 16, 2020

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how text is animated (see gif)
@EgorBoEgorBo
added

os-ios
Apple iOS
and removed

os-ios
Apple iOS
labels
Mar 16, 2020
marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/HelloiOS/runtime.m
static os_log_t stdout_log;

/* These are not in public headers */
typedef unsigned char* (*MonoLoadAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void **out_handle);
@marek-safarmarek-safarMar 17, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lambdageek could this be fixed?
@akoeplingerakoeplingerMar 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes let's file an issue about this, we shouldn't need to rely on private functions.
marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/HelloiOS/runtime.m
Outdated

marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
using System.Threading.Tasks;
using System.Runtime.InteropServices;

public class MonoPInvokeCallbackAttribute : Attribute
@marek-safarmarek-safarMar 17, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to avoid this and use NativeCallableAttribute
@vargaz could you please check where we are with the support of mono/mono#17479
@EgorBoEgorBoMar 17, 2020

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it basically same thing? but yeah NativeCallableAttribute sounds better.
@stephentoub
stephentoub
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
Neat
stephentoub
stephentoub
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
Outdated

akoeplinger
akoeplinger
approved these changes
Mar 18, 2020
View reviewed changes
@akoeplingerakoeplinger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a few nits.
Comment threadsrc/mono/netcore/sample/iOS/Makefile
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Plist.in
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.cs
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.csproj
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.csproj
Outdated

Comment threadsrc/mono/netcore/sample/iOS/runtime.m
Outdated

@EgorBo
EgorBo
merged commit 67d1cb6
into
dotnet:masterMar 18, 2020
@lambdageeklambdageek
mentioned this pull request
Mar 18, 2020
 Merged

lambdageek
lambdageek
reviewed
Mar 18, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/runtime.m

Comment on lines

+15
 to 
+20

/* These are not in public headers */
typedef unsigned char* (*MonoLoadAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void **out_handle);
typedef void (*MonoFreeAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void *handle);
void mono_install_load_aot_data_hook (MonoLoadAotDataFunc load_func, MonoFreeAotDataFunc free_func, void *user_data);
void mono_trace_init (void);
void mono_gc_init_finalizer_thread (void);
@lambdageeklambdageekMar 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #33736
@monojenkinsmonojenkins
mentioned this pull request
Mar 18, 2020
 Merged

@EgorBoEgorBo
mentioned this pull request
Mar 18, 2020
 Merged

@steveisoksteveisok
mentioned this pull request
Mar 21, 2020

Closed

4 tasks
monojenkins pushed a commit
to monojenkins/mono
that referenced
this pull request
Mar 24, 2020
@lambdageek
[mono] Make some API functions public and private
dff5ab9
See dotnet/runtime#33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4
* `mono_install_load_aot_data_hook` was already a `MONO_API`, but it was not in a public header.
It is added to `mono/jit/mono-private-unstable.h`
* `mono_gc_init_finalizer_thread` was [used by Xamarin.iOS](https://github.com/xamarin/xamarin-macios/blob/63ab48e679716264b33af00f86c24426da1d9f97/runtime/mono-runtime.h.t4#L278) for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with `--disable-visibility-hidden`. Make the function a proper `MONO_API` unconditionally - but make it do nothing if the runtime is compiled without `--with-lazy-thread-creation` (the default). It is now a public Mono API function.
* `mono_trace_init` was a `MONO_API` function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as `mono_trace_set_log_handler`
lambdageek added a commit
to mono/mono
that referenced
this pull request
Mar 24, 2020
@monojenkins@lambdageek
[mono] Make some API functions public and private (#19259)
1425b4d
See dotnet/runtime#33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4
* `mono_install_load_aot_data_hook` was already a `MONO_API`, but it was not in a public header.
It is added to `mono/jit/mono-private-unstable.h`
* `mono_gc_init_finalizer_thread` was [used by Xamarin.iOS](https://github.com/xamarin/xamarin-macios/blob/63ab48e679716264b33af00f86c24426da1d9f97/runtime/mono-runtime.h.t4#L278) for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with `--disable-visibility-hidden`. Make the function a proper `MONO_API` unconditionally - but make it do nothing if the runtime is compiled without `--with-lazy-thread-creation` (the default). It is now a public Mono API function.
* `mono_trace_init` was a `MONO_API` function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as `mono_trace_set_log_handler`
Co-authored-by: lambdageek <lambdageek@users.noreply.github.com>
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@lambdageeklambdageeklambdageek left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@stephentoubstephentoubstephentoub left review comments
@steveisoksteveisokAwaiting requested review from steveisok
@vargazvargazAwaiting requested review from vargaz

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@EgorBo@stephentoub@marek-safar@lambdageek@akoeplinger@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[mono] Add iOS sample (AOT, arm64) by EgorBo · Pull Request #33633 · dotnet/runtime · GitHub
Skip to content
[mono] Add iOS sample (AOT, arm64) - #33633
Merged
EgorBo merged 15 commits into
dotnet:masterfrom 
EgorBo:ios-sample
Mar 18, 2020
Merged
[mono] Add iOS sample (AOT, arm64)#33633
EgorBo merged 15 commits into
dotnet:masterfrom 
EgorBo:ios-sample
Conversation
@EgorBo
@EgorBoEgorBo
commented
Mar 16, 2020•

edited

Loading

Copy link


Copy Markdown

Member
I'd like to add a minimal Full AOT sample for iOS (to our mono/netcore/sample directory).

I decided to add it as an xcode project to be able to easily open & debug/deploy on a device.

Such samples are useful for experiments and debug purposes (I use it in order to debug issues in corefx tests).
Steps to run the sample:
./build.sh -os iOS -arch arm64
cd src/mono/netcore/sample/iOS
make xcode
# now you can open the xcode project and deploy/debug the sample
Безымянный проект
However, xcode files are quite verbose so probably makes sense to generate the project via cmake.

What do you think @akoeplinger@steveisok@marek-safar do we need the sample in the repo?
UPD replaced with CMake.
EgorBo
EgorBo
commented
Mar 16, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
 // a kind of an animation
 ios_set_text (msg.Substring (0, i + 1));
 await Task.Delay (100);
 }
@EgorBoEgorBoMar 16, 2020

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how text is animated (see gif)
@EgorBoEgorBo
added

os-ios
Apple iOS
and removed

os-ios
Apple iOS
labels
Mar 16, 2020
marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/HelloiOS/runtime.m
static os_log_t stdout_log;

/* These are not in public headers */
typedef unsigned char* (*MonoLoadAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void **out_handle);
@marek-safarmarek-safarMar 17, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lambdageek could this be fixed?
@akoeplingerakoeplingerMar 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes let's file an issue about this, we shouldn't need to rely on private functions.
marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/HelloiOS/runtime.m
Outdated

marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
using System.Threading.Tasks;
using System.Runtime.InteropServices;

public class MonoPInvokeCallbackAttribute : Attribute
@marek-safarmarek-safarMar 17, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to avoid this and use NativeCallableAttribute
@vargaz could you please check where we are with the support of mono/mono#17479
@EgorBoEgorBoMar 17, 2020

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it basically same thing? but yeah NativeCallableAttribute sounds better.
@stephentoub
stephentoub
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
Neat
stephentoub
stephentoub
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
Outdated

akoeplinger
akoeplinger
approved these changes
Mar 18, 2020
View reviewed changes
@akoeplingerakoeplinger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a few nits.
Comment threadsrc/mono/netcore/sample/iOS/Makefile
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Plist.in
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.cs
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.csproj
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.csproj
Outdated

Comment threadsrc/mono/netcore/sample/iOS/runtime.m
Outdated

@EgorBo
EgorBo
merged commit 67d1cb6
into
dotnet:masterMar 18, 2020
@lambdageeklambdageek
mentioned this pull request
Mar 18, 2020
 Merged

lambdageek
lambdageek
reviewed
Mar 18, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/runtime.m

Comment on lines

+15
 to 
+20

/* These are not in public headers */
typedef unsigned char* (*MonoLoadAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void **out_handle);
typedef void (*MonoFreeAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void *handle);
void mono_install_load_aot_data_hook (MonoLoadAotDataFunc load_func, MonoFreeAotDataFunc free_func, void *user_data);
void mono_trace_init (void);
void mono_gc_init_finalizer_thread (void);
@lambdageeklambdageekMar 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #33736
@monojenkinsmonojenkins
mentioned this pull request
Mar 18, 2020
 Merged

@EgorBoEgorBo
mentioned this pull request
Mar 18, 2020
 Merged

@steveisoksteveisok
mentioned this pull request
Mar 21, 2020

Closed

4 tasks
monojenkins pushed a commit
to monojenkins/mono
that referenced
this pull request
Mar 24, 2020
@lambdageek
[mono] Make some API functions public and private
dff5ab9
See dotnet/runtime#33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4
* `mono_install_load_aot_data_hook` was already a `MONO_API`, but it was not in a public header.
It is added to `mono/jit/mono-private-unstable.h`
* `mono_gc_init_finalizer_thread` was [used by Xamarin.iOS](https://github.com/xamarin/xamarin-macios/blob/63ab48e679716264b33af00f86c24426da1d9f97/runtime/mono-runtime.h.t4#L278) for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with `--disable-visibility-hidden`. Make the function a proper `MONO_API` unconditionally - but make it do nothing if the runtime is compiled without `--with-lazy-thread-creation` (the default). It is now a public Mono API function.
* `mono_trace_init` was a `MONO_API` function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as `mono_trace_set_log_handler`
lambdageek added a commit
to mono/mono
that referenced
this pull request
Mar 24, 2020
@monojenkins@lambdageek
[mono] Make some API functions public and private (#19259)
1425b4d
See dotnet/runtime#33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4
* `mono_install_load_aot_data_hook` was already a `MONO_API`, but it was not in a public header.
It is added to `mono/jit/mono-private-unstable.h`
* `mono_gc_init_finalizer_thread` was [used by Xamarin.iOS](https://github.com/xamarin/xamarin-macios/blob/63ab48e679716264b33af00f86c24426da1d9f97/runtime/mono-runtime.h.t4#L278) for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with `--disable-visibility-hidden`. Make the function a proper `MONO_API` unconditionally - but make it do nothing if the runtime is compiled without `--with-lazy-thread-creation` (the default). It is now a public Mono API function.
* `mono_trace_init` was a `MONO_API` function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as `mono_trace_set_log_handler`
Co-authored-by: lambdageek <lambdageek@users.noreply.github.com>
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@lambdageeklambdageeklambdageek left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@stephentoubstephentoubstephentoub left review comments
@steveisoksteveisokAwaiting requested review from steveisok
@vargazvargazAwaiting requested review from vargaz

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@EgorBo@stephentoub@marek-safar@lambdageek@akoeplinger@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[mono] Add iOS sample (AOT, arm64) by EgorBo · Pull Request #33633 · dotnet/runtime · GitHub
Skip to content
[mono] Add iOS sample (AOT, arm64) - #33633
Merged
EgorBo merged 15 commits into
dotnet:masterfrom 
EgorBo:ios-sample
Mar 18, 2020
Merged
[mono] Add iOS sample (AOT, arm64)#33633
EgorBo merged 15 commits into
dotnet:masterfrom 
EgorBo:ios-sample
Conversation
@EgorBo
@EgorBoEgorBo
commented
Mar 16, 2020•

edited

Loading

Copy link


Copy Markdown

Member
I'd like to add a minimal Full AOT sample for iOS (to our mono/netcore/sample directory).

I decided to add it as an xcode project to be able to easily open & debug/deploy on a device.

Such samples are useful for experiments and debug purposes (I use it in order to debug issues in corefx tests).
Steps to run the sample:
./build.sh -os iOS -arch arm64
cd src/mono/netcore/sample/iOS
make xcode
# now you can open the xcode project and deploy/debug the sample
Безымянный проект
However, xcode files are quite verbose so probably makes sense to generate the project via cmake.

What do you think @akoeplinger@steveisok@marek-safar do we need the sample in the repo?
UPD replaced with CMake.
EgorBo
EgorBo
commented
Mar 16, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
 // a kind of an animation
 ios_set_text (msg.Substring (0, i + 1));
 await Task.Delay (100);
 }
@EgorBoEgorBoMar 16, 2020

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how text is animated (see gif)
@EgorBoEgorBo
added

os-ios
Apple iOS
and removed

os-ios
Apple iOS
labels
Mar 16, 2020
marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/HelloiOS/runtime.m
static os_log_t stdout_log;

/* These are not in public headers */
typedef unsigned char* (*MonoLoadAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void **out_handle);
@marek-safarmarek-safarMar 17, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lambdageek could this be fixed?
@akoeplingerakoeplingerMar 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes let's file an issue about this, we shouldn't need to rely on private functions.
marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/HelloiOS/runtime.m
Outdated

marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
using System.Threading.Tasks;
using System.Runtime.InteropServices;

public class MonoPInvokeCallbackAttribute : Attribute
@marek-safarmarek-safarMar 17, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to avoid this and use NativeCallableAttribute
@vargaz could you please check where we are with the support of mono/mono#17479
@EgorBoEgorBoMar 17, 2020

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it basically same thing? but yeah NativeCallableAttribute sounds better.
@stephentoub
stephentoub
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
Neat
stephentoub
stephentoub
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
Outdated

akoeplinger
akoeplinger
approved these changes
Mar 18, 2020
View reviewed changes
@akoeplingerakoeplinger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a few nits.
Comment threadsrc/mono/netcore/sample/iOS/Makefile
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Plist.in
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.cs
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.csproj
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.csproj
Outdated

Comment threadsrc/mono/netcore/sample/iOS/runtime.m
Outdated

@EgorBo
EgorBo
merged commit 67d1cb6
into
dotnet:masterMar 18, 2020
@lambdageeklambdageek
mentioned this pull request
Mar 18, 2020
 Merged

lambdageek
lambdageek
reviewed
Mar 18, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/runtime.m

Comment on lines

+15
 to 
+20

/* These are not in public headers */
typedef unsigned char* (*MonoLoadAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void **out_handle);
typedef void (*MonoFreeAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void *handle);
void mono_install_load_aot_data_hook (MonoLoadAotDataFunc load_func, MonoFreeAotDataFunc free_func, void *user_data);
void mono_trace_init (void);
void mono_gc_init_finalizer_thread (void);
@lambdageeklambdageekMar 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #33736
@monojenkinsmonojenkins
mentioned this pull request
Mar 18, 2020
 Merged

@EgorBoEgorBo
mentioned this pull request
Mar 18, 2020
 Merged

@steveisoksteveisok
mentioned this pull request
Mar 21, 2020

Closed

4 tasks
monojenkins pushed a commit
to monojenkins/mono
that referenced
this pull request
Mar 24, 2020
@lambdageek
[mono] Make some API functions public and private
dff5ab9
See dotnet/runtime#33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4
* `mono_install_load_aot_data_hook` was already a `MONO_API`, but it was not in a public header.
It is added to `mono/jit/mono-private-unstable.h`
* `mono_gc_init_finalizer_thread` was [used by Xamarin.iOS](https://github.com/xamarin/xamarin-macios/blob/63ab48e679716264b33af00f86c24426da1d9f97/runtime/mono-runtime.h.t4#L278) for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with `--disable-visibility-hidden`. Make the function a proper `MONO_API` unconditionally - but make it do nothing if the runtime is compiled without `--with-lazy-thread-creation` (the default). It is now a public Mono API function.
* `mono_trace_init` was a `MONO_API` function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as `mono_trace_set_log_handler`
lambdageek added a commit
to mono/mono
that referenced
this pull request
Mar 24, 2020
@monojenkins@lambdageek
[mono] Make some API functions public and private (#19259)
1425b4d
See dotnet/runtime#33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4
* `mono_install_load_aot_data_hook` was already a `MONO_API`, but it was not in a public header.
It is added to `mono/jit/mono-private-unstable.h`
* `mono_gc_init_finalizer_thread` was [used by Xamarin.iOS](https://github.com/xamarin/xamarin-macios/blob/63ab48e679716264b33af00f86c24426da1d9f97/runtime/mono-runtime.h.t4#L278) for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with `--disable-visibility-hidden`. Make the function a proper `MONO_API` unconditionally - but make it do nothing if the runtime is compiled without `--with-lazy-thread-creation` (the default). It is now a public Mono API function.
* `mono_trace_init` was a `MONO_API` function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as `mono_trace_set_log_handler`
Co-authored-by: lambdageek <lambdageek@users.noreply.github.com>
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@lambdageeklambdageeklambdageek left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@stephentoubstephentoubstephentoub left review comments
@steveisoksteveisokAwaiting requested review from steveisok
@vargazvargazAwaiting requested review from vargaz

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@EgorBo@stephentoub@marek-safar@lambdageek@akoeplinger@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[mono] Add iOS sample (AOT, arm64) by EgorBo · Pull Request #33633 · dotnet/runtime · GitHub
Skip to content
[mono] Add iOS sample (AOT, arm64) - #33633
Merged
EgorBo merged 15 commits into
dotnet:masterfrom 
EgorBo:ios-sample
Mar 18, 2020
Merged
[mono] Add iOS sample (AOT, arm64)#33633
EgorBo merged 15 commits into
dotnet:masterfrom 
EgorBo:ios-sample
Conversation
@EgorBo
@EgorBoEgorBo
commented
Mar 16, 2020•

edited

Loading

Copy link


Copy Markdown

Member
I'd like to add a minimal Full AOT sample for iOS (to our mono/netcore/sample directory).

I decided to add it as an xcode project to be able to easily open & debug/deploy on a device.

Such samples are useful for experiments and debug purposes (I use it in order to debug issues in corefx tests).
Steps to run the sample:
./build.sh -os iOS -arch arm64
cd src/mono/netcore/sample/iOS
make xcode
# now you can open the xcode project and deploy/debug the sample
Безымянный проект
However, xcode files are quite verbose so probably makes sense to generate the project via cmake.

What do you think @akoeplinger@steveisok@marek-safar do we need the sample in the repo?
UPD replaced with CMake.
EgorBo
EgorBo
commented
Mar 16, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
 // a kind of an animation
 ios_set_text (msg.Substring (0, i + 1));
 await Task.Delay (100);
 }
@EgorBoEgorBoMar 16, 2020

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how text is animated (see gif)
@EgorBoEgorBo
added

os-ios
Apple iOS
and removed

os-ios
Apple iOS
labels
Mar 16, 2020
marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/HelloiOS/runtime.m
static os_log_t stdout_log;

/* These are not in public headers */
typedef unsigned char* (*MonoLoadAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void **out_handle);
@marek-safarmarek-safarMar 17, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lambdageek could this be fixed?
@akoeplingerakoeplingerMar 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes let's file an issue about this, we shouldn't need to rely on private functions.
marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/HelloiOS/runtime.m
Outdated

marek-safar
marek-safar
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
using System.Threading.Tasks;
using System.Runtime.InteropServices;

public class MonoPInvokeCallbackAttribute : Attribute
@marek-safarmarek-safarMar 17, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to avoid this and use NativeCallableAttribute
@vargaz could you please check where we are with the support of mono/mono#17479
@EgorBoEgorBoMar 17, 2020

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it basically same thing? but yeah NativeCallableAttribute sounds better.
@stephentoub
stephentoub
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
Neat
stephentoub
stephentoub
reviewed
Mar 17, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/Program.cs
Outdated

akoeplinger
akoeplinger
approved these changes
Mar 18, 2020
View reviewed changes
@akoeplingerakoeplinger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a few nits.
Comment threadsrc/mono/netcore/sample/iOS/Makefile
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Plist.in
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.cs
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.csproj
Outdated

Comment threadsrc/mono/netcore/sample/iOS/Program.csproj
Outdated

Comment threadsrc/mono/netcore/sample/iOS/runtime.m
Outdated

@EgorBo
EgorBo
merged commit 67d1cb6
into
dotnet:masterMar 18, 2020
@lambdageeklambdageek
mentioned this pull request
Mar 18, 2020
 Merged

lambdageek
lambdageek
reviewed
Mar 18, 2020
View reviewed changes
Comment threadsrc/mono/netcore/sample/iOS/runtime.m

Comment on lines

+15
 to 
+20

/* These are not in public headers */
typedef unsigned char* (*MonoLoadAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void **out_handle);
typedef void (*MonoFreeAotDataFunc) (MonoAssembly *assembly, int size, void *user_data, void *handle);
void mono_install_load_aot_data_hook (MonoLoadAotDataFunc load_func, MonoFreeAotDataFunc free_func, void *user_data);
void mono_trace_init (void);
void mono_gc_init_finalizer_thread (void);
@lambdageeklambdageekMar 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #33736
@monojenkinsmonojenkins
mentioned this pull request
Mar 18, 2020
 Merged

@EgorBoEgorBo
mentioned this pull request
Mar 18, 2020
 Merged

@steveisoksteveisok
mentioned this pull request
Mar 21, 2020

Closed

4 tasks
monojenkins pushed a commit
to monojenkins/mono
that referenced
this pull request
Mar 24, 2020
@lambdageek
[mono] Make some API functions public and private
dff5ab9
See dotnet/runtime#33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4
* `mono_install_load_aot_data_hook` was already a `MONO_API`, but it was not in a public header.
It is added to `mono/jit/mono-private-unstable.h`
* `mono_gc_init_finalizer_thread` was [used by Xamarin.iOS](https://github.com/xamarin/xamarin-macios/blob/63ab48e679716264b33af00f86c24426da1d9f97/runtime/mono-runtime.h.t4#L278) for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with `--disable-visibility-hidden`. Make the function a proper `MONO_API` unconditionally - but make it do nothing if the runtime is compiled without `--with-lazy-thread-creation` (the default). It is now a public Mono API function.
* `mono_trace_init` was a `MONO_API` function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as `mono_trace_set_log_handler`
lambdageek added a commit
to mono/mono
that referenced
this pull request
Mar 24, 2020
@monojenkins@lambdageek
[mono] Make some API functions public and private (#19259)
1425b4d
See dotnet/runtime#33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4
* `mono_install_load_aot_data_hook` was already a `MONO_API`, but it was not in a public header.
It is added to `mono/jit/mono-private-unstable.h`
* `mono_gc_init_finalizer_thread` was [used by Xamarin.iOS](https://github.com/xamarin/xamarin-macios/blob/63ab48e679716264b33af00f86c24426da1d9f97/runtime/mono-runtime.h.t4#L278) for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with `--disable-visibility-hidden`. Make the function a proper `MONO_API` unconditionally - but make it do nothing if the runtime is compiled without `--with-lazy-thread-creation` (the default). It is now a public Mono API function.
* `mono_trace_init` was a `MONO_API` function in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such as `mono_trace_set_log_handler`
Co-authored-by: lambdageek <lambdageek@users.noreply.github.com>
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@lambdageeklambdageeklambdageek left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@stephentoubstephentoubstephentoub left review comments
@steveisoksteveisokAwaiting requested review from steveisok
@vargazvargazAwaiting requested review from vargaz

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@EgorBo@stephentoub@marek-safar@lambdageek@akoeplinger@Dotnet-GitSync-Bot