Uh oh!
There was an error while loading. Please reload this page.
Address System.Net.Http.WinHttpHandler's nullable warnings targeting .NETCoreApp - #54995
Merged
Conversation
ghost
commented
Jul 1, 2021
Tagging subscribers to this area: @dotnet/ncl Issue DetailsCloses #54598 Mainly using asserts.
|
huoyaoyuan
commented
Jul 1, 2021
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
stephentoub
approved these changes
Jul 1, 2021
stephentoub
left a comment
Member
There was a problem hiding this comment.
Thanks for doing this. A few small comments, otherwise LGTM.
Uh oh!
There was an error while loading. Please reload this page.
huoyaoyuan
commented
Jul 13, 2021
MemberAuthor
@MihaZupan I think this one should be ready, can you trigger a CI rerun to see if anything is still failing? |
MihaZupan
approved these changes
Jul 13, 2021
MihaZupan
left a comment
Member
There was a problem hiding this comment.
I agree that the RequestHandle assertion was wrong and the behavior is fine.
I restarted CI, LGTM assuming it passes now
stephentoub
approved these changes
Jul 13, 2021
thaystg added a commit
to thaystg/runtime
that referenced
this pull request
Jul 14, 2021
…debugger_custom_views * 'main' of github.com:thaystg/runtime: (125 commits) [wasm] [debugger] Support method calls (dotnet#55458) [debugger] Fix debugging after hot reloading (dotnet#55599) Inliner: Extend IL limit for profiled call-sites, allow inlining for switches. (dotnet#55478) DiagnosticSourceEventSource supports base class properties (dotnet#55613) [mono] Fix race during mono_image_storage_open (dotnet#55201) [mono] Add wrapper info for native func wrappers. (dotnet#55602) H/3 and Quic AppContext switch (dotnet#55332) Compression.ZipFile support for Unix Permissions (dotnet#55531) [mono] Fix skipping of static methods during IMT table construction. (dotnet#55610) Combine System.Private.Xml TrimmingTests projects (dotnet#55606) fix name conflict with Configuration class (dotnet#55597) Finish migrating RSAOpenSsl from RSA* to EVP_PKEY* Disable generic math (dotnet#55540) Obsolete CryptoConfig.EncodeOID (dotnet#55592) Address System.Net.Http.WinHttpHandler's nullable warnings targeting .NETCoreApp (dotnet#54995) Enable Http2_MultipleConnectionsEnabled_ConnectionLimitNotReached_ConcurrentRequestsSuccessfullyHandled (dotnet#55572) Fix Task.WhenAny failure mode when passed ICollection of zero tasks (dotnet#55580) Consume DistributedContextPropagator in DiagnosticsHandler (dotnet#55392) Add property ordering feature (dotnet#55586) Reduce subtest count in Reflection (dotnet#55537) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#54598
Mainly using asserts.
!is only used in lambda and local function.