Compression.ZipFile support for Unix Permissions by eerhardt · Pull Request #55531 · dotnet/runtime

eerhardt · 2021-07-12T19:13:31Z

When running on Unix, capture the file's permissions on ZipFile Create and write the captured file permissions on ZipFile Extract.

Fix#1548

When running on Unix, capture the file's permissions on ZipFile Create and write the captured file permissions on ZipFile Extract. Fixdotnet#1548

ghost · 2021-07-12T19:13:38Z

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

Issue Details

When running on Unix, capture the file's permissions on ZipFile Create and write the captured file permissions on ZipFile Extract.

Fix #1548

Draft: Still need to add tests.

Author:	eerhardt
Assignees:	-
Labels:	`area-System.IO.Compression`
Milestone:	-

eerhardt · 2021-07-13T01:35:37Z

@lewing @radical @ViktorHofer @safern - ~~any ideas on the wasm failures?~~

##[error].packages\microsoft.dotnet.sharedframework.sdk\6.0.0-beta.21357.3\targets\sharedfx.targets(467,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Assembly 'netstandard' is missing dependency 'System.IO.Compression.ZipFile'

UPDATE: Fixed by adding a Browser TFM to the project.

stephentoub

Other than my comments, LGTM. Thanks.

eerhardt · 2021-07-14T03:02:56Z

Runtime failures are #55536 and #55618.

…debugger_custom_views * 'main' of github.com:thaystg/runtime: (125 commits) [wasm] [debugger] Support method calls (dotnet#55458) [debugger] Fix debugging after hot reloading (dotnet#55599) Inliner: Extend IL limit for profiled call-sites, allow inlining for switches. (dotnet#55478) DiagnosticSourceEventSource supports base class properties (dotnet#55613) [mono] Fix race during mono_image_storage_open (dotnet#55201) [mono] Add wrapper info for native func wrappers. (dotnet#55602) H/3 and Quic AppContext switch (dotnet#55332) Compression.ZipFile support for Unix Permissions (dotnet#55531) [mono] Fix skipping of static methods during IMT table construction. (dotnet#55610) Combine System.Private.Xml TrimmingTests projects (dotnet#55606) fix name conflict with Configuration class (dotnet#55597) Finish migrating RSAOpenSsl from RSA* to EVP_PKEY* Disable generic math (dotnet#55540) Obsolete CryptoConfig.EncodeOID (dotnet#55592) Address System.Net.Http.WinHttpHandler's nullable warnings targeting .NETCoreApp (dotnet#54995) Enable Http2_MultipleConnectionsEnabled_ConnectionLimitNotReached_ConcurrentRequestsSuccessfullyHandled (dotnet#55572) Fix Task.WhenAny failure mode when passed ICollection of zero tasks (dotnet#55580) Consume DistributedContextPropagator in DiagnosticsHandler (dotnet#55392) Add property ordering feature (dotnet#55586) Reduce subtest count in Reflection (dotnet#55537) ...

Currently, .NET doesn't automatically add Unix file permissions to our zip's file entries. This means that all of the files cannot be opened without setting the permissions manually in the OS. To fix this, we manually add the Unix file permissions ourselves by converting a permission string to an octal literal on the zip entry. I believe that in .NET 6, this should be done automatically for us due to the following change: dotnet/runtime#55531

Compression.ZipFile support for Unix Permissions
60c64ca
When running on Unix, capture the file's permissions on ZipFile Create and write the captured file permissions on ZipFile Extract. Fixdotnet#1548

ghost added the area-System.IO.Compression label Jul 12, 2021

stephentoub reviewed Jul 12, 2021
View reviewed changes

Comment thread...IO.Compression.ZipFile/src/System/IO/Compression/ZipFileExtensions.ZipArchive.Create.Unix.cs

Add unit tests
d52fce0

eerhardt marked this pull request as ready for review July 12, 2021 23:24

eerhardt requested review from adamsitnik, carlossanlop and jozkee July 12, 2021 23:25

eerhardt added 2 commits July 12, 2021 18:35

Fix build
d4f1821

Fix windows build
db4f43a

eerhardt added 2 commits July 12, 2021 20:51

Add Browser TFM
1d012c5

Fix tests on wasm
f7f2078