Uh oh!
There was an error while loading. Please reload this page.
[release/6.0-preview7] Eliminate backtracking in the interpreter for patterns with .* - #55960
Conversation
ghost
commented
Jul 19, 2021
Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions |
danmoseley
commented
Jul 20, 2021
This is approved to merge. The test failure is unrelated. |
ghost
commented
Jul 20, 2021
Hello @danmoseley! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me ( |
BrennanConroy
commented
Jul 20, 2021
FYI, this change (in RC1) likely broke some tests in ASP.NET Core dotnet/aspnetcore#34491 Looking into the previous and current behavior, will post in a couple minutes the results. |
BrennanConroy
commented
Jul 20, 2021
Rule: Expected backreferences:
Actual backreferences: None, didn't match @danmoseley@safern@pgovind I don't think this was intended to be a breaking change |
It was not. This should be reverted. On .NET 5, |
pgovind
commented
Jul 20, 2021
It was not. I think I see the problem. Let's revert this change for now |
Backport of #51508 to release/6.0-preview7
/cc @pgovind
Customer Impact
.*in them. In my performance tests (part of the original PR), I get a speed up of 6xTesting
.*and various patterns (strings/numbers/case sensitivity/RightToLeft).*patternRisk