Uh oh!
There was an error while loading. Please reload this page.
Add a unit test from aspnetcore - #56108
Conversation
ghost
commented
Jul 21, 2021
Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions Issue DetailsJust adding a unit test to our tests.
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
pgovind
commented
Jul 29, 2021
GH won't let me approve this PR since I opened it. The changes look good to me. There are interesting patterns to add with |
ghost
commented
Jul 29, 2021
Hello @jeffhandley! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me ( |
jeffhandley
commented
Jul 29, 2021
Thanks, @pgovind. Good thinking on I noticed that there's very little coverage of negative scenarios where matches are unsuccessful. One of the mistakes I made yesterday was assuming I could cover such scenarios within the group tests, but that's not in place--the test method assumes every scenario is a successful match. There are a few other tests in this feature area for unsuccessful matches, but nowhere near the coverage we have in these group tests. I held back from updating this particular test suite to capture such scenarios. |
jeffhandley
commented
Jul 29, 2021
Failure is unrelated and infrastructural. |
Add a unit test that covers a critical scenario from ASP.NET. This scenario was identified when #51508 was merged in and caused a regression in ASP.NET, as reported when the change was backported to preview 7. That regression was first observed in dotnet/aspnetcore#34491.
Rule:
(.*)/(.*).aspxInput:
/pages/homepage.aspxExpected backreferences:
Actual backreferences: None, didn't match
This scenario represents multiple
.*groups within a pattern and being able to capture all expected backreferences.