Uh oh!
There was an error while loading. Please reload this page.
Fix GetGenerationBounds under USE_REGIONS - #57101
Conversation
ghost
commented
Aug 9, 2021
Tagging subscribers to this area: @dotnet/gc Issue DetailsDo not merge, this is currently a work-in-progress.
|
a22ea0d to
31d7bbfCompare31d7bbf to
212128eCompare212128e to
678175dCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
d384b9a to
a39f5b2CompareUh oh!
There was an error while loading. Please reload this page.
Maoni0
commented
Aug 25, 2021
I haven't really looked at the changes in proftoeeinterfaceimpl.cpp, I'll defer to @davmason. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
e832f3d to
365a2f2Compare
davmason
left a comment
There was a problem hiding this comment.
Just the minor things I made comments on, otherwise looks good to me. Thanks Andrew!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
43020c6 to
9aaba6dCompareUh oh!
There was an error while loading. Please reload this page.
cshung
commented
Aug 27, 2021
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1174937983 |
@cshung backporting to release/6.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: DiagAddNewRegion prototype
Applying: Updating the table directly under a lock
error: sha1 information is lacking or useless (src/coreclr/gc/gc.cpp).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Updating the table directly under a lock
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Fixes#55965.