Uh oh!
There was an error while loading. Please reload this page.
Fix GetGenerationBounds under USE_REGIONS (#57101) - #58277
Merged
Anipik merged 1 commit intoAug 27, 2021
Conversation
ghost
commented
Aug 27, 2021
Tagging subscribers to this area: @dotnet/gc Issue Detailsnull
|
mangod9
approved these changes
Aug 27, 2021
jeffschwMSFT
approved these changes
Aug 27, 2021
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. Once we have a green CI we can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer Impact
Our plan is to continue to work on regions in
clrgc.dll.NET 7 so that we can start to have customers try it out. We hope that they can get their workload on .NET 6 and then grab aclrgc.dllfrom any .NET 7 build. However, without fixing the profiler support in the VM in .NET 6, customers will need to run the whole thing under .NET 7 in order to try out regions. This would be hard for many customers.Testing
This change is tested with a profiler that keep calling
GetObjectGenerationandGetGenerationBoundsand checking that the call succeeded and the returned generation bounds are non-overlapping.Risk
Low risk. The change should only affect
USE_REGIONS, which is only turned on forclrgc.dllfor .NET 6.