[mono] Support public key token in DefineDynamicAssembly

[uweigand]

• Fixes[mono] DefineDynamicAssembly ignores PublicKeyToken #58015

[ghost]

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• Fixes [mono] DefineDynamicAssembly ignores PublicKeyToken #58015

Author:	uweigand
Assignees:	-
Labels:	area-VM-meta-mono
Milestone:	-

[jkotas]

Do we need to add test?

[uweigand]

Do we need to add test?

I noticed there are existing tests for DefineDynamicAssembly, but

• they are disabled for Mono
• enabling them exposes an endless recursion which is apparently a regression from [mono] Allow overriding GetCustomAttributesData routines #55726
• and they don't test assembly names including a public key anyway

I've just pushed a version that fixes the endless recursion, enables the test cases, and adds a public key test. The test passes on CoreCLR, fails on Mono before this patch, and succeeds on Mono after this patch.

Does this look OK or would you prefer if I split off the regression fix into a separate PR?

[lambdageek]

Does this look OK or would you prefer if I split off the regression fix into a separate PR?

I'd prefer the fix in a separate PR - just because it'll be easier to reason about the backports to 6.0

[uweigand]

Does this look OK or would you prefer if I split off the regression fix into a separate PR?

I'd prefer the fix in a separate PR - just because it'll be easier to reason about the backports to 6.0

OK, this is now #58201

[uweigand]

Rebased after #58201 was merged.

[lambdageek]

/backport to release/6.0

[github-actions]

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1175273337