Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] [mono] Support public key token in DefineDynamicAssembly - #58283
Merged
Conversation
github-actionsBot
requested review from
lambdageek, marek-safar, thaystg and vargaz
as code ownersAugust 27, 2021 18:37
ghost
commented
Aug 27, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
lambdageek
commented
Aug 27, 2021
Member
Depends on #58255 |
ghost
commented
Aug 27, 2021
Tagging subscribers to this area: Issue DetailsBackport of #58016 to release/6.0 Customer ImpactUsing System.Reflection.Emit to define assemblies with a public key token will not work on Mono. Breaks several aspnetcore scenarios on s390x. #58015 TestingCI. Adds new tests to cover this scenario. RiskLow. Allows more programs to run without throwing exceptions.
|
lambdageek
approved these changes
Aug 27, 2021
marek-safar
approved these changes
Aug 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58016 to release/6.0
/cc @lambdageek@uweigand
Customer Impact
Using System.Reflection.Emit to define assemblies with a public key token will not work on Mono. Breaks several aspnetcore scenarios on s390x. #58015
Testing
CI. Adds new tests to cover this scenario.
Risk
Low. Allows more programs to run without throwing exceptions.