Skip to content

[wasm][debugger] Fixing DebuggerDisplayAttribute when using utf16 characters - #58084

Merged
lewing merged 1 commit into
dotnet:mainfrom
thaystg:thays_fix_58046
Aug 25, 2021
Merged

[wasm][debugger] Fixing DebuggerDisplayAttribute when using utf16 characters#58084
lewing merged 1 commit into
dotnet:mainfrom
thaystg:thays_fix_58046

Conversation

@thaystg

@thaystgthaystg commented Aug 25, 2021

Copy link
Copy Markdown
Member

Fixing viewing DebuggerDisplayAttribute content with utf16 characters.
Using the same method used on debugger-libs to read string from buffer: https://github.com/mono/debugger-libs/blob/03850bfd42eb17d6425f03ee03114f9dc471db6c/Mono.Debugger.Soft/Mono.Debugger.Soft/Connection.cs#L865

Fixes#58046

@thaystg
thaystg requested review from lewing and radicalAugust 25, 2021 00:01
@ghost

ghost commented Aug 25, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixing viewing DebuggerDisplayAttribute content with utf16 characters.
Using the same method used on debugger-libs to read string from buffer: https://github.com/mono/debugger-libs/blob/03850bfd42eb17d6425f03ee03114f9dc471db6c/Mono.Debugger.Soft/Mono.Debugger.Soft/Connection.cs#L865

Fixes #58046

Author:thaystg
Assignees:-
Labels:

area-Debugger-mono

Milestone:-

@thaystg
thaystg removed the request for review from marek-safarAugust 25, 2021 00:01
@radicalradical added the arch-wasm WebAssembly architecture label Aug 25, 2021
@ghost

ghost commented Aug 25, 2021

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixing viewing DebuggerDisplayAttribute content with utf16 characters.
Using the same method used on debugger-libs to read string from buffer: https://github.com/mono/debugger-libs/blob/03850bfd42eb17d6425f03ee03114f9dc471db6c/Mono.Debugger.Soft/Mono.Debugger.Soft/Connection.cs#L865

Fixes #58046

Author:thaystg
Assignees:-
Labels:

arch-wasm, area-Debugger-mono

Milestone:-

@thaystg

thaystg commented Aug 25, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0-rc1

@github-actions

github-actionsBot commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1164698641

@github-actionsgithub-actionsBot mentioned this pull request Aug 25, 2021
Merged
@lewing
lewing merged commit d40fbf4 into dotnet:mainAug 25, 2021
@ghostghost locked as resolved and limited conversation to collaborators Sep 24, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical approved these changes
@lewinglewinglewing approved these changes

Assignees

No one assigned

Labels

arch-wasmWebAssembly architecturearea-Debugger-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: DebuggerDisplay in Blazor has problems with special characters (umlauts)

3 participants

@thaystg@radical@lewing