Uh oh!
There was an error while loading. Please reload this page.
[release/6.0-rc1] [wasm][debugger] Fixing DebuggerDisplayAttribute when using utf16 characters - #58087
Merged
Merged
Conversation
ghost
commented
Aug 25, 2021
Tagging subscribers to this area: @thaystg |
lewing
approved these changes
Aug 25, 2021
lewing
commented
Aug 25, 2021
Member
Two lanes failed with #11063 |
mmitche
commented
Aug 25, 2021
Member
Merge when ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58084 to release/6.0-rc1
/cc @thaystg
Customer Impact
Fixing viewing DebuggerDisplayAttribute content with utf16 characters.
#58046
Testing
Unit test.
Risk
Low, using the same method used on debugger-libs to read string from buffer: https://github.com/mono/debugger-libs/blob/03850bfd42eb17d6425f03ee03114f9dc471db6c/Mono.Debugger.Soft/Mono.Debugger.Soft/Connection.cs#L865