Skip to content

Use OutputRid in test projects - #58166

Merged
ViktorHofer merged 1 commit into
dotnet:mainfrom
am11:feature/rid
Aug 26, 2021
Merged

Use OutputRid in test projects#58166
ViktorHofer merged 1 commit into
dotnet:mainfrom
am11:feature/rid

Conversation

@am11

@am11am11 commented Aug 26, 2021•
edited
Loading

Copy link
Copy Markdown
Member

To test an outerloop test leg failure.

Fixes#55657

@ghost

ghost commented Aug 26, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost added the community-contribution Indicates that the PR has been added by a community member label Aug 26, 2021
@am11

am11 commented Aug 26, 2021

Copy link
Copy Markdown
MemberAuthor

@ViktorHofer, once normal CI / priority 0 tests are green'ish, can we trigger outerloop tests in the PR for priority 1 tests; where matrix has some interesting platforms?

@ViktorHofer

ViktorHofer commented Aug 26, 2021

Copy link
Copy Markdown
Member

/azp run runtime-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Aug 26, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@am11
am11 marked this pull request as ready for review August 26, 2021 13:26
@am11

am11 commented Aug 26, 2021

Copy link
Copy Markdown
MemberAuthor

failures are unrelated:

@am11am11 mentioned this pull request Aug 26, 2021
Closed
@ghost

ghost commented Aug 26, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

To test an outerloop test leg failure.

Fixes #55657

Author:am11
Assignees:-
Labels:

area-Infrastructure, community-contribution

Milestone:-

trylek
trylek approved these changes Aug 26, 2021
View reviewed changes

@trylektrylek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ViktorHofer
ViktorHofer merged commit 16de9a2 into dotnet:mainAug 26, 2021
@am11
am11 deleted the feature/rid branch August 26, 2021 19:08
@am11

am11 commented Aug 30, 2021

Copy link
Copy Markdown
MemberAuthor

@ViktorHofer, linux-musl outerloop legs are failing in release/6.0. Is it a valid reason to backport this change?

@hoyosjs

hoyosjs commented Aug 30, 2021

Copy link
Copy Markdown
Member

/backport to release/6.0

@am11 it is, as it is relevant for servicing exercises. Thanks.

@github-actions

github-actionsBot commented Aug 30, 2021

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1181101738

@github-actionsgithub-actionsBot mentioned this pull request Aug 30, 2021
Merged
@ghostghost locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@trylektrylektrylek approved these changes

Assignees

No one assigned

Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generate CORE_ROOT failing for linux_musl arm/arm64

6 participants

@am11@ViktorHofer@hoyosjs@jkoritzinsky@trylek@danmoseley