Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Use OutputRid in test projects - #58340
Merged
Merged
Conversation
ghost
commented
Aug 30, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
commented
Aug 30, 2021
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
hoyosjs
commented
Aug 30, 2021
Member
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jeffschwMSFT
approved these changes
Aug 30, 2021
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. Please request a code review and once we have a green CI we can merge.
akoeplinger
approved these changes
Aug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly pass the RID to the CORE_ROOT generation logic.
Backport of #58166 to release/6.0
/cc @hoyosjs@am11
Customer Impact
Without this, testing arm variants in outerloop for servicing is not possible.
Testing
CI tests
Risk
Really low, Test only impact.