Skip to content

[HTTP/3] Stress disable offending op causing server errors - #58442

Merged
ManickaP merged 1 commit into
dotnet:mainfrom
ManickaP:mapichov/56310_disable_100_continue
Aug 31, 2021
Merged

[HTTP/3] Stress disable offending op causing server errors#58442
ManickaP merged 1 commit into
dotnet:mainfrom
ManickaP:mapichov/56310_disable_100_continue

Conversation

@ManickaP

@ManickaPManickaP commented Aug 31, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Kestrel doesn't like Expect 100 Continue in H/3.

See #58110 (comment)
Contributes to #56310
Fixes#55261

@ghost

ghost commented Aug 31, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Kestrel doesn't like Expect 100 Continue in H/3.

See #58110 (comment)
Contributes to #56310

Author:ManickaP
Assignees:-
Labels:

area-System.Net.Http

Milestone:-

@ManickaP

ManickaP commented Aug 31, 2021

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-libraries stress-http

@azure-pipelines

azure-pipelinesBot commented Aug 31, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ManickaPManickaP mentioned this pull request Aug 31, 2021
Closed
@ManickaP
ManickaP marked this pull request as ready for review August 31, 2021 19:41
@ManickaPManickaP mentioned this pull request Aug 31, 2021
Closed
antonfirsov
antonfirsov approved these changes Aug 31, 2021
View reviewed changes

@antonfirsovantonfirsov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ManickaP
ManickaP merged commit 5ca197c into dotnet:mainAug 31, 2021
@ManickaP
ManickaP deleted the mapichov/56310_disable_100_continue branch August 31, 2021 19:55
@karelz

karelz commented Aug 31, 2021

Copy link
Copy Markdown
Member

@ManickaP this may be worth backporting to 6.0, right?

@ManickaP

ManickaP commented Sep 1, 2021

Copy link
Copy Markdown
MemberAuthor

Yep, @antonfirsov did some PRs enabling the stress pipeline there (has it been merged?), so we should probably get this there as well.

@ManickaP

ManickaP commented Sep 2, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0

@github-actions

github-actionsBot commented Sep 2, 2021

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1193516392

@github-actionsgithub-actionsBot mentioned this pull request Sep 2, 2021
Merged
@karelzkarelz added this to the 7.0.0 milestone Sep 2, 2021
@karelzkarelz mentioned this pull request Sep 9, 2021
Closed
@adityamandaleeka

adityamandaleeka commented Sep 10, 2021

Copy link
Copy Markdown
Member

@ManickaP FYI, we are about to get 100 continue support for h3 into Kestrel in both main and 6.0

dotnet/aspnetcore#36168 (main)
dotnet/aspnetcore#36395 (release/6.0)

Thanks again for finding this!

@ManickaP

ManickaP commented Sep 13, 2021

Copy link
Copy Markdown
MemberAuthor

Awesome, thanks! I'll update the stress tests once it gets into the nightly docker image.

@ghostghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@antonfirsovantonfirsovantonfirsov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Net.Http

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

H/2 stress many failure in content posting methods

4 participants

@ManickaP@karelz@adityamandaleeka@antonfirsov