Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] [HTTP/3] Stress disable offending op causing server errors - #58541
Merged
Conversation
ghost
commented
Sep 2, 2021
Tagging subscribers to this area: @dotnet/ncl |
karelz
commented
Sep 2, 2021
Member
Test failures:
|
karelz
approved these changes
Sep 2, 2021
ManickaP
commented
Sep 2, 2021
Member
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Anipik
commented
Sep 2, 2021
Contributor
cc @danmoseley |
danmoseley
commented
Sep 3, 2021
Contributor
approved - test stability changes only - if CI passes, anyway. |
ManickaP
commented
Sep 7, 2021
Member
Just FYI, even though runtime-libraries stress-http pipeline is red, it's OK to merge. I checked the details of the run and the results correspond to the state we have in main. There are some errors in H/3 stress, but they are vastly reduced. |
Member
@danmoseley this is ready for merge as described above by @ManickaP (the stress in CI is considered passing despite the red cross there at stress) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58442 to release/6.0
Re-enables HTTP stress scenarios that were broken by Kestrel (it's fixed now). Disables 100 Continue operation for HTTP/3 (not yet implemented by Kestrel) which highly improved stability of H/3 stress.
See #58110 (comment)
Contributes to #56310
Fixes#55261
/cc @ManickaP
Customer Impact
Improves HTTP stress coverage and stability.
Testing
Stress test runs in CI / locally.
Risk
Low. This is a test infra change impacting NCL stress test runs only.