Uh oh!
There was an error while loading. Please reload this page.
Don't force using the system libunwind for source-build - #58641
Merged
Conversation
Instead, use the runtime's normal detection logic to decide what to do. Fixes: dotnet/source-build#2408
ghost
commented
Sep 3, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
omajid
commented
Sep 3, 2021
MemberAuthor
cc @dotnet/source-build-contrib |
MichaelSimons
approved these changes
Sep 9, 2021
MichaelSimons
left a comment
Member
There was a problem hiding this comment.
@omajid - this will have to be manually ported to the release/6.0 branch as well.
omajid added a commit
to omajid/dotnet-runtime
that referenced
this pull request
Sep 9, 2021
Instead, use the runtime's normal detection logic to decide what to do. Backport of dotnet#58641 to release/6.0. See: dotnet/source-build#2408
omajid
commented
Sep 9, 2021
MemberAuthor
Thanks for the reminder, @MichaelSimons! I opened #58911 for that (simple cherry-pick from main). |
jeffschwMSFT pushed a commit
that referenced
this pull request
Sep 15, 2021
Instead, use the runtime's normal detection logic to decide what to do. Backport of #58641 to release/6.0. See: dotnet/source-build#2408
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, use the runtime's normal detection logic to decide what to do.
Fixes: dotnet/source-build#2408