Skip to content

[release/6.0] Don't force using the system libunwind for source-build - #58911

Merged
jeffschwMSFT merged 1 commit into
dotnet:release/6.0from
omajid:6.0-arpow-dont-hardcode-system-libunwind
Sep 15, 2021
Merged

[release/6.0] Don't force using the system libunwind for source-build#58911
jeffschwMSFT merged 1 commit into
dotnet:release/6.0from
omajid:6.0-arpow-dont-hardcode-system-libunwind

Conversation

@omajid

Copy link
Copy Markdown
Member

Instead, use the runtime's normal detection logic to decide what to do.

Backport of #58641 to release/6.0.

See: dotnet/source-build#2408

Instead, use the runtime's normal detection logic to decide what to do.
Backport of dotnet#58641 to release/6.0.
See: dotnet/source-build#2408
@ghost

ghost commented Sep 9, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost added the community-contribution Indicates that the PR has been added by a community member label Sep 9, 2021
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Instead, use the runtime's normal detection logic to decide what to do.

Backport of #58641 to release/6.0.

See: dotnet/source-build#2408

Author:omajid
Assignees:-
Labels:

area-Infrastructure, community-contribution

Milestone:-

@janvorlijanvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Anipik

Copy link
Copy Markdown
Contributor

cc @jeffschwMSFT

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@jeffschwMSFT
jeffschwMSFT merged commit b9f273a into dotnet:release/6.0Sep 15, 2021
@ghostghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@omajid@Anipik@MichaelSimons@jeffschwMSFT@janvorli