Skip to content

The signal enum in the native library should match the managed code. - #58658

Merged
stephentoub merged 1 commit into
dotnet:mainfrom
JamesWTruher:main
Sep 4, 2021
Merged

The signal enum in the native library should match the managed code.#58658
stephentoub merged 1 commit into
dotnet:mainfrom
JamesWTruher:main

Conversation

@JamesWTruher

Copy link
Copy Markdown
Contributor

the native library enum for the posix signal and the managed enum PosixSignal don't match and they probably should.

@ghost

ghost commented Sep 3, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost added the community-contribution Indicates that the PR has been added by a community member label Sep 3, 2021
@stephentoubstephentoub added this to the 6.0.0 milestone Sep 4, 2021
@tmds

tmds commented Sep 4, 2021

Copy link
Copy Markdown
Member

Oops... poor copy-pasting. I checked the other values, they are in order.

Thank you for fixing!

tmds
tmds approved these changes Sep 4, 2021
@stephentoub

Copy link
Copy Markdown
Member

Is it possible to write tests that would catch this, even if manual ones?

@stephentoub

Copy link
Copy Markdown
Member

/backport to release/6.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1200970208

@tmds

tmds commented Sep 4, 2021

Copy link
Copy Markdown
Member

Is it possible to write tests that would catch this, even if manual ones?

We can add/update a test so it uses the kill executable with a signal name. That way we check our own mapping against that of kill. I'll look into it.

@stephentoub

Copy link
Copy Markdown
Member

Thanks, Tom.

@ghostghost locked as resolved and limited conversation to collaborators Oct 4, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Runtime.InteropServicescommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@JamesWTruher@tmds@stephentoub