Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] The signal enum in the native library should match the managed code. - #58682
Conversation
| PosixSignalSIGWINCH = -6, | ||
| PosixSignalSIGCONT = -7, | ||
| PosixSignalSIGCONT = -6, | ||
| PosixSignalSIGWINCH = -7, |
There was a problem hiding this comment.
For reference, these values map to
.stephentoub
commented
Sep 7, 2021
cc: @danmoseley |
danmoseley
commented
Sep 7, 2021
@stephentoub@tmds should we pull #58711 into this also? |
stephentoub
commented
Sep 7, 2021
Either way is fine. I wouldn't block fixing the bug on getting that test pulled in as well. |
danmoseley
commented
Sep 7, 2021
would you mind cherry picking it in? it will only hold us up a couple hours. |
danmoseley
commented
Sep 7, 2021
Approved otherwise -- localized fix for self evidently wrong code. |
* PosixSignalRegistrationTests.Unix: validate signal pal mapping * Use InvariantCulture for pid ToString * Invoke kill through shell. * Remove InvariantCulture
stephentoub
commented
Sep 7, 2021
Done |
danmoseley
commented
Sep 8, 2021
@mdh1418 could you please port into 6.0 the fix for @steveisok I'm not sure what to make of the test jobs that just terminated on iOSSimulator and tvOSSimulator. how can we make these diagnosable? I see no dump or relevant info in any of the logs -- is there any more info we can gather than: I'm going to merge this though as I can't see how it could have failures specific to just these. |
steveisok
commented
Sep 8, 2021
@danmoseley We have a few commits that @mdh1418 is working to backport that will clean these up. And to answer your question, there are about 7-8 suites that crash immediately for unknown reasons and seemingly only on CI. We will be skipping them for now until we're able to get a better understanding as to why. |
danmoseley
commented
Sep 8, 2021
Sounds good thanks @steveisok |
#58841 Backport PR is open :) ! |
Backport of #58658 to release/6.0
/cc @stephentoub@JamesWTruher
Customer Impact
Trying to register for SIGWINCH (window resize) will actually register for SIGCONT (making a suspend process continue), and vice versa.
Testing
CI (a new test was added separately/subsequently to validate our mappings).
Risk
Minimal. It's obvious from code inspection that the code was wrong and is now correct.