Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Add cast when replacing promoted struct with field in lowering - #58951
Merged
Conversation
We may need to sign/zero-extend when we do this replacement very late. Normally this cast would be inserted in morph. Fix#58373
Retyping it to the type of the ret node is not right when reinterpreting small structs as a type that needs to be normalized.
ghost
commented
Sep 10, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsBackport of #58589 to release/6.0 /cc @jakobbotsch Customer ImpactTestingRisk
|
jeffschwMSFT
approved these changes
Sep 10, 2021
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. Please get a code review and once we have a green ci we can merge.
JulieLeeMSFT
commented
Sep 10, 2021
Member
CC @AndyAyersMS PTAL. |
AndyAyersMS
approved these changes
Sep 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58589 to release/6.0
/cc @jakobbotsch
Customer Impact
Returning a pointer indirection reinterpreting a small struct as a small primitive type does not correctly zero/sign extend the result. We have one such case in our own libraries.
Testing
There are two test cases included.
Risk
Low, this is a targeted fix that inserts the necessary zero/sign-extensions when necessary.