Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Remove benign assert - #59044
Merged
Merged
Conversation
It is perfectly possible for us to replace a promoted struct by its only field where that field is marked do-not-enregister. Since this path does handle the proper retyping when normalization is required this assertion is benign. Fix#58972
ghost
commented
Sep 13, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsBackport of #58980 to release/6.0 /cc @jakobbotsch Customer ImpactTestingRisk
|
JulieLeeMSFT
commented
Sep 14, 2021
Member
CC @dotnet/jit-contrib @kunalspathak Please review it ASAP before RC2 snap. |
kunalspathak
approved these changes
Sep 14, 2021
Anipik
commented
Sep 14, 2021
Contributor
jeffschwMSFT
approved these changes
Sep 14, 2021
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. Let's wait for a green ci.
jeffschwMSFT
commented
Sep 14, 2021
Member
I feel this is opportunistic. If we make the RC2 snap, let's take it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58980 to release/6.0
/cc @jakobbotsch
Customer Impact
In #58589 I added an overly eager assert that also got backported in #58951. To avoid hitting this assert in the 6.0 branch in case we need to investigate a problem, I'm also backporting the removal of this assert.
Testing
There is a new test that uses this code path hitting the assert.
Risk
None, this is removing debug-only code.