Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Check if External Object Context is still active after a possible GC - #59293
Closed
github-actions[bot] wants to merge 1 commit into
Closed
[release/6.0] Check if External Object Context is still active after a possible GC#59293github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
AaronRobinsonMSFT
marked this pull request as draft
September 20, 2021 22:06
…59285) * Handle a possible GC after allocating an array by iterating over the hash again. Co-authored-by: Elinor Fung <elfung@microsoft.com>
AaronRobinsonMSFTforce-pushed
the
backport/pr-59285-to-release/6.0
branch
from
September 21, 2021 22:15
162a3c3 to
dedd799CompareAaronRobinsonMSFT
marked this pull request as ready for review
September 21, 2021 22:16
jeffschwMSFT
approved these changes
Sep 21, 2021
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. We should consider this for .NET 6.
davidwrighton
approved these changes
Sep 21, 2021
jeffschwMSFT
commented
Sep 27, 2021
Member
Merged into RC2 via #59436 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #59285 to release/6.0
/cc @AaronRobinsonMSFT
Customer Impact
This would have impact on WinRT scenarios during Reference Tracker (Jupiter shutdown). This supports an API that had severe implementation flaws and went unused in .NET Framework scenarios. This adds support for its use in .NET 6+.
Testing
The issue was detected via a GCStress run – #59072.
Risk
Low. This is only used in WinRT scenarios –
IReferenceTrackerHost::NotifyEndOfReferenceTrackingOnThread().