Uh oh!
There was an error while loading. Please reload this page.
[release/6.0-rc2] Check if External Object Context is still active after a possible GC - #59436
Merged
Merged
Conversation
Check if `IsActive()` during consideration too.
… detach state instead of IsActive state for EOC.
Co-authored-by: Elinor Fung <elfung@microsoft.com>
Co-authored-by: Elinor Fung <elfung@microsoft.com>
jeffschwMSFT
approved these changes
Sep 21, 2021
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. Let's take for consideration in RC2.
davidwrighton
approved these changes
Sep 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #59285 to release/6.0-rc2
/cc @AaronRobinsonMSFT
Customer Impact
This would have impact on WinRT scenarios during Reference Tracker (Jupiter shutdown). This supports an API that had severe implementation flaws and went unused in .NET Framework scenarios. This adds support for its use in .NET 6+.
Testing
The issue was detected via a GCStress run – #59072.
Risk
Low. This is only used in WinRT scenarios –
IReferenceTrackerHost::NotifyEndOfReferenceTrackingOnThread().