Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Generic Math Preview - Use correct NumberStyle when parsing double and float - #59349
Merged
Merged
Conversation
IParseable<float> and IParseable<double> would fail when parsing a decimal point number due to incorrect NumberStyles parameter. E.g. IParseable<double>.TryParse would fail as opposed to IParseable<double>.Parse because the former explicitly states to use NumberStyles.Integer
ghost
commented
Sep 20, 2021
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsBackport of #59205 to release/6.0 Customer ImpactTestingRisk
|
tannergooding
commented
Sep 20, 2021
Member
CC. @jeffhandley, @danmoseley |
danmoseley
commented
Sep 20, 2021
Contributor
LGTM. feel free to send mail to Steve/tactics. The key point being it's only the preview methods affected (I would have snipped out the diff for the non preview methods even though it's a no-op, but it's not important.) |
danmoseley
commented
Sep 21, 2021
Contributor
was approved offline |
Anipik
commented
Sep 21, 2021
Contributor
cc @tannergooding@pgovind can you add a CR here ? |
danmoseley
approved these changes
Sep 21, 2021
danmoseley
commented
Sep 21, 2021
Contributor
reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #59205 to release/6.0
/cc @tannergooding@7rakir
Customer Impact
Customers using the new generic math preview feature will not be able to use
IParseable<float>,IParseable<double>orIParseable<Half>and have it work for anything except strings containing integers.They would need to fallback to the parse methods exposed by
INumber<T>that take aNumberStylesinstead.Testing
Additional tests were duplicated and updated to explicitly cover the generic math scenario.
Risk
Low. This is a small fix for a preview API that requires explicit opt-in to consume.