Skip to content

[release/6.0-rc2] Generic Math Preview - Use correct NumberStyle when parsing double and float - #59366

Merged
danmoseley merged 3 commits into
release/6.0-rc2from
backport/pr-59205-to-release/6.0-rc2
Sep 21, 2021
Merged

[release/6.0-rc2] Generic Math Preview - Use correct NumberStyle when parsing double and float#59366
danmoseley merged 3 commits into
release/6.0-rc2from
backport/pr-59205-to-release/6.0-rc2

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Sep 20, 2021

Copy link
Copy Markdown
Contributor

Backport of #59205 to release/6.0-rc2

/cc @tannergooding@7rakir

Customer Impact

Customers using the new generic math preview feature will not be able to use IParseable<float>, IParseable<double> or IParseable<Half> and have it work for anything except strings containing integers.

They would need to fallback to the parse methods exposed by INumber<T> that take a NumberStyles instead.

Testing

Additional tests were duplicated and updated to explicitly cover the generic math scenario.

Risk

Low. This is a small fix for a preview API that requires explicit opt-in to consume.

Richard Sefrand others added 3 commits September 20, 2021 19:19
IParseable<float> and IParseable<double> would fail when parsing
a decimal point number due to incorrect NumberStyles parameter.
E.g. IParseable<double>.TryParse would fail as opposed to
IParseable<double>.Parse because the former explicitly states to use
NumberStyles.Integer
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #59205 to release/6.0-rc2

/cc @tannergooding@7rakir

Customer Impact

Testing

Risk

Author:github-actions[bot]
Assignees:-
Labels:

area-System.Numerics

Milestone:-

@tannergooding

Copy link
Copy Markdown
Member

CC. @jeffhandley, @danmoseley, this is a dupe of #59349 but for RC2 as suggested by Jeff.

@tannergoodingtannergooding changed the title [release/6.0-rc2] Use correct NumberStyle when parsing double and float[release/6.0-rc2] Generic Math Preview - Use correct NumberStyle when parsing double and floatSep 20, 2021
@danmoseleydanmoseley added the Servicing-approved Approved for servicing release label Sep 21, 2021
@danmoseley

Copy link
Copy Markdown
Contributor

@lewing docker seems to have been killed here. known issue?

2021-09-20T20:13:01.3886121Z "/usr/local/emscripten/emsdk/node/14.15.5_64bit/bin/node" /usr/local/emscripten/emsdk/upstream/emscripten/src/compiler.js /tmp/tmpo2pt6d0q.txt
2021-09-20T20:13:01.5143286Z "/usr/local/emscripten/emsdk/node/14.15.5_64bit/bin/node" /usr/local/emscripten/emsdk/upstream/emscripten/src/compiler.js /tmp/tmp435as1da.txt
2021-09-20T20:13:01.6391861Z "/usr/local/emscripten/emsdk/node/14.15.5_64bit/bin/node" /usr/local/emscripten/emsdk/upstream/emscripten/src/compiler.js /tmp/tmp6cxoxgqq.txt
2021-09-20T20:13:01.7098581Z "/usr/local/emscripten/emsdk/node/14.15.5_64bit/bin/node" /usr/local/emscripten/emsdk/upstream/emscripten/src/compiler.js /tmp/tmpx9tb7leh.txt
2021-09-20T20:13:02.0118480Z "/usr/local/emscripten/emsdk/upstream/bin/wasm-opt" --post-emscripten --no-exit-runtime -Oz --low-memory-unused --zero-filled-memory --strip-producers /__w/1/s/artifacts/obj/mono/Wasm.BrowserProfile.Sample/wasm/Release/browser-wasm/wasm/for-publish/dotnet.wasm -o /__w/1/s/artifacts/obj/mono/Wasm.BrowserProfile.Sample/wasm/Release/browser-wasm/wasm/for-publish/dotnet.wasm -g --mvp-features --enable-mutable-globals
2021-09-20T20:13:02.0244129Z "/usr/local/emscripten/emsdk/upstream/bin/wasm-opt" --post-emscripten --no-exit-runtime -Oz --low-memory-unused --zero-filled-memory --strip-producers /__w/1/s/artifacts/obj/mono/Wasm.Browser.Sample/wasm/Release/browser-wasm/wasm/for-publish/dotnet.wasm -o /__w/1/s/artifacts/obj/mono/Wasm.Browser.Sample/wasm/Release/browser-wasm/wasm/for-publish/dotnet.wasm -g --mvp-features --enable-mutable-globals
2021-09-20T20:13:02.0263226Z "/usr/local/emscripten/emsdk/upstream/bin/wasm-opt" --post-emscripten --no-exit-runtime -Oz --low-memory-unused --zero-filled-memory --strip-producers /__w/1/s/artifacts/obj/mono/Wasm.Console.Sample/wasm/Release/browser-wasm/wasm/for-publish/dotnet.wasm -o /__w/1/s/artifacts/obj/mono/Wasm.Console.Sample/wasm/Release/browser-wasm/wasm/for-publish/dotnet.wasm -g --mvp-features --enable-mutable-globals
2021-09-20T20:13:02.0487053Z "/usr/local/emscripten/emsdk/upstream/bin/wasm-opt" --post-emscripten --no-exit-runtime -Oz --low-memory-unused --zero-filled-memory --strip-producers /__w/1/s/artifacts/obj/mono/Wasm.Browser.Bench.Sample/wasm/Release/browser-wasm/wasm/for-publish/dotnet.wasm -o /__w/1/s/artifacts/obj/mono/Wasm.Browser.Bench.Sample/wasm/Release/browser-wasm/wasm/for-publish/dotnet.wasm -g --mvp-features --enable-mutable-globals
2021-09-20T20:13:27.9301742Z ##[error]Exit code 137 returned from process: file name '/usr/bin/docker', arguments 'exec -i -u 1000 -w /home/cloudtest_azpcontainer b83235f59c1bc2ed429f59eee9a2b581dc60a11f552022275f970e2281bc6751 /__a/externals/node/bin/node /__w/_temp/containerHandlerInvoker.js'.
2021-09-20T20:13:27.9868514Z ##[section]Finishing: Build product
``

@danmoseley
danmoseley merged commit d060300 into release/6.0-rc2Sep 21, 2021
@danmoseley
danmoseley deleted the backport/pr-59205-to-release/6.0-rc2 branch September 21, 2021 00:40
@ghostghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.NumericsServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tannergooding@danmoseley