Skip to content

Release 6.0 rc2 localized manifest - #59379

Merged
steveisok merged 2 commits into
dotnet:release/6.0-rc2from
wli3:release-6.0-rc2-localized-manifest
Sep 21, 2021
Merged

Release 6.0 rc2 localized manifest#59379
steveisok merged 2 commits into
dotnet:release/6.0-rc2from
wli3:release-6.0-rc2-localized-manifest

Conversation

@wli3

@wli3wli3 commented Sep 20, 2021

Copy link
Copy Markdown

@wli3
wli3 requested a review from steveisokSeptember 20, 2021 21:34
@ghostghost added the area-System.Net label Sep 20, 2021
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Part of dotnet/sdk#20497

Author:wli3
Assignees:-
Labels:

area-System.Net

Milestone:-

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Part of dotnet/sdk#20497

Author:wli3
Assignees:-
Labels:

area-Infrastructure-mono

Milestone:-

@lewinglewing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

@danroth27 any objections?

@danroth27

Copy link
Copy Markdown
Member

No objections from me.

@wli3

wli3 commented Sep 21, 2021

Copy link
Copy Markdown
Author

@lewing@steveisok could you help me merge it? I don't have the permission

@wli3

wli3 commented Sep 21, 2021

Copy link
Copy Markdown
Author

?

@steveisoksteveisok added Servicing-consider Issue for next servicing release review Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 21, 2021
@steveisok

Copy link
Copy Markdown
Member

Approved by tactics over email.

@steveisok
steveisok merged commit 307d945 into dotnet:release/6.0-rc2Sep 21, 2021
sfoslund pushed a commit that referenced this pull request Oct 1, 2021
steveisok pushed a commit that referenced this pull request Oct 4, 2021
Fixing a bug in #59379, part of dotnet/sdk#20497
Workload/SDK logic only copies content in the data directory, so moving the localize directory into the proper location to be picked up and laid down on disk.
@karelzkarelz added this to the 6.0.0 milestone Oct 14, 2021
@ghostghost locked as resolved and limited conversation to collaborators Nov 13, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-monoServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@wli3@danroth27@steveisok@radical@lewing@marek-safar@karelz@danmoseley