Skip to content

Update workload localization file directory structure - #59827

Merged
steveisok merged 1 commit into
release/6.0from
UpdateWorkloadLocAuthoring
Oct 4, 2021
Merged

Update workload localization file directory structure#59827
steveisok merged 1 commit into
release/6.0from
UpdateWorkloadLocAuthoring

Conversation

@sfoslund

@sfoslundsfoslund commented Sep 30, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Fixing a bug in #59379, part of dotnet/sdk#20497

Workload/SDK logic only copies content in the data directory, so moving the localize directory into the proper location to be picked up and laid down on disk.

@ghostghost added the area-System.Net label Sep 30, 2021
@ghost

ghost commented Sep 30, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:sfoslund
Assignees:-
Labels:

area-System.Net

Milestone:-

@sfoslund

sfoslund commented Sep 30, 2021

Copy link
Copy Markdown
MemberAuthor

@marek-safar is this the correct branch for 6.0 GA?

@marek-safar

marek-safar commented Oct 1, 2021

Copy link
Copy Markdown
Contributor

is this the correct branch for 6.0 GA?

Yes but the better way is to land it to main first with automatic backport

@marek-safarmarek-safar added the Servicing-consider Issue for next servicing release review label Oct 1, 2021
@sfoslund

sfoslund commented Oct 1, 2021

Copy link
Copy Markdown
MemberAuthor

Yes but the better way is to land it to main first with automatic backport

It looks like the original change I'm working off of is not in main yet, so I'll cherry pick these changes into main in a separate PR.

@sfoslund

sfoslund commented Oct 1, 2021

Copy link
Copy Markdown
MemberAuthor

@joeloff@steveisok@lewing can I get a review here so I can send a QB approval request?

@sfoslund

sfoslund commented Oct 1, 2021

Copy link
Copy Markdown
MemberAuthor

Thanks!

@steveisok

steveisok commented Oct 1, 2021

Copy link
Copy Markdown
Member

Please cherry pick the localization changes to main in the follow up PR.

@sfoslund

sfoslund commented Oct 1, 2021

Copy link
Copy Markdown
MemberAuthor

Follow up PR into main: #59872

@sfoslund

sfoslund commented Oct 4, 2021

Copy link
Copy Markdown
MemberAuthor

@steveisok this has been approved but I don't have permissions to merge, can you please merge?

@steveisoksteveisok added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 4, 2021
@steveisok
steveisok merged commit 8a75ba0 into release/6.0Oct 4, 2021
@sfoslund
sfoslund deleted the UpdateWorkloadLocAuthoring branch October 4, 2021 16:08
@karelzkarelz added this to the 6.0.0 milestone Oct 14, 2021
@ghostghost locked as resolved and limited conversation to collaborators Nov 13, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisoksteveisoksteveisok approved these changes
@joeloffjoeloffjoeloff approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safarmarek-safar is a code owner
@lewinglewingAwaiting requested review from lewing
@wli3wli3Awaiting requested review from wli3

Assignees

No one assigned

Labels

area-Infrastructure-monoServicing-approvedApproved for servicing release

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@sfoslund@marek-safar@steveisok@joeloff@karelz