Skip to content

[wasm][debugger] Fix concurrent access to cache. - #59412

Merged
thaystg merged 3 commits into
dotnet:mainfrom
thaystg:thays_fix_cache_access_concurrent
Sep 22, 2021
Merged

[wasm][debugger] Fix concurrent access to cache.#59412
thaystg merged 3 commits into
dotnet:mainfrom
thaystg:thays_fix_cache_access_concurrent

Conversation

@thaystg

@thaystgthaystg commented Sep 21, 2021

Copy link
Copy Markdown
Member

PropertiesBinaryReader could be access by more than one thread which was causing starting reading from the wrong position and skip positions.
Added a test case for it.
@lewing I would like to backport to rc2.

@thaystg
thaystg requested a review from lewingSeptember 21, 2021 14:25
@ghost

ghost commented Sep 21, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

PropertiesBinaryReader could be access by more than one thread which was causing starting reading from the wrong position and skip positions.
Added a test case for it.
@lewing I would like to backport to rc2.

Author:thaystg
Assignees:-
Labels:

area-Debugger-mono

Milestone:-

@thaystg

thaystg commented Sep 21, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0-rc2

@github-actions

github-actionsBot commented Sep 21, 2021

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1258807377

@github-actionsgithub-actionsBot mentioned this pull request Sep 21, 2021
Merged
@radicalradical added the arch-wasm WebAssembly architecture label Sep 21, 2021
@ghost

ghost commented Sep 21, 2021

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

PropertiesBinaryReader could be access by more than one thread which was causing starting reading from the wrong position and skip positions.
Added a test case for it.
@lewing I would like to backport to rc2.

Author:thaystg
Assignees:-
Labels:

arch-wasm, area-Debugger-mono

Milestone:-

radical
radical reviewed Sep 21, 2021
View reviewed changes
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs Outdated
radical
radical reviewed Sep 21, 2021
View reviewed changes
Comment threadsrc/mono/wasm/debugger/DebuggerTestSuite/CustomViewTests.cs Outdated
radical
radical approved these changes Sep 21, 2021
View reviewed changes

@radicalradical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thaystg

thaystg commented Sep 21, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0-rc2

@github-actions

github-actionsBot commented Sep 21, 2021

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1259023975

@thaystg
thaystg merged commit 22a1a61 into dotnet:mainSep 22, 2021
@ghostghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical approved these changes
@lewinglewinglewing approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

No one assigned

Labels

arch-wasmWebAssembly architecturearea-Debugger-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thaystg@radical@lewing