Uh oh!
There was an error while loading. Please reload this page.
[release/6.0-rc2] [wasm][debugger] Fix concurrent access to cache. - #59423
Merged
Conversation
ghost
commented
Sep 21, 2021
Tagging subscribers to this area: @thaystg |
github-actionsBotforce-pushed
the
backport/pr-59412-to-release/6.0-rc2
branch
from
September 21, 2021 19:33
7a4ee85 to
8b01075Comparethaystg
commented
Sep 21, 2021
Member
approved in email |
Anipik
approved these changes
Sep 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #59412 to release/6.0-rc2
/cc @thaystg
Customer Impact
When it's stepping over in a C# program that has a list for example, the DebuggerDisplayAttribute works sometimes, and other times it doesn't work.
Testing
Added a unit test that reproduces the same situation of debugging from VS.
Manually tested debugging from VS and from Chrome.
Risk
Low risk, it's caching the byte[] and not the MemoryReader anymore.