Uh oh!
There was an error while loading. Please reload this page.
[wasm][debugger] Fixing memory corruption - #59419
Conversation
ghost
commented
Sep 21, 2021
Tagging subscribers to this area: @thaystg Issue DetailsAs @pavelsavara detected the code that I wrote was corrupting memory on Module.HEAPU8.buffer, it was reusing the begin of this heap everytime that was sending debugger commands. @lewing can we backport? Thanks a lot @pavelsavara
|
lewing
commented
Sep 21, 2021
/backport to release/6.0-rc2 |
Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1258574584 |
ghost
commented
Sep 21, 2021
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsAs @pavelsavara detected the code that I wrote was corrupting memory on Module.HEAPU8.buffer, it was reusing the begin of this heap everytime that was sending debugger commands. @lewing can we backport? Thanks a lot @pavelsavara
|
radical
commented
Sep 21, 2021
What did the failure look like? |
We don't detect any failure, @pavelsavara saw that the code was strange by reading it to refactor. |
Uh oh!
There was an error while loading. Please reload this page.
As @pavelsavara detected the code that I wrote was corrupting memory on Module.HEAPU8.buffer, it was reusing the beginning of this heap everytime that was sending debugger commands.
I think we should backport it to rc2.
@lewing can we backport?
Thanks a lot @pavelsavara