Skip to content

[wasm][debugger] Fixing memory corruption - #59419

Merged
thaystg merged 1 commit into
dotnet:mainfrom
thaystg:thays_fix_memory_corruption
Sep 21, 2021
Merged

[wasm][debugger] Fixing memory corruption#59419
thaystg merged 1 commit into
dotnet:mainfrom
thaystg:thays_fix_memory_corruption

Conversation

@thaystg

@thaystgthaystg commented Sep 21, 2021

Copy link
Copy Markdown
Member

As @pavelsavara detected the code that I wrote was corrupting memory on Module.HEAPU8.buffer, it was reusing the beginning of this heap everytime that was sending debugger commands.
I think we should backport it to rc2.

@lewing can we backport?

Thanks a lot @pavelsavara

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

As @pavelsavara detected the code that I wrote was corrupting memory on Module.HEAPU8.buffer, it was reusing the begin of this heap everytime that was sending debugger commands.
I think we should backport it to rc2.

@lewing can we backport?

Thanks a lot @pavelsavara

Author:thaystg
Assignees:-
Labels:

area-Debugger-mono

Milestone:-

@lewing

Copy link
Copy Markdown
Member

/backport to release/6.0-rc2

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1258574584

@thaystgthaystg added Servicing-consider Issue for next servicing release review and removed Servicing-consider Issue for next servicing release review labels Sep 21, 2021
@radicalradical added the arch-wasm WebAssembly architecture label Sep 21, 2021
@ghost

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

As @pavelsavara detected the code that I wrote was corrupting memory on Module.HEAPU8.buffer, it was reusing the begin of this heap everytime that was sending debugger commands.
I think we should backport it to rc2.

@lewing can we backport?

Thanks a lot @pavelsavara

Author:thaystg
Assignees:-
Labels:

arch-wasm, area-Debugger-mono

Milestone:-

@radical

Copy link
Copy Markdown
Member

As @pavelsavara detected the code that I wrote was corrupting memory on Module.HEAPU8.buffer, it was reusing the begin of this heap everytime that was sending debugger commands.

What did the failure look like?

@thaystg

thaystg commented Sep 21, 2021

Copy link
Copy Markdown
MemberAuthor

We don't detect any failure, @pavelsavara saw that the code was strange by reading it to refactor.

Comment threadsrc/mono/wasm/runtime/library_mono.js
@thaystg
thaystg merged commit 0ea3b7d into dotnet:mainSep 21, 2021
@ghostghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-Debugger-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@thaystg@lewing@radical