Uh oh!
There was an error while loading. Please reload this page.
[release/6.0-rc2] [wasm][debugger] Fixing memory corruption - #59420
Merged
Conversation
ghost
commented
Sep 21, 2021
Tagging subscribers to this area: @thaystg |
lewing
approved these changes
Sep 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #59419 to release/6.0-rc2
/cc @lewing@thaystg
Customer Impact
We don't see any impact for customer yet, but probably it was writing on the heap in a memory that was used for other areas of the application.
Testing
Run all the debugger tests
Risk
Low risk, it's reusing a function already used to load all the assemblies.